- 13 Nov, 2020 40 commits
-
-
minch authored
See doc linked at the crbug for the details. Bug: 1134809 Change-Id: Ie001e5ec75729ac61f5f5ffd10e8289982151733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536754Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#827357}
-
Nina Satragno authored
Remove an old TODO that no longer applies. Change-Id: Ib17cc59de2d4a38a31e5d9dce0eafa09687f7af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532885 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#827356}
-
minch authored
Bug: 1145363 Change-Id: Ia1d5a051aa2da436855b5891923a8b091d2039a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537592Reviewed-by:
-
Yicheng Li authored
These adjustments have been approved in UXImpl review so they are final. Bug: b:156258540, b:144861739 Change-Id: Iaa65c359304a406df0630da853a0e0cfe6a3302e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538151Reviewed-by:
-
Morten Stenshorne authored
We got rid of this for block break tokens a long time ago, but it had to be kept for inline break tokens, for one reason only: to keep a vector in the fragment builder whose size would correspond with the number of lines added. This was needed for orphans / widows support. Let's just count the lines added instead. Rather than creating a "finished" break token, just don't create a break token at all for fragments whose node didn't break. No behavior changes intended. Change-Id: I880a1d2fafb7d72a9c885013793520781c7308fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534910 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#827353}
-
Ian Kilpatrick authored
It's time to retire this flag, (primarily it is the easiest to remove to make room for the StretchBlockSizeIfAuto() bit). There should be no correctness change, potentially a slight performance change to querying baselines from tables for example. Change-Id: I6f12e9016d2c2475009a19859ce50324617d15ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491977 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#827352}
-
Filip Gorski authored
TBR=yfriedman@chromium.org Bug: 1147922 Change-Id: I44024e289ce4691bef9ba037954c3b66f47884d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536449Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Joshua Peraza <jperaza@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#827351}
-
Chris Sharp authored
Updated the following policies: DeviceAllowRedeemChromeOsRegistrationOffers DeviceQuirksDownloadEnabled DeviceShowLowDiskSpaceNotification DNSInterceptionChecksEnabled ExternalProtocolDialogShowAlwaysOpenCheckbox LocalDiscoveryEnabled NtlmV2Enabled NTPContentSuggestionsEnabled Also added a default value for ExternalProtocolDialogShowAlwaysOpenCheckbox Bug: 1139306 Change-Id: Ieee92a5c66291ea3f64203e56a63c62aae283bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521304Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#827350}
-
Jacob Kopczynski authored
Bug: chromium:1127088 Change-Id: I8a65d433deb00a4d56bdef3775a70176aec5e336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535998 Auto-Submit: Jacob Kopczynski <jkop@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#827349}
-
Garrett Beaty authored
Bug: 1148845 Change-Id: I130de84b651b361cb7893c79b916123220a915be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537153Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#827348}
-
kylechar authored
This reverts commit c6f4b552. Reason for revert: Remove diagnostic check. Original change's description: > Add diagnostic CHECKs for deserialization error. > > A crash has been traced back to a deserialization error on the > viz.mojom.FrameSinkManager RegisterFrameSinkHierarchy IPC. Add some > CHECKs to identify the root cause of bad FrameSinkId(s) being sent. > > Bug: 1115094 > Change-Id: Ie8aaf54bdddfb6d649b1386ac62edfb0df639cff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403581 > Reviewed-by: Jonathan Backer <backer@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805836} TBR=backer@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1115094 Change-Id: I747cdb08bcb28fcd8e5f7cebee4c0d976c72c164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537578Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#827347}
-
David Maunder authored
This was determined to be necessary in cl/342061697 Bug: 1148823 Change-Id: I125e177fa057e6aebd92a0750559e4a68940c312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537699Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#827346}
-
Ian Kilpatrick authored
This patch "flips" the meaning of the NGConstraintSpace::IsShrinkToFit bit, instead naming it NGConstraintSpace::StretchInlineSizeIfAuto. This is in preparation for a similar API in the block-direction: NGConstraintSpace::StretchBlockSizeIfAuto, which is needed for GridNG. See: https://chromium-review.googlesource.com/c/chromium/src/+/2523743 This may also simplify the flex layout algorithm (as we'll have the ability to natively "stretch" in both directions, instead of setting a fixed block-size). By default all layouts will now shrink-to-fit, and we'll need to explicitly stretch if desired (the default for block-layout for example). There should be no behaviour change. Bug: 1045599 Change-Id: If41aac74ae2829fd13046a0e11be6553fe80a448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513771 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bee6408d7b67..4543697b3755 2020-11-13 gustaf@webrtc.org Set range of GetLinearAecOutput to [-1, 1] If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia838a3ec92d2ddf2c9179da8b7839a48f89e3b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538039Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827344}
-
Mason Wilde authored
Making this field required led to issues with test devices. This changes it to optional like many other fields. Bug: chromium:1146143 Change-Id: Ie0bdfe38462aef987021c42eec20749255d5ddf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536150Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mason Wilde <masonwilde@google.com> Cr-Commit-Position: refs/heads/master@{#827343}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4cd11945c5a1..f1f7c370eb0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9f2451f5a55d4583ae7ef42fc92e158b530fe9b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536981Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8bf9368130b8..f1f7c370eb0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id4029895a3f94b5fd9bd754e911439e97ddff3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537917Reviewed-by:
-
Joe Downing authored
This is a clean-up CL which removes build rule for M24 hosts which are well beyond obsolescence at this point. I also tweaked a comment to fit on one line and updated 'Google Inc.' to 'Google LLC'. Change-Id: Ibadde4353bb9108f9b0260913c10a70f366489a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537577Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#827340}
-
Clark DuVall authored
The metric was split out of the WebView version, so we should use this now for WebLayer startup tests. Pinpoint job running: https://pinpoint-dot-chromeperf.appspot.com/job/104b30a9520000 Bug: 1146438 Change-Id: I9938614b94740a3222fb832ab994427b136bf1d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536797Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#827339}
-
Kyle Horimoto authored
Change-Id: I89e063cc92572ce9590cfe6f6602f34489d9eebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537582 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#827338}
-
Ken Rockot authored
All dependents are also (minimally) updated to support this change. The module-supporting bindings.js is also modified here so that its import has no destructive side effects on the global object state. This allows bindings.js and mojo_bindings_lite.js to be imported by the same page to mix usage of module-based and non-module-based JS bindings, which is temporarily needed here by chrome://new-tab-page/ Bug: 1004256 Change-Id: I7e74ca222e099cc8143e5476a9cdcd62b40a8afd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521907 Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Brian Salomon <bsalomon@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#827337}
-
Devlin Cronin authored
Increment to 3; update tests. Bug: 1147355 Change-Id: I8469f30b6bb25f2ecc56217c83bb73c81521bafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528614Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827336}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b6f4d53126d3..56523dff6983 2020-11-13 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 1980095da7f4 to 8ca4561b25dd (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: Ic81c355cbe3cbf60abdf2758493384a9eab02440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538034Reviewed-by:
-
Bartek Nowierski authored
Bug: 1121427 Change-Id: I7d45cabd66678c4eb363920f2e3ee531773620ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536576 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Eric Lawrence [MSFT] authored
Previously, a decode step was performed inside of a DCHECK. The decode should always happen, even in release builds. Bug: 893350 Change-Id: I1432a67d233693f011a06644d7ace078d1509e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533243Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#827333}
-
Dominic Farolino authored
Before crrev.com/c/2490442, we had SetUpMojoIfNeeded() calls in places where it was ambiguous whether the AgentSchedulingGroupHost mojos needed to be initialized or not. After that CL, the lifetimes of the AgentSchedulingGroupHost mojos match those of the RenderProcessHostImpl, and we removed some calls to SetUpMojoIfNeeded(), and left the only callsites that were required to actually setup mojo. By way of a follow-up, this CL renames the method to SetUpMojo(), and changes its implementation to assert that the AgentSchedulingGroupHost mojos are unbound and need to be bound. Bug: 1111231 Change-Id: I963fc51a99a665ed729abca6f023f33338d4e2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533161 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#827332}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e2a55140424f..33eec64159df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC markusheintz@google.com,adithyas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: markusheintz@google.com,adithyas@google.com Change-Id: I4da15a77f839beb4901e2bcc135c8d8281ecb0dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537971Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827331}
-
Xianzhu Wang authored
For the following case: <div style="background: black; height: 500px; overflow: scroll"> <div style="background: rgba(255, 255, 255, 0.1); height: 10000px">Text</div> </div> previously we chose rgba(255, 255, 255, 0.1) as the layer's background color, causing white flash when the color was used for checkerboarding. Now blend overlapping layers of background colors. Bug: 1147379 Change-Id: I3badbbf060265fa1d1d31081a4882837fef408e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533306 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#827330}
-
S. Ganesh authored
Change to copy and compare only the files pertaining to the current invocation of midl.py, instead of copying the entire directory. The latter causes timing issues with parallel builds when multiple IDL files are involved. Bug: 1148656 Change-Id: Ie3e24e5fb2193ae046db086859e9bca8c11e9604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535921 Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#827329}
-
Adithya Srinivasan authored
This reverts commit 7b356bed. Reason for revert: Seems like WaylandKeyboardTest.EventAutoRepeat is failing again in ozone_unittests (https://ci.chromium.org/p/chromium/builders/ci/Linux%20Ozone%20Tester%20%28Headless%29/20279), this seems the likely culprit. Original change's description: > Reland "Fix auto key repeat event interpretation." > > This is a reland of 7fdaa429 > > Original change's description: > > Fix auto key repeat event interpretation. > > > > The original code interprets "rate" (the second argument) in > > millisecond units. However, by definition, it is the number of > > key events per second. > > > > Bug: 1141473 > > Test: Ran on DUT. Ran unittest locally. > > Change-Id: Iccdcd2c1e5fc3160da054617bc3e173bb23e9657 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507412 > > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827223} > > Bug: 1141473 > Change-Id: I9af00fa55fc77cd931d3e203afd47e3a48e4b826 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537793 > Reviewed-by: Markus Heintz <markusheintz@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Markus Heintz <markusheintz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827287} TBR=rjkroege@chromium.org,mukai@chromium.org,markusheintz@chromium.org,hidehiko@chromium.org Change-Id: I55a9cccf78410ee4a2718649de626c0691b0da20 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1141473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537135Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#827328}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6729bed0d4fd..1f7a8206536e 2020-11-13 aerotwist@chromium.org [unit test] Fix remaining non-entrypoint imports 2020-11-13 andoli@chromium.org [ts] Typecheck elements/PlatformFontsWidget.js with TypeScript 2020-11-13 andoli@chromium.org [ts] Typecheck elements/InspectElementModeController.js with TypeScript 2020-11-13 tvanderlippe@chromium.org Typecheck inspector_main/InspectorMain.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1148296 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icf9da6faa6d6ac62bdf9ce399d46a5d716746239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537915Reviewed-by:
-
Alexis Hetu authored
A missing flush in SkiaOutputSurfaceImplTest.SupportsColorSpaceChange was causing the test to fail when run with SwANGLE. Adding it fixes the issue. Bug: angleproject:5338 Change-Id: I3c098e66af738535e3da495192e5c37a3d34fba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537998Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#827326}
-
Melissa Zhang authored
Bug: 1148694 Change-Id: I2843e2c39c3ad5229b45b5889a76cb93b1795689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537505 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#827325}
-
Scott Little authored
This reverts commit bfaedb07. Reason for revert: I think I've found the culprit CL that caused these test failures in the first place (https://chromium-review.googlesource.com/c/chromium/src/+/2537580), so I'm re-enabling these tests to see if they still fail. See https://bugs.chromium.org/p/chromium/issues/detail?id=1148771#c3 for more details of the investigation. Original change's description: > Sheriff: Disable tests in ExistingUserControllerActiveDirectoryTest > > Bug: 1148771 > Change-Id: I676dd86028dbca3f39661aa2b35202facf880281 > Tbr: alemate@chromium.org > No-Try: True > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536978 > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827245} TBR=alemate@chromium.org,adithyas@chromium.org Change-Id: Id51b3e6102219db51af7dc030d9e8256838de7c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537581Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#827324}
-
Scott Little authored
This reverts commit 674caeb6. Reason for revert: Broke ASAN browser tests: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38849 The initial CL (before the reland) was previously reverted, and now relanded, corresponding to the test failures in both the initial landing and the reland. See https://bugs.chromium.org/p/chromium/issues/detail?id=1148771#c3 for a more detailed explanation including discussing other possible culprit CLs. Original change's description: > Reland "UserSessionManager trigger tpm initialization whenever TPM is enabled." > > This is a reland of f5684467 > > Original change's description: > > UserSessionManager trigger tpm initialization whenever TPM is enabled. > > > > we are obsoleting `TpmIsBeingOwned()`, which is not really necessary > > anyway; even if `TpmIsBeingOwned()` returns `true`, triggering the TPM > > initilaization again is just no-ops at ChromeOS side. > > > > BUG=b:172775884 > > TEST=TBD if untitests needed. > > > > Change-Id: If4240a0c8a9a7485d77856e1e5c346c89407c09a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532155 > > Commit-Queue: Leo Lai <cylai@google.com> > > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#826306} > > Bug: b:172775884 > Change-Id: I0499d47b9962f41bcfa956d6efa73b850a0b2021 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534372 > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Commit-Queue: Leo Lai <cylai@google.com> > Cr-Commit-Position: refs/heads/master@{#827141} TBR=achuith@chromium.org,alemate@chromium.org,cylai@google.com,adithyas@chromium.org Change-Id: I5f443979f1f420f1abaf1371cac10c10f1eb2b0d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:172775884, 1148771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537580Reviewed-by:
-
Ian Barkley-Yeung authored
Add the remaining testing hooks needed for the Browser & Tast tests for the WebUI JS Error Reporting project. In particular, added ability to log errors (via console.error) and have unhandled promise rejections. Since the page now does more than just throw exceptions, renamed from chrome://webuiexception to chrome://webuierror. Bug: chromium:1121816 Change-Id: I7aed32673569a51a3853594ac5b6e6dc04ef3b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531802Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#827322}
-
Fredrik Söderqvist authored
A follow-up CL will make use of the reason to share external resources for cloned <use> elements. Bug: 1147461 Change-Id: I0c4474a28ec9a520bf6ff556e4f386a972882aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536442Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#827321}
-
Mark Pearson authored
*Not* renaming the histogram despite the change in semantics because it looks like <0.5% of omnibox interactions are paste-and-search or paste-and-go. It's probably similar for this metric: paste-and-go as a percent of all omnibox URL navigations. This is small enough that I'm not concerned. Noted the change in semantics in the changelist description. Tested using chrome://histograms Bug: 1144343 Change-Id: I8e1bb4f37b339112174be3c2423fc47394a74661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536250Reviewed-by:
Steven Bingler <bingler@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#827320}
-
Xiaohui Chen authored
Bug: None Test: compiles Change-Id: I1adeaa38059ca097ea57ff9e9296f5a75d351e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536691Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#827319}
-
Robert Ogden authored
Persists origin retry-after data to disk. Serialization of a base::Time into a DictionaryValue was tricky, suggestions welcome. Bug: 1146210 Change-Id: I57e356c44d014076fcfe3895d82cd7bd0fbdbdcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531273Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#827318}
-
![Eric Lawrence [MSFT]'s avatar](https://secure.gravatar.com/avatar/16e6d745c0e05bade0525857d18118ce?s=80&d=identicon "Eric Lawrence [MSFT]")
