- 20 Feb, 2019 40 commits
-
-
gogerald authored
The target element may be there but may not be interactive. Bug: 806868 Change-Id: Ia89f7e52421cf61ffa87271565b6a5ed75603d42 Reviewed-on: https://chromium-review.googlesource.com/c/1476544 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#633751}
-
Daniel Bratell authored
In an effort to reduce or even ban variable shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The warnings this avoids is: third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc:3688:18: error: declaration shadows a local variable [-Werror,-Wshadow] unsigned length; ^ third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc:3658:13: note: previous declaration is here GLsizei length = 0; ^ third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc:5234:31: error: declaration shadows a local variable [-Werror,-Wshadow] ScopedTexture2DRestorer restorer(gl); ^ third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc:5190:27: note: previous declaration is here ScopedTexture2DRestorer restorer(this); Bug: 923510 Change-Id: Idef0b7f4b47aad7c0199d9e11571dc93d1c94429 Reviewed-on: https://chromium-review.googlesource.com/c/1477679 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#633750}
-
Joe Downing authored
The SecurityKeyResponseTimeout test is flaky on MacOS as the timeout observed can vary by a couple hundred milliseconds which makes the test flaky. The original timeout was just a 'sensible' value so we can increase that value so the test is more consistent. BUG=933522 Change-Id: I9ca78270c7446760022e97a4b477b6bc7074dcee Reviewed-on: https://chromium-review.googlesource.com/c/1478253 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#633749}
-
Becky Zhou authored
Bug: 933492 Change-Id: I48fc19c185ebb0581045668d07e057fb12130521 Reviewed-on: https://chromium-review.googlesource.com/c/1478106 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#633748}
-
sangwoo.ko authored
When gfx::Animation::ShouldRenderRichAnimation() returns false, we shouldn't do heavy animation. In favor of this, disable the following animations: * find bar * info bar * download shelf * bookmarks bar While doing this, fix a bug in gfx::SlideAnimtion::Hide(). As the previous comment mentioned, we should pass 1.0 to AnimateToState() in order to skip to the end of animation. The parameter represents the progress of each animation, not the value. Bug: 8944 Change-Id: Ifc7d3ea8a5379d41f37cafa5a3094a0fe4555dd4 Reviewed-on: https://chromium-review.googlesource.com/c/1457697Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#633747}
-
Daniel Bratell authored
In an effort to reduce or even ban variable shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The warning this avoids is: third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc:1200:20: error: declaration shadows a local variable [-Werror,-Wshadow] for (auto const& transport_iterator : dtls_transports_by_mid_) { ^ third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc:1187:8: note: previous declaration is here auto transport_iterator = dtls_transports_by_mid_.find(mid); ^ Bug: 923510 Change-Id: Ia9e1734c1bd1aa42bf4b13f6d2b43fe28b6ed511 Reviewed-on: https://chromium-review.googlesource.com/c/1478872 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by: -
John Chen authored
Due to occasional ChromeDriver startup timeout on Linux Tests (dbg) builder, modify run_webdriver_tests.py to retry starting ChromeDriver. Bug: 931586 Change-Id: I6eb4c0e01f857bff88b26647a9aec67159b898be Reviewed-on: https://chromium-review.googlesource.com/c/1478332 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#633745}
-
Daniel Bratell authored
In an effort to reduce or even ban variable shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact error this avoids is: third_party/blink/renderer/modules/notifications/notification_data.cc:93:45: error: declaration shadows a local variable [-Werror,-Wshadow] SerializedScriptValue::SerializeOptions options; ^ ./../../third_party/blink/renderer/modules/notifications/notification_data.cc:43:32: note: previous declaration is here const NotificationOptions* options, ^ Bug: 923510 Change-Id: Ie49096ef30fbab30567ad45f3f2d8b76a8eab9ed Reviewed-on: https://chromium-review.googlesource.com/c/1478891Reviewed-by: -
Francois Doray authored
The content implementation was updated to work properly across components. See https://chromium-review.googlesource.com/c/1354402. TBR=eugenebut@chromium.org Bug: 589840 Change-Id: Ie3fd2292c4c730e8e9db0516ea1b1c3899bc6909 Reviewed-on: https://chromium-review.googlesource.com/c/1476055 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#633743}
-
Daniel Bratell authored
In an effort to reduce or even ban variable shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact error this avoids is: third_party/blink/renderer/modules/credentialmanager/credentials_container.cc:180:23: error: declaration shadows a local variable [-Werror,-Wshadow] OriginAccessEntry access_entry( ^ third_party/blink/renderer/modules/credentialmanager/credentials_container.cc:166:21: note: previous declaration is here OriginAccessEntry access_entry( ^ Bug: 923510 Change-Id: I61b11ecd489ed9842e1a9ebee9293050f7f1cde5 Reviewed-on: https://chromium-review.googlesource.com/c/1478890Reviewed-by: -
Marc Treib authored
Missed this one in https://crrev.com/c/1477604... Bug: 924508 Change-Id: I6b7f2690f0efbbf2620b0114d28d8727f442161a Reviewed-on: https://chromium-review.googlesource.com/c/1478875 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#633741}
-
Tomasz Wiszkowski authored
This change separates AnswerSuggestionView from SuggestionView. Because the current functionality still depends on SuggestionView to present answers, the new mechanism still supports a little bit of both. Decision which should be used depends on the state of the omnibox new answer layout flag. Bug: 920396 Change-Id: I84864ecbb52e025c1cb58f6c8f1bca2a85c4a3ee Reviewed-on: https://chromium-review.googlesource.com/c/1471461Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#633740}
-
Bo Liu authored
Broken case is WebContents::WasHidden is called before the first load then page visibility remains visible because nothing handles PageMsg_WasHidden, and nothing rechecks the state after first load. Note RenderView is invisible due to EnsureRenderFrameHostVisibilityConsistent. A related bug is that in this case RenderView is created to be visible and then marked visible after. Turns out fixing this will also correctly set page visibility, so this CL fixes this bug instead. Previously reverted due to test flake due to test environment changing visibility of WebContents under test. New version uses a WebContents that's detached from the window, so should not be subject to such external signals. Bug: 929860 Change-Id: Id163bc57c79dbaf628eac50014d571aa76ad4ef6 Reviewed-on: https://chromium-review.googlesource.com/c/1476812Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#633739}
-
Elly Fong-Jones authored
This function is deprecated as of GTM 85341176, which we are about to roll past. Bug: 386671 Change-Id: I134cca2c9c2252ceaa63facb289ac907a1774696 Reviewed-on: https://chromium-review.googlesource.com/c/1478498 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#633738}
-
Martin Robinson authored
AtkText APIs support getting text via various boundary and granularity types. This change extends support to the API to include all API / boundary combination used by Orca. Bug: 866337 Change-Id: Id9e92b790d753f42afab0e8b27f04ce97c51a65b Reviewed-on: https://chromium-review.googlesource.com/c/1461043 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#633737}
-
Xianzhu Wang authored
This reverts commit f70ca727. Reason for revert: crbug.com/933693 Original change's description: > Optimize TransformPaintPropertyNode for 2d translations > > Based on crrev.com/c/1457744, this CL also optimizes > TransformPaintPropertyNode by storing 2d translation by default, > and allocate TransformationMatrix only when the transform is > not identity or 2d translation. > > Combined with crrev.com/c/1457744, this CL can improve > record_time by 3.2%, record_time_caching_disabled by 1.9%, > record_time_subsequence_caching_disabled by 2.1%, > pixel_recorded by 2.7%: > https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20190213071211/html/index.html > > Bug: 921729 > Change-Id: I41ba5d81477fd1339b4aaca29d4518023aa2abdc > Reviewed-on: https://chromium-review.googlesource.com/c/1460135 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#633482} TBR=wangxianzhu@chromium.org,pdr@chromium.org,chrishtr@chromium.org Change-Id: I55930b83f3eae22e282def26db569b08ce7ebbab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 921729, 933693 Reviewed-on: https://chromium-review.googlesource.com/c/1478943Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#633736}
-
chrome://browser-switchNicolas Ouellet-payeur authored
This adds the BrowserSwitcherDelay policy, which is a # of milliseconds to wait on the chrome://browser-switch page before launching the alternative browser. Bug: 887005 Change-Id: I73228251fdbc446ae632f4807c23f403506d289f Reviewed-on: https://chromium-review.googlesource.com/c/1478083Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#633735}
-
Robert Ogden authored
Bug: 933665 Change-Id: I99b895de5345808b3d5ca3fcf2f78fe39bf0177a Reviewed-on: https://chromium-review.googlesource.com/c/1478933 Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#633734}
-
Tatiana Buldina authored
Bug: chromedriver:2080 Change-Id: I5e8eef67c4489caee61c2e7d6945b5d8671e8d71 Reviewed-on: https://chromium-review.googlesource.com/c/1478397Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#633733}
-
Moe Ahmadi authored
These histograms are equivalent to the ones in TranslateCompactInfoBar.java Bug: 910994 Change-Id: Id52acce20babf34582481e840d92ab2d462d88b0 Reviewed-on: https://chromium-review.googlesource.com/c/1476976Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#633732}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1baa5dddb7dc..74142cf4ffe7 git log 1baa5dddb7dc..74142cf4ffe7 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 taylori@google.com Merge "perfetto-ui: Workaround protozero bug" Created with: gclient setdep -r src/third_party/perfetto@74142cf4ffe7 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I661f2ef929857b4345f2a15c746875f59d4df2f2 Reviewed-on: https://chromium-review.googlesource.com/c/1477402Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633731}
-
Eli Ribble authored
Reland commit f4f6c5ff Revert was 172ccc05 The previous attempt at a reland changed FetchGitRevision which caused breakage when chrome/test/chromedriver/embed_version_in_cpp.py attempted to call this function. https://crrev.com/c/1459921 was recently merged which completely removed embed_version_in_cpp.py which should allow this change to re-land without modification from the previous attempt at a reland. Change-Id: I0dbd7436938ae27167a9381415277d95d0d8312f Bug: 917159 Reviewed-on: https://chromium-review.googlesource.com/c/1460454Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Eli Ribble <eliribble@chromium.org> Cr-Commit-Position: refs/heads/master@{#633730}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9e3080f52cbc..177cd13347a9 git log 9e3080f52cbc..177cd13347a9 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@177cd13347a9 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I9b42a11dbc628c41347c592a1a471d3659680edf Reviewed-on: https://chromium-review.googlesource.com/c/1477401Reviewed-by:
-
Daniel Bratell authored
In an effort to reduce or even ban variable shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact warnings this avoids is: third_party/blink/renderer/modules/filesystem/directory_reader.cc:140:21: error: declaration shadows a local variable [-Werror,-Wshadow] EntryHeapVector entries; ^ third_party/blink/renderer/modules/filesystem/directory_reader.cc:136:57: note: previous declaration is here void DirectoryReader::AddEntries(const EntryHeapVector& entries) { ^ third_party/blink/renderer/modules/filesystem/dom_window_file_system.cc:248:37: error: declaration shadows a local variable [-Werror,-Wshadow] Vector<ScriptPromise> result; ^ third_party/blink/renderer/modules/filesystem/dom_window_file_system.cc:238:32: note: previous declaration is here base::File::Error result, ^ Bug: 923510 Change-Id: Ib907382435b0d1417e9ca2f070bfb68ef591e123 Reviewed-on: https://chromium-review.googlesource.com/c/1478871 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#633728}
-
Nate Fischer authored
No change to logic. This proposes an OWNERS file for WebView's net-service-specific code, and makes Tim and I owners (since we're the primary engineers for the WebView-specific work). R=timvolodine@chromium.org, tobiasjs@chromium.org Bug: 841556 Test: N/A Change-Id: Id2b8ed4e9229b1ec18336821c2aa257183a3d122 Reviewed-on: https://chromium-review.googlesource.com/c/1478352Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#633727}
-
Mike West authored
Rather than sending a `Sec-CH-UA` header containing the full version number by default (e.g. "Chromium 99.0.1232.12"), send only the major version (e.g. "Chromium 99"). This does not effect the value of `UserAgent.version` obtained from `navigator.getUserAgent()`, but only the HTTP request header. Bug: 928669 Change-Id: I074e244a3918b0bdab4453c2f56dc737c506f732 Reviewed-on: https://chromium-review.googlesource.com/c/1475438Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
David Roger authored
This CL fixes an edge case where multilogin flow and merge session flow were behaving differently. The right behavior is the multilogin one. Bug: none Change-Id: Id815b6089dca48f51d712653801538b51212914e Reviewed-on: https://chromium-review.googlesource.com/c/1477605Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#633725}
-
Mohamed authored
This change removes the member is_external_protocol and changes the getter to get it directly from the GetContentClient. Change-Id: Iec3ac802bbf051e4f295b765bc4385114739d611 Bug: 916537 Reviewed-on: https://chromium-review.googlesource.com/c/1477697Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#633724}
-
edchin authored
This enables by default an experiment that uses the faster |-drawViewHierarchyInRect:| instead of |-renderInContext:|. TEST=Ensure that snapshots entering/exiting the tab grid look good. Test NTP, "No internet connection" page, and sad tab page. Bug: 636188 Change-Id: I8f482ce189a89a578ed79f4b6add7a303cbfb327 Reviewed-on: https://chromium-review.googlesource.com/c/1450973Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#633723}
-
chrome://settingsLucas Tenório authored
This change adds a button that toggles the Contained Shell pref and signs out the current user. Since this is a rough transition, we are also adding a dialog that warns users that we need to sign them out. Bug: 922687 Change-Id: I88f161ee7bfd2e1f26c00840c6ac66c65d8eed64 Reviewed-on: https://chromium-review.googlesource.com/c/1471110 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#633722}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ca145bec7f33..bc42944741bc git log ca145bec7f33..bc42944741bc --date=short --no-merges --format='%ad %ae %s' 2019-02-20 robertphillips@google.com Switch image filters over to GrRecordingContext Created with: gclient setdep -r src/third_party/skia@bc42944741bc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I8dbdc887e2021c1ac41234860a781a8761eb6b25 Reviewed-on: https://chromium-review.googlesource.com/c/1477398Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e82643fb9c64..109b5fb5f5b2 git log e82643fb9c64..109b5fb5f5b2 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 mbonadei@webrtc.org Revert "Extend TransportSequenceNumber RTP header extension" 2019-02-20 kron@webrtc.org Extend TransportSequenceNumber RTP header extension 2019-02-20 eshr@google.com Clarify that pacing rate is based on raw target rate 2019-02-20 srte@webrtc.org Adds support for VP8 simulcast to scenario tests. 2019-02-20 eladalon@webrtc.org Create version 01 of Generic Frame Descriptor - with discardability flag 2019-02-20 titovartem@google.com Add a task queue into pc e2e fixture implementation Created with: gclient setdep -r src/third_party/webrtc@109b5fb5f5b2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ide7ab8132754ea916d5dabb2235e042cca31dccd Reviewed-on: https://chromium-review.googlesource.com/c/1477396Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/274ad0c9456b..106dac4e61d8 Created with: gclient setdep -r src-internal@106dac4e61d8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I15eb7451fcecc33311cfbded56a42686a86a2a66 Reviewed-on: https://chromium-review.googlesource.com/c/1477399Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633719}
-
Nick Diego Yamane authored
Wayland compositors let clients know about keyboard layout index currently set using the "group" parameter in wl_keyboard::modifiers event[1]. Currently it is used to update the libxkbcommon modifiers mask and generate the corresponding event flags value, but is not used later on when translating keysyms into UTF characters (when xkb_state_update_modifiers function is used again). That makes the keys to be converted using incorrect layout. To fix it, this CL does the following: 1. Rename GetModifierFlags -> UpdateModifiers; modifying it to be non-const and then be able to cache 'group' value (coming from wl_keyboard::modifiers event) into the new layout_index_ class variable; 2. In XkbLookup method, pass in the previously cached layout_index_ when calling xkb_state_update_modifiers function, making the characters to be correctly converted when xkb_state_key_get_utf32 is called. [1] https://wayland.freedesktop.org/docs/html/apa.html#protocol-spec-wl_keyboard Bug: 921947 Change-Id: I5758da5b771bd46c6a43250439b63b0911f51fbb Reviewed-on: https://chromium-review.googlesource.com/c/1474041Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Nick Diego Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#633718}
-
Alexander Timin authored
Move TaskAnnotator out of base::debug namespace (as is also runs tasks, which can be useful not only for debug but also in some other cases). Move it to base/task/common to other task posting and running infrastructure. R=gab@chromium.org TBR=gab@chromium.org Change-Id: Ia464c7476f9d8342f417f364fb2a66a87899b02b Reviewed-on: https://chromium-review.googlesource.com/c/1477894 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#633717}
-
Maksim Sisov authored
$ git log --oneline ff1ecaf...4fe3038 4fe3038 Reland "minigbm: define GBM_BO_IMPORT_FD_MODIFIER" eea88fa minigbm:amdgpu: align stride to 256 067594b minigbm: msm: Add modifier for tiled buffer allocation 90f8bb0 minigbm: Fix some clang-format issues c65bd8c minigbm: msm: Add platform specific alignment for NV12 linear format 400e928 Revert "minigbm: define GBM_BO_IMPORT_FD_MODIFIER" bc667c3 minigbm: define GBM_BO_IMPORT_FD_MODIFIER ff66c80 amdgpu: use amdgpu_gem_wait_idle_ioctl to wait for GPU to finish. 74e4893 amdgpu: Don't use AMDGPU_GEM_CREATE_EXPLICIT_SYNC flag. d7630cd amdgpu: fix misplaced code block 39eb951 minigbm: i915: Do not use I915_MMAP_WC for camera buffers 11161ac minigbm: add MINIGBM define. ee98f4e minigbm: align width so that stride aligns to 256 617ee71 minigbm: minimal buffer allocation support using msm gem ioctls 71bc665 minigbm: don't advertise BGR24 as a render/texture target 86ddfdc minigbm: use drv_add_combination when adding a single combination 2fdb721 minigbm: delete unused functions and definitions 2b1d689 minigbm: run clang-format a72f442 minigbm: mediatek: always provide munmap() with a valid address 500928f minigbm: mediatek: wait for outstanding operations when invalidating b131c9d minigbm: msm: add supported formats 571a687 minigbm/i915.c: Android's HAL_PIXEL_FORMAT_BLOB is not tilable if BO_USE_PROTECTED d706a8c minigbm: move height adjustments to helper function 79155d7 minigbm: run clang-format a13dda7 minigbm: support NV12 in virtio_gpu af94db9 minigbm: adjust height of NV12 buffer in helper Bug: 933123 Change-Id: I174363f379407697ae0d571175ecc43d4cc51d3e Reviewed-on: https://chromium-review.googlesource.com/c/1477075 Auto-Submit: Maksim Sisov <msisov@igalia.com> Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
Daniel Bratell authored
In an effort to reduce or even ban variable shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact error this avoid is: third_party/blink/renderer/modules/cache_storage/inspector_cache_storage_agent.cc:313:22: error: declaration shadows a local variable [-Werror,-Wshadow] for (const auto& request_response : responses_) { ^ third_party/blink/renderer/modules/cache_storage/inspector_cache_storage_agent.cc:277:22: note: previous declaration is here RequestResponse& request_response = Bug: 923510 Change-Id: I8f6b6cd11f80a254c2c926e934dacefaa6dfccf8 Reviewed-on: https://chromium-review.googlesource.com/c/1477285Reviewed-by:Ben Kelly <wanderview@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#633715}
-
Michael Lippautz authored
The root in AbortSignal was creating the following cycle with unified heap: Request -> AbortSignal -> AbortSignal (root) -> ExecutionContext -> Request Bug: 928781,843903 Change-Id: Iefad41f37fe3ccb3960a7c3d9e1b963730aab7ec Reviewed-on: https://chromium-review.googlesource.com/c/1477241Reviewed-by:
-
Sylvain Defresne authored
Update the implementation of AutofillAutomationTestCase to use JSONReader::Read instead of JSONReader::ReadDeprecated. Bug: 925165 Change-Id: I6048349675225b82f04274b209064d258ef02ac2 Reviewed-on: https://chromium-review.googlesource.com/c/1477226 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#633713}
-
Christian Dullweber authored
This reverts commit 8c4d384b. Reason for revert: Probably caused flakiness: https://crbug.com/933788 Original change's description: > Tracing: Re-add the Coordinator::StartTracing callback > > This effectively reverts http://crrev.com/627423 and then implements > the callback in a different way. > > The issue is that there are cases (mostly tests) that use this pattern: > 1. Start tracing > 2. Wait for BeginTracing callback > 3. Send IPC to some other child process to add trace events. > > With the tracing service now running on-demand, this would be inherently > flaky. The CL which this is reverting changed the behavior to send > the callback when the browserprocess got tracing enabled, which covers most > cases, but not all of them. > > This CL (see diff between patchset 1 and last, for the actual changes) > re-implements the central callback by leveraging service_manager callbacks > to try and wait for running services to connect back and have tracing > enabled. > > TBRing owners for files that do not include any of the new changes, > only the revert. > > R=ssid@chromium.org > TBR=yusukes@chromium.org,nasko@chromium.org > BUG=843467,929802 > > Change-Id: Ifd8e6a927a2bc3e946dde22cc7c30678e294a8dd > Reviewed-on: https://chromium-review.googlesource.com/c/1474309 > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Commit-Queue: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#633659} TBR=yusukes@chromium.org,nasko@chromium.org,oysteine@chromium.org,ssid@chromium.org Change-Id: I67afcf62b0637cae17281f3433cf9f630ec385ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843467, 929802, 933788 Reviewed-on: https://chromium-review.googlesource.com/c/1477682Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#633712}
-
