GitLab

std::vector<>::data() is a C++11 feature and not available on all
toolchains. This uses &vector[0] instead.

Review URL: https://codereview.chromium.org/393583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284558 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384897

Review URL: https://codereview.chromium.org/404613009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284557 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377852

Review URL: https://codereview.chromium.org/379293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284556 0039d316-1c4b-4281-b951-d872f2087c98

Fixing some of the strings that are used for permissions warnings to ensure their consistency.

BUG=362794
R=felt

Review URL: https://codereview.chromium.org/405653005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284555 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284553 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/3d533ac917eaadf2fb3561f57d7266d8c0e665fd..ad1df153a16b7723d2d4afd13627919fc3ee87ce

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=robertphillips@google.com
BUG=

Review URL: https://codereview.chromium.org/404443006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284552 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of https://codereview.chromium.org/402993002/ with an additional check to make sure that the DLLs exist before trying to copy them.

BUG=395183

Review URL: https://codereview.chromium.org/405983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284550 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393413

Review URL: https://codereview.chromium.org/387163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284549 0039d316-1c4b-4281-b951-d872f2087c98

Older versions of gcc, like 4.6.* (which is the default on ubuntu 12.04 LTS), throw build error for using const_iterator.
This has been documented here [1]

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57158

Review URL: https://codereview.chromium.org/401263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284548 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/407713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284547 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394821

Review URL: https://codereview.chromium.org/405693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284546 0039d316-1c4b-4281-b951-d872f2087c98

Also fix an issue with missing constriants logged at webrtc-internals.

See a snapshot of the UI at https://docs.google.com/a/google.com/presentation/d/1dL2flqsQj8h_dTO9t8BWOCjiwbLiZCN2Nt93FHqpM9o/edit?usp=sharing

BUG=304023

Review URL: https://codereview.chromium.org/405683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284545 0039d316-1c4b-4281-b951-d872f2087c98

In Yosemite, holding down alt while clicking the fullscreen button is supposed
to zoom the window. This doesn't work because Chrome violates unstated AppKit
assumptions.

The problem seems to lie in hit testing the location of the zoom button.
Reordering the subviews by moving the tab strip and the content view behind the
zoom button fixes the problem.

BUG=393808

Review URL: https://codereview.chromium.org/402443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284544 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284540 0039d316-1c4b-4281-b951-d872f2087c98

This broke linux builder:
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Builder%20%28dbg%29&number=75554

[1147/10681 | 99.521] CXX
obj/net/disk_cache/simple/net.simple_net_log_parameters.o
FAILED: cd ../../chrome/test/data/nacl; python
../../../../native_client/build/build_nexe.py -t
../../../../out/Debug/gen/sdk/ --arch x86-32 --build newlib_translate
--root ../../../.. --name
../../../../out/Debug/ppapi_ppb_instance_pnacl_newlib_x32.nexe
"--link_flags=
-Wl,-L../../../../out/Debug/gen/tc_pnacl_translate/lib-x86-32"
../../../../out/Debug/nacl_test_data/pnacl/ppapi_ppb_instance_newlib_pnacl.pexe
/b/build/slave/Linux_Builder__dbg_/build/src/out/Debug/gen/sdk/linux_x86/pnacl_newlib/host_x86_32/bin/le32-nacl-ld.gold:error:
cannot open
../../../../out/Debug/gen/tc_pnacl_translate/lib-x86-32/libpnacl_irt_shim.a:
No such file or directory
/b/build/slave/Linux_Builder__dbg_/build/src/out/Debug/gen/sdk/linux_x86/pnacl_newlib/lib-x86-32/crtbegin.o:/mnt/data/b/build/slave/nacl-toolchain/build/native_client/toolchain_build/out/libs_support_native_x86_32_install/lib-x86-32/crtbegin.o---crtbegin.c---.expand.po:function
__pnacl_start:error: undefined reference to '_pnacl_wrapper_start'
../../../../out/Debug/gen/sdk/linux_x86/pnacl_newlib/bin/pnacl-translate
-arch x86-32
../../../../out/Debug/nacl_test_data/pnacl/ppapi_ppb_instance_newlib_pnacl.pexe
-o ../../../../out/Debug/ppapi_ppb_instance_pnacl_newlib_x32.nexe
-Wl,-L../../../../out/Debug/gen/tc_pnacl_translate/lib-x86-32
FAILED: Command
'['../../../../out/Debug/gen/sdk/linux_x86/pnacl_newlib/bin/pnacl-translate',
'-arch', 'x86-32',
'../../../../out/Debug/nacl_test_data/pnacl/ppapi_ppb_instance_newlib_pnacl.pexe',
'-o',
'../../../../out/Debug/ppapi_ppb_instance_pnacl_newlib_x32.nexe',
'-Wl,-L../../../../out/Debug/gen/tc_pnacl_translate/lib-x86-32']'
returned non-zero exit status 1
ninja: build stopped: subcommand failed.

> NaCl: Update revision in DEPS, r13456 -> r13506
> 
> This pulls in the following Native Client changes:
> 
> r13457: (dyen) LLVM Regression tests check for build files instead of empty dirs.
> r13458: (noelallen) Update and add GN files to build sel_ldr.
> r13459: (jvoung) Remove env cleanser references to obsolete env vars.
> r13460: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> r13461: (hamaji) Non-SFI Mode: Add prctl syscall wrapper
> r13462: (hamaji) Non-SFI Mode: Implement IRT fstat
> r13463: (hamaji) Correct the return type of TestSuite in timefuncs_test
> r13464: (hamaji) syscall_test: Do not test st_atime in the test for fstat
> r13465: (earthdok) Implement initial MSan support. Also, adjust ASan build flags.
> r13466: (dschuff) pnacl-ld: Do not attempt to parse ELF or bitcode files as linker scripts
> r13467: (jvoung) Remove NaClSrpcIsStandalone() function.
> r13468: (dschuff) Make testing architecture explicit PNaCl toolchain buildbot script
> r13469: (dschuff) Stub out pnacl-opt and pnacl-finalize tools for scons built_elsewhere=1
> r13470: (dschuff) Update revision for PNaCl r13392->r13466
> r13471: (noelallen) Build nacl_bootstrap_helper and test with GN scons
> r13472: (dschuff) Build PNaCl with mingw again
> r13473: (earthdok) Zap the NaClSignalContext struct in SignalCatch.
> r13474: (dschuff) Update revision for PNaCl r13466->r13472
> r13475: (sehr) Munge nacl_helper_bootstrap using python rather than libelf
> r13476: (sky) Changes scan_sources not to output on bogus directory
> r13477: (dschuff) Reduce debugging metadata for pexe builds in Chrome
> r13480: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> r13481: (hidehiko) Align at 16 bytes for stack for created thread.
> r13484: (jfb) Revert "Munge nacl_helper_bootstrap using python rather than libelf"
> r13485: (ncbray) Fix untrusted.gypi and build_nexe.py
> r13486: (teravest) Split nacl_defines to an importable .gni file.
> r13487: (dyen) Actually make package_version include logs when argument is set.
> r13488: (jfb) Update revision for PNaCl r13472->r13480
> r13489: (hidehiko) Wrap irt_interfaces.h by extern "C".
> r13490: (hidehiko) Non-SFI Mode: Implement irt_mprotect.
> r13493: (jvoung) Revert "Non-SFI Mode: Implement irt_mprotect."
> r13494: (noelallen) Add per-file OWNERS for .gn in this sub directory since per-file only works on the directory the OWNERS is in.
> r13495: (noelallen) Fix vc_toolchain.py paths.
> r13496: (noelallen) Revert of 7e955d3ab6159dc05a7f255c6daf03847809414a
> r13497: (dyen) Implemented Exists for pynacl.LocalStorageCache.
> r13500: (hidehiko) Non-SFI Mode: Make elf_loader usable from Chrome.
> r13503: (jvoung) PNaCl: Update compiler-rt revision in pnacl/COMPONENT_REVISIONS
> r13504: (sehr) Munge nacl_helper_bootstrap using python rather than libelf
> r13505: (dschuff) Roll PNaCl toolchain revision back to r13466
> r13506: (dschuff) Revert "Fix untrusted.gypi and build_nexe.py"
> 
> BUG=none
> TEST=browser_tests and nacl_integration
> CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_nacl_sdk_build
> (omitting linux_rel_precise32 and linux_arm_cross_compile because they're currently broken)
> 
> Review URL: https://codereview.chromium.org/404663002

TBR=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/409733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284539 0039d316-1c4b-4281-b951-d872f2087c98

Ephemeral apps are not shown in the app launcher or NTP, but they are
assigned ordinals, which results in unfilled NTP pages. This patch
does not give ephemeral apps launch ordinals until they are promoted
to fully installed apps.

AppSorting::MarkExtensionAsHidden() was refactored to
AppSorting::SetExtensionVisible() to allow the visibility of the
extension in the NTP to change.

BUG=394192
TEST=browser_tests

Review URL: https://codereview.chromium.org/397903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284536 0039d316-1c4b-4281-b951-d872f2087c98

This change passes the basic auth information to android mediaplayer to solve the issue that media with basic auth is not able to play.
Previously MediaInfoLoader and MediaResourceGetter could be ran at the same time. 
However, MediaResourceGetter could miss the credential info if we do that. 
As a result, we should wait until MediaInfoLoader finishes before creating the browser side MediaPlayer.

BUG=319885

Review URL: https://codereview.chromium.org/405663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284535 0039d316-1c4b-4281-b951-d872f2087c98

Enable DCHECKs in Lock and ConditionVariable when compiled
with dchecks_always_on.

Note the correctness of DCHECKs relies on DCHECKs enabled
in both Lock and ConditionVariable. This CL keeps the
condition to enable DCHECKs in ConditionVariable the
same as Lock, to avoid any issues here.

BUG=

Review URL: https://codereview.chromium.org/403803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284534 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369643
TEST=None

Review URL: https://codereview.chromium.org/408853005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284533 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284532 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13457: (dyen) LLVM Regression tests check for build files instead of empty dirs.
r13458: (noelallen) Update and add GN files to build sel_ldr.
r13459: (jvoung) Remove env cleanser references to obsolete env vars.
r13460: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13461: (hamaji) Non-SFI Mode: Add prctl syscall wrapper
r13462: (hamaji) Non-SFI Mode: Implement IRT fstat
r13463: (hamaji) Correct the return type of TestSuite in timefuncs_test
r13464: (hamaji) syscall_test: Do not test st_atime in the test for fstat
r13465: (earthdok) Implement initial MSan support. Also, adjust ASan build flags.
r13466: (dschuff) pnacl-ld: Do not attempt to parse ELF or bitcode files as linker scripts
r13467: (jvoung) Remove NaClSrpcIsStandalone() function.
r13468: (dschuff) Make testing architecture explicit PNaCl toolchain buildbot script
r13469: (dschuff) Stub out pnacl-opt and pnacl-finalize tools for scons built_elsewhere=1
r13470: (dschuff) Update revision for PNaCl r13392->r13466
r13471: (noelallen) Build nacl_bootstrap_helper and test with GN scons
r13472: (dschuff) Build PNaCl with mingw again
r13473: (earthdok) Zap the NaClSignalContext struct in SignalCatch.
r13474: (dschuff) Update revision for PNaCl r13466->r13472
r13475: (sehr) Munge nacl_helper_bootstrap using python rather than libelf
r13476: (sky) Changes scan_sources not to output on bogus directory
r13477: (dschuff) Reduce debugging metadata for pexe builds in Chrome
r13480: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13481: (hidehiko) Align at 16 bytes for stack for created thread.
r13484: (jfb) Revert "Munge nacl_helper_bootstrap using python rather than libelf"
r13485: (ncbray) Fix untrusted.gypi and build_nexe.py
r13486: (teravest) Split nacl_defines to an importable .gni file.
r13487: (dyen) Actually make package_version include logs when argument is set.
r13488: (jfb) Update revision for PNaCl r13472->r13480
r13489: (hidehiko) Wrap irt_interfaces.h by extern "C".
r13490: (hidehiko) Non-SFI Mode: Implement irt_mprotect.
r13493: (jvoung) Revert "Non-SFI Mode: Implement irt_mprotect."
r13494: (noelallen) Add per-file OWNERS for .gn in this sub directory since per-file only works on the directory the OWNERS is in.
r13495: (noelallen) Fix vc_toolchain.py paths.
r13496: (noelallen) Revert of 7e955d3ab6159dc05a7f255c6daf03847809414a
r13497: (dyen) Implemented Exists for pynacl.LocalStorageCache.
r13500: (hidehiko) Non-SFI Mode: Make elf_loader usable from Chrome.
r13503: (jvoung) PNaCl: Update compiler-rt revision in pnacl/COMPONENT_REVISIONS
r13504: (sehr) Munge nacl_helper_bootstrap using python rather than libelf
r13505: (dschuff) Roll PNaCl toolchain revision back to r13466
r13506: (dschuff) Revert "Fix untrusted.gypi and build_nexe.py"

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_nacl_sdk_build
(omitting linux_rel_precise32 and linux_arm_cross_compile because they're currently broken)

Review URL: https://codereview.chromium.org/404663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284531 0039d316-1c4b-4281-b951-d872f2087c98

This broke compile on android:
http://build.chromium.org/p/chromium/builders/Android/builds/26268/steps/compile/logs/stdio

../android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java:794:
cannot find symbol
symbol  : class DisabledTest
location: class
org.chromium.android_webview.test.AwContentsClientShouldOverrideUrlLoadingTest
    @DisabledTest
     ^
1 error

> Disable a flaky test.
> 
> BUG=395817
> TEST=none
> TBR=joth
> 
> Review URL: https://codereview.chromium.org/408043002

TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/407003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284530 0039d316-1c4b-4281-b951-d872f2087c98

While writing some new tests I ran into some hard to track down failures
that were a result of:
  1) Using AudioBufferConverter due to different input/output rates
  2) Using "int" for all input/output frame counts

For example, DeliverRemainingAudio() would actually over-deliver since
it didn't take the ratio of input/output rates into account.

To help make things better, use the type system to differentiate between
input and output frame counts. In addition, use simpler input/output
rates to make it easier to calculate expected time and frame values.

BUG=370634

Review URL: https://codereview.chromium.org/403003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284529 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the SSL interstitial only displayed this for the non-overridable pages. Now it displays it for all SSL errors.

BUG=

Review URL: https://codereview.chromium.org/407693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284528 0039d316-1c4b-4281-b951-d872f2087c98

Each GuestView derived type is now responsible for managing it's own construction.

BUG=none

Review URL: https://codereview.chromium.org/409603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284527 0039d316-1c4b-4281-b951-d872f2087c98

Predictor is modified to call functions CanPredictNetworkActionsIO and
CanPredictNetworkActionsUI to comply with user preferences (and consider
network connection state).  This obsoletes Predictor::EnablePredictor.  Also,
bool members Predictor::preconnect_enabled_ and Predictor::predictor_enabled_
now depend solely on command line switches, therefore they are made const.

BUG=334602

Review URL: https://codereview.chromium.org/360733005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284526 0039d316-1c4b-4281-b951-d872f2087c98

Remove the remaining overrides of View::GetEventHandlerForRect()
and instead implement ViewTargeterDelegate::TargetForRect().
Make View::GetEventHandlerForRect() non-virtual.

BUG=391845
TEST=none

Review URL: https://codereview.chromium.org/403963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284525 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/391413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284524 0039d316-1c4b-4281-b951-d872f2087c98

BUG=278919
NOTRY=True

Review URL: https://codereview.chromium.org/375133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284523 0039d316-1c4b-4281-b951-d872f2087c98

This file is used by the cq to measure loads and other stats. We want
changes to it to result in a compile and test.

BUG=383609
TEST=none
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/403393007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284522 0039d316-1c4b-4281-b951-d872f2087c98

RTCP sender report has a race condition when then current time is
submitted asynchronously (from another process). This caused the value
for DLRR to be negative.

This code is going to be removed it is fine to just suppress this
condition.

BUG=393042
NOTRY=true

Review URL: https://codereview.chromium.org/410433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284521 0039d316-1c4b-4281-b951-d872f2087c98

'WebURLRequest::TargetType' has been dropped in Blink in favor of
'RequestContext' and 'FrameType', matching the Fetch specification's
changes, and allowing both more granularity in various Blink-side checks
and more clarity around the thing that caused a request, and the frame
that the request affects.

This CL should have zero practical effect, as it's simply hoisting the
translation work that 'WebURLRequest::setTargetType' is already doing
up into the content layer to bring us one step closer to removing the
concept entirely.

There's still one call to 'ResourceType::FromTargetType' in
RenderFrameImpl that this CL doesn't remove: that method will be
converted to RequestContext in a future CL.

BUG=390497

Review URL: https://codereview.chromium.org/403323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284520 0039d316-1c4b-4281-b951-d872f2087c98

They were previously only disabled in static_library builds. This is believed
to have been due to problems with old MSVC versions, but it should work now.

This change is relevant for Clang, which currently doesn't support exceptions
on Windows.

Last time I attempted to do this, it broke some tests due to a debug assertion.
Gtest had previously been catching the exception, but with exceptions disabled
it crashed. Those tests were actually broken in static_library Debug builds
too, but we don't seem to have bots for that. After Blink r176189, we no longer
hit that debug assertion, so the tests now pass.

BUG=82385
TEST=blink_platform_unittests --gtest_filter=DateTimeFormatTest.CommonPattern,
     content_browsertests --gtest_filter=RenderViewImplTest.SetEditableSelectionAndComposition
     webkit_unit_tests

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/404853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284519 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395817
TEST=none
TBR=joth

Review URL: https://codereview.chromium.org/408043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284518 0039d316-1c4b-4281-b951-d872f2087c98

> GN chrome/common build, rename enable_printing.
> 
> This adds the missing conditions to the chrome/common GN build file (previously
> only the basic files were there). Some refactoring of the GYP file to make this
> possible.
> 
> Renames the enable_printing flag to printing_mode since this is an integer
> tri-state.
> 
> Minor improvements to chrome/renderer
> 
> R=jamesr@chromium.org
> 
> Review URL: https://codereview.chromium.org/400243003

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/409543008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284517 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395726
TEST=none
TBR=miu

Review URL: https://codereview.chromium.org/410453006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284516 0039d316-1c4b-4281-b951-d872f2087c98

jingle_glue_test_util was added long time ago for P2P API in Pepper.
The API was removed long time ago and we no longer need
jingle_glue_test_util.

Review URL: https://codereview.chromium.org/400093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284514 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395796
TEST=none
TBR=elijahtaylor, asargent

Review URL: https://codereview.chromium.org/405233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284510 0039d316-1c4b-4281-b951-d872f2087c98

A check for unused variables was missing for some helper functions.
The main thing that this affects is the "config" function, where
people were confused when setting deps or configs didn't work the
way they expected (because they were unused).

BUG=392026
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/399143006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284509 0039d316-1c4b-4281-b951-d872f2087c98

This adds the missing conditions to the chrome/common GN build file (previously
only the basic files were there). Some refactoring of the GYP file to make this
possible.

Renames the enable_printing flag to printing_mode since this is an integer
tri-state.

Minor improvements to chrome/renderer

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/400243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284508 0039d316-1c4b-4281-b951-d872f2087c98