- 21 Jan, 2021 40 commits
-
-
Tommy Nyquist authored
This reverts commit 305cf78b. Reason for revert: Crashing many browser tests, in particular BackgroundTracingManagerBrowserTest.* Original change's description: > tracing: make PosixSystemProducer work in child processes on Posix. > > The security sandbox forbids making socket connections directly from > within most child processes (except the network utility process). Trace > data for renderers are missing from a tracing session with Chrome data > sources on non-Android Posix platforms. > > This change introduces a new Mojo interface, SystemTracingService, that > is shared between the browser and child processes for making a socket > connection to the system tracing service daemon. A child process > receives a Mojo remote interface and then invokes the OpenProducerSocket > method to open the socket connection in the browser process. The browser > process then passes the socket connection to the child in the response. > The child process then adopts the connected socket in initializing the > connection in PosixSystemProducer. > > Full design doc: go/crosetto-chrome-producer-dd > > SystemPerfettoTest.SandboxedOpenProducerSocket > > Bug: b/147789115 > Test: services_unittests: SystemTracingServiceTest.*, > Change-Id: Id698dc656b7b9ede723e3a887532c33544914edc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435129 > Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844743} TBR=kinuko@chromium.org,primiano@chromium.org,skyostil@chromium.org,eseckler@chromium.org,chinglinyu@chromium.org,nuskos@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/147789115, 1169185 Change-Id: Ibe932297b317fdee6cbd9ef5b09ad1aeffd2f1ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643258Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#845763}
-
Peter Wen authored
Recursive resource deps is meant for an android_library target to directly depend on all of its transitive resource deps. A target that does this also needs to rebuild its build config file when its transitive java library deps change, since otherwise, if a transitive resource dep is removed from the build by being removed from the java target that used to depend on it, the recursive resource target's build config would be stale and the removed resource would be included in the final apk/bundle. Example: A: Resource dep that turns on recursive_resource_deps. B: Java library C: Java library D: Resource dep A depends on B depends on C depends on D. Previously, A's depfile would only contain D.build_config. But if C removes D as a dependency, and the removal doesn't result in a change for B.build_config, A.build_config would not be rebuilt, since it only depends on B.build_config (via direct dep) and D.build_config (via recursive_resources_deps). Thus entirely missing the change to C.build_config. Bug: 1168655 Fixed: 1168655 Change-Id: I500d307802d64ef81099540ebd6fb54f4953c270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639227Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#845762}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/79b1b0af2eb9..dc8ef8034344 2021-01-21 fmayer@google.com Merge "Add ELOG to truncation path in UnixSocket." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I136ed8a0493cd4120750bcda93104e78c4eb1fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642815Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845761}
-
Ben Mason authored
Change-Id: I75471776f45dd2d6cc7ee562f90c5690d2a23025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642958 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845760}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f28a06ba7281..203154b52a46 2021-01-21 syoussefi@chromium.org Vulkan: Remove swiftshader workaround for missing gl_Position If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I5b6dcf3cd35704ee71cd771e0c1ea2bc9809692e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643097Reviewed-by:
-
Anthony Vallee-Dubois authored
This is a reland of the CL reverted in https://chromium-review.googlesource.com/c/chromium/src/+/2628949. Bug: 1166369 Change-Id: I86c177e525a8e330f2b135106488febb0e2d5669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637954Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#845758}
-
Yuchen Liu authored
Bug: 177786478 Test: QA test shows the av sync is improved after disabling it. Change-Id: Ic9257ece4169b54b8b9126717657fb2abe80dcb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643402 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Auto-Submit: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#845757}
-
minch authored
Bug: 1166374 Change-Id: I9e513de723c7d27cd12ac0bb7604c4ebbe5200b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628254Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#845756}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1890f38f2471..8d1dafc6c231 2021-01-21 vidorteg@microsoft.com [Loc] Migrate heap_snapshot_worker to Localization V2 2021-01-21 tvanderlippe@chromium.org Disable Karma coverage preprocessing for component_docs 2021-01-21 andoli@chromium.org [module.json extensions] persistence views 2021-01-21 soxia@microsoft.com Service Workers Test Runner filters date information 2021-01-21 andoli@chromium.org [module.json extensions] Adds documentation on extension registrations. 2021-01-21 andoli@chromium.org [module.json extensions] protocol_monitor 2021-01-21 wolfi@chromium.org Fix: show OpenedWindowDetailsView when clicking on respective item in If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103,chromium:1136655,chromium:1153091,chromium:1159502 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5ec61b1d059fc8d54e4f1c402f9661688e25230c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642886Reviewed-by:
-
Henrique Nakashima authored
The getowners.py script periodically reads OWNERS files and git history and generates per-module data to be surfaced in go/clank- OWNERS files do not contain Monorail component, Team and OS information anymore, DIR_METADATA files have replaced them and broken the script since then. Bug: 1135347 Change-Id: Ib88e9d576d94ad5484b6a3dbbfff156639275dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634833Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#845754}
-
Eugene But authored
Bug: None Change-Id: I8959d5ef64a2242bf7002cb826a40087d96ef292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638418Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#845753}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e0d023562bd9..230cd50238f2 2021-01-21 mtklein@google.com close out simple assembler TODO If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: Ie33af84899b2882904cc92d804eb775c56165ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643236Reviewed-by:
-
Shengfa Lin authored
This reverts commit 28c5a54b. Reason for revert: The test failure cases mostly are real failures. Original change's description: > Disable __main__.ChromeDriverTest.testCanSwitchToPrintPreviewDialog > > It's flaky. > > I can't figure out how to mark it as flaky using this test harness, so disabling instead. > > BUG=1166314 > > Change-Id: I744540f637ec527dc33acf7d96190fd9a89e5914 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626415 > Commit-Queue: Mark Pearson <mpearson@chromium.org> > Auto-Submit: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Shengfa Lin <shengfa@google.com> > Cr-Commit-Position: refs/heads/master@{#843395} TBR=mpearson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,shengfa@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1166314 Change-Id: Ia8c5f9f0bef64a21f2b0066ba1f218b5aed0874d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641099Reviewed-by:
Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#845751}
-
Matt Reynolds authored
This CL adds a histogram to record the reason why the HID device chooser was closed. Bug: 964041 Change-Id: I1fbe006314b0d2faab57771f07ccf57c5ed01c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600218Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#845750}
-
Ahmed Fakhry authored
When recording a window or a partial region, the display can be rotated, or its device scale factor can change, leading to the DIPs display bounds changing. If we don't propagate this change to the recording service, the video capturer will try to fit (i.e. center and letter-box) the new frame dimensions into the original requested video resolution. This is ok when recording fullscreen, but leads to completely broken cropping when recording a region (See bug for video demo). It can also lead to a bad quality window recording. This CL fixes this issue by propagating display bounds changes to the service to reconfigure the video capturer and encoder if necessary (Demo of fix is on the bug). BUG=1168434 TEST=Manually, added a new test Change-Id: I9db5d29bddc217042b007b422b1084c86d8be959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641082Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#845749}
-
Joshua Pawlicki authored
If the device ID cannot be fetched, we prefer to still send the request with no ID. The client will be counted by CR counting, and we still prefer the client to get up-to-dateness info rather than fail the entire request. Bug: 1158707 Change-Id: Ic6a1a8653ff6db7fbfa2ed79d1906d2c8b50095a Fixed: 1158707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643178Reviewed-by:
-
Caitlin Fischer authored
The server-side config shows that the study has ended. Bug: 1126640 Change-Id: I8093fccdd6ab46e36178bb020ffec2ce3ed968ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631932Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#845747}
-
Avi Drissman authored
Bug: 1164487 Change-Id: I7a2fbfd53d7321b3fead090ead52f1de699f53af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631428Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845746}
-
David Maunder authored
Speedup: 14397ms -> 5191ms (64% improvement) Bug: 1168647 Change-Id: Idbf3a3e10cd4e4b04e5f34d0d997ca4bd8b05f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640919 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#845745}
-
Ben Pastene authored
This will prevent the goma bots from running tests on 10.10, which is being deprecated, and which appears to fail the tests anyway. Change-Id: I17ed6c430e5ea3ee7b7eaa95fd6653038706fece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641146Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#845744}
-
Yuwei Huang authored
Looks like calls to AudioQueue APIs don't always trigger audio capture permission request, e.g. it doesn't seem to pop up the permission dialog after I reset microphone permission with `tccutil reset Microphone`. Without audio capture permission, calls to AudioQueue APIs will still succeed as if everything works, but what we get will be empty buffers. Bug: 1168729 Change-Id: I5491e420fb907a1e438f57ef172ecb997f99e6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641145Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#845743}
-
Alice Wang authored
This CL uses AccountManagerTestRule instead of SyncTestRule in SigninFragmentTest to facilitate ProfileDataCache update tests in the future. Bug: 1167672 Change-Id: If3d8753b5a894a76b9db2d961aaa336306b717ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632678 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845742}
-
Olivier Yiptong authored
This adds the ability in TableView to add a range of items comprised of only 1 item. This requirement manifests itself when using a "select-all" capability. Prior to this CL, only ranges of 2+ items would be allowed. Furthermore, this fixes a bug when all items are selected while there is no 'active' row in a table. This can occur when the selection UI is outside of the TableView. Change-Id: I950fca34e8c83b650d14e0d6da3e7ad9d0b84f33 Fixed: 1169260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641320 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845741}
-
Dan Harrington authored
get_element_shadow_root Bug: 1168659 Change-Id: I0f6ae65d0ea995d5ea9cc2effa34053be7423db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640639Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#845740}
-
Austin Sullivan authored
This method just overrode the identically behaving implementation from the base WritableStream class. Intent to Implement and Ship thread here: https://groups.google.com/a/chromium.org/g/blink-dev/c/98OnGPp1_M8/m/HK4lRghLAgAJ Bug: 1163351 Change-Id: I8b6ffc033bbef22eb699eac50d8f79b829fa5a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613527 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#845739}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/54d70996a75a..21b394fcfab2 2021-01-21 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-21 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-21 vapier@chromium.org cros_sdk: drop cgroups usage 2021-01-21 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-20 vapier@chromium.org gs: update to latest 4.57 release 2021-01-20 vapier@chromium.org gs: fix unicode handling w/python2 2021-01-20 vapier@chromium.org apiclient: drop old alias 2021-01-20 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Iac01d2e095adbf2b238d92c1db0274f4bab98c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642820Reviewed-by:
-
Austin Eng authored
Bug: dawn:565 Change-Id: I530a1126c9b7043f35deadd1f5aaa6c256ca2bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633198 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#845737}
-
Matthias Körber authored
Currently, the return value is conditions on the actual import of an address. However, the import can only fail if the incognito mode is enabled, which is already checked beforehand. Therefore, the return value for an importable profile is set to be always true if the profile is importable to support a consistent behavior with future asynchronous import flows. Bug: 1135178 Change-Id: I7f062151706919439c82a6bd150ec8be7f219f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632963 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#845736}
-
Eugene But authored
Bug: None Change-Id: I6f21624edbe5bc5e428913265b078eee1de80430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638450Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Zhiyuan Cai authored
When users clicks the menu item "Track prices" in grid tab switcher, a PriceTrackingSettings dialog will pop up allowing users to turn on/off the features "Track prices on tabs" and "Price drop alerts". Bug: 1163136 Change-Id: I9d1d3401185f5d118ba7bfa2cfb4e35837c69d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611275 Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#845734}
-
dpapad authored
Fixed: 1168475 Change-Id: I3e63b2c710a12389e635803ccb473bf12e49e7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641985Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#845733}
-
Anders Hartvoll Ruud authored
This adds support for using basic pseudo-elements in @container rules. Complicated pseudo-elements (e.g. ::first-line) are deferred for later CLs. Bug: 1145970 Change-Id: I0b67ce446c16d3204fe14188981393ed6f2da269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637556 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#845732}
-
Regan Hsu authored
Previously, if the user clicked the (i) tooltip icon, the tooltip would not appear. Now it does. Bug: 1168153 Change-Id: I1bba717a760961ae1088d0bfba6b740940d05d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639228 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#845731}
-
Mike Dougherty authored
This reverts commit 8904382c. Reason for revert: This CL breaks AppStateTest.resumeSessionWithStartupParameters for iOS 12 devices. See https://ci.chromium.org/ui/p/chrome/builders/ci/iphone-device/15349/blamelist. Original change's description: > [iOS] Fix Session.TotalDuration metric with multiwindow. > > Track the session as open while there is at least one foreground window. > Log this in a dedicated app agent to avoid polluting AppState. > The same is done to IOSProfileSessionDurationsService's session > start/end events. > > Bug: 1156586 > Change-Id: I37586f989039206fbaa90f7ec4046fbf9582e70a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599870 > Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> > Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845653} TBR=mpearson@chromium.org,marq@chromium.org,msarda@chromium.org,stkhapugin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Icd927a3252658933c02c8101067657f3ac7365b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1156586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643264Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#845730}
-
Maksim Sisov authored
This test suite was disabled by accident in https://crrev.com/c/2476731 Enable it back. PS also added shards as in other places in test_suites.pyl file. Change-Id: I7a07fd729c09141859e8e6129d384f847345a87e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642778 Auto-Submit: Maksim Sisov <msisov@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#845729}
-
Stephen Roe authored
Add SDK arch directory to test data to allow discovery of SDK libraries. Adjust test size limits. Bug: 1126177 Change-Id: I807539c53153af6b804b7bad60c96a8e60fe515b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638075Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#845728}
-
Alan Screen authored
There were no preexisting unit tests for LocalPrinterHandlerDefault, even though some tests did exist for the ChromeOS-specific counterpart of LocalPrinterHandlerChromeos. Start to introduce some support for getting capabilities which will benefit testing coverage of new paths to support printer handling performed out of the browser process. This is basically just a slightly modified version of the StartGetCapability() tests which already exist for ChromeOS. Bug: 809738 Change-Id: Icee1fc72eddb4bd1f3721eb0e848ab14cd85f28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628025 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#845727}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e41b3bb941a6..ea17cd60ebc3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lgrey@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1164189,chromium:1166926 Tbr: lgrey@google.com Change-Id: I0abc4bed9977ab6a3c9ed08ad73c8c3b92d9579f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643177Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845726}
-
Takuto Ikuta authored
This is to prevent failure causing revert like https://crrev.com/c/2639349 Bug: 1127205 Change-Id: I6d6fac6a900caa3c64fc80f3b33cf4be5b7713c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642838 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#845725}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a7e34d33fe70..6031b74664d0 2021-01-21 ivoc@webrtc.org Implement a Neon optimized function to find the argmax element in an array. 2021-01-21 sprang@webrtc.org Fixes issue triggered by WebRTC-VP9-PerformanceFlags trial. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1167353,chromium:12355 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1db0278740ff3e8346c4dc293edd633f6efd2982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643136Reviewed-by:
-
