- 18 May, 2015 8 commits
-
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#330324}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/33ccde6..2dd4f36 TBR= Review URL: https://codereview.chromium.org/1126393007 Cr-Commit-Position: refs/heads/master@{#330323}
-
amistry authored
BUG=488357 Review URL: https://codereview.chromium.org/1130763005 Cr-Commit-Position: refs/heads/master@{#330322}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/0698cc2..33ccde6 TBR= Review URL: https://codereview.chromium.org/1129353008 Cr-Commit-Position: refs/heads/master@{#330321}
-
raymes authored
Presumably during destruction, the RenderView can be destroyed before the RenderFrame (since it only holds a weak pointer to it). We need to check whether it is alive before clearing the plugin find handler. BUG=487146 Review URL: https://codereview.chromium.org/1123393004 Cr-Commit-Position: refs/heads/master@{#330320}
-
mgiuca authored
FakeProfileStore now returns the real kProfileLastUsed (from the pref store), instead of a dummy value. This means that tests for code that sets or manipulates the kProfileLastUsed pref will behave correctly. AppListServceUnitTest.RemovedProfileResetsToInitialProfile now properly tests the behaviour of RemoveProfile (that it clears kAppListProfile, and that GetProfilePath returns the initial profile when kAppListProfile is missing). Previously, it did not distinguish between the initial and last used profiles. AppListServiceUnitTest.RemovedProfileResetsToLastUsedProfileIfExists also tests that the kAppListProfile has been set correctly. BUG=487951 Review URL: https://codereview.chromium.org/1134533007 Cr-Commit-Position: refs/heads/master@{#330319}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/3340c79a..0698cc2 TBR= Review URL: https://codereview.chromium.org/1130343004 Cr-Commit-Position: refs/heads/master@{#330318}
-
rch authored
DynamicSocketDataProvider only has one consumer, FtpSocketDataProvider. This CL moves the functionality of DynamicSocketDataProvider directly into FtpSocketDataProvider. Review URL: https://codereview.chromium.org/1137183005 Cr-Commit-Position: refs/heads/master@{#330317}
-
- 17 May, 2015 23 commits
-
-
sbc authored
All the ARM linux builders already specify this, and armhf is the now the default for both Ubuntu and Debian. Followup cleanup cl for the bots: https://codereview.chromium.org/1141643004/ BUG=308256 Review URL: https://codereview.chromium.org/1140503004 Cr-Commit-Position: refs/heads/master@{#330316}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/e3dad87..3340c79a TBR= Review URL: https://codereview.chromium.org/1135763005 Cr-Commit-Position: refs/heads/master@{#330315}
-
rch authored
Review URL: https://codereview.chromium.org/1123393005 Cr-Commit-Position: refs/heads/master@{#330314}
-
thakis authored
This reverts https://codereview.chromium.org/1129103005/ , which turned them off. Now what all [blink-gc] warnings are fixed, we can turn them on again on the warnings-as-errors 64-bit builds. BUG=486571,467287 TBR=hans Review URL: https://codereview.chromium.org/1131333003 Cr-Commit-Position: refs/heads/master@{#330313}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/bd46509..e3dad87 TBR= Review URL: https://codereview.chromium.org/1135323003 Cr-Commit-Position: refs/heads/master@{#330312}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2e4c5505..57cf87de Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1144743002 Cr-Commit-Position: refs/heads/master@{#330311}
-
thakis authored
ignored_directories assumes that the path separator is /. (https://codereview.chromium.org/1072203002 did the same change for the style plugin.) BUG=486571 Review URL: https://codereview.chromium.org/1130823005 Cr-Commit-Position: refs/heads/master@{#330310}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/21445b8..bd46509 TBR= Review URL: https://codereview.chromium.org/1128923007 Cr-Commit-Position: refs/heads/master@{#330309}
-
jochen authored
This code is inlined all over the place, however, there's no good location to put it. Just factoring it out in two places, however, doesn't really make sense, so don't do it R=mkwst@chromium.org BUG=478250 Review URL: https://codereview.chromium.org/1141993002 Cr-Commit-Position: refs/heads/master@{#330308}
-
jochen authored
If a link has target=_blank we don't navigate to it, but create a new tab, and then navigate to it. To be able to write a layout test for the policy used to create the new tab, I need to dump it here too BUG=454222 R=mkwst@chromium.org Review URL: https://codereview.chromium.org/1129203005 Cr-Commit-Position: refs/heads/master@{#330307}
-
r.kasibhatla authored
LayerTreeAsJson is useful during debugging of layer tree operations. Adding the layer id into the information for the layer currently being serialized. This helps the function be more usable as user knows which layer he is looking when checking the json. BUG=None R=danakj,enne Review URL: https://codereview.chromium.org/1140913002 Cr-Commit-Position: refs/heads/master@{#330306}
-
dmazzoni authored
BUG=323462 Review URL: https://codereview.chromium.org/1128963004 Cr-Commit-Position: refs/heads/master@{#330305}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/ae8e195..21445b8 TBR= Review URL: https://codereview.chromium.org/1144723002 Cr-Commit-Position: refs/heads/master@{#330304}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#330303}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/573d924..ae8e195 TBR= Review URL: https://codereview.chromium.org/1138003008 Cr-Commit-Position: refs/heads/master@{#330302}
-
lazyboy authored
to receive the ack on browser/. We perform a sanity check upon background page ACKing an event, by checking whether the ACKed message is expected to be ACKed. We store the pending ACK message IDs into a set |unacked_messages_|, but due to PostTask call to IncrementInFlightEventsOnUI, the event ack might arrive earlier than storing the pending message's ID. This results in incorectly kill the renderer process. BUG=485440, 473821 Test=Rise Vision chrome app shouldn't crash anymore. Review URL: https://codereview.chromium.org/1138643010 Cr-Commit-Position: refs/heads/master@{#330301}
-
rouslan authored
When drmemory_full runs, the browser tests are slowed down enough to timeout the user gesture indicator, which prevents autofill from processing the input and passing the browser test. The fix is to disable user gesture checking for all autofill browser tests except AutofillRendererTest.IgnoreNonUserGestureTextFieldChanges. TBR=thestig@chromium.org,estade@chromium.org BUG=484910 Review URL: https://codereview.chromium.org/1143593003 Cr-Commit-Position: refs/heads/master@{#330300}
-
thakis authored
clang can't handle dllexported classes with only member initializers yet (see crbug and http://llvm.org/PR23542). As a workaround, don't dllexport this class. This has the effect of emitting the class's constructor into every translation unit that uses it instead of just every translation unit of the media component, but in a way that seems nicer anyways since there's no .cc file for this header and so currently this relies on some translation unit in media including this header by lucky accident (else the constructor wouldn't be defined anywhere.) Once the clang bug is fixed we can consider adding this back; in the meantime this seems like a tiny price to pay to get the bots back green. Also add the .h file to the relevant gyp/gn files, else the analyze step will make the trybots think that nothing changed when this .h file is touched. BUG=488634,467779 TBR=sandersd Review URL: https://codereview.chromium.org/1133423003 Cr-Commit-Position: refs/heads/master@{#330299}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#330298}
-
stevenjb authored
This CL should facilitate conversion of cr- elements and help debugging them in isolation. To view elements in demo_elements.html, navigate to: chrome://resources/cr_elements/v0_8/demo_page.html BUG=485381 Review URL: https://codereview.chromium.org/1124073007 Cr-Commit-Position: refs/heads/master@{#330297}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/410d4d6..573d924 TBR= Review URL: https://codereview.chromium.org/1137123003 Cr-Commit-Position: refs/heads/master@{#330296}
-
thakis authored
This time with correct copyright headers. On Windows, clang-cl only parses template methods that are referenced (-fdelayed-template-parsing), so members traced from unreferenced template methods weren't seen by the plugin, which caused it to warn about them. Explicitly parse delayed template methods that look like they are trace methods and that aren't in system headers to work around this. This is based on Kim Grasman's patch for the IWYU project: https://code.google.com/p/include-what-you-use/source/detail?r=566 Together with clang r237531 ( http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150511/129285.html ) this should fix all failing oilpan plugin tests on Windows. BUG=486571 TBR=hans Review URL: https://codereview.chromium.org/1135333007 Cr-Commit-Position: refs/heads/master@{#330295}
-
thakis authored
Revert of Add support for backgrounding processes on the Mac (patchset #21 id:400001 of https://codereview.chromium.org/989703002/) Reason for revert: Speculative; several browser_tests started failing on the Mac 10.9 bots, and this looks like the most likely culprit: http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/1929 http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/6014 Original issue's description: > Add support for backgrounding processes on the Mac > > Added process_mac.cc with implementations of IsProcessBackgrounded() and > SetProcessBackgrounded(). > > BUG=460102 TBR=rsesek@chromium.org,gab@chromium.org,asvitkine@chromium.org,avi@chromium.org,kbr@chromium.org,shrike@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460102 Review URL: https://codereview.chromium.org/1128183011 Cr-Commit-Position: refs/heads/master@{#330294}
-
- 16 May, 2015 9 commits
-
-
rch authored
BUG= Review URL: https://codereview.chromium.org/1113203002 Cr-Commit-Position: refs/heads/master@{#330293}
-
rch authored
BUG=332112 Review URL: https://codereview.chromium.org/1124553002 Cr-Commit-Position: refs/heads/master@{#330292}
-
kpschoedel authored
Review URL: https://codereview.chromium.org/1133283004 Cr-Commit-Position: refs/heads/master@{#330291}
-
rch authored
Once the DNS test conversion CL lands, I'll be able to remove DelayedSocketData. Review URL: https://codereview.chromium.org/1117863003 Cr-Commit-Position: refs/heads/master@{#330290}
-
Bruce Dawson authored
This reverts commit 28c1b109. The delayed_parsing.cpp file has no license which is causing license check failures. TBR=hans@chromium.org,thakis@chromium.org,rnk@chromium.org BUG=486571 Review URL: https://codereview.chromium.org/1146563002 Cr-Commit-Position: refs/heads/master@{#330289}
-
rch authored
to use SequencedSocketData. Reduces runtime to 7 seconds from 11 seconds on my linux workstation BUG=332112 Committed: https://crrev.com/d7b1887392866667126162a4e7854a2736449970 Cr-Commit-Position: refs/heads/master@{#328221} Review URL: https://codereview.chromium.org/1124533002 Cr-Commit-Position: refs/heads/master@{#330288}
-
rch authored
Reduces runtime to 11 seconds from 59 seconds on my linux workstation. There are still a number of tests which have not been unconverted because they make use of "CompleteRead" semantics which I still need to implement in SequencedSocketData. BUG=332112 Committed: https://crrev.com/73e1742f4729161d16f70cbdad9d4c1c1836be52 Cr-Commit-Position: refs/heads/master@{#328171} Review URL: https://codereview.chromium.org/1114213005 Cr-Commit-Position: refs/heads/master@{#330287}
-
vkuzkokov authored
BUG=483693 Review URL: https://codereview.chromium.org/1132913004 Cr-Commit-Position: refs/heads/master@{#330286}
-
mtomasz authored
Since all volumes can be now configurable, make the method generic, instead of limiting to FSP API only. NOPRESUBMIT=true TEST=Tested manually on configurable and non-configurable volumes. BUG=474146 Review URL: https://codereview.chromium.org/1142593002 Cr-Commit-Position: refs/heads/master@{#330285}
-