GitLab

This CL removes the flag names and descriptions that were no longer
used.

Bug: none
Change-Id: I61b056b85ecdd29b1849892d16714b7538d52047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780823
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692419}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3f94735d8926..03119fd61fdb

git log 3f94735d8926..03119fd61fdb --date=short --no-merges --format='%ad %ae %s'
2019-09-02 vapier@chromium.org cros_branch_unittest: disable flaky test

Created with:
  gclient setdep -r src/third_party/chromite@03119fd61fdb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Ib85e1d11c542ec9199b9ce4e31d95046221b714b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781227Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692418}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/69d20d24..cf9e0d36

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6aa65dd7b8a874f4cf524d47459861b127b36a4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779865Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692417}

Change-Id: I98519ab0dd8c16733c05215db038575a1df85aed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779364
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692416}

Change row height for the main view.

Old view: https://bugs.chromium.org/p/chromium/issues/attachment?aid=409715&signed_aid=YSeOQ3JwzBU8qYy0vZmkqw==&inline=1
New view: https://bugs.chromium.org/p/chromium/issues/attachment?aid=409716&signed_aid=srOEmpb-mKz-hv5te-fa_Q==&inline=1

Bug: 999923
Change-Id: Ie487f9977cb61b618a2e9c7b3815fb25d8f45a02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778894
Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692415}

TBR=luoe@chromium.org

Bug: chromium:999739
Change-Id: I6a9a0a6c70f98f5cf018aa473e30a7b4dc659ec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778614Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692414}

Bug: None
Change-Id: I9876bfde53741bb9c7ede70f1fad021f43c38862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777925Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#692413}

There has been significant discussion on the explainer repo
about the best way for badging to work. The API has undergone
a major redesign.

Previously, badges were associated with a specific installed
web application, which severely limited the usefulness of the
API.

In the revised API, a badge is associated with a scope. This
reflects the way that web applications work, so it is possible
to badge multiple nested applications. In addition, this
should allow us to expose the API from the service worker in
future (which is not implicitly associated with any
application). The scopes solution has the added advantage
that other, non-app contexts (such as bookmarks) could be
badged in the future.

Explainer:
https://github.com/WICG/badging/blob/master/explainer.md

Bug: 987514
Change-Id: Ib11500e1b4f26eabe402153d27176e786c33768a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723849
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692412}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0b598b6e8d5b..7c391b3aa37f


Created with:
  gclient setdep -r src-internal@7c391b3aa37f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None
Change-Id: I6c051f4fa66e7f8dc91099764baef14a4023a3f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780635Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692411}

Since we postponed OOR-CORS launch, we will update the
expiry milestone.

Bug: 905971
Change-Id: Ifae7c33745c126e9c08b994db20772de234ff2db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781133
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692410}

This CL uses the newly-introduced
kPrefetchMainResourceNetworkIsolationKey flag to get the prefetch
NetworkIsolationKey work from crrev.com/c/1735366 behind. It also
removes usages of the kSplitCacheByNetworkIsolationKey feature
introduced by the aforementioned CL. Furthermore, it reverts the
changes made to audit_non_blink_usage.py, introduced by that CL.

R=haraken@chromium.org, kinuko@chromium.org, yhirano@chomium.org

Bug: 939317
Change-Id: I14cd84b2b7ec8bbe4dc450f60f8b0532cf8a5115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778893Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692409}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/cbee985a2bc1..543a3b939df5

git log cbee985a2bc1..543a3b939df5 --date=short --no-merges --format='%ad %ae %s'
2019-09-01 wl@gnu.org * src/sfnt/sfwoff2.c (woff2_open_font): Add sanity check.

Created with:
  gclient setdep -r src/third_party/freetype/src@543a3b939df5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
TBR=bungeman@google.com,drott@google.com,thestig@google.com

Bug: None
Change-Id: I840fe6429b03900fd2784d31d2b2de8a00ea357c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780863Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692408}

Since VaapiDmaBufVideoFrameMapper has some issue with Intel iHD driver,
use GMB::Map() instead of VideoFrameMapper to map the output buffer.

Bug: b:139655380
Test: Pass jpeg_decode_accelerator_unittest on eve/sarien.
Change-Id: Ibeb1e8e2bbcace7eb34d5e1a09b44be93ed1a928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777444Reviewed-by: Ricky Liang <jcliang@chromium.org>
Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692407}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Id629598336b834eacc6d6c8b87a63ad81761ab95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781034Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692406}

This reverts commit a1d47a7f.

Reason for revert: Fix build failure with target_os="chromeos"

Original change's description:
> Revert "media/gpu: make VideoDecoderPipeline select VD implementation during Initialize()."
>
> This reverts commit cae62756.
>
> Reason for revert: Breaks build with target_os="chromeos"
>
> FAILED: libmedia_gpu.so libmedia_gpu.so.TOC
> python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --sofile="./libmedia_gpu.so" --tocfile="./libmedia_gpu.so.TOC" --output="./libmedia_gpu.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,-soname="libmedia_gpu.so" -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--color-diagnostics -m64 -Werror -Wl,--gdb-index -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath=\$ORIGIN -Wl,-rpath=\$ORIGIN -o "./libmedia_gpu.so" @"./libmedia_gpu.so.rsp"
> ld.lld: error: undefined symbol: media::VideoDecoderPipeline::Create(scoped_refptr<base::SequencedTaskRunner>, std::__Cr::unique_ptr<media::DmabufVideoFramePool, std::__Cr::default_delete<media::DmabufVideoFramePool> >, std::__Cr::unique_ptr<media::VideoFrameConverter, std::__Cr::default_delete<media::VideoFrameConverter> >)
> >>> referenced by chromeos_video_decoder_factory.cc:54 (../../media/gpu/chromeos/chromeos_video_decoder_factory.cc:54)
> >>>               obj/media/gpu/chromeos/chromeos/chromeos_video_decoder_factory.o:(media::ChromeosVideoDecoderFactory::Create(scoped_refptr<base::SequencedTaskRunner>, std::__Cr::unique_ptr<media::DmabufVideoFramePool, std::__Cr::default_delete<media::DmabufVideoFramePool> >, std::__Cr::unique_ptr<media::VideoFrameConverter, std::__Cr::default_delete<media::VideoFrameConverter> >))
> clang: error: linker command failed with exit code 1 (use -v to see invocation)
>
> Original change's description:
> > media/gpu: make VideoDecoderPipeline select VD implementation during Initialize().
> >
> > Some devices select the video decoder implementation by the video
> > configuration (e.g. codec). VideoDecoderPipeline needs to select a
> > proper video decoder in Initialize() when a video configuration is
> > specified.
> >
> > This CL implements the mechanism of selecting VD at Initialize()
> > instead of Create() method.
> >
> > BUG=chromium:952730
> > TEST=Run video_decode_accelerator_tests on Kevin and Eve
> >
> > Change-Id: I76077df0bc1e1eeae730e618a62c6e1049e02500
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708693
> > Reviewed-by: David Staessens <dstaessens@chromium.org>
> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
> > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#691946}
>
> TBR=deanliao@chromium.org,akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org,dstaessens@chromium.org
>
> Change-Id: I2edea554734a766fce1d61943297547159c8cbeb
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:952730
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778048
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Reviewed-by: Vladislav Kuzkokov <vkuzkokov@chromium.org>
> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#692035}

TBR=ellyjones@chromium.org,deanliao@chromium.org,vkuzkokov@chromium.org,akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org,dstaessens@chromium.org

Bug: chromium:952730
Test: Run `autoninja media/gpu` with gn gargs: target_os="chromeos"
Change-Id: I34405281dbe106e3182456da154e3ceafd19f9b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781126Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692405}

https://webrtc.googlesource.com/src.git/+log/ce6a0c8fb3f3..54c03266f7af

git log ce6a0c8fb3f3..54c03266f7af --date=short --no-merges --format='%ad %ae %s'
2019-09-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a42eacf1..78591f12 (692288:692389)
2019-09-01 terelius@webrtc.org Filter out small packets from delay-based overuse detection.
2019-09-01 sprang@webrtc.org Revert "Simplify pacer queue"

Created with:
  gclient setdep -r src/third_party/webrtc@54c03266f7af

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: I41f4e6bdb627bec04d2077af34a6a86a6d4403c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779845Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692404}

The down icon changes colour to match the underline when the input
is focused.

BUG=987947,977313

Change-Id: I82e3c277493209633905b8836346e9c69e27d7eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774000Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692403}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/34facef63327..3f94735d8926

git log 34facef63327..3f94735d8926 --date=short --no-merges --format='%ad %ae %s'
2019-09-01 vapier@chromium.org Revert "parallel_emerge_new: Disable Portage vardb locks for boards"

Created with:
  gclient setdep -r src/third_party/chromite@3f94735d8926

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I9e91532dc9cd066ae73208b54a319417b1020a55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780862Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692402}

https://skia.googlesource.com/skia.git/+log/6e637472ebf3..0a1e9efa392c

git log 6e637472ebf3..0a1e9efa392c --date=short --no-merges --format='%ad %ae %s'
2019-09-02 michaelludwig@google.com Don't use AA convex path renderer if direction can't be determined
2019-09-01 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2019-09-01 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps

Created with:
  gclient setdep -r src/third_party/skia@0a1e9efa392c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jlavrova@google.com

Bug: chromium:996140
Change-Id: I931683042b9988fc9e51a7b75e6b53c7b1632338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779844Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692401}

This reverts commit 824a86d4.

Reason for revert: causes compile failure on Linux CFI bot.

Sample build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/14810

Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8903575125463586160/+/steps/compile/0/stdout?format=raw

---
[1121/1363] CXX obj/third_party/angle/libANGLE_base/OverlayWidgets.o
FAILED: obj/third_party/angle/libANGLE_base/OverlayWidgets.o
/b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF...(too long)
In file included from ../../third_party/angle/src/libANGLE/OverlayWidgets.cpp:12:
In file included from ../../third_party/angle/src/libANGLE/Overlay.h:17:
../../third_party/angle/src/libANGLE/angletypes.h:553:12: error: 'gl::overlay::Widget' is not polymorphic
ASSERT(ANGLE_HAS_DYNAMIC_TYPE(DestT *, src));
^                               ~~~
../../third_party/angle/src/libANGLE/angletypes.h:543:48: note: expanded from macro 'ANGLE_HAS_DYNAMIC_TYPE'
---


Original change's description:
> Roll src/third_party/angle c3f57231124b..93bb092f88c9 (2 commits)
>
> https://chromium.googlesource.com/angle/angle.git/+log/c3f57231124b..93bb092f88c9
>
> git log c3f57231124b..93bb092f88c9 --date=short --no-merges --format='%ad %ae %s'
> 2019-08-31 syoussefi@chromium.org Fix build error
> 2019-08-31 syoussefi@chromium.org Vulkan: Debug overlay
>
> Created with:
>   gclient setdep -r src/third_party/angle@93bb092f88c9
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/angle-chromium-autoroll
> Please CC cwallez@chromium.org on the revert to ensure that a human
> is aware of the problem.
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> TBR=cwallez@chromium.org
>
> Bug: None
> Change-Id: Ib95dca1bd877ad6ee70343b17d0e41d44e291b27
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779493
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#692365}

TBR=cwallez@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: Ic64b483a2283453bbb35424f5acee743eedddf84
notry: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778459Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#692400}

This CL updates the permission icons to new GM2 icons. No functionality
was changed.

Old icons: https://bugs.chromium.org/p/chromium/issues/attachment?aid=409698&signed_aid=KHf1YuUcQlNCm3xUD8IW7A==&inline=1

New icons: https://bugs.chromium.org/p/chromium/issues/attachment?aid=409697&signed_aid=7Z3p0_DlDpX8mL5F3ghv6A==&inline=1

Bug: 999893
Change-Id: Iec9a9e2846cb5bdaddfc5d26482dc0744517346f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778888
Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692399}

See https://whatpr.org/html/4862/interaction.html#the-rendersubtree-attribute
for spec.

Bug: 991095
Change-Id: I460a63a742a62e911d1cb0d8c777ee30d9902c79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776148
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692398}

This reverts commit 5a8be727.

Reason for revert: causes crashpad_tests failure on chromium.memory/Linux MSan Tests.

Sample build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/18980

Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8903656082016781184/+/steps/crashpad_tests/0/logs/Deterministic_failure:_CrashpadClient.SanitizedChild__status_FAILURE_/0

Original change's description:
> Update Crashpad to cd92fba233d3cc28909c3791710a747c818de244
> 
> 726ab2a65539 Integrate Crashpad with Chrome OS
> db6f51d3fca8 fuchsia: Check results of Initialize() subcalls in
>              ProcessReaderFuchsia
> 50aa576622fd Disable implicit fallthrough warning for zlib
> 1c7023875b74 [build] //zircon/public/fidl --> //zircon/system/fidl
> 7b5a55c3b188 Move whitelist ownership to ProcessSnapshotSanitized
> 10a1d2d87743 [fuchsia] Use the appropriate separator for FIDL library
>              names
> b71f61f8e31f fuchsia: Defer initialization of memory map
> 23a1be41ce3a linux: refactor snapshotting into CaptureSnapshot()
> 80473094a4d2 linux, compat: add a memfd_create wrapper
> cd92fba233d3 linux: Move Cros crash handling to
>              CrosCrashReportExceptionHandler
> 
> Change-Id: I035a3ad1e3eed573a9c8871c096181baf4178ea5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779013
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#692234}

TBR=jperaza@chromium.org,mark@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I73b23bb1f766990fc73641588eb8d78935f6a36c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778452Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#692397}

to make it easier to clean up the environment.

Bug: 994083
Test: exo_unittests keyboard_unittests
Change-Id: I90c24548ef3a49a1ed783645dee8c168451b147c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761881
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692396}

Update expiration_date from 2018-08 to 2023-08.

Bug: 999902
Change-Id: Id5776675c7fcc9b4d2a4e56886b7db01cf8211d4
TBR: battre@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780085Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#692395}

This reverts commit 1b50834a.

Reason for revert: need to revert this to revert 692365. #692365 causes compile failure on Linux CFI bot.

Sample build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/14810

Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8903575125463586160/+/steps/compile/0/stdout?format=raw

Original change's description:
> Roll src/third_party/angle 93bb092f88c9..791ad7b8774a (2 commits)
>
> https://chromium.googlesource.com/angle/angle.git/+log/93bb092f88c9..791ad7b8774a
>
> git log 93bb092f88c9..791ad7b8774a --date=short --no-merges --format='%ad %ae %s'
> 2019-08-31 syoussefi@chromium.org Vulkan: Enable more GLES3.1 dEQP tests
> 2019-08-31 syoussefi@chromium.org Vulkan: Storage image support
>
> Created with:
>   gclient setdep -r src/third_party/angle@791ad7b8774a
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/angle-chromium-autoroll
> Please CC cwallez@chromium.org on the revert to ensure that a human
> is aware of the problem.
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> TBR=cwallez@chromium.org
>
> Bug: None
> Change-Id: I224c7e2a76bc7eb8c5f9d59c4cfb0a95168fed80
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779496
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#692368}

TBR=cwallez@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: Id6e89cdcaa76b4463d3eb9046d41f9647df729c4
notry: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780984Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#692394}

ServiceWorkerImportedScriptUpdateCheck is now enabled and the tests are passing.

Bug: 648295
Change-Id: Idd7862d6acf116b592b49a41869556a41e0e8ca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777842
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Auto-Submit: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692393}

This CL supports AppCache with PlzDedicatedWorker. Dedicated workers use their
ancestor frame's AppCacheHost, while shared workers have their own AppCacheHost.

The most tricky part of this CL is that dedicated workers are handled as
subresources of the nearest ancestor frame's AppCacheHost, but they also behave
as independent execution contexts. That is, dedicated workers have their own
subresource loaders. See comments in DedicatedWorkerHost and
AppCacheRequestHandler for details.

Change-Id: I0f24c57e94bf6fa71b8f15a22214ed91a96fbb17
Bug: 945673
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768485
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692392}

The ServiceWorker spec requires to expose it to ServiceWorker, but Blink
has exposed it only to Window:
https://w3c.github.io/ServiceWorker/#serviceworker-interface

Instances of the ServiceWorker interface have been available on
ServiceWorkerGlobalScope for a long time via |self.registration|, so this isn't
exposing anything new (see https://crbug.com/437677).

Ideally, this should also be exposed to DedicatedWorker and SharedWorker, but
this CL doesn't do it. This is because Blink hasn't supported ServiceWorker APIs
on the workers yet, and exposing the interface to the workers may churn feature
detections etc (see https://crbug.com/371690).

Bug: 999023
Change-Id: I5b36706d4d09dd830af00097bc9c724e3adf56b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775942
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692391}

This reverts commit 10fa9630.

Reason for revert: Split view regression http://b/138674508

Original change's description:
> Implement ArcImeService::EnsureCaretNotInRect.
> 
> It's left as unimplemented because Android WM handles insets by VK for
> most cases.
> However, Android WM can't move the SystemTray up for inline-reply in an
> Android notification because from Android WM's point of view,
> notificaiton is placed at (0, 0).
> This CL implements ArcImeService::EnsureCaretNotInRect to cover that
> case.
> This CL changes the behavior of windowed Android app with a11y keyboard.
> Before this CL, a position of a window is not changed by a11y keyboard
> visibility, but after this CL a position can be changed not to be
> covered by a11y keyboard.
> 
>       SystemTray moves up if there is a space for it.
> 
> Bug: b/114115612
> Test: manual - Focus on inline reply of an Android notificatioln and
> Change-Id: Ib666b6c269a8fc36195d30affa4c7a8a805560d7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631859
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#664583}

TBR=sadrul@chromium.org,yhanada@chromium.org,tetsui@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

BUG=b:114115612
BUG=b:138674508

Change-Id: Ic614e72899dbd9efb7317bdecd33f540e5b85452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777461Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692390}

Metrics for training are bucketed, and this CL adds parity to bucket the
metrics before scoring each link.

TBR=tbansal@chromium.org

Bug: 999897
Change-Id: I8082e9bbaff0cb3aba75273e53ed00690f9c6c06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779843Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692389}

... and use its WTF counterparts.

BUG=78725
R=haraken@chromium.org

Change-Id: Ib706c5c63a41363ca85effa42f0970ed60d660e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778664
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#692388}

We always check if a file exists before returning it as a candidate
search result. This CL adds to that so that if we find a file doesn't
exist, we remove it from the model.

Bug: 959697
Change-Id: I2ddca3015a265a9ef3910e6447872f92404a6922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775954Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692387}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I87a6eb40d113fcf02de46a1a9410413a56718f01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780631Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692386}

To discover how frequent they are, use -Wno-error= instead of disabling the
warnings completely for now.

TBR=rnk@chromium.org

Bug: 999886,999871
Change-Id: I297a2461c377727a1871bda5849ce0a7658c17ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780882Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692385}

clang r370594 added a warning on non-final classes with final dtors.
One plugin test has code like this; just add final to these classes.

TBR=dcheng

Bug: 999869
Change-Id: I0eff3f561530b28855f21fd0c0e421613e86aa58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778974Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692384}

In the past, base::File object was passed to the CDM process and it
read/write using the handle. Now that all the reading/writing is done
in the browser process, it's no longer a concern that the handle can
exist after the underlying file was deleted.
The test is removed while removing usages of CreateOrOpen() function
that is on deprecation path.

Bug: 936722
Change-Id: Ic2ab6ffece24118e3f7384b440b77cecd12ddc5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768590
Auto-Submit: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692383}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I84e4f35df9f237266f5aba6345001cd0f2746d86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779467Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692382}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome

BUG=762641
TBR=sammiequon@google.com

Change-Id: Ibac7f2e511babde63b199ac98c98428671056118
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779864Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692381}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/aa3fccf4..69d20d24

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6e5136131e7ed6d01c09b3c5151a00428bbb3feb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779863Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692380}