GitLab

Currently, the .cc is included in multiple targets. In incremental builds this results in errors like:

[609->8104/8713 ~0] LINK_EMBED unit_tests.exe
FAILED: d:\src\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x86 True unit_tests.exe "d:\src\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /OUT:unit_tests.exe @unit_tests.exe.rsp" 1 mt.exe rc.exe "obj\chrome\unit_tests.unit_tests.exe.intermediate.manifest" obj\chrome\unit_tests.unit_tests.exe.generated.manifest ..\..\build\win\compatibility.manifest
content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl content::InitializeSandboxInfo(struct sandbox::SandboxInterfaceInfo *)" (?InitializeSandboxInfo@content@@YAXPAUSandboxInterfaceInfo@sandbox@@@Z) already defined in test_support_content.startup_helper_win.obj
content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl `anonymous namespace'::InvalidParameter(wchar_t const *,wchar_t const *,wchar_t const *,unsigned int,unsigned int)" (?InvalidParameter@?A0xc496daa2@@YAXPB_W00II@Z) already defined in test_support_content.startup_helper_win.obj
content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl `anonymous namespace'::PureCall(void)" (?PureCall@?A0xc496daa2@@YAXXZ) already defined in test_support_content.startup_helper_win.obj
content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl content::RegisterInvalidParamHandler(void)" (?RegisterInvalidParamHandler@content@@YAXXZ) already defined in test_support_content.startup_helper_win.obj
content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl content::SetupCRT(class base::CommandLine const &)" (?SetupCRT@content@@YAXABVCommandLine@base@@@Z) already defined in test_support_content.startup_helper_win.obj
unit_tests.exe : fatal error LNK1169: one or more multiply defined symbols found

when incremental_chrome_dll=1 used in Release build.

By putting the .cc in a static_library target and depending on it as necessary, rather than including the .cc into multiple places, this is avoided.

R=jam@chromium.org
TBR=sky@chromium.org
BUG=404809

Review URL: https://codereview.chromium.org/470523005

Cr-Commit-Position: refs/heads/master@{#291256}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291256 0039d316-1c4b-4281-b951-d872f2087c98

Previously our handling of ignored touches would put the gesture recognizer into a very confused state.

BUG=405519
TEST=GestureRecognizerTest.IgnoredEventsDontPreventFutureEvents

Review URL: https://codereview.chromium.org/489213003

Cr-Commit-Position: refs/heads/master@{#291255}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291255 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394869

Review URL: https://codereview.chromium.org/488163003

Cr-Commit-Position: refs/heads/master@{#291254}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291254 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291253}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291253 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/489243002

Cr-Commit-Position: refs/heads/master@{#291252}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291252 0039d316-1c4b-4281-b951-d872f2087c98

Also removed dependent switches --disable-scripted-print-throttling and --renderer-print-preview.

BUG=374321

Review URL: https://codereview.chromium.org/488853002

Cr-Commit-Position: refs/heads/master@{#291251}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291251 0039d316-1c4b-4281-b951-d872f2087c98

Now is up to the component embedding the SystemInfo API to implement
the DisplayInfoProvider. The motivation for this change is we want to
move the SystemInfo API to extensions/ but DisplayInfoProvider depends
on ash/, which will link with ui/views/, and that is way too big.

The ultimate goal is to have SystemInfo on the app_shell without increasing its
footprint considerably.

BUG=392842

Review URL: https://codereview.chromium.org/476103002

Cr-Commit-Position: refs/heads/master@{#291250}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291250 0039d316-1c4b-4281-b951-d872f2087c98

Add unittest that fails crbug/399671 but pass with the fix.

BUG=399671

Review URL: https://codereview.chromium.org/488763004

Cr-Commit-Position: refs/heads/master@{#291249}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291249 0039d316-1c4b-4281-b951-d872f2087c98

Previously, we flattened all the iterations and reported one number. Now we
report the geo mean of each iteration so that the dashboard can display the
stddev.

BUG=405719

Review URL: https://codereview.chromium.org/493153002

Cr-Commit-Position: refs/heads/master@{#291248}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291248 0039d316-1c4b-4281-b951-d872f2087c98

While we're here, remove silly DCHECKs on pointers that are
dereferenced in the next line anyway.

R=asanka@chromium.org,jsbell@chromium.org
TBR=falken@chromium.org,dominicc@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/461343006

Cr-Commit-Position: refs/heads/master@{#291247}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291247 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401180

Review URL: https://codereview.chromium.org/461043003

Cr-Commit-Position: refs/heads/master@{#291246}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291246 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387122
TEST=none
R=keybuk@chromium.org

Review URL: https://codereview.chromium.org/495763004

Cr-Commit-Position: refs/heads/master@{#291245}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291245 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393873
R=dbeam@chromium.org
TEST=gyp --depth . third_party/closure_compiler/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/490213003

Cr-Commit-Position: refs/heads/master@{#291244}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291244 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393873
R=dbeam@chromium.org
TEST=./third_party/closure_compiler/runner/build_runner_jar.py && gyp --depth . chrome/browser/resources/history/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/454223004

Cr-Commit-Position: refs/heads/master@{#291243}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291243 0039d316-1c4b-4281-b951-d872f2087c98

We don't draw layers with non-invertible transforms, so this check is
a waste. Especially in the case where we don't even use the inverse
transform.

R=enne

Review URL: https://codereview.chromium.org/492953002

Cr-Commit-Position: refs/heads/master@{#291242}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291242 0039d316-1c4b-4281-b951-d872f2087c98

Extension options pages often have links to external pages as well as
internal extension pages. When embedded in an <extensionoptions> element
open external links in a new tab, and internal links in the embedded
view (unless specified otherwise).

BUG=386838

Review URL: https://codereview.chromium.org/471053003

Cr-Commit-Position: refs/heads/master@{#291241}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291241 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359249

Review URL: https://codereview.chromium.org/465713002

Cr-Commit-Position: refs/heads/master@{#291240}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291240 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/491733002

Cr-Commit-Position: refs/heads/master@{#291238}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291238 0039d316-1c4b-4281-b951-d872f2087c98

Adding support for PpapiHostMessage_OpenResource to SFI mode is tricky.
Validating the file tokens requires that a message to be sent to the browser
(!) to validate that information in the case of a compromised renderer.

This change is one step to allowing processing for the reply of the
PpapiHostMessage_OpenResource message to send a message to the browser for
constructing a NaClDesc properly.

This makes the encapsulation of NaClMessageScanner a bit worse, but also
reduces the amount of code for which the critical section under lock_ must be
held.

BUG=394130

Review URL: https://codereview.chromium.org/472073003

Cr-Commit-Position: refs/heads/master@{#291234}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291234 0039d316-1c4b-4281-b951-d872f2087c98

Delaying launch of multi-profile for managed accounts to M38, so setting
the default policy to "not-allowed".

BUG=405983

Review URL: https://codereview.chromium.org/469003010

Cr-Commit-Position: refs/heads/master@{#291233}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291233 0039d316-1c4b-4281-b951-d872f2087c98

(Chrome part).
This patch adds code for removing spelling markers under words on 
chrome's side.

BUG=3506

Review URL: https://codereview.chromium.org/411393004

Cr-Commit-Position: refs/heads/master@{#291232}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291232 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405950

Review URL: https://codereview.chromium.org/495123002

Cr-Commit-Position: refs/heads/master@{#291231}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291231 0039d316-1c4b-4281-b951-d872f2087c98

Adjusted DS2784PowerMonitor, DumpsysPowerMonitor, and MonsoonPowerMonitor 
to extend SysfsPowerMonitor to get CPU data. Also cleaned up a little bit
of SysfsPowerMonitor.

BUG=

Review URL: https://codereview.chromium.org/470803006

Cr-Commit-Position: refs/heads/master@{#291230}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291230 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405682

Review URL: https://codereview.chromium.org/495723002

Cr-Commit-Position: refs/heads/master@{#291228}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291228 0039d316-1c4b-4281-b951-d872f2087c98

Remove enable-browser-text-subpixel-positioning flag.

BUG=388844
TEST=covered by tests

Review URL: https://codereview.chromium.org/485873002

Cr-Commit-Position: refs/heads/master@{#291227}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291227 0039d316-1c4b-4281-b951-d872f2087c98

This allows us to allocate a smaller region when painting native
controls on Mac.

BUG=247716

Review URL: https://codereview.chromium.org/462423006

Cr-Commit-Position: refs/heads/master@{#291226}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291226 0039d316-1c4b-4281-b951-d872f2087c98

We prefer immutable texture to mutable texture and normal texture to framebuffer target texture.

There are 3 changes;
1. Introduce TextureHint enum to clarify immutable and framebuffer target.
2. The texture for render pass and background filter target is changed from mutable
 framebuffer texture to immutable framebuffer texture.
3. The texture for background filter source is changed from mutable framebuffer
 texture to mutable texture.

TEST=ResourceProviderTest.TextureHint, ResourceProviderTest.TextureAllocationHint
BUG=404986

Review URL: https://codereview.chromium.org/486853002

Cr-Commit-Position: refs/heads/master@{#291223}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291223 0039d316-1c4b-4281-b951-d872f2087c98

This allows embedders to send a chunk when they do not yet know if it is
the final chunk or not.

BUG=405678

Review URL: https://codereview.chromium.org/492063002

Cr-Commit-Position: refs/heads/master@{#291222}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291222 0039d316-1c4b-4281-b951-d872f2087c98

Functionality:

The |AppRegistry| has for each running application an |AppActivityRegistry|.

The |AppActivityRegistry| knows all activities associated with the application it represents.
It can furthermore shut the app entirely down upon resource manager request. It will then create
an |AppActivityProxy| for the overview mode which shows a placeholder for an unloaded app. This
placeholder can then ask the |AppActivityRegistry| to restart the application again.

A shutdown request for the application is only performed when all activities were marked for
UNLOAD.

If there were multiple activities upon shutdown for one app, the app has to take care of
re-creating all windows and thus re-creating all activities. Since an activity match cannot
be performed, the |AppActivityProxy| will only be shown once and it will show in the location
of the most recently used activity of that app. If we later on find an app which really uses
multiple windows and it is imperative to keep the history for all of them tact & the app is
recreating them properly, (a lot of if's) we can revisit the single |AppActivityProxy| and
try to address it in a cleaner way, but at this time that seems rather un-useful since it is
not known if required.

BUG=388085
TEST=AppActivityTest.*

Review URL: https://codereview.chromium.org/477523002

Cr-Commit-Position: refs/heads/master@{#291221}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291221 0039d316-1c4b-4281-b951-d872f2087c98

Some extension files are compiled on android when enable_plugins is set
to 1. These files need to have the parts that references extension
files compiled out of the code.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032
TEST= trybots

Review URL: https://codereview.chromium.org/468913006

Cr-Commit-Position: refs/heads/master@{#291219}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291219 0039d316-1c4b-4281-b951-d872f2087c98

 * AppListViewDelegate was accessing deleted search_provider.
 * DeviceSocketListener::StopListening can happen after DeviceSocketManager is deleted
 * Explicitly delete FilePathWatcher. This was causing
   recursive callback to FilePathWatcherImpl::Cancel from
   FilePathWatcherImpl::CancelOnMessageLoopThread, which
   caused crash.


Clean ups
 * change OnIO to OnFILE as they run on FILE thread.
 * removed unused singleton related code.

BUG=None
TEST=Run athena_main on desktop and close window.

Review URL: https://codereview.chromium.org/490033003

Cr-Commit-Position: refs/heads/master@{#291214}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291214 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403618

Review URL: https://codereview.chromium.org/475263002

Cr-Commit-Position: refs/heads/master@{#291213}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291213 0039d316-1c4b-4281-b951-d872f2087c98

Original: https://codereview.chromium.org/487913004/
Reverted because of a conflict with a patch that landed after it.
Only change is to use the new location for id_util (crx_file).

Original Description:
Only show the checkbox for all urls when the switch is on
BUG=402958

TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/490793003

Cr-Commit-Position: refs/heads/master@{#291212}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291212 0039d316-1c4b-4281-b951-d872f2087c98

Update existing configs and add a bunch more.

BUG=396139,357253,361300

Review URL: https://codereview.chromium.org/491113002

Cr-Commit-Position: refs/heads/master@{#291211}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291211 0039d316-1c4b-4281-b951-d872f2087c98

* No need to pass manager in callback
* No need to keep pointer to manager in provider
* Rename test methods Foo to FooForTesting

Review URL: https://codereview.chromium.org/486203004

Cr-Commit-Position: refs/heads/master@{#291209}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291209 0039d316-1c4b-4281-b951-d872f2087c98

Design Doc (Googlers Only):
https://docs.google.com/a/google.com/document/d/1RUY0BcxBppdkwFP3T8qbQmQStBRFGsLmuR4WuIXhiCA/edit

BUG=384011
TBR=timsteele@chromium.org

Review URL: https://codereview.chromium.org/379283002

Cr-Commit-Position: refs/heads/master@{#291207}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291207 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291206}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291206 0039d316-1c4b-4281-b951-d872f2087c98

See https://codereview.chromium.org/484923003

R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/497513002

Cr-Commit-Position: refs/heads/master@{#291204}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291204 0039d316-1c4b-4281-b951-d872f2087c98

This patch contains a test page used for manually checking the
functionality of the Battery Status API. It is currently also
available at http://jsbin.com/battery-status-test.

BUG=

Review URL: https://codereview.chromium.org/464073003

Cr-Commit-Position: refs/heads/master@{#291203}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291203 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403007
TBR=yurys@chromium.org

Review URL: https://codereview.chromium.org/493203003

Cr-Commit-Position: refs/heads/master@{#291202}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291202 0039d316-1c4b-4281-b951-d872f2087c98