- 10 May, 2019 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f3794c6f3ef5..5c293b71dc3e git log f3794c6f3ef5..5c293b71dc3e --date=short --no-merges --format='%ad %ae %s' 2019-05-10 fmayer@google.com Merge "Bump buildtools system/core to newest version." Created with: gclient setdep -r src/third_party/perfetto@5c293b71dc3e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I894ac3421931da45fa0032cf92862d0c252528fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605861Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658530}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/995da00b992c..62d6b621decf Created with: gclient setdep -r src-internal@62d6b621decf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I717e07abd967c14b7795584b6a551725baddf7a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605860Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658529}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/cd86d0d20a..aa468ad755 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/cd86d0d20a..aa468ad755 Bug: None Change-Id: I60b77aab9d6bf82fb8f914ff67b07ae3edbdf51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599604 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#658528}
-
Dominic Battré authored
This reverts commit 72316111. Reason for revert: Speculative revert, see crbug.com/950159 Original change's description: > Use DocumentInterfaceBroker to register AppCacheHost > > This CL uses DocumentInterfaceBroker to stop passing frame ID > over mojo from WebApplicationCacheHostImpl for the render > frame path and moves AppCacheHost registration and |host_| > from AppCacheBackendImpl to AppCacheServiceImpl. > > Now AppCacheBackend is only used for workers and it registers > AppCacheHost through AppCacheServiceImpl. > > Bug: 950159 > Change-Id: Ic1ba441a6a4bb7f430cf8fce8267ba69a7a4c32c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589478 > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658481} TBR=dgozman@chromium.org,kinuko@chromium.org,mek@chromium.org,haraken@chromium.org,jkim@igalia.com Change-Id: Ife2c87e8f79912f15ed925c85458b5becfa8490b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605416Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#658527}
-
Raphael Kubo da Costa authored
IWYU. This fixes the libstdc++ build after commit a1092aed ("Fix leak in FontService PPAPI fallback function"): ../../components/services/font/ppapi_fontconfig_matching.cc:130:8: error: no member named 'unique_ptr' in namespace 'std' std::unique_ptr<FcLangSet, decltype(&FcLangSetDestroy)> langset( ~~~~~^ Bug: 957519 Change-Id: Ia1425d5b7046ebeb8d7351a184a9cc119bf9d8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605689 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#658526}
-
Thomas Tangl authored
Replace the settings-privacy-page element with a settings-personalization-options element. (The code for the metrics reporting was moved to settings-personalization-options as part of UnifiedConsent.) Bug: 960259 Change-Id: I919248f4078bbca438611fc0e64da907fe86ef2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604269 Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#658525}
-
Morten Stenshorne authored
TBR=kojii@chromium.org Change-Id: If34020a8d2e823e33b3a76f61af44530603a653a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605691Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#658524}
-
Daniel Cheng authored
This is a reland of 28eb992f Fixes: - Disable sanitizers in the test helper. The test is intended to test baseline behavior with max optimizations/undefined behavior, and the assumption is that sanitized builds will, in fact, be saner. - Relax the nonce check, as the compiler can reorder IMMEDIATE_CRASH() blocks in the function epilogue as it wants. Original change's description: > Add test to verify the opcodes generated by IMMEDIATE_CRASH(). > > Bug: 958675 > Change-Id: Ica6b5bab7849f227567d8016354a39383533799f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595585 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658344} Bug: 958675 Change-Id: Ic1af1994909d58427cc12f1f9aee2765aa5b449c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604487 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/952b571a4ac7..199295882d87 git log 952b571a4ac7..199295882d87 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 oprypin@webrtc.org Qualify cmath function calls 2019-05-10 eladalon@webrtc.org Reland "Refactor handling of configuration overrides from Vp8FrameBufferController" 2019-05-10 nisse@webrtc.org Change SimpleStringBuilder::Append to not use strcpyn and SIZE_UNKNOWN Created with: gclient setdep -r src/third_party/webrtc@199295882d87 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib1b6739fbc385fbde482a70cfc2897a0fe09a622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604097Reviewed-by:
-
Antonio Gomes authored
This is a reland of 2f2d5d96 This revised CL fixes the missing include of third_party/blink/renderer/platform/scheduler/public/thread.h , originally missing. TBR=haraken@chromium.org Original change's description: > Onion soup canvas_capture_handler.cc/h > > This is a first step to OnionSoup content/renderer/media_capture_from_element/. > > It summary, this CL > > - Moves content/renderer/media_capture_from_element/canvas_capture_handler* to > third_party/blink/renderer/modules/mediacapturefromelement/. > - Adapts the existing code for Blink restrictions, eg use WTF::Bind > instead of base::Bind. > - Removes the code that used to plumb the creation of > content::CanvasCaptureHandler instances through blink::Platform, and make > blink::HTMLCanvasElementCapture to create it (see the second TODO > below). > > To be done (follow up CLs): > > - migrate some remaining base::Bind{Once,Repeating} uses to the > respective Blink/WTF alternatives. This is now blocked on having > a CrossThreadBindOnce implementation available (see > crrev.com/c/1597228). > - eliminate blink::WebCanvasCaptureHandler > third_party/blink/public/platform/web_canvas_capture_handler.h. > Note that this is not done now because there is code in > third_party/blink/renderer/core/html/canvas/canvas_draw_listener.cc|h > that use blink::WebCanvasCaptureHandler, and can not use > blink::CanvasCaptureHandler directly, because core/ can not depend on > modules/. > > R=kentaro@chromium.org, guidou@chromium.org > > BUG=787261 > > Change-Id: Id2dc1f6441e2568c8420f0849a2cb5f87f9a6d75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600898 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#658376} Bug: 787261 Change-Id: I9b5829d82c1b5420a5fc8c4cbb33505284471912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605560 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#658521}
-
David 'Digit' Turner authored
This CL implements step 2 in the refactoring described by http://crbug.com/951391, which attemps to port the viz component and service to use our new shared memory API (base::SharedMemory is deprecated). It modifies SharedBitmapManager::ChildAddedSharedBitmap to accept WritableSharedMemoryMapping values directly. This simplifies the implementation and gets rid of Mojo handle usage to pass shared memory region, in favor of the new base::UnsafeSharedMemoryRegion and base::WritableSharedMemoryMapping types. BUG=951391,795291 R=alexilin@chromium.org, enne@chromium.org, danakj@chromium.org, piman@chromium.org, samans@chromium.org, liberato@chromium.org Change-Id: I0314f43f64fc4cd5591c65816b764adb97fe6b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571648 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#658520}
-
David 'Digit' Turner authored
This CL extends the LoadParams struct to allow loading a library from an existing file descriptor and/or a reserved memory mapping as well. This will be used later to implement a wrapper for android_dlopen_ext() that support ANDROID_DLEXT_{USE_LIBRARY_FD, USE_LIBRARY_FD_OFFSET, RESERVED_ADDRESS, RESERVED_ADDRESS_HINT}. + Provide new tests to verify that the feature works properly. + Fix FileDescriptor move assignment operator for 64-bit unit tests. BUG=936001 R=pasko@chromium.org, agrieve@chromium.org, cjgrant@chromium.org Change-Id: I1ed174dfa268f780c5397f6e76c659f8fa57c935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564111 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:Egor Pasko <pasko@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#658519}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5dc689c12028..95e58587bed9 git log 5dc689c12028..95e58587bed9 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src e291f7a09f67..2dd4ab3a4acb (4 commits) Created with: gclient setdep -r src/third_party/angle@95e58587bed9 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: Ieb4a364446439c723edde1b9c03c740a594c743b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604096Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6e959bcf..fb60ce92 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9796f1cb99bcd2a0f08d311b272ba1ea021422d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605301Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658517}
-
Martin Robinson authored
When grabbing focus or setting the sequential focus navigation starting point for AtkText nodes, we should use the character offset to set it on the proper child node. This ensures that tab navigation works as expected after calling AtkText APIs on a parent node. Bug: 955349 Change-Id: Idf8677f7d4fb205fee46905c80fb1bf5bc9baf40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599616 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#658516}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be6aa332df1b..995da00b992c Created with: gclient setdep -r src-internal@995da00b992c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I1a5f8243a13aa6051416b66befb6ca6e918bb66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604094Reviewed-by:
-
Rune Lillesveen authored
Introduced in: https://crrev.com/bf7739c4947015b9ddfd245f28ea35de58fe45f8 Caused various fuzzer crashes. R=andruud@chromium.org Bug: 961535, 961520 Change-Id: I84fc226afb690fab5cbf07d7ca6aa9b79b4e2f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605406Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#658514}
-
alanlxl authored
Add an internal page (chrome://machine-learning-internals) to debug ML Service models and test connectivity/performance. Currently it supports a built-in TEST model which add two floats. What is planned for this page: * Each built-in model can add a tab here, if it's worthwhile to help debugging of on-device issues. * Plan to add performance metrics (i.e. latency) of different operations. * Plan to add control operations like Disconnect/Connect from ML Service. Bug: 924738 Change-Id: I23ff4ad93c532b7c1fc951a7ede1cb376b551f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1411959 Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#658513}
-
Javier Ernesto Flores Robles authored
When the return key in the keyboard is pressed, the following text field will become first responder. If there is none, the current text field resigns first responder to hide the keyboard. Bug: 960420, 951300 Change-Id: I6497bc9e1930b06054ab2946665e4836de94d428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602497 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#658512}
-
Finnur Thorarinsson authored
The new permission they added in earlier betas has been removed and a new RELATIVE_PATH column has been added, which replaces the DATA column (being deprecated). Bug: 905257, 656015 Change-Id: Ie30d234a031920fdb6487732c8d5a719267d9e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602719 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#658511}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 72316111. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." a554ea37 "Reland "[EventTiming] Round instead of ceil the |duration|"" a06bcc90 "WebXR: Rename requestSession parameter variables to match use" eeafcaee "[sms] Introduce testing infrastructure and handle some corner cases." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" faed29aa "[EventTiming] Remove unneeded prefix from WPT tests" 9d5bc5ec "Portals: Add support for frame-src CSP directive." d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I650f0f468b4d2936a4d3809ef7ba086d26658761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605302Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658510}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8c59e4b6dba6..f3794c6f3ef5 git log 8c59e4b6dba6..f3794c6f3ef5 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 fmayer@google.com Merge "Turn --pid and --name into comma separated lists." Created with: gclient setdep -r src/third_party/perfetto@f3794c6f3ef5 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia93909d03b7a5772a2ee91b8523301dcdf9e6fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604092Reviewed-by:
-
Elly Fong-Jones authored
Bug: None Change-Id: I162bdbdb5de4a5f094cf631f769878cc90c46b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602096 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#658508}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/09537e93fddd..4c03bf558364 git log 09537e93fddd..4c03bf558364 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 perezju@chromium.org [Telemetry] Remove old code for ClockSync as AsyncEvent Created with: gclient setdep -r src/third_party/catapult@4c03bf558364 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:947675 TBR=skyostil@google.com Change-Id: I022f1c0e6a187b9fecdb1d532c2bc043d293e29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605209Reviewed-by:
-
Dominic Battre authored
TBR=alph@chromium.org Bug: 959129 Change-Id: I90a383f3ee617f58614b14f0d54675ffc612b703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604266Reviewed-by:
-
Oleg Davydov authored
For further investigation of issues with forceinstalled extensions we need to know what happens with extensions in downloading stage in a more detailed way. We already collect data for this (in InstallationReporter via ExtensionDownloaderDelegate), so this commit introduces an UMA histogram. Change-Id: Id4d13b9e9678d0f7ef5bd30fbfbfebd7e57291bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587032 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658505}
-
Alex Clarke authored
Origional patch: https://crrev.com/c/1539981 This is the internal promise representation. It implements the machinery needed to marshal and dispatch promises as they become ready for execution. Care has been taken to try and minimize the size of the AbstractPromise class and to keep down the number of heap allocations. The promise result and the executor are both stored in the base::unique_any since they are never needed at the same time. The size of AbstractPromise on x64 is 96 bytes in builds without DCHECKS. In builds with DCHECKS it's larger because there's additional storage used to diagnose and prevent various usage hazards: * Unhandled rejection * Double move of promise results to callbacks * Mixed move and non-move semantics of promise results to callbacks The base::any_internal type has been adjusted so it can store the SmallUniqueObject<> inline, which is used to store the promise executor. The largest anticipated promise executor base::All is the size of 3x sizeof(void*) to hold a vtable and a std::vector. Design: https://docs.google.com/document/d/1l12PAJgEtlrqTXKiw6mk2cR2jP7FAfCCDr-DGIdiC9w/edit TBR=fdoray@chromium.org, etiennep@chromium.org Bug: 906125 Change-Id: I15dbb78d4aecb6ae60f5dfaca8f73aba3fdd0963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605683Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#658504}
-
Dominic Battré authored
This reverts commit 8964034e. Reason for revert: see crbug.com/961620 Original change's description: > [SpatNav] Navigation of stacked focusables > > Background: > SpatNav compares activeElement's bounding rect > with all other focusables' bounding rects. > > Example (snav-fragmented-link.html): > A multi-line ("fragmented") link has focus. > > xxxxxxLINK L > INKLINKxx #A > > Here LINK's bounding box's area is bigger than the > the combined area of its two fragments. The box, > returned by NodeRectInRootFrame(), even overlaps > another focusable, #A. We can say that LINK's > bounding box "contains" #A. > > Problem: > Spatial navigation searches _from_ the focused > element's bounding box (but not inside of it). > Here LINK's rect completely contains A's rect so > #A will never be considered as a focus candidate. > > Solution: > Give priority to focusables inside the current focus rect. > > This also solves the generic case, crbug.com/798102, > where one focusable lays "under" another one, i.e > where a focus rect "contains" (or is positioned > behind) another focusable. I test this case in > snav-focus-rect-contains-links.html. > > Previously, such containers where unreachable because > of 86d40f3d's (anno 2010): > > "... if there are 2 overlapping focusable nodes, we do > a hit test and only the node on top can get focus." > > Now, when two focusables overlap, SpatNav first goes > go the outer box. From there, focus can go to the > "on-top", or "inner" (thinking in 2D) focusables. > > Related CLs: > Search scrollers from their edges: crrev.com/589502. > This CL uses the same approach as crrev.com/589502; > when a "container" is focused, we first search inside of > it, from one of its edges. > > Distance calculation fixup: > OppositeEdge()'s returned slice will now be "just outside" > the box it is slicing. This change helps us avoid if-logic > to cover cases when focusables sit at the very top of their > container. > > Bonus cleanup: > AreElementsOnSameLine() can now be removed. It was > introduced back in 2011 at 3568f132 to support > [some] line-broken links but it didn't fix 956900. > > Bug: 798102, 956900 > Change-Id: I00aaba88a7846b36275f9913034145679576e410 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587559 > Commit-Queue: Hugo Holgersson <hholgersson@fb.com> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658484} TBR=bokan@chromium.org,fs@opera.com,junho0924.seo@lge.com,hholgersson@fb.com Change-Id: If908a9fe49b9a653018ae7f9fdbf9120b130cc6d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 798102, 956900, 961620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605410Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6bf102206a6c..be6aa332df1b Created with: gclient setdep -r src-internal@be6aa332df1b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: Ifde234608f6bcc05a1882f383897c016b94060fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605210Reviewed-by:
-
Dominic Battre authored
TBR=mcnee@chromium.org Bug: 961607 Change-Id: I26c5b72817e69b9835ce309602bac64efcb21d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605407Reviewed-by:
-
Andy Paicu authored
Spec change in progress: https://github.com/whatwg/html/issues/4510 Bug: 920531 Change-Id: Idef348de028acbb400ae39ed5e9d058a2fc0173d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545067 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#658500}
-
Javier Ernesto Flores Robles authored
This way the alert will adjust itself to acommodate for it. BUG=959737 Change-Id: Ia0a4945f8d18079ca698af6ecd74423fe7bec459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602511 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Adds a toolbar to the implementation to showcase, which helps demostrating how the alert respects the safe areas. The toolbar contains a dummy button to demostrate how the presentation is done not modally. R=edchin Bug: 951301, 951300 Change-Id: I31297cfc73a0e59b854404685cdb1d4851f12bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594584 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658498}
-
Rune Lillesveen authored
The IsNull() check for the content attribute when processing referrer- policy got lost in [1] which caused a DCHECK to happen. Re-introduce the IsNull() check. [1] https://crrev.com/bf7739c4947015b9ddfd245f28ea35de58fe45f8 Bug: 961304 Change-Id: I5cb755d47725f56e84b372b5cc6175d92dca1b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602729Reviewed-by:
-
Javier Ernesto Flores Robles authored
Tests to follow in another CL. Bug: 951300 Change-Id: I1e622285758b22c84986242bd39e5f4c99b0496c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590135 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Nektarios Paisios authored
The affected test would count the number of selection changed notifications and succeed if 4 notifications had been received. This is brittle because the test was counting both the notifications that resulted from the setup method in addition to the test itself. To exclude the selection changed notificationsfired from the setup method, the test is mmodified so that it runs after layout and paint. R=aboxhall@chromium.org Bug: 639340 Change-Id: I766138415f6d36042214eeba3ada02645f54dc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601994Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#658495}
-
Tanmoy Mollik authored
Bug: None Change-Id: I0d56179e339c4c361823f438b7d70072de80ee59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602712Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#658494}
-
Tanmoy Mollik authored
This CL replaces the deprecated base::SharedMemoryHandle used to hold the crash information in nacl:: classes with new shared memory api. The plugin side writes to the shared memory region using base::WritableSharedMemoryRegion and sends a read only version of the region to the renderer process through the browser. The renderer side reads the crash info using base::ReadOnlySharedMemoryRegion. Change-Id: I335040a9884d6dc79f107070c954a3ff250458a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565974Reviewed-by:
Derek Schuff <dschuff@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Sergio Villar Senin authored
Most of the code uses "loading" but there were a few samples of code using "loader". Unifying both under the "loading" umbrella. Bug: 954854 Change-Id: I9fa3c7ecb6f342a30614ea3485bcb7eb0eea2475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594587Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#658492}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3d622d6e5c42..952b571a4ac7 git log 3d622d6e5c42..952b571a4ac7 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 nisse@webrtc.org Delete unused class InsecureCryptStringImpl 2019-05-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a91b44f5..5f38b3b2 (658232:658382) Created with: gclient setdep -r src/third_party/webrtc@952b571a4ac7 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7c96569ea6adc8e64f5ff6f089a19e27618a0ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605208Reviewed-by:
-
