- 23 Oct, 2020 40 commits
-
-
Kushagra Sinha authored
Fix use-after-move in chromeos::AccountManager::GetAccountEmailInternal callback. Change-Id: I463165fe2e642ffed07c5c11c26984d99daf5815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495060Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#820199}
-
Marc Treib authored
Notably, visitors were missing for the custom_nudge_delays field, which meant that this field wouldn't show up in the traffic log in sync-internals. Bug: 1141792 Change-Id: I60ea80be9b026ae2d6a386837f707c2180b17cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494862 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#820198}
-
Tanmoy Mollik authored
Test two different sign-out flows in AccountManagerFragment. When the user is signed in without sync consent, sign out dialog should not be shown and data on device should not be wiped. When the user is signed in with sync consent, sign out dialog should be shown giving the user the choice to wipe device data. Bug: 1138935 Change-Id: Ie31d14b8fac938614dda927076e81344d52d5774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478980Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#820197}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e369f4fe6ec4..4c63602bdb60 2020-10-23 alcastano@google.com Typecheck elements/ElementStatePaneWidget.js with TypeScript 2020-10-23 wolfi@chromium.org Display frame ID in FrameDetailsView for debugging 2020-10-23 patrick.brosset@microsoft.com Refactor the ColorSwatch to use TypeScript and LitHTML web component If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1137438,chromium:1140481 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4b9fdd1aaa72d4075ff0919ae447813b99390da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494901Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820196}
-
Rushan Suleymanov authored
Moved classes: * FakeSyncChangeProcessor * ModelTypeStoreTestUtil * SyncChangeProcessorWrapperForTest * SyncErrorFactoryMock Bug: 948661 Change-Id: Ic2476778322af7b0bf64d071e10d0991dc8c07b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489980Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#820195}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d9ccb94f..cdd7e6fa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1affd489b188618d14707633ac118e271eb485ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494425Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820194}
-
Bret Sepulveda authored
TBR=jdeblasio@chromium.org Bug: 1139955 Change-Id: Ib622080583b8ebf3764b75513346d179e1be43f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494762Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#820193}
-
Marc Treib authored
It was always called directly from ModelAssociationManager::Associate(). The only non-trivial thing Associate() did was make sure it gets called only once per datatype and ModelAssociationManager::Initialize(). DataTypeManagerImpl now takes care of that itself, by storing a map of ConfigurationStats instead of a vector. One small behavior difference is that the ordering of those ConfigurationStats is not the same anymore. AFAICT, nothing depends on the ordering, and anyway each ConfigurationStats entry contains ordering information in the form of "types_configured_before", so this should not matter. Bug: 1102837 Change-Id: I95d71e8fa98b8b382bc182dc11e1fcbd6e58c4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490109Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#820192}
-
Rushan Suleymanov authored
Without this patch in several cases when the commit request fails (e.g. the server returns any other than 200 HTTP error code), the model type processor doesn't reset transient state for entities. These entities won't be retried on the next sync cycle. In case when there are no new unsynced entities, those entities in the transient state won't be committed. If there is any new unsynced entity, it will be committed and eventually the transient state for all (even previous) entities will be reset. It means that in the most cases the issue is barely noticeable. This CL clears transient state of all entities on any commit failure. In this case the next commit request will collect all data again and commit it. For the integration test the fake server has been slightly changed. It stores the latest commit and get updates requests even on http error and stores the request and empty response to logs for debug print. Bug: 1137817 Change-Id: I50125dcbec9244f10227383a7081320be91b57db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485941 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7dee50774b30..7874beb5c5a1 2020-10-23 landrey@webrtc.org Roll out upload completion token for all requests from specified group If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1114061 Tbr: oysteine@google.com Change-Id: I19df667d17d18ebc8a2bff944682326967f0a2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493739Reviewed-by:
-
Hiroki Nakagawa authored
This is a follow-up CL for: https://chromium-review.googlesource.com/c/chromium/src/+/2409473/54/content/browser/browser_interface_binders.cc#756 It should be less error-prone to put the binder for Prerender2 in the same BinderMap variant as the binder for NoStatePrefetch. These are enabled in a mutually exclusive way. Bug: 1132746 Change-Id: I441c748c9dc1429550fd9de54cc2e387fbaaf71b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494286Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#820189}
-
Tanmoy Mollik authored
Add tests to check "Allow Chrome Sign-in" toggle behavior in GoogleServicesSettings page. It tests two specific behavior: 1. When the user is signed in without sync consent, toggling the preference off should sign the user out without showing the sign-out dialog and should not wipe user data. 2. When the user is signed in with sync consent, toggling the preference off should launch the sign out dialog to give the user an option to wipe data. Bug: 1138167 Change-Id: I481039755bcadd626e9bc0662b29f94b5d4298b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475059Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#820188}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1603357187-4783767f29971847246b39ba5f03512056047f0d.profdata to chrome-win64-master-1603410964-0d0b8de70170fa01a9e55b31b32c1f982b32b97d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I716510b6419baa5b541d3bcaa7a9914a027095d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493728Reviewed-by:
-
Mugdha Lakhani authored
Bug: 1141553 Change-Id: Ic20aa40baf1302e17f9f0f8f2c7a7fbd480ef7de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494760Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#820186}
-
Benoit Lize authored
PartitionAlloc perftests can OOM sometimes, if threads are too fast to allocate. Free memory periodically while allocating enough to gooutside the thread cache (if any). Bug: 998048 Change-Id: Id70e6f807accfd85a5039b5bd5d37bb950acbf45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489655 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#820185}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bf66f2d5f6b3..805ba2eff0e1 2020-10-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I53ad925c5f690d12a0719d9401fbb985a24cc7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493149Reviewed-by:
-
arthursonzogni authored
[3/3] of: https://docs.google.com/document/d/13jcj_mATRxKakPEGy72YYHZBTBkkNrAHzaNIIjVsC8I/edit In theory, the MHTML file can be any arbitrary file. It can be malformed. In practise, this should be rare, because the majority of the archives are produced by Chrome for offline pages. We would like to make blink not to be able to fail to fail to commit the document. If the browser process initially classified it to be an MHTML document, it must be considered to be an MHTML document by blink. This patch do not clear the `archive_` on malformed documents. By doing it, it will continue to be considered as a MHTML document. For instance, it will be sandboxed (=> no javascript, => opaque origin) Along the way some minor improvement: - The console message has been moved after the commit, fixing https://crbug.com/967377 - Several rafactoring and comments have been added to help my own comprehension. Fixed:967377,1139283 Bug:967377,1139283 Bug: 1139283 Change-Id: I4a2b5f6ce3dfac40f0b36fa067c2965583cacbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480083 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#820183}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ba15b5886290..69f07da41b3b 2020-10-22 afdx@google.com spirv-fuzz: Fix mismatch with shrinker step limit (#3985) 2020-10-22 afdx@google.com spirv-fuzz: Fix off-by-one error in replayer (#3982) 2020-10-22 afdx@google.com spirv-fuzz: Get order right for OpSelect arguments (#3974) 2020-10-22 afdx@google.com spirv-fuzz: Do not add synonym-creating loops in dead blocks (#3975) 2020-10-22 afdx@google.com spirv-fuzz: Skip OpTypeSampledImage when propagating up (#3976) 2020-10-22 afdx@google.com spirv-fuzz: Pass OpUndef in function call if needed (#3978) 2020-10-22 afdx@google.com spirv-fuzz: Fix off-by-one in TransformationCompositeConstruct (#3979) 2020-10-21 afdx@google.com spirv-fuzz: Tolerate absent ids in data synonym fact management (#3966) 2020-10-21 afdx@google.com spirv-fuzz: Fix to id availability (#3971) 2020-10-21 afdx@google.com spirv-fuzz: Fix operand types (#3962) 2020-10-21 8729214+jonahryandavis@users.noreply.github.com Update SPIRV-Headers revision in DEPS file (#3961) 2020-10-21 afdx@google.com spirv-fuzz: Don't flatten conditional if condition is irrelevant (#3944) 2020-10-21 afdx@google.com spirv-fuzz: Do not produce OpPhis of type OpTypeSampledImage (#3964) 2020-10-21 afdx@google.com spirv-fuzz: Restrict fuzzer pass to reachable blocks (#3970) 2020-10-21 afdx@google.com spirv-fuzz: Handle more types when extending OpPhi instructions (#3969) 2020-10-21 afdx@google.com spirv-fuzz: Skip early terminator wrappers when merging returns (#3968) 2020-10-21 afdx@google.com spirv-fuzz: Avoid irrelevant constants in synonym-creating loops (#3967) 2020-10-21 afdx@google.com spirv-fuzz: Skip dead blocks in FuzzerPassAddOpPhiSynonyms (#3965) 2020-10-21 afdx@google.com spirv-fuzz: Avoid the type manager when looking for struct types (#3963) Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers from 3fdabd0da293 to 05836bdba63e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I576e5fc09a8bb418cb7a33146e002592fee943c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494515Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0517bfe506ad..79a76200e48b 2020-10-23 thestig@chromium.org Remove loading of unused gdiplus functions. 2020-10-23 thestig@chromium.org Remove most CFX_WindowsDIB code. 2020-10-23 tsepez@chromium.org Bicubic image transforms are not used by PDFium. 2020-10-22 thestig@chromium.org Further reduce manual memory management in CGdiplusExt::LoadDIBitmap(). 2020-10-22 tsepez@chromium.org Remove some references to |cmyk| from fxge/dib. 2020-10-22 tsepez@chromium.org Make class CFX_DIBitmap::Channel private. 2020-10-22 thestig@chromium.org Replace manual memory allocation / deletion with a unique_ptr. 2020-10-22 tsepez@chromium.org Remove arguments from CFX_DIBitmap::LoadChannel() 2020-10-22 tsepez@chromium.org Make FXDIB_Channel an enum class and nest in CFX_DIBitmap. 2020-10-22 thestig@chromium.org Remove unused members in CFX_ImageStretcher. 2020-10-22 thestig@chromium.org Remove a CFX_DIBitmap::CompositeRect() parameter. 2020-10-22 thestig@chromium.org Slightly simplify CFX_ImageTransformer. 2020-10-22 thestig@chromium.org Use more spans in CFX_ScanlineCompositor for palette data. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ied0c7de04ce1d0c6f4cdb9d074c1281acea901ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494516Reviewed-by:
-
Ramin Halavati authored
InProcessBrowserTest::CreateGuestBrowser does not work on ChromeOS and to create a Guest browser, proper switches need to be added while setting up the test. The function is excluded from ChromeOS build. Bug: 1125474 Change-Id: If14266e1a1372ebec4e4ae92c0fea16164d726f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490007 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Fredrik Söderqvist authored
Fold SVGResourcesCache::ResourceReferenceChanged into its two users, greatly tailoring the resulting code for one user (SVGPatternElement). Expose a function for updating the SVGResources object. Bug: 1028063 Change-Id: I439ca043c659bad7dbb3fa89d9a4d3d9578f7c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489650Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#820179}
-
Morten Stenshorne authored
This is a reland of 3786076d Original change's description: > Enable "gn check" for //third_party/blink/renderer/core/typed_arrays > > Bug: 800764 > Change-Id: I7e09231307f6de1c5457150581438f590b43de85 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484596 > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818852} Bug: 800764 Change-Id: Ibf1b672b0d773aee91c5ac33b2f379d8e950cd6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490051Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6abe5ba13913..e369f4fe6ec4 2020-10-23 almuthanna@google.com Reduce flickering for the profiling test 2020-10-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1140926 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I81cd26aa62eecfea465b89dcd44e5b9916ca739b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494512Reviewed-by:
-
Victor Hugo Vianna Silva authored
SyncController used to create a SignInStateObserver that would call ProfileSyncService.requestStart() on every sign-in. Soon users will be able to be signed in but not syncing, so this CL removes the observer. requestStart() is still called if sync is enabled, since SignInManager.finishSignInAfterPolicyEnforced() still calls AndroidSyncSettings.enableChromeSync() [1][2], eventually calling SyncController.updateSyncStateFromAndroid(). [1] https://source.chromium.org/chromium/chromium/src/+/3073cfbd9528937c5cdf94a15c96f56206f1fac5:chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java;l=568 [2] https://source.chromium.org/chromium/chromium/src/+/3073cfbd9528937c5cdf94a15c96f56206f1fac5:chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java;l=805 Fixed: 1141512 Change-Id: I6cba35e710d768810c63592d969f3be753aa32e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490014 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Ricky Liang authored
When the render thread encounters GPU context lost, we need to re-create the SharedImage resources to recover the video capture stream. This is a reland of crrev.com/c/2455328 with a fix to address the MSAN test failure Bug: 1131998, b:169429427 Test: Manually with chrome://gpuclean on soraka TBR=jcliang@chromium.org,ccameron@chromium.org,kbr@chromium.org,dcastagna@chromium.org,guidou@chromium.org,ccameron@google.com Change-Id: I3d00abaea04ccf95a795e116f5fc7ff5c7d7f43a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494406Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#820175}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/734a27a2f391..58cf3fe83b93 2020-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 22505a5afe1f to ade9a5235c73 (2 revisions) 2020-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e02d8938821a to 8012e62471be (1 revision) 2020-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d74754378f09 to 097f307e75a4 (10 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Test: Test: Test: angle_perftests -v --local-output --gtest_filter="TracePerfTest.Run/*nba*" Change-Id: I4b79e7fc0f0e471571b95fffa1b443cd7a77eed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494508Reviewed-by:
-
Daniel Cheng authored
Bug: 1140588 Change-Id: I2c55eeae2125a4c4dea4683a2a017723c3f14e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488320Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#820173}
-
sauski authored
Added type checking for the following tests: - collapse_radio_button_tests.js - do_not_track_toggle_test.js - recent_site_permissions_test.js Bug: 1000989 Change-Id: I310777a6f17ffff9c63b03965c71ea14485b54d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489630 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#820172}
-
Andrew Shulaev authored
Bug: 171470675 Change-Id: I377272cc73f80a98efdeeed6d05c64bc23ea2630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489631Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Andrew Shulaev <ddrone@google.com> Cr-Commit-Position: refs/heads/master@{#820171}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603410964-a2043bc9224640fe9aacb254c17e5c20cde84377.profdata to chrome-linux-master-1603426036-fdbbb30b2e93e949277645ff11f5cf593a24568b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I349f4d66d47328e94ad1a21ca4315c97c31071e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493444Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iafc2798927e20959e4f5b52ae1830eaae0b067da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494640Reviewed-by:
-
Tal Pressman authored
Before crrev.com/c/2485659, this was done in RenderThreadImpl::CreateView, but this got lost when moving CreateView to AgentSchedulingGroup. Fixed: 1141547, 1141397 Change-Id: Iccf2ecab42b039640c53001544823e2b599ccbcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494191Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#820168}
-
Bret Sepulveda authored
This reverts commit 43831226. Reason for revert: Causing failures in the generate_build_files step on multiple builders. See for example: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9336 https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/10837 https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome-easwa/1288 Original change's description: > Use grd generation in the Sample System Web App. > > Bug: None > Change-Id: I4485ddbb595ade6ef078abda2436fa887a0d8b7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489060 > Commit-Queue: calamity <calamity@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820135} TBR=khorimoto@chromium.org,calamity@chromium.org,ortuno@chromium.org Change-Id: I62815e6e75e4d6483dd162ec8c0a415584667060 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494722Reviewed-by:
-
kouhei authored
Before this CL, RenderFrameProxyHost registered itself to per-process IPC channel. This is wrong, since RenderFrameProxy is bound to an AgentSchedulingGroup. This ends up AgentSchedulingGroupHost being queried `GetRoute()` to associate interface for the RenderFrameProxyHost, but fails, since it was never registered. This CL fixes the issue by correcting RenderFrameProxyHost to register its route to AgentSchedulingGroupHost. This behavior will be enforced by a DCHECK which to be introduced in an upcoming CL. Bug: 1111231 Change-Id: I135547ccb2d30268e84d9f3e6b054b6b2e9069f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494285 Auto-Submit: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
Currently, the keyboard accessory may show stale suggestions. This is because sheets are cached by adding them with `emplace` to a flat_map. `emplace` only adds an item if it isn't present, so the oldest, non-empty sheet (for a given tab) will be shown forever. This isn't immediately obvious since sheets are also pushed directly when they are updated but with indirect updates (e.g. updating another sheet), the stale value will override the new one. By using `insert_or_assign`, the newer value replaces the old one. Bug: 1140358, 1134119 Change-Id: I933ec47a1da596f58fa99d5b9bc481954122c2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489899Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#820165}
-
Hirokazu Honda authored
This adds WARN_UNUSED_RESULT to VaapiWrapper functions whose result should have the critical impact enough to regard its failure as video processing fatal. VaapiVideoDecoder actually doesn't handle the failure of VaapiWrapper::CreateContext. This CL also fixes it. Bug: b:171536540 Test: Build media_unittest and vaapi_unittest Change-Id: Iba6924849bfe8627fd328c3541c7a2c5cb0f0371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493742 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#820164}
-
sandromaggi authored
This can be used for sending keypresses instead of a click. This is intended for experimentation and not to be exposed to scripters directly. Bug: b/171280538 Change-Id: I83b4053cbc29f03ce2a2158ffefee8cf1f200e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484423 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#820163}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2e5b59565826..6b3c8d667a5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I57edfcc86c667f0ff4555b9a9ac192a3d57e4f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493417Reviewed-by:
-
Jiawei Shao authored
This patch adds a temporary command line parameter to allow the developers testing the performance of WebGPU with and without the robust buffer access pass in Dawn. BUG=dawn:480 Change-Id: I9ad312115e718d97cc9b89c0f20edf8aa0212518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490208Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#820161}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c97292f87f01..9a16bdb16349 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kinuko@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1080853,chromium:1126301,chromium:1130697,chromium:1138657,chromium:1141430 Tbr: kinuko@google.com Change-Id: I34f46b41837e271e713d6592c33b14e112a7786f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493730Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820160}
-
