GitLab

UX has requested that we update two strings related to UMA consent.
Additionally, this CL moves two strings which were OS-specific from
settings_strings.grdp to os_settings_strings.grdp.

Fixed: 1043688
Bug: 967883
Change-Id: I906c942ad4b093e95fad6ddc77960d49e879a281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146081
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758368}

* Allow string whenever a property is text, Thing, or Enum type.
* Allow URL whenever a property is Thing or Enum type, /as long as/ the
  URL is a schema.org ID of an appropriate thing or enum.

https://schema.org/docs/gs.html#schemaorg_expected

Change-Id: I72edef99f705c64838f09829de6c34058b10b860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144401Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Sam Bowen <sgbowen@google.com>
Cr-Commit-Position: refs/heads/master@{#758367}

This CL renames the video.requestAnimationFrame into the
video.requestVideoFrameCallback API. It also updates non WPTs to use the
new API.

WPTs will updated in their own CL.

Bug: 1012063
Change-Id: Id41c3979e1f74df51ab10bbff68a9a0b39b7ccd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144625
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758366}

Adds performance tests for both |includeContinuous: true| as well as the
default event set. Removes existing test suppression.

Bug: 1069468
Change-Id: I42ca33dfc07a9fdd97011aa81d05c430d4fbd204
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146098Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Andrew Comminos <acomminos@fb.com>
Cr-Commit-Position: refs/heads/master@{#758365}

This CL fixes a problem where VaapiWrapper would detect a given codec as
being supported when in reality it wasn't. This occurs because before
this CL, VaapiWrapper::GetEntryPointsForProfile() ignored the CodecMode.
So, for example, in lulu, JPEG decoding is supported but encoding is
not. However, since GetEntryPointsForProfile() didn't care about the
decoding or encoding mode, it would return VAEntrypointVLD for both.
This would cause VaapiWrapper::IsJpegEncodeSupported() to return true.

This CL makes VaapiWrapper::GetEntryPointsForProfile() take the
CodecMode into consideration by grouping the VAEntrypoints according to
the corresponding CodecMode.

Additionally, a test is added to ensure that the default VAEntrypoint
(as determined by VaapiWrapper::GetDefaultVaEntryPoint()) is actually
supported. This is useful because we use the default entrypoint in
VaapiWrapper::Initialize() and we never check if it's actually
supported, so this test serves as an assertion on all boards.

Bug: 1068440
Test: ./vaapi_unittest --gtest_filter="VaapiTest.*" on lulu and grunt.
Change-Id: Ib4cceb75d67a4d26582874f810c04deacd1b51f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144863
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758364}

Change-Id: Ie3133d8a9d1b9887265639bea52066cf9c8cf869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146112Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758363}

* No results UI shown when there are no results and the input text
  is nonempty.
* Dropdown is closed if input text is empty.
* Adds a separator that covers top box-shadow of dropdown.

Mock (See Zero State):
https://docs.google.com/presentation/d/1-DftlpMfwFvvCi5RDpT4chSRpNk13EUTyX3AzT80I1c

Screenshot:
* No results UI and no shadow on top of dropdown section:
  https://screenshot.googleplex.com/iv7QUkg28wn

Bug: 1056909
Change-Id: I1a26e1c9b933f540bf294db6165ef0c11e187c53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138165
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758362}

This makes FlexNG support the aspect-ratio property.

Bug: 1045668
Change-Id: I3cd7883846dd3d087850bccf5b5f1d3ce0c3d8c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144365
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758361}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3431cbde4e5a..a07910e9e064


Created with:
  gclient setdep -r src-internal@a07910e9e064

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1058152,chromium:1061193,chromium:1067290,chromium:1067765
Tbr: nhiroki@google.com,reillyg@google.com
Change-Id: I9010d2a701e367ca18f8fc3138bf878030026555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145928Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758360}

This CL introduces a new omnibox view to contain the button row.
The layout and element handling will be reworked but initially the goal
is to preserve as much as possible from the working logic in the
result view.

Bug: 1046523
Change-Id: Ibf5f20b0494d35669991da343d62afa4f036ba4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141234
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758359}

Commonly spoofed domains are mostly only raw domains
but the matching domains to the reuse saved passwords
are now eTLD+1. (i.e. login.live.com vs live.com).
Thus, the matching domains should either be equal
to the raw domains or have the suffix of "."
concatenated with the commonly spoofed domains. The
first part of this was  https://crrev.com/c/2133974.

Screenshot:
http://screen/xGQJbODneQe.png

Bug: 1067401,1069578
Change-Id: I3d50f768c7bd4c445cd050c286ec0c510e0c39c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140623Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758358}

This was disabled in 2013 as flaky, but I ran 3000 iterations on the
bots with no flakes.

Bug: 248047
Change-Id: I7f8e791a587ee9cc3c396890296a4a88f7b3328e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144742Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758357}

GetRawDataResource assumes that underlying files are not compressed,
whereas LoadDataResourceString automatically decompresses if necessary.

This is one of many CLs, in preparation of compressing all HTML, JS,
CSS, SVG files by default (meaning without requiring compress="gzip"
to be specified).

Bug: 1068407
Change-Id: Icb1dc7f1911d6b3bce54fa8132d66fb0acf71be5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145819
Commit-Queue: dpapad <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758356}

Before integrating the new updater with Chromium src,
there needs to be end-to-end validation of the updater
features. Adding a simple test app will help in easily
determining this.

Bug: 1063435
Change-Id: I44d9ddaceec035be75158af5f6824c5410be0a0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133169
Commit-Queue: Michael Chang <donchan@microsoft.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758355}

Mostly this reworks the sync change processing order to try to declare
variables near their first use, factor out common bits, and reduce
indenting.  It does change the error message on ACTION_INVALID
(shouldn't be a problem).

Bug: none
Change-Id: I843a76353bae9cba6f693f996ab60deec1b01e4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145913
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758354}

This reverts commit c195e902.

Reason for revert: Causing local build failures.

Original change's description:
> [base] Move the CHECK and CHECK_op macros to more light-weight headers
> 
> This provides cheaper (in terms of compile time) alternatives for code
> that just wants to do a few simple CHECKs without pulling in the full
> weight of logging.h. On Linux, the preprocessed size of check.h and
> check_op.h are 2% and 62% of logging.h, respectively.
> 
> Splitting the CHECK and CHECK_op macros out to separate files also
> reduces the complexity of logging.h which has become very complicated.
> 
> As a bonus, the new implementation is leaner, causing a 3% local
> compile-time reduction for the chrome target on Linux even though no
> includes have been changed yet.
> 
> Bug: 1031540
> Change-Id: If7aca321f077110bea0907e487d2e8d29a8c50fd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128112
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#758287}

TBR=thakis@chromium.org,hans@chromium.org

Change-Id: Ia5cc40588e336a9d35420b862157ff9286c2370a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1031540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146055Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758353}

NaCl processes exit directly via ExitProcess rather than returning from
the content main function back to ChromeMain (see comment on NaClExit
in native_client/src/shared/platform/win/nacl_exit.c). This means
we have to disable the default behavior of crashing on process detach;
otherwise all exits are reported as crashes

R=bbudge@chromium.org

Bug: 1008178
Change-Id: I87e1e3e70a50ed587f6ef7c637fc4b874574e1d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144468
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758352}

https://android.googlesource.com/platform/external/perfetto.git/+log/50f449b1dfd7..e14328694186

git log 50f449b1dfd7..e14328694186 --date=short --first-parent --format='%ad %ae %s'
2020-04-10 lalitm@google.com Merge "Fix max trace_bounds"

Created with:
  gclient setdep -r src/third_party/perfetto@e14328694186

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I98aa93ed81d8b753c5256e0468e619d5aa7c7b44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144843Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758351}

Move IgnorePaintTimingScope from paint_timing_detector.h into dedicated
.h and .cc files under renderer/platform, so that PaintController can
check it before recording first paint status.

This fixes several wpt tests for FCP about opacity in
CompositeAfterPaint which always paint opacity:0 contents. This doesn't
fix (and probably we'll never fix) missing FCP when opacity:0 becomes
non-zero, because we don't repaint.

Change-Id: If1b393f5c1440fada11806a7ac071b5700843ac5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145134
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758350}

https://webrtc.googlesource.com/src.git/+log/fdabfbc3349a..9d8cede79b05

git log fdabfbc3349a..9d8cede79b05 --date=short --first-parent --format='%ad %ae %s'
2020-04-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bc4df9dd..666362b2 (758140:758256)

Created with:
  gclient setdep -r src/third_party/webrtc@9d8cede79b05

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I7fc23ec3fc42411419ec760a306427452f8bbcc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145927Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758349}

https://quiche.googlesource.com/quiche.git/+log/e4524052d19d..b86cd3f5fb91

$ git log e4524052d..b86cd3f5f --date=short --no-merges --format='%ad %ae %s'
2020-04-06 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_use_standard_deviation_for_pto.
2020-04-06 renjietang gfe-relnote: deprecate gfe2_reloadable_flag_quic_writevdata_at_level
2020-04-06 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_minimum_validation_of_coalesced_packets.
2020-04-06 bnc Deprecate --gfe2_reloadable_flag_http2_skip_querying_entry_buffer_error.
2020-04-06 ianswett gfe-relnote: Deprecate unverified flag quic_bbr_one_mss_conservation false, because it increased retransmit rates and all work is now on BBRv2.
2020-04-06 bnc gfe-relnote: Send IETF QUIC, HTTP/3 and QPACK error codes in CONNECTION_CLOSE frames.  Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27.
2020-04-05 bnc gfe-relnote:  Refactor QuicConnectionCloseFrame.  Not protected.
2020-04-04 bnc gfe-relnote: Delay writes on QPACK streams.  Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27.
2020-04-03 fayang gfe-relnote: In QUIC, split ConfigureMaxDynamicStreamsToSend to two and update max open incoming streams count in stream id manager. Protected by existing gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27.
2020-04-03 renjietang Use protocol flag to gate HTTP/3 server push.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

R=bnc@chromium.org

Change-Id: I3412be38f059050a7578ac95806b0d2dcd68599a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137925
Commit-Queue: Ian Swett <ianswett@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758348}

Bug: 1025857
Change-Id: I4a40cfeb8ad0c63ddf0abcf843130d888661b50a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137516
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758347}

This CL updates the Header to always show the toggle icon.

This CL fixes mouse events for the header, by deriving the control
from views::View correctly (instead of Label, which was a typo).

It also brings the layout closer to the final layout, with a
left-aligned label and the button on the right, by setting the flex
on the label to 1.

Bug: 1052522
Change-Id: I751dee3a3e73c1f1cba936e6a29b0ff7629a4b74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145822
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Auto-Submit: Tommy Li <tommycli@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758346}

GetRawDataResource assumes that underlying files are not compressed,
whereas LoadDataResourceString automatically decompresses if necessary.

This is one of many CLs, in preparation of compressing all HTML, JS,
CSS, SVG files by default (meaning without requiring compress="gzip"
to be specified).

Bug: 1068407
Change-Id: If7df690e2b423ba0d2775d5b7d31a4800d8cd03d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145817
Commit-Queue: dpapad <dpapad@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758345}

Enable wide color gamut in same condition as chrome, except use
kUseWindow instead of kUseDisplay.

Change-Id: I199bb3545143ad169b13f47ed5986c6d0865728f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143861
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758344}

Bug: 836700, 836110
Change-Id: Id22b0e22d95f3b0429c20799f59a95062a99ac5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143691Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758343}

Previously it used RecordSource and RasterSource which did some extra
work not needed and caused DCHECK failure in CompositeAfterPaint when one
DisplayItemList was handled by RecordSource and RasterSource more than
once. In CompositeAfterPaint,
ContentLayerClient::PaintContentsToDisplayList() just returns the cached
DisplayItemList.

Simplify cc::PictureLayer::GetPicture() by directly calling
DisplayItemList::Raster().

Change-Id: I17cbf004371861ef901c95d21011f1bc9b07f880
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142695Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758342}

These radii were being converted to ints too early. Allow them to pass
through the CTM before rounding.

At the moment Skia will round the radii after mapping them through the
CTM. The specification is unclear about how to convert to integer
physical pixels, with clarification discussed at
https://github.com/w3c/csswg-drafts/issues/3619 .

Bug: chromium:719999,chromium:856178,skia:10110
Change-Id: I6a400eb7398c533fcdc46c6f2ca22c11f56a3912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132426Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758341}

Change-Id: Id99a39facc81873a57f0e0b3671dcc108e811da5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145967
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758340}

Removes a unnecessary SetSize call after updating the icon. It is
unnecessary because we should be using the bounds specified by Layout.

Test: manual
Bug: 1069428
Change-Id: Ia3c24ed4c94472236c193f1fc85569af36d8e647
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145952Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758339}

For actions that are not supported on the Fuchsia SemanticsManager side,
handle those explicitly by running
OnAccessibilityActionRequestedCallback with false. This indicates the
action was received and deliberately not handled.

Add ConvertAction to convert a single Fuchsia action to a Chromium
action.

Test: Added AccessibilityBridgeTest.PerformUnsupportedAction
Bug: fuchsia:16501
Bug: 973095
Change-Id: I32fc33b439ae7cca951c21fcf6d875a07c8fa76c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144343Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758338}

These tests were erroneously running only on CrOS, even though
chrome://view-cert WebUI is available everywhere where
USE_NSS_CERTS is true.

Bug: None
Change-Id: I11568120a2173ba704b2efb04fec99604f632ab2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145869
Commit-Queue: dpapad <dpapad@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758337}

In any screen rotation other than 0, the two-finger gesture scrolls
to move the focus region of the fullscreen magnifier are broken; i.e.
scrolling horizontally would move the focus region vertically or vice
versa, and also the scroll directions are not consistent (in some
rotations user needs to move fingers in the same direction where the
focus region is desired to move, and in other rotations in the opposite
direction.

This CL fixes these issues.

BUG=867537
TEST=Manually by enabling the fullscreen magnifier, rotating the
     screen in various orientations, and performing 2-finger scrolls.
     New test was added.

Change-Id: I17bd9dfe79d1c042f12fafdac11ede70e7b4697f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143115
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758336}

This is the first step of local blacklist clean up on Java side.
The interface init(observer, enableLocalBlacklists) will be removed
eventually.

Add its default implementation in this CL, so when the upstream
implementation is removed, the build won't break.

Bug: 1054179
Change-Id: I72f9b183f3090172ac96898107a67bb08e51ad29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143113
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Auto-Submit: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758335}

Prior to this CL, when a slot with imperatively assigned nodes is
removed from its shadow root, assignment recalc is deferred until
an API (Slot.assignedNodes, Node.assignedSlot) or a LifeCycleUpdate
triggers the recalc. If no assignment recalc is triggered and the
slot is added back to its original shadow root, its imperatively
assigned nodes will reappear. This is an unwanted side effect
because if an assignment recalc is trigger before slot is added back,
its assigned nodes will be cleared.

This CL fixes this side effect by clearing a slot's imperatively
assigned nodes whenever it's removed from its parent node. Thus,
regardless of whether a recalc is trigger before the slot is added back
or not, the end result is that the slot's assigned nodes are empty.

Note: With this CL, even moving the slot inside it's shadow root will
clear out its imperatively assigned nodes. See example:
   host
       ---sr
           --s1
           --s2
       --c1

s2.assign([c1]);
sr.insertBefore(s2, s1);
assert_array_equals(s2.assignedNodes(), []);

I believe this is correct behavior. The output should be the same as
removed = sr.removeChild(s2)
sr.appendChild(removed);

Bug: 869308
Change-Id: Ie1247684b77d5c4b8e5f113421807c0c187224f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135371Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758334}

Calling preventDefault for touchstart is going to suppress the click
event that actually updates the color format.

The fix here is to simply avoid handling the touchstart event since the
default behavior is doing what we want.

Bug: 1068066, 1069818
Change-Id: I9990d2001a2de8978019053b4615f7bbf2676372
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144460
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758333}

https://chromium.googlesource.com/openscreen.git/+log/c2dcb3eec9ad..07e64e6eeffc

git log c2dcb3eec9ad..07e64e6eeffc --date=short --first-parent --format='%ad %ae %s'
2020-04-10 btolsch@chromium.org Fix mac loopback checking

Created with:
  gclient setdep -r src/third_party/openscreen/src@07e64e6eeffc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: I8a9d29e66915e0eb62f7c75d4936dd78491ffda6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145917Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758332}

Bug: internal b/151166224
Test: cast video on Smart Display
Change-Id: I50fafbac4dab0c01b9679c3eb5e25074a00cdc46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145870
Commit-Queue: Sandeep Vijayasekar <sandv@google.com>
Auto-Submit: Sandeep Vijayasekar <sandv@google.com>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758331}

We want to remove the single argument version of the method, rather than
have consumers assemble a header in the form of "foo: bar" by joining
two strings.

Having AddHeaders itself do this in only one place is safer and allows
it to validate the key and value arguments are reasonable. Also,
the single argument overload places limitations on the implementation of
AddHeaders works, unless we want to have AddHeaders potentially parse
the single string (that many consumers just merged from two separate
strings) into a name/value pair, so ideally we can just remove it, once
consumers are all converted to use the two-argument overload.

Bug: 1068194
Change-Id: Ida6ec5cf190a397d9f0f896da0d6f876580bf761
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144821Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758330}

This tester runs three kinds of tests:
* chromium_mac_gtests, which are completely swarmed
* chromium_mac_rel_isolated_scripts, which are also swarmed
* chromium_mac_scripts, which are identical to chromium_linux_scripts,
  and which run on linux just fine

This means that the OS of the Mac10.15 Tests builder shouldn't
matter, all that matters is the OS of the hosts running its
triggered swarming tasks, which this CL doesn't change.

Assuming this goes well, I will also convert the other Mac testers
(10.10, 10.11, 10.12, 10.13, and 10.14, all on the main waterfall)
to also use Linux hosts. This will both free up some mac capacity
to use for compilers and testers, and make these builders
"builderless" which should help with capacity and scheduling.

Bug: 1061582
Change-Id: I307db015865288136e7fec0921942e051547be90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146053
Commit-Queue: Aaron Gable <agable@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Auto-Submit: Aaron Gable <agable@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758329}