- 07 Feb, 2020 40 commits
-
-
Jay Harris authored
Previously, file handlers were registered once, when the app was installed. This makes it possible to update registrations, which is a requirement for the origin trial. Bug: 1028448 Change-Id: Id1e05f6efdc69da601573349de6ab6932a7901c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032700 Auto-Submit: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#739249}
-
Chris Lu authored
This reverts commit ac791f4c. Reason for revert: Compile build fails. Original change's description: > [ios] Update Firebase library to 6.16 > > This brings in the new library files as a CIPD package and update > DEPS to refer to this updated library. > > Fixed: 1049042 > Change-Id: I874f1a148bd7c47a4756d25f5edb590a39709b0d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042215 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739162} TBR=eugenebut@chromium.org,pkl@chromium.org,thegreenfrog@chromium.org Change-Id: I225f141037073ac8d7926bd2c96825b94b74a0da No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043081Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#739248}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6c6827cbf27d..73c76703bee6 git log 6c6827cbf27d..73c76703bee6 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 ehmaldonado@google.com git-cl: Don't use assertRegexpMatches on tests. Created with: gclient setdep -r src/third_party/depot_tools@73c76703bee6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I3512bcf721de2a061a15c13a479fda45af0ae77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043055Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739247}
-
shrekshao authored
Add new expectations for Android Nvidia devices Bug: 1013369, 1049733 Change-Id: I9162775442db52e0c3187b68b4670bfc743232b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042754 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#739246}
-
Eric Willigers authored
Various shortcut tests are extracted from hosted_app_browsertest.cc They now also run with BMO, i.e. with no dependencies on Extensions. Bug: 1026080 Change-Id: I6438bcbf38028b700b5f451dd4d781cedaf96d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040593 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#739245}
-
Kenichi Ishibashi authored
This enum is going to be used as status code of operations performed by the Storage Service. Convert it to a mojo enum so that we can define mojo interfaces for service worker storage. Bug: 1046335 Change-Id: Ie4cf45a5dc119cc6b9e454d31e680dce32084986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040790Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#739244}
-
Nicholas Verne authored
We restart vm when upgrading, if it wasn't running already. CrostiniRestarter now calls the final callback with RESTART_ABORTED when aborting. Call sites and test expectations have been changed to match this new behavior. Bug: 1024693 Change-Id: I9a24577eb6a8514e9eb8a8941f5c59d114ee673b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040501Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#739243}
-
Christopher Cameron authored
This applies to viz::OutputSurface::Reshape and viz::SkiaOutputDevice::Reshape, their many many many sub-classes, and to viz::BufferQueue::Reshape. This value is still effectively treated as a bool -- we convert from a bool to this value in viz::DirectRenderer::DrawFrame by selecting either RGBA_8888 or RGBX_8888, and we convert from this back to a bool by the new gfx::AlphaBitsForBufferFormat. The next steps for this include - Make viz::BufferQueue::Reshape use the format value from Reshape, and remove the initialization parameter - Plumb format to through glResizeCHROMIUM to gl::GLSurface, where it can be used by gl::DirectCompositionChildSurfaceWin. Bug: 1049334 Change-Id: I3f1d1402cac76bb7b399c247a84d2fe2b1cd6b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040446 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739242}
-
tby authored
This re-enables the launcher collection that we disabled while moving from the hashed logging prototype to the structured metrics framework. All logging is the same, with one exception: we previously had two metrics aimed at recording which provider a search result comes from, with each determining about half of the providers. I've simplified this by combining them into one metric, which records the value of RankingItemType, the enum we use for type identification for all on-device models. To do this I've cleaned up the RankingItemType enum, removing item types that we no longer use and adding a "don't change this" header. Bug: 1016655 Change-Id: Id04156a4818f842af6489aea23d4048d7aeb4824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038292Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#739241}
-
Omer Katz authored
This is a followup to CL 2012030: https://chromium-review.googlesource.com/c/chromium/src/+/2012961 Loading whole keys atomically resulted in data races involving the fields prev_ and next_ (which were not accessed concurrently before). This CL takes the same approach as was used for ListHashSetNode (https://chromium-review.googlesource.com/c/chromium/src/+/1984308) and wraps prev_ and next_ with atomic writes. This CL already includes the optimizations added to ListHashSetNode in https://chromium-review.googlesource.com/c/chromium/src/+/1995175. Bug: 986235 Change-Id: I4ef881ce181af25e53ccb51169b199c3315c7132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012345Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#739240}
-
Omer Katz authored
This is part of an ongoing effort to simplify heap collections and limit the types they can support (specifically, this CL removes the only existing non-member usage of HeapHashSet). Bug: 1047147 Change-Id: I2d408a5bbace633002c354c17b13d892e1938dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025427Reviewed-by:
-
Steven Bennetts authored
Bug: 1047812 Change-Id: I68513f609e42db54fa0d76c7a127970f4b123e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042316 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#739238}
-
Robert Liao authored
The IncreasedContrastThemeSupplier previously had these colors: Frame Tab Bkgnd Contrast Color Text Ratio Light Mode Inactive Gray Black 5.92 Light Mode Active Dark Gray Black 2.15 Dark Mode Inactive Gray White 3.54 Dark Mode Active Dark Gray White 9.73 This doesn't really make sense as the frame color doesn't change with light/dark mode. Previously, this worked accidentally as BlendForMinContrast would save us. After http://crrev.com/687315 , the IncreasedContrastThemeSupplier was no longer blended, revealing the bug. Since the frame color is invariant with respect to light/dark mode, the new colors are as follows: Frame Tab Bkgnd Contrast Color Text Ratio Light Mode Inactive Gray Black 5.92 Light Mode Active Dark Gray White 9.73 Dark Mode Inactive Gray Black 5.92 Dark Mode Active Dark Gray White 9.73 BUG=1046818 Change-Id: Ic9452154f833f471a51e2ea6eacfb49f10cf1232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042144Reviewed-by:Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#739237}
-
Jiewei Qian authored
This CL is a preparation to use SystemWebAppManager in WebAppTabHelper. Bug: 1024655 Change-Id: Id2a4e71e852696bfbf8386ffdd221d523ab55161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040755 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
David Tseng authored
Change-Id: I39b0b7e4ec10430f2162390db923cd58b909f0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042034Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#739235}
-
Alexandre Courbot authored
A request timing out indicates a serious issue ; this should be logged at level 1, not 3. BUG=None TEST=VDtest builds and runs. Change-Id: I5742a0f8e8de93852e30ae049b54148f16ac7d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041710 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#739234}
-
Hiroki Sato authored
Currently, if Android app starts before ChromeVox or S2S starts, ARC AXTrees are not recognized from these ATs. This is because: - AXChildTreeID is not attached to the parent surface at that moment. - ARC AXTrees are not triggered to update on automationInternal.enableFrame. This CL fixes these issues. Android side change is http://ag/10167029. Bug: b:129681889 Test: manual. Open any Android app, then enable ChromeVox. Confirm that Android app gets focus. Change-Id: I38cb372f706817f5e305c4a10a1ac84176275397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018624Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#739233}
-
Xianzhu Wang authored
This reverts commit be47c44f. Reason for revert: The reland was an accident. Forgot to uncheck automatically send revert change to CQ. Original change's description: > Reland "Ensure cc::Layer's NeedsPushProperties when blink directly sets scroll offset" > > This reverts commit 5db928ee. > > The original issue was caused by additional scroll tree scroll offset > entries. DirectSetScrollOffset should not create new entries, but just > change existing entries, otherwise after a document lifecycle update, > the scroll tree may contain entries whose element ids don't correspond > any scroll node. > > Original change's description: > > Revert "Ensure cc::Layer's NeedsPushProperties when blink directly sets scroll offset" > > > > This reverts commit 617a9c19. > > > > Reason for revert: Broke some browser tests. The tests flakily crash when pushing scroll properties at impl-side. > > > > Original change's description: > > > Ensure cc::Layer's NeedsPushProperties when blink directly sets scroll offset > > > > > > When blink directly sets scroll offset in the scroll tree, we need to > > > set the associated cc::Layer's NeedsPushProperties to ensure update of > > > cc::LayerImpl's scroll related properties > > > (see cc::LayerImpl::UpdateScrollable()). > > > > > > This reverts the change about cc::LayerTreeHost::LayerByElementId() in > > > https://chromium-review.googlesource.com/c/chromium/src/+/2020554 > > > because we still need it in layer list mode. > > > > > > Bug: 1048113 > > > Change-Id: I686beebcf54e96cc517700c0f987aaceec880c58 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036834 > > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#739043} > > > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > > > Change-Id: Ib52291c52f8bac3f4a3c9fe0248f55d0162c556c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1048113 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042763 > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#739183} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > Change-Id: Ie72b629bbdb20b0ed4c33746c33828f4d596a884 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1048113 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043056 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739220} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: I23bf77e95117f2599086bef6ec4113f0fd442cd9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043090Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739232}
-
Huanzhong Huang authored
Remove NewClearBrowsingDataUI experiment, as it has become the default. Bug: 947456 Change-Id: I41f1b2eb5824d18f77bea3447b7b79bfb1469eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039410Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#739231}
-
Wei-Yin Chen (陳威尹) authored
Show a chip on the tab card if that tab has search result page in its navigation stack. The chip contains the search term. When clicked, the tab would visit the search result page again. This is behind a Finch parameter "enable_search_term_chip" under TabGridLayoutAndroid. The CL is split into two, and this is part two, which can be verified to be behind the flag isSearchTermChipEnabled() by the Formal Equivalence Checker in http://crrev.com/c/1934235/4. See also: part one (http://crrev.com/c/2038458). Bug: 1048255 Change-Id: I03d61d97a99964168ebcd758b772231185d9223f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036513Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#739230}
-
Yuichiro Hanada authored
This CL changes RewriteTouchEvent and RewriteScrollEvent to use the new API. These two methods seems to be the easiest to rewrite. Bug: 1049489 Test: unit_tests Change-Id: Ic133c9c829883728b4a65d04e0470c36f891c203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041131 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
-
Benjamin Beaudry authored
An accessible node that represents generated content (e.g., the ::before selector) is completely ignored in AXNodePosition::MaxTextOffset and AXNodePosition::GetText. Both methods return the ax::mojom::StringAttribute::kValue's length and value, respectively. Since this attribute's value doesn't include the value of the generated content (because this generated content is either before or after the main content of the text field), we return a wrong maximum text offset and text. To fix this, we should only use ax::mojom::StringAttribute::kValue's length and value when the node has no child. When a node has a child, we need to compute the maximum text offset by summing the maximum text offset values of all of its children. The same applies for AXNodePosition::GetText. Bug: 928948 Change-Id: I624779a3e372d19ac2036de09fe9dbf1c4892867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037965 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#739228}
-
David Van Cleve authored
This reverts commit 7f4af748. Reason for revert: Perf bot identified a memory regression; reverting while I investigate locally. Original change's description: > Add a testing config for ReducedReferrerGranularity > > We're going to 50% beta on this feature (changing the > default referrer policy to strict-origin-when-cross-origin) > so it's time to add a field trial testing config. > > Also updates the following tests, which were failing with > the testing config enabled: > - ContextMenuBrowserTest.OpenInNewTabReferrer > - DownloadReferrerPolicyTest.DownloadCrossDomainReferrerPolicy > > > Bug: 1014207 > > Change-Id: Ic50657d9c2f642af8538fea47fe2263797d45018 > Cq-Do-Not-Cancel-Tryjobs: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012087 > Commit-Queue: David Van Cleve <davidvc@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737362} Bug: 1014207 Bug: 1048550 Change-Id: I4eeb5ddb45ca6685d632d2f51268455b87346779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036795Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4db6affff29a..22f2b82b60a3 Created with: gclient setdep -r src-internal@22f2b82b60a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1024588,chromium:1041701 Tbr: jbudorick@google.com Change-Id: I7a5c65bd4a907f118ce4aa344c45b5b8566ccad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042668Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739226}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9ffef5dc43cec87e71e8cce46fe572a290aae66e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043050Reviewed-by:
-
Anand K. Mistry authored
Bug: 648275 Change-Id: I3d933396788139cefebb5ea337c5a478498e483a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512982 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Anand Mistry <amistry@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#739224}
-
Su Hong Koo authored
Move DisplayManager::GetSecondaryDisplay() to DisplayManagerTestApi as it is now only used in unit tests. Update all affected unit tests to use DisplayManagerTestApi. Bug: 867966 Change-Id: I26fe6ef2d7f4ef8406c90b5f8ebd0c150f7bb09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032671 Commit-Queue: Su Hong Koo <sukoo@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
This CL migrates the legacy InitiateCaptureDump IPC message to the new Mojo defined in WebTestClient interface. Bug: 1039247 Change-Id: Idd38ecf67d10593f3bfc6f3c48d9832514cec595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032634 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#739222}
-
Isabella Scalzi authored
In preparation for adding a delete button to the Quick View toolbar add property |canDelete| to |files-quick-view|, which indicates whether the file shown can be deleted or not. In a future CL, |shouldShowDeleteButton_| will then toggle the display of the delete button in Quick View. Test: Tests coming in future CL. Bug: 803259 Change-Id: I880fd7f2065c11435a16ec923abca12277b0c824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040502 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#739221}
-
Xianzhu Wang authored
This reverts commit 5db928ee. The original issue was caused by additional scroll tree scroll offset entries. DirectSetScrollOffset should not create new entries, but just change existing entries, otherwise after a document lifecycle update, the scroll tree may contain entries whose element ids don't correspond any scroll node. Original change's description: > Revert "Ensure cc::Layer's NeedsPushProperties when blink directly sets scroll offset" > > This reverts commit 617a9c19. > > Reason for revert: Broke some browser tests. The tests flakily crash when pushing scroll properties at impl-side. > > Original change's description: > > Ensure cc::Layer's NeedsPushProperties when blink directly sets scroll offset > > > > When blink directly sets scroll offset in the scroll tree, we need to > > set the associated cc::Layer's NeedsPushProperties to ensure update of > > cc::LayerImpl's scroll related properties > > (see cc::LayerImpl::UpdateScrollable()). > > > > This reverts the change about cc::LayerTreeHost::LayerByElementId() in > > https://chromium-review.googlesource.com/c/chromium/src/+/2020554 > > because we still need it in layer list mode. > > > > Bug: 1048113 > > Change-Id: I686beebcf54e96cc517700c0f987aaceec880c58 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036834 > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#739043} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > Change-Id: Ib52291c52f8bac3f4a3c9fe0248f55d0162c556c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1048113 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042763 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739183} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: Ie72b629bbdb20b0ed4c33746c33828f4d596a884 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043056Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7476ab6e9eff..8052d2973b2a git log 7476ab6e9eff..8052d2973b2a --date=short --first-parent --format='%ad %ae %s' 2020-02-06 bsheedy@chromium.org [Telemetry] Remove GetStackTrace Created with: gclient setdep -r src/third_party/catapult@8052d2973b2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1008075 Tbr: sadrul@google.com Change-Id: I909d1b995a0a6588377637360903cd0a7aeb9a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042662Reviewed-by:
-
Wan-Teh Chang authored
Also print the hash padded with leading 0's to 8 hex digits. Bug: 1026522 Change-Id: I2f8f8db71619839beccd8723461f0842ea960240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042195Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#739218}
-
Maggie Cai authored
Click to call dialogs needs to be closed if the tab navigates to a different origin. In ChromeOS, click to call uses the same dialog as intent picker. Intent picker dialog will show when tab navigates to a different origin and there are Android apps that can handle this origin. The click to call dialog closes cause the dialog to automatically closed after briefly show up. This CL change the code to only close the dialog for click to call. This CL also fix a issue the intent picker icon don't show up for auto dialog pop up. BUG=1045036 Bug: b/146227259 Change-Id: Iadb1db30c7e24108bee933eb93d57d73a206d3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035821Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#739217}
-
Daniel Rubery authored
SafeBrowsingURLRequestContextGetter doesn't exist anymore, so remove the friend class declaration. Bug: 678653 Change-Id: If8e5105ff5e8178f3402372c4df43138e30c1a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041887 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739216}
-
Wan-Teh Chang authored
Also fix a spelling error: unitialized => uninitialized. Bug: N/A Change-Id: Ie61e8be22499660642ae7ab884c32b78b4e9763a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042323Reviewed-by:
-
Pavel Feldman authored
Passing this parameter will desotry all the contexts created by the session upon session disconnect. Change-Id: I6608ef672b41b922308bf71921a074faa037ae7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042279 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#739214}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/816c2b3548fb..6c6827cbf27d git log 816c2b3548fb..6c6827cbf27d --date=short --first-parent --format='%ad %ae %s' 2020-02-06 ehmaldonado@google.com git-cl: Simplify FetchDescription and UpdateDescription 2020-02-06 ehmaldonado@google.com git-cl: Remove GetDescriptionFooters and UpdateDescriptionFooters 2020-02-06 ehmaldonado@google.com git-cl: Simplify Change object construction. Created with: gclient setdep -r src/third_party/depot_tools@6c6827cbf27d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042324 Tbr: agable@chromium.org Change-Id: I687d022f4e77369cd25805a9e24aedbbc838123f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042776Reviewed-by:
-
CJ DiMeglio authored
Bug: 982014 Merge-With: eureka-internal/360834 Change-Id: I47b9995892f7141c6f76222a7fe1a437d541792a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040210Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#739212}
-
Jeff Yoon authored
iOS utilizes otool to analyze and distribute test case execution against x number of shards. This logic was run in the recipe, such that the sublist of test cases would be passed into the isolate for execution. Chromium does not support recipe-level sharding. To mitigate, we clone the otool sharding logic into the test runner. Each swarming task (shard) is provided with two keys via env vars: shard index, and total number of shards. A given test on a given run should be broken down identically across each swarming task, because the test bundle does not change and the number of total shards is the same. Because each task also is provided the index, it can select the corresponding index from the sublist and execute that sublist of test cases. There is minimal performance hit, and this logic is only invoked when those env vars are present, which are only set by swaring for shards greater than 1. Change-Id: Id3b4c96cc68ef97b62ed79afc145bbbe55156063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040371Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#739211}
-
Ayu Ishii authored
This failure is caused by the same failure fixed here [1]. Checking the flake portal, seems to be stably passing since the fix [2]. [1] https://crrev.com/c/2040370 [2] http://screen/Gwwn5WLDahZ Bug: 1048766 Change-Id: Ibb58dbd19c62be657c9c1ca1f90423bf7d73a0f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042741 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
-
