- 15 Dec, 2017 40 commits
-
-
Danyao Wang authored
This CL handles two cases: 1) When restore_session.html is first loaded, set virtual URL to the item that will be displayed when session is fully restored. 2) If a restore_session.html is loaded in the webview, set the virtual URL to the encoded URL, as that will be the page that will eventually be displayed. Moved session restore logic into a separate util file so it's easier to test. Bug: 789993 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1547f792f1e3de0bf97d11dced09383b82c507fc Reviewed-on: https://chromium-review.googlesource.com/817713 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#524418}
-
Réda Housni Alaoui authored
Fixes for reland: - "Win8 Tester" browser_tests_functional failure - "Win8 Tester" capture_unittests failure Original description: - Full rewrite of the MediaFoundation implementation video part to use IMFCaptureEngine - Implementation of takePhoto, setPhotoOptions and getPhotoCapabilities - takePhoto triggers a still image capture with the highest available resolution without stopping the video stream thanks to IMFCaptureEngine TEST=adapted video_capture_device_unittest.cc and webrtc_image_capture_browsertest.cc; launch Chrome with --force-mediafoundation on Win8+ and capture video using e.g. https://webrtc.github.io/samples/src/content/getusermedia/gum/ R=mcasas@chromium.org Bug: 730068 Change-Id: I3835a48ca8516fc66a6a8394b3709d4dea862f89 Reviewed-on: https://chromium-review.googlesource.com/734042 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521435} Reviewed-on: https://chromium-review.googlesource.com/810766 Cr-Commit-Position: refs/heads/master@{#524417}
-
Takumi Fujimoto authored
This CL corrects the provider ID attribute name, which was causing data to not get converted to Mojo properly. Bug: Change-Id: I476e17eeb82387090fe6a5f6003fa60d04d40df5 Reviewed-on: https://chromium-review.googlesource.com/828288Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#524416}
-
Marc Treib authored
This works around a race condition between loading the page and the IPC message that contains the MV items. Before this CL, if the page load won the race, then it would assume there are no tiles and load incorrect metrics. This CL exposes "did we ever receive MV tiles" to the page, so it can delay loading them while they're not available anyway. This is very much working around the symptoms rather than fixing the root cause. Unfortunately I have no idea how to really fix the issue. Bug: 794942, 793818 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I091b71d17d36e28b3f53ceebef6829ef23d82b3b Reviewed-on: https://chromium-review.googlesource.com/829254Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#524415}
-
Alexander Timin authored
R=skyostil@chromium.org BUG=789901 Change-Id: I39e845e80772571c9bac3c0d5f53fb04c3c53be5 Reviewed-on: https://chromium-review.googlesource.com/823031 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#524414}
-
Greg Kerr authored
This hardens the macOS sandbox by specifying an explicit vnode type for all writeable files, reducing the risk that an attacker can symlink a file Chrome has write access to, and modify the filesystem at will. Bug: 793402 Change-Id: I53bbcc84345e432756eff0d2dc18a505719fd521 Reviewed-on: https://chromium-review.googlesource.com/829877Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#524413}
-
Bin Zhao authored
Recent changes removed dial_device_description_parser_impl* from chrome/utility/media_router and introduces a new SafeXmlParser. (https://chromium-review.googlesource.com/c/chromium/src/+/770920) Abandoned previous DialAppInfoParser patch (https://chromium-review.googlesource.com/c/chromium/src/+/745538), resolved most comments in the new patch and added a SafeDialAppInfoParser class which uses SafeXmlParser. Bug: 779892 Change-Id: I1c0d141381e1a8c992888476e8643385a96db06f Reviewed-on: https://chromium-review.googlesource.com/826126Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524412}
-
Eric Karl authored
This reverts commit a71b54d8. Reason for revert: Breaking the Linux Debug NVidia bot. See crbug.com/795332 for more details. Original change's description: > [cfi-icall] Refactor GL g_driver_* to be CFI-safe > > Control Flow Integrity [1] indirect call (cfi-icall) checking can not > verify that dynamically resolved function pointers call their intended > function. To account for this, we place the function pointers in the > various g_driver_* structs in ProtectedMemory, a wrapper for keeping > variables in read-only memory except for when they are initialized. > Once they are set they can not be tampered with since the memory is set > back to read-only. > > The generated bindings in gl_bindings_autogen_*.cc are not aware of the > fact that their implementation is held in protected memory, so instead > of using base::UnsanitizedCfiCall() we mark the individual function > stubs with __attribute__((no_sanitize("cfi-icall"))) to disable icall > checks on the generated bindings since their function pointer calls > are routed through protected memory. > > [1] https://www.chromium.org/developers/testing/control-flow-integrity > > Bug: 771365 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I6bbf1b9a4122e1d00f6d2a365ae3730b4bb95a73 > Reviewed-on: https://chromium-review.googlesource.com/770252 > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524318} TBR=dcheng@chromium.org,dalecurtis@chromium.org,kbr@chromium.org,sandersd@chromium.org,pcc@chromium.org,vtsyrklevich@chromium.org Change-Id: Ib4a1eae5e9f01f5e9ddbb1fcc5c66fc0b91f1015 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 771365, 795332 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/830173Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#524411}
-
Robert Sesek authored
https://chromium.googlesource.com/breakpad/breakpad.git/+log/a61afe7a3e86..c283630201ac $ git log a61afe7a3..c28363020 --date=short --no-merges --format='%ad %ae %s' 2017-12-15 rsesek Reconcile -[BreakpadController withBreakpadRef:] with its documentation. 2017-12-11 wittman Update binaries with dump_syms changes to write new field 2017-12-11 wittman Write field indicating multiple symbols at an address in dump_syms 2017-12-05 adamharrison Remove duplicate import. Created with: roll-dep src/third_party/breakpad/breakpad Change-Id: I75b9d3a240b9818e2f527a591c6be2a61974088c Reviewed-on: https://chromium-review.googlesource.com/829674Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#524410}
-
Dirk Pranke authored
R=jbudorick@chromium.org Change-Id: I480364ec2aa241cdfc9b0f016cdb008f5226ecac Reviewed-on: https://chromium-review.googlesource.com/821558 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#524409}
-
Anna Maria authored
Renaming WebVR 2 code to WebXR as per community group desision. Bug: 670510 Change-Id: Ia85cfe584afa3e21d4634414748e11f3c9b9bfc3 Reviewed-on: https://chromium-review.googlesource.com/823424Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#524408}
-
Xiaocheng Hu authored
This patch changes the layout test runner to treat LayoutNG name mismatch (e.g., LayoutBlockFlow vs. LayoutNGBlockFlow) as PASS instead of TEXT failure, to reduce noise in test result. Bug: 795043 Change-Id: Ia0a358f7ccf47cc809fff6b20eea1847d4754413 Reviewed-on: https://chromium-review.googlesource.com/828276Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#524407}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a49f2ad6..eaa72a5e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I247bec30d451790ee7a95c3de3f8b41921d26694 Reviewed-on: https://chromium-review.googlesource.com/829673Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#524406}
-
Jonathan Metzman authored
Bug: Change-Id: I8f9d5efa70f298fe523fc3caf1d4b1baacd8ebae Reviewed-on: https://chromium-review.googlesource.com/828714Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#524405}
-
Matthew Cary authored
This script used the old python WPR wrapper, which has disappared in favor of a Go-based server which may or may not be publically supported (see crbug.com/795229). For the time being, it seems expedient to just tear out WPR, and hence traffic-shaping, support in the script. Change-Id: Ia001929a110b580fb35ae0cc2b8f8d7c80154caf Reviewed-on: https://chromium-review.googlesource.com/829034Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#524404}
-
rnephew authored
TBR: bustamante@chromium.org Bug: 781409 Change-Id: Ie2c3eda81add06d897369933588363ebc293c4e7 Reviewed-on: https://chromium-review.googlesource.com/823178 Commit-Queue: rnephew <rnephew@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#524403}
-
Jonathan authored
After landing viz_browser_test on the Windows FYI bot even more failures have turned up. I'm disabling them until we triage/fix them. TEST=viz_browser_test TBR=kylechar@chromium.org Bug: 794961 Change-Id: I0d80fe1404174e1b94260389877a5c1d6d19333f Reviewed-on: https://chromium-review.googlesource.com/829616Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#524402}
-
Yves Arrouye authored
The servers are picked using the same command line switch that we use to pick PCAs. BUG=b:69687094 TEST=None Change-Id: Ia1c79fda63e2d3d07b44da1ce814974d56d6726d Reviewed-on: https://chromium-review.googlesource.com/795187 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Darren Krahn <dkrahn@chromium.org> Cr-Commit-Position: refs/heads/master@{#524401}
-
Ian Vollick authored
This CL adds a drop shadow behind the omnibox suggestions (which needed a bit of a topological change), adds spacers above and below the suggestions, and adds and binds corner radii. Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If9dc8939896de59708aeedc566a564850fcf3639 Reviewed-on: https://chromium-review.googlesource.com/828391 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#524400}
-
Reilly Grant authored
r524372 renamed a number of tests from WorkerFetchTest.* to WorkerTest.* and removed parameterization for the OffMainThreadFetch feature. This change updates the filters for network_content_browsertests to match. Bug: 794089 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia7b44629161a71d66787477c6077cb26712ecb19 No-Try: true No-Presubmit: true Tbr: jam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/829974Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#524399}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/2b4bc3c31636..67a86d50f38d $ git log 2b4bc3c31..67a86d50f --date=short --no-merges --format='%ad %ae %s' 2017-12-15 mtklein Try /Z7 on Windows builds. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: Id89dcc64df7dc056dbd9afe48d9380eb672b634f Reviewed-on: https://chromium-review.googlesource.com/829533Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524398}
-
Robert Ma authored
The type of 'cc' field is inconsistent with the API docs. Marshal the field to work around the bug for now. Bug: 765334, monorail:3300 Change-Id: I1b252b649b665e77ff643b34b87ce9587723db0d Reviewed-on: https://chromium-review.googlesource.com/826186Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#524397}
-
Mohamad Ahmadi authored
Bug: 792879 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic86fa2a72adeab804c22a62efa9b291408e5b482 Reviewed-on: https://chromium-review.googlesource.com/827725Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#524396}
-
Sriram authored
Upstream the below tests from media/track/ to wpt 1. track-webvtt-tc021-valign.html 2. track-webvtt-tc022-entities.html 3. track-webvtt-tc023-markup.html 4. track-webvtt-tc024-timestamp.html 5. track-webvtt-tc025-class-markup.html Bug: 782555 Change-Id: Ib5159571de1efee1e4cb9b94fcede977e813aad2 Reviewed-on: https://chromium-review.googlesource.com/826846 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#524395}
-
Tibor Goldschwendt authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibd5db704d11782a5fc4d53f1eef772d3236db497 Reviewed-on: https://chromium-review.googlesource.com/827984 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#524394}
-
Ian Vollick authored
With this CL, we wait for a brief timeout before forwarding suggestions to the UI. If we exceed the maximum number of suggestions, however, there is no point in waiting further and we sent along the suggestions immediately. Bug: None Change-Id: I0230d2a34ee3ee5b4a3cd6bfc5f43b9d7aa8f3ea Reviewed-on: https://chromium-review.googlesource.com/828389 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#524393}
-
Boris Sazonov authored
This CL adds FakeAccountManagerDelegate initialization to NewTabPageAdapterTest.setUp(), as NewTabPageAdapter indirectly uses ProfileDataCache. This CL also adds AccountManagerFacade.isUpdatePending(), which is useful for ensuring that AccountManagerFacade cache was updated in tests. Bug: 792430 Change-Id: I95c83b006b4836562fbdf43fc7f80ffc2ad03c11 Reviewed-on: https://chromium-review.googlesource.com/825062 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#524392}
-
Johann authored
third_party/libaom uses a BSD 2 clause license: This source code is subject to the terms of the BSD 2 Clause License R=thestig@chromium.org Change-Id: I7b1dda5d5c485353b8024386541b853d12f0299c Reviewed-on: https://chromium-review.googlesource.com/827543Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#524391}
-
Julia Tuttle authored
Right now, the ReportingUploader cancels requests once the headers are received, which causes the requests to fail with ERR_ABORTED, which triggers a NEL report. This CL breaks that loop by attaching user data to upload requests and ignoring ERR_ABORTED errors stemming from them. TBR=mkwst@chromium.org Bug: 793392 Change-Id: Id26516533ec0e7531797717526b015c56a742c1b Reviewed-on: https://chromium-review.googlesource.com/817553 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#524390}
-
Tom Anderson authored
This CL switches Linux to use in-tree fontconfig builds. It exposes some leaks and races detected by LSAN and TSAN. For now, these will be suppressed since these issues were preexisting, but instrumenting fontconfig exposed the issues. R=dnicoara@chromium.org,dpranke@chromium.org BUG=795110,795148 Change-Id: Ia75db4ced6ec78a5f0610af9ebc78a87840b86f7 Reviewed-on: https://chromium-review.googlesource.com/826403 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#524389}
-
Charles Harrison authored
Bug: 792524 Change-Id: I3c05b7c3f4c979ff795aa41cd97393e8b562df3d Reviewed-on: https://chromium-review.googlesource.com/820790 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#524388}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7f26ff95..a49f2ad6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I093fc7c2fbafa25dfa0005f4bb7f87bb85a625af Reviewed-on: https://chromium-review.googlesource.com/829213Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#524387}
-
Nicolas Dossou-gbete authored
Simple cleanup change. Replaces some uses of @CommandLineFlags with @ChromeHome and @EnableFeatures, and removes unused code from @ChromeHome. Bug: 783160 Change-Id: I508ea74b923360fde65eb2e247c727aab825f8a9 Reviewed-on: https://chromium-review.googlesource.com/788214Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#524386}
-
Fredrik Söderquist authored
'x' and 'y' were turned into presentation attributes in https://codereview.chromium.org/896773002 (r190180), but the property values were not actually applied. Apply the property values from ComputedStyle, cleaning up the surrounding code a bit in the process by moving the "is a <use> element" check into a method. Also fix the FIXME in SVGUseElement::ToClipPath by using the computed transform from the LayoutObject, rather than "manually" recomputing it. This code-path should already require a LayoutObject for the element in question. Bug: 400725, 697052 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iff261e468c4476cfb98efbadd6989ada027e47ab Reviewed-on: https://chromium-review.googlesource.com/829314Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#524385}
-
Adithya Srinivasan authored
While some input types (like checkboxes) don't need a shadow subtree for their implementation, they do need a shadow root to hide any children that may be appended by script. This CL makes input elements lazily create a shadow root when children are appended. Bug: 794484 Change-Id: I4dfeecd33b7ff39c9cfe94192b3f9ac8aa5a779d Reviewed-on: https://chromium-review.googlesource.com/826426Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#524384}
-
Elly Fong-Jones authored
Otherwise, the page info bubble hides when an iframe on the page navigates, which happens dozens of times on some JS-heavy pages, or when the page navigates itself using a meta-refresh or similar. Bug: 788301 Change-Id: I10e4676bc3e0b4c688e5e435d243799a831c5bc3 Reviewed-on: https://chromium-review.googlesource.com/793230Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#524383}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/9eedea7c5075..2b4bc3c31636 $ git log 9eedea7c5..2b4bc3c31 --date=short --no-merges --format='%ad %ae %s' 2017-12-15 mtklein Don't set /GS- on Windows builds. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I257f7d418cf05da9cf7e65f5f665253878db400f Reviewed-on: https://chromium-review.googlesource.com/829454Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524382}
-
Olivier Robin authored
onFormDataFilled can have some non trivial behavior particularly when there are multiple fields with the same name. Bug: None Change-Id: I89e5eacf658cf7c82b0c6dd01725f497b1c856e1 Reviewed-on: https://chromium-review.googlesource.com/822073 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#524381}
-
Yash Malik authored
Before this CL, we would hide the keyboard before releasing the button, which is incorrect behavior. This CL also makes the background unfocusable so clicking on it doesn't steal focus from text fields and hide the keyboard. Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0a74c7f3d036e8bff6fc4daa2ce6b47f33f2a2e3 Reviewed-on: https://chromium-review.googlesource.com/828120Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#524380}
-
Chris Nardi authored
When computing the RGBA channels for HSL/HSLA values, we currently multiply by 256 and truncate the value. However, this can cause miscalulations for alpha values, and can cause each channel to be nearly 1 unit away from what was intended. This changes the behavior to multiply by 255 and round, having the same behavior as Edge and Firefox. Bug: 786139 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iad92dc6f7b110e250c7cf9987832c94eec4c930e Reviewed-on: https://chromium-review.googlesource.com/818629 Commit-Queue: Chris Nardi <hichris123@gmail.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#524379}
-