- 25 Apr, 2018 40 commits
-
-
Hiroki Nakagawa authored
This is just a cleanup and doesn't change behavior. Bug: 825740 Change-Id: I36c4002ca29bd3ad5af1a8f63ef2b33e6b977981 Reviewed-on: https://chromium-review.googlesource.com/1027370Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#553485}
-
Tatsuhisa Yamaguchi authored
This is preparation for fixing Issue 834675, where we will be changing execution paths for these procedures based on input file locations. Test: manually tested by zipping files on My Drive Bug: 834675 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iac3637d46760066b18c36e799448af5d7f6cd705 Reviewed-on: https://chromium-review.googlesource.com/1027332 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#553484}
-
Matt Falkenhagen authored
We were only doing this check at registration time previously, which is sketchy since the browser or content settings could change in the meantime after registration. Actually the motivating example was if you register an extension service worker once and then run Chrome with --disable-extensions and then try to start the worker via chrome://serviceworker-internals. It turns out the checks for JavaScript and cookies in ChromeContentBrowserClient::AllowServiceWorker were disallowing start worker in that case, but it seems fragile to rely on those. Change-Id: Iea3706ccf08ec72ed9e2306b01a6ddfd0fa3b9eb Reviewed-on: https://chromium-review.googlesource.com/1027171Reviewed-by:
-
Yuzu Saijo authored
Now that Document leak bug (crbug.com/734427) is fixed, leak detector must no more skip any tests. This CL updates the expectation file. Change-Id: Ieaa29267952d259c1a7911f566a25257b7f29a63 Reviewed-on: https://chromium-review.googlesource.com/1025537 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#553482}
-
Bill Orr authored
This reverts commit 0ad90c2f. Reason for revert: Found the issue with the broken tests. Original change's description: > Revert "WebXR: Do not provide poses to frames without focus" > > This reverts commit 666960b1. > > Reason for revert: Causing a test bug. Reverting while I investigate that bug (crbug.com/835047). > > > > Original change's description: > > WebXR: Do not provide poses to frames without focus > > > > This change plumbs through focus (both blink/frame and device) to XRSessions, so we > > only call raf callbacks when focused. > > > > BUG=813230 > > > > Change-Id: I0aefdce989f6dd60b4cd0acf1a1477fdb2e845b8 > > Reviewed-on: https://chromium-review.googlesource.com/1011288 > > Reviewed-by: Brandon Jones <bajones@chromium.org> > > Reviewed-by: David Dorwin <ddorwin@chromium.org> > > Commit-Queue: Bill Orr <billorr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#551842} > > TBR=ddorwin@chromium.org,bajones@chromium.org,billorr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 813230 > Change-Id: I5c1e1dcb9aaef3fe46c085d6572cea81673e4789 > Reviewed-on: https://chromium-review.googlesource.com/1020800 > Commit-Queue: Bill Orr <billorr@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552268} Change-Id: I065ccb0972a33e553aa73140bd649a939a6547f8 Bug: 813230 Reviewed-on: https://chromium-review.googlesource.com/1022560Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#553481}
-
Yutaka Hirano authored
We don't need it for keepalive requests any more, and DetachableResourceHandler ignores cancel requests from renderer, which is bad. Change-Id: Iada35d44e2290760ed7b293cdd3dd7280e69edea Bug: 836641 Reviewed-on: https://chromium-review.googlesource.com/1026333Reviewed-by:
-
Xianzhu Wang authored
It's unfortunate that composited animation with subpixels is incompatible with pixel snapping. We have to accept some imperfection of pixel snapping to achieve high performance composited animation with subpixels, otherwise each step of the animation might cause full layer raster invalidation. SPv175 lost the imperfect optimization and this CL brings it back by - excluding the subpixel accumulation of the composited layer from the visual rects of composted layer contents, if there is no non- translation transform between the composited layer and the object. - adding the subpixel accumulation back to the final visual rects when generating raster invalidations and convert to cc display item list. Bug: 833083 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie8cfb3712bf7839a60b2a3187fd792b0fa4fe4d2 Reviewed-on: https://chromium-review.googlesource.com/1023606 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#553479}
-
Tsuyoshi Horo authored
SignedExchangeDevToolsProxy lives on the IO thread and sends messages to DevTools via the UI thread to show signed exchange related information. Currently it is used only to send error messages. When Network Service is not enabled, the frame tree node ID is not available while handling prefetch requests on the IO thread. So this CL introduces |frame_tree_node_id_getter| callback. For non-NetworkService prefetch requests, the callback is GetFrameTreeNodeId() in resource_message_filter.cc. For other cases (non-NetworkService navigation requests, NetworkService navigation requests, NetworkService prefetch requests) the callback is the lambda which just returns frame_tree_node_id. Bug: 830505 Change-Id: I22777225b8b678f406fc35dacf963b935236c0ab Reviewed-on: https://chromium-review.googlesource.com/1025492Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#553478}
-
Yutaka Hirano authored
Having a non-zero keep alive refcount prevents the task queue throttling even when the page is in background. This CL avoids that with calling RenderProcessHost::DecrementKeepAliveRefCount eagerly. Bug: 831853 Change-Id: I79562153286aee08d65520de0bf48eb8087db961 Reviewed-on: https://chromium-review.googlesource.com/1023628Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#553477}
-
Kimmo Kinnunen authored
Third parties would construct toolchain packages on their own, with the best of their abilities, based on the instructions provided. They could then accumulate <canonical hash> -> <their own hash> pairs in their environment to support historical builds. Example mapping: set GYP_MSVS_HASH_1180cb75833ea365097e279efb2d5d7a42dee4b0=4181fce548fece344a85cb6898cf996692998531 Bug: 836225 Change-Id: I4a46e51b09049340344c9717481b141a2a7c296b Reviewed-on: https://chromium-review.googlesource.com/1025896Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kimmo Kinnunen FI <kkinnunen@nvidia.com> Cr-Commit-Position: refs/heads/master@{#553476}
-
Matt Falkenhagen authored
r553437 added one for dedicated-inheritance.html, but shared is also flaky: external/wpt/content-security-policy/inside-worker/shared-inheritance.html Bug: 836627 Change-Id: I84be5f95c0b1a2aa267ed76c849bb98f4b4b5dcd TBR: robertma NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1027213 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#553475}
-
Antoine Labour authored
It doesn't use any active unctionality from it. This would let us merge ResourceProvider into DisplayResourceProvider. Bug: 738190 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie08c7c75e8586e239f706cd03ad632b0c4ac1c47 Reviewed-on: https://chromium-review.googlesource.com/1023378 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#553474}
-
Luciano Pacheco authored
ServiceWorkerResponse type doesn't provide move constructor nor assignment, thus when moving to vector it creates a copy, so we need unique_ptr to delete the memory used by its value, otherwise it leaks. Bug: 835611 Change-Id: I1276b5e3935f9759b8d9dd84df3a958b1dd9d25e Reviewed-on: https://chromium-review.googlesource.com/1023731Reviewed-by:
-
Alexandr Ilin authored
Bug: 826213 Change-Id: Ifa1d7e3fd3625ef0161073d594f3f48aada7b7c8 Reviewed-on: https://chromium-review.googlesource.com/1019448Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553472}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/355b11a31f0d..2f2142eff8c0 $ git log 355b11a31..2f2142eff --date=short --no-merges --format='%ad %ae %s' 2018-04-24 tandrii CQ: switch to 100% LUCI builders. Created with: roll-dep src/third_party/depot_tools BUG=chromium:830992 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ica524f17eec27192e7821c9f13652d540f1b8a0e Reviewed-on: https://chromium-review.googlesource.com/1027204Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553471}
-
Daniel Cheng authored
Bug: 706466 Change-Id: I418253ffc3cb314466beb3cad6eb0f36b099f28c Reviewed-on: https://chromium-review.googlesource.com/1027117Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#553470}
-
Hitoshi Yoshida authored
"basename" does not include exntensions, but the function outputs filename including ".h" extension. This CL rename the function and clean up around its use cases. Bug: None Change-Id: Ie04b198f5c8c34e206c5909089104258c88c92ab Reviewed-on: https://chromium-review.googlesource.com/1023070Reviewed-by:
-
Andrey Lushnikov authored
This patch starts displaying color swatches in suggest box next to css variables that compute to color value. For this to be possible, the ColorSwatch and BezierSwatch were moved under the ui/ module. The CSSShadowSwatch stayed in the inline_editor/ for now because it has a dependency on ShadowModel. R=einbinder, dgozman Change-Id: Ic29a13073dc8236d5ef9a2fe35adf6bcd927290b Reviewed-on: https://chromium-review.googlesource.com/1026882 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#553468}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 51459d66. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16234 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts meade@chromium.org: external/wpt/web-animations rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com: external/wpt/css/geometry yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=markdittmer No-Export: true Change-Id: Ia37d2e32fe51b2eb459430574f03d623f76ccda5 Reviewed-on: https://chromium-review.googlesource.com/1027312 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#553467}
-
Daniel Cheng authored
Bug: 706466 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6bfda065d7d4026ea92409b198dc7b7f7cdca91b Reviewed-on: https://chromium-review.googlesource.com/1027083Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#553466}
-
Jinsuk Kim authored
mActivityTestRule.getActivity().getActivityTab().getWebContents() is too long to type. Adds a convenience method in ChromeActivityTestRule. Turns lots of calls to one-liner, and makes my fingers happy. Change-Id: Ic2133fa1d413e865ab761404b0fdb3cac1a706e3 Reviewed-on: https://chromium-review.googlesource.com/1027010Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#553465}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cf1d296fd683..47b24cc1ce35 $ git log cf1d296fd..47b24cc1c --date=short --no-merges --format='%ad %ae %s' 2018-04-24 chrome-bot Update config settings by config-updater. 2018-04-18 ihf chromeos_config: let betty-arcnext run VMTest on Pi PFQ. Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I396ca9c3f52d5c6e9a8203b6d962036072248338 Reviewed-on: https://chromium-review.googlesource.com/1027120Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553464}
-
khmel@google.com authored
Test: unit_test + manually Bug: 834439 Change-Id: Id3bee682062eeacf7f88ea079ea37bdd4cafe09e Reviewed-on: https://chromium-review.googlesource.com/1023068Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#553463}
-
Antoine Labour authored
All Resources are now always DELEGATED, so remove functionality associated with INTERNAL resources (and Resource::Origin). Bug: 738190 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1edfa175dadb4a50608f03097196af11bf02144a Reviewed-on: https://chromium-review.googlesource.com/1023377 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
-
Vaclav Brozek authored
When some Mojo-related OWNERS rules are not added where they should be, the _CheckIpcOwners check suggests to add what is missing. The output of that check is vague about what lines are supposed to go into OWNERS. This way, components/password_manager/public/interfaces/OWNERS got extended with some garbage text. [1] This CL removes that text and also improves a little the presubmit message, which now says how many of the following lines should be added to the OWNERS file, as well as moves those lines to the very end of the whole message. Adding NOPRESUBMIT because the OWNERS syntax check fails on the old OWNERS file (which this CL is fixing). This is a known issue and was discussed on the associated bug. The resolution is that since presubmit should avoid landing a malformed OWNERS in the future, it is no problem if it fires for old OWNERS. NOPRESUBMIT=true [1] https://chromium-review.googlesource.com/c/chromium/src/+/840381/14/components/password_manager/public/interfaces/OWNERS#8 Bug: 836032 Change-Id: I0c6bdc321de06925d06775a5f1bd034c6c4dc957 Reviewed-on: https://chromium-review.googlesource.com/1025093 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
Daniel Cheng authored
Using a double timestamp is prone to errors, since nothing stops a numerical quantity with the wrong units from being passed in (or even worse... random unscoped enumerators). Instead, just use base::TimeTicks directly in blink::WebInputEvent: this allows all the conversions between base::TimeTicks and doubles to be removed and ensures better type-safety throughout the code. Several methods in the Blink public API have also been converted to pass time as base::TimeTicks, though those changes are limited to avoid changing the entire codebase in one CL. Bug: 763980 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I258486006302d010b121b39628ca3e8b3d71491f Reviewed-on: https://chromium-review.googlesource.com/793050 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
We are moving find-in-page related functions out of web_local_frame_impl_find_in_page.cc to its own class (FindInPage) for easier mojoification and so that we can add new find-in-page related functions more easily. In this CL, we are introducing find_in_page.h. WebLocalFrameImpl still have the find-in-page functions, but TextFinder ownership is moved to the FindInPage class. The functions in web_local_frame_impl_find_in_page.cc are changed to call the FindInPage functions (that are in the same file for smaller CL), and will be removed entirely in the next CLs. Previous CL: crrev.com/c/956648 In the previous CL, we moved find-in-page related functions to a new file, but it's still in the WebLocalFrameImpl class. After more discussions, we decided to do the old plan of refactoring the functions to its own class. Next CLs: Move functions from "web_local_frame_impl_find_in_page.cc" to "find_in_page.cc" Remove find-in-page functions from WebLocalFrame Refactor plan doc: https://goo.gl/CtLsFR Further plans: Mojoification https://goo.gl/JenyGm Find-in-page APIs https://github.com/rakina/find-in-page-api/ Bug: 819919 Change-Id: Icc8da3b321c72f2e7a210d5b350711b673eedfec Reviewed-on: https://chromium-review.googlesource.com/1025242Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#553459}
-
Daniel Cheng authored
Bug: 706466 Change-Id: Ibfca7f6baf3fcb475dd3bb78f3453624ef79c83c Reviewed-on: https://chromium-review.googlesource.com/1027118Reviewed-by:
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f05d63ff48c5..c56c9493dbc3 $ git log f05d63ff4..c56c9493d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic4a1167e611d611c3006647683f60588870502a9 Reviewed-on: https://chromium-review.googlesource.com/1027201 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553457}
-
Lei Zhang authored
This reverts commit 4596c802. Reason for revert: UnalignedSharedMemoryTest failing on multiple bots. Original change's description: > [media] Add interface for VDAs to Decode() media::DecoderBuffers. > > Using DecoderBuffer removes the need to provided SharedMemoryHandles in > cases that SharedMemory is not already allocated (in particular, when > VDAs are used through MojoVideoDecoder+VdaVideoDecoder). Since > base::SharedMemory is not an interface, a new type is required, and > DecoderBuffer already implements a suitable interface for this use case. > > This CL adds: > - A VideoDecodeAccelerator::Decode() overload for decoding > DecoderBuffers, which VDAs may optionally implement. > Note that VdaVideoDecoder will require this, and therefore all VDAs > will be updated to support DecoderBuffers over time. > - Support for SHM in DecoderBuffer. This eases the transition by > allowing BitstreamBuffers to be easily converted to equivalent > DecoderBuffers. > - An implementation of the new VideoDecodeAccelerator::Decode() > overload in VTVideoDecodeAccelerator. > - Calling the new overload from VdaVideoDecoder. > > Bug: 522298 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Ib932c3524b37e339f592b150685937ea94d4199d > Reviewed-on: https://chromium-review.googlesource.com/1015965 > Reviewed-by: Pawel Osciak <posciak@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553364} TBR=posciak@chromium.org,dalecurtis@chromium.org,sandersd@chromium.org Change-Id: Iad674ebb5286d5f068b2fc7bb6c67ab5f9a26fc0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 522298 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1026914Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#553456}
-
Philip Rogers authored
With root layer scrolling the layout view clips and we need to ensure the clip occurs in the correct (un)scrolled space for fixed position. This patch changes the fixed position case: we stop applying the layout view scroll, clip, and then do not counter-scroll. There is a similar codepath for the !RLS case which has not been changed in this patch. Here's a summarized description of where scroll offsets apply: 1) MapToVisualRectInAncestorSpaceInternal calls MapVisualRectToContainer 2) MapVisualRectToContainer calls MapContentsRectToBoxSpace 3) MapContentsRectToBoxSpace applies the layout view scroll offset 4) MapContentsRectToBoxSpace clips 5) MapToVisualRectInAncestorSpaceInternal un-applies the scroll offset This patch removes #3 and #5 for fixed position. Bug: 831380 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3437d3933155960abfcbebd437ddb6cb606ea37e Reviewed-on: https://chromium-review.googlesource.com/1025329Reviewed-by:
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=sky@chromium.org Bug: 825327 Change-Id: Ieae521d62d35bae3cd5c54309796f2b0c702679c Reviewed-on: https://chromium-review.googlesource.com/1024378Reviewed-by:
-
Antoine Labour authored
It is not used any more \o/ Bug: 738190 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic0bfa65a3ed9c43ff28450c305abbf7d0a93d3a5 Reviewed-on: https://chromium-review.googlesource.com/1023160 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
-
Kent Tamura authored
which is the new name of run-webkit-tests. This CL also replaces references to "run-webkit-tests" with "run_web_tests.py". * //blink/tools/run_layout_tests.py Show a message, and run run_web_tests.py. * //BUILD.gn "webkit_layout_tests" doesn't need //third_party/WebKit/Tools/Scripts any longer. * //testing/buildbot/gn_isolate_map.pyl Replace run-webkit-tests with run_web_tests.py. * //third_party/blink/tools/run_web_tests.{bat,py} Added. * //third_party/WebKit/Tools/Scripts/run-webkit-tests Show a message. * Other files: Really trivial changes. In many files, this CL replaces "run-webkit-tests" with "run_web_tests.py" in comments or strings. Note that we decided to rename LayoutTests to web_tests. https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/KKNbuzj-3HY/H8FWgtKrBgAJ Bug: 829697 Change-Id: I899457cb3bcdb306aa47843a4c767c5980d9edc0 Reviewed-on: https://chromium-review.googlesource.com/1025543 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:Nico Weber <thakis@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
-
Xi Cheng authored
Bug: 734095 Change-Id: Idf5637bb57a7cbfb0b5831cf99e45806d8a9abc6 Reviewed-on: https://chromium-review.googlesource.com/1026972Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#553451}
-
Xiaocheng Hu authored
We previously deduplicated left and right traversal algorithm in SelectionModifierCharacter, but haven't changed the variable names and comment yet, which is finished by this patch. Change-Id: Ie4a801b8b203433c189c70d8cb3824bd06931037 Reviewed-on: https://chromium-review.googlesource.com/1026835Reviewed-by:
-
Yoshifumi Inoue authored
This patch simplifies |FixLeadingWhiteSpaceForReplacedElement()| of |TextIteratorTextNodeHandler| by moving conditional expression into another function for improving code health. Change-Id: I6d83dd5e78696c808b87ce2998bccbd9b1edaa9c Reviewed-on: https://chromium-review.googlesource.com/1025675Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553449}
-
Devlin Cronin authored
Migrate the FeatureSwitch::scripts_require_action feature to a base::Feature. base::Features are a little more flexible than FeatureSwitch is now, since they are set up for finch experimentation and are always sent to the renderer (avoiding a commandline hack in place for the FeatureSwitch approach). Also rename scripts_require_action to kRuntimeHostPermissions. This is a little more descriptive, since the feature affects host permissions beyond just scripting (e.g., cookies and webRequest). Bug: 835339 Change-Id: I8b2a5c46a194655a811766114d8115da967719c0 Reviewed-on: https://chromium-review.googlesource.com/1022082 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#553448}
-
Daniel Cheng authored
Bug: 706466 Change-Id: I6f9db18aaca1c24a3da055907786943e55ea36d9 Reviewed-on: https://chromium-review.googlesource.com/1027115Reviewed-by:
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=ssid@chromium.org Bug: 825327 Change-Id: I69f4952b57c7693c441abe1a6173f453aa10e7e6 Reviewed-on: https://chromium-review.googlesource.com/1024288Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553446}
-
