GitLab

AXSelection: Added unit tests for retrieving and clearing the current selection, and for cancelling a selection that is in progress

R=dmazzoni@chromium.org, aleventhal@chromium.org

Change-Id: I9bb2589a938930e9e967525c4a627c893eecaa48
Bug: 639340
Reviewed-on: https://chromium-review.googlesource.com/c/1350195Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611502}

 - remove file_operation_manager_unittest.html
 - add BUILD rules to auto-generate and compile this unittest
 - define mockChrome and install it in unittest Setup()
 - fix Closure compile errors

No change in test behavior, no new tests.

Bug: 907967
Change-Id: I523218dd179c5e9b0ae55b81d4a5480eea279f8c
Reviewed-on: https://chromium-review.googlesource.com/c/1352115Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611501}

This CL creates a new type of KeyboardHook to listen to media keys.
KeyboardHook::Create is split in two, providing access to each type of
KeyboardHook. This creates the media hook implementation for Windows,
and returns nullptr for other platforms.

Bug: 903582
Change-Id: I5eb6bbd94ec23dd54867eeb9ced585bc1b726961
Reviewed-on: https://chromium-review.googlesource.com/c/1333118
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611500}

Record metrics when user logs out the demo session by using the buttons
on shelf and system tray.

Bug: 900263
Change-Id: I23ad6bf89b3b0e7a0edee265792cbffe8a9b9951
Reviewed-on: https://chromium-review.googlesource.com/c/1328231Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611499}

@IntDef annotation are preferred way for declaring set of int values.

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is replacing DetailsField enum to the style common with other @IntDef:

1. with @IntDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with @Retention(RetentionPolicy.SOURCE)
4. without "static final" in the @interface


Change-Id: I4e551520fd51c23a60f5d9d561fb23f6f0e93909
Reviewed-on: https://chromium-review.googlesource.com/c/1350901Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#611498}

If we currently have audio focus we should re-request
audio focus when the web contents is focused. This
means with grouping the media session that was
last focused will be pushed to the top of the stack.

BUG=906285

Change-Id: I9a7a72897c3c7be1186bdfbc4ef87364f7744a20
Reviewed-on: https://chromium-review.googlesource.com/c/1347614
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611497}

This was part of the reason one of the Android tests is failing.

Bug: 721403
Change-Id: I58493a24c32aaac2e568ade3541dea36ff87b88c
Reviewed-on: https://chromium-review.googlesource.com/c/1352325Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611496}

Bug: 867154
Change-Id: I456d03ab6ec8f9f995d8cbbc00f2a3e6b195bef1
Reviewed-on: https://chromium-review.googlesource.com/c/1352117Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611495}

Move CrashKeys class to //components/crash so that other components can
make use of it. This CL is a precursor for adding the installed feature
modules to crash reports.

Bug: 873719
Change-Id: I68d51a50cc9f239a94171ab7afec19b78224c53e
Reviewed-on: https://chromium-review.googlesource.com/c/1349729
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611494}

This CL allows PWA title bars to show the manage passwords icon
by moving it from LocationBarView to PageActionIconContainerView.

PWA title bar:
Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=368396&signed_aid=_t4hsG2GFjiEe__8vT-LtQ==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=368397&signed_aid=q2ASdnVuMGpsPn9GAjrdmg==&inline=1

Location bar (no diff):
Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=368398&signed_aid=hPiZlkK4KcRMeaLejACitg==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=368399&signed_aid=q0PRCcZ5Fi0BRFv3oqcSQA==&inline=1

Bug: 788051
Change-Id: I54508125c77858bb8c40e80a0971fb6f9ddc9384
Reviewed-on: https://chromium-review.googlesource.com/c/1345672
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611493}

https://chromium.googlesource.com/chromium/deps/nasm.git/+log/a0a6951e259b..4ee6a69ce33b

$ git log a0a6951e2..4ee6a69ce --date=short --no-merges --format='%ad %ae %s'
2018-11-19 dalecurtis Remove uses of time(NULL) for build determism.
2018-11-19 dalecurtis Add README.patches, clone find_patches.py from ffmpeg repository.

Created with:
  roll-dep src/third_party/nasm

R=davidben

Bug: 766721
Change-Id: Ie98e0aae2b4c955913da9bc88e19820232aa0a88
TBR: davidben
Reviewed-on: https://chromium-review.googlesource.com/c/1352586Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611492}

Change-Id: I85fd510b4245f966e32340b9d433f7d9b96b3810
Bug: 904000
Reviewed-on: https://chromium-review.googlesource.com/c/1303041
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611491}

Changes:
1, make init screen focusable so as to read it's content for accessibility
2, announce first run experience is shown and autofill assistant is available
3, announce autofill assistant message
4, do not show autofill assistant bottom bar when showing init screen.
5, move the functions around in controller.cc to match their declaration order.

Bug: 806868
Change-Id: I7376ef905d3e7dc7f9949557f1307cb07ed28c95
Reviewed-on: https://chromium-review.googlesource.com/c/1351649
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611490}

Previously it was only available in test on Chrome OS

Bug: 719176
Change-Id: Ie329c8c900f0f9e57a2aadfe4863133b0fd8e39d
Reviewed-on: https://chromium-review.googlesource.com/c/1350376Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611489}

This line currently causes my gdb sessions to error out with:

  TypeError: unorderable types: list() > int()

Looks like this just wants to check for an empty list

Bug: None
Change-Id: I5de214c2373045a320e83db229b2ae449b78c967
Reviewed-on: https://chromium-review.googlesource.com/c/1352645Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611488}

The omnibox is always automatically focused after a blank new tab is
opened. Hence, we don't have to consider the omnibox being focused in
the triggering logic for reopen tab in-product help.

Bug: 887991
Change-Id: Ie9bac48ebb471002926156c488deb886688a4af4
Reviewed-on: https://chromium-review.googlesource.com/c/1351495Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611487}

Writes to cross-thread persistents are no longer atomic (release) stores, so
this is not more safe than a non-atomic access -- its correctness depends on
external synchronization, which at the sole call site is provided by
ProcessHeap::CrossThreadPersistentMutex(), which also guards all writes to
PersistentBase::raw_ for cross-thread handles.

Bug: 736037
Change-Id: Ic47ef65b731030cdf9897f2d7dd48899514eea5e
Reviewed-on: https://chromium-review.googlesource.com/c/1351567Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611486}

Prevents the loading animation from looking stuck. 0% looked buggy, like
we wouldn't even start loading. 100% looks similarly buggy, if we're
100% done we should not be stuck in a loading state.

Bug: chromium:908920
Change-Id: I280a9f7ce9f7db3920c41add9220a5ed4604b900
Reviewed-on: https://chromium-review.googlesource.com/c/1351103
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611485}

This is a reland of I7946d7acab334bffdf2bb49a1d9c424cf46fc610 and
the following bug fixes as follows;
"viz: Fix wrong uv_rect calculation" 4bf9d01d
"viz: add unittests for CL:1291590" f8dfbe74

Additional fix:
- Fix the flickering issue because of primary |uv_rect| cropping even though
an overlay attemption fails mainly due to limited pixel rate (e.g. 4k video).
- Fix wrong |uv_rect| calculation which causes atomic page flip failures with
"No space left on device (28)" error.

Original change's description:
> viz: Turn off or crop primary plane when possible
>
> For many fullscreen cases, the rest of the renderpass quads are solid
> black quads. In that case, we can turn off the primary plane, and not
> having to scan out an full screen of black pixels saves a good deal of
> power. In other cases, we can crop down the primary plane down to the
> content rectangle (youtube channel logo, for example) and save power.
>
> Averaging battery draw measurement over about a minute of play back
> for a fullscreen youtube video, power savings for soraka is around
> 500mW (6.5W to 6.0W) and 300mW for kevin (4.4W to 4.1W), when we
> turn off the primary plane.
>
> Change-Id: I7946d7acab334bffdf2bb49a1d9c424cf46fc610
> Reviewed-on: https://chromium-review.googlesource.com/c/1045256
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com>
> Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600415}

TEST=SingleOverlayOnTopTest.AllowVideoNormalTransformWithOutputSurfaceOverlay

Bug: 896945, 900373
Change-Id: I88db118dbc3ca2fed8c8eaf1f9a4337cdae12990
Reviewed-on: https://chromium-review.googlesource.com/c/1346997
Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com>
Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com>
Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611484}

TBR=dtrainor@chromium.org
BUG=

Change-Id: Ifa7d8506dac19d308cd161f4852cec979d27c6fc
Reviewed-on: https://chromium-review.googlesource.com/c/1352620Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611483}

This gives us precise control over callers of navigation-related
methods. This technique allows to update navigation sequence
without worrying that some client will mess up the calls.

For example, the immediate application is to get rid of some
WebLocalFrameClient callbacks like DidStartProvisionalLoad.
RenderFrameImpl will manage them itself, given that it has full
control of all the navigations that commit. This will remove
a lot of indirection we currently have, and bring us closer to
removing provisional document loaders.

This corresponds to the step 7.a from the one-pager (see bug).

TBR=mmenke,tommycli,thestig

Bug: 855189
Change-Id: Iaff018955e86cbc3a5ba73a5d58e070f3095782a
Reviewed-on: https://chromium-review.googlesource.com/c/1257550
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611482}

This CL adds a CanvasResourceProviderDirectGpuMemoryBuffer test
case to the mentioned unit test file after crrev.com/c/1321773
lands this new provider.

The mentioned new provider needs to use GpuMemoryBuffers, so a
Fake GLES2 interface and a FakePlatformSupport are needed and
added.

Bug: 902585
Change-Id: I2a1da94a2108bead8394e715b2a85fa57fac1c59
Reviewed-on: https://chromium-review.googlesource.com/c/1351746Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611481}

The crash would happen if you install Chrome of a specific language
and run it for the first time on a Windows OS of a different
language.

It was caused by code setting the language pref in-between the two
places where it was queried - such that the first time it was
queried resulted in a different value than the second.

This triggered the CHECK that was introduced by this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1349770

Which correctly identified the problem. This CL fixes the issue
by moving the importing of the first-run locale setting to
earlier.

Bug: 908791, 908114
Change-Id: Ie2e0178f298f78d38e0bc7f0b58c2205bb617561
Reviewed-on: https://chromium-review.googlesource.com/c/1352482Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611480}

Update the tests to use the test UI API, which is implemented using the
Views Cast dialog, replacing the use of the WebUI dialog. Some changes
are made to the test UI API to better suit the needs of the tests.

This re-enables many tests that were previously disabled for being flaky.

Local file casting tests (5 test cases) are disabled in this CL, and
will be implemented in a later CL:
DISABLED_OpenLocalMediaFileInCurrentTab
DISABLED_OpenLocalMediaFileInNewTab
DISABLED_OpenLocalMediaFileFailsAndShowsIssue
DISABLED_OpenLocalMediaFileFullscreen
DISABLED_OpenLocalMediaFileCastFailNoFullscreen

The following tests are still flaky, so they are marked MANUAL and will
be run only on the private waterfall until they are fixed:
MediaRouterIntegrationBrowserTest.MANUAL_Fail_NoProvider
MediaRouterIntegrationBrowserTest.MANUAL_Dialog_Basic
MediaRouterIntegrationBrowserTest.MANUAL_Dialog_RouteCreationTimedOut
MediaRouterIntegrationOneUABrowserTest.MANUAL_SendAndOnMessage
MediaRouterIntegrationOneUABrowserTest.MANUAL_ReceiverCloseConnection

Bug: 900248
Change-Id: Ie328fd1c4b606a7f8291d8d22b7d83a89f1ee666
Reviewed-on: https://chromium-review.googlesource.com/c/1338226
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611479}

Bug: 884059
Change-Id: I8f17beea35b0dd3ed356aeb04b25ae5d869a1c71
Reviewed-on: https://chromium-review.googlesource.com/c/1334190Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611478}

Adds GetOriginalMimeType() to web::DownloadTask in order to retrieve the
MIME type download request originally attempted to fetch as the effective
MIME type can change.

Bug: 908696
Change-Id: I2bc1cd0fbc3ff038d0c5b50c819901a30e639d8e
Reviewed-on: https://chromium-review.googlesource.com/c/1351338
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611477}

https://chromium.googlesource.com/angle/angle.git/+log/4f2b94cb9a6b..752d220a5f31


git log 4f2b94cb9a6b..752d220a5f31 --date=short --no-merges --format='%ad %ae %s'
2018-11-27 jmadill@chromium.org Use flat enum for PrimitiveMode.
2018-11-27 geofflang@chromium.org Supress RobustResourceInitTestES3.MaskedStencilClearBuffer on Linux OpenGL
2018-11-27 jmadill@chromium.org Reformat all cpp and h files.


Created with:
  gclient setdep -r src/third_party/angle@752d220a5f31

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: I1f5422540001e82ca4b6d275b59648428e958c87
Reviewed-on: https://chromium-review.googlesource.com/c/1352551Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611476}

Adds a drop-in motion to the current fade-in effect. This (fade in and
motion) is currently linear but expected to be updated in a later change
after consulting UX.

Bug: chromium:903806
Change-Id: Iebc44c281ad18be2c02a1e84903cc6d0ff64b84f
Reviewed-on: https://chromium-review.googlesource.com/c/1352689Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611475}

Before this CL, all histograms under ServiceWorker.LoadTiming category
were recorded by UMA_HISTOGRAM_TIMES macro. The macro can record up to
10 seconds but we've realized that 10 seconds limit isn't enough for
some milestones. Use UMA_HISTOGRAM_MEDIUM_TIMES for these histograms
so that they can be recorded up to 3 minutes.

Bug: 877972
Change-Id: Icca1ddd583c87c4dd9a6ebd924b81edd2648b2f0
Reviewed-on: https://chromium-review.googlesource.com/c/1350433
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611474}

Right now, the draw functor factory is named in such a way that it only
creates OpenGL functors. We want to also be able to create Vulkan
functors.

This CL renames the factory to be API-agnostic and renames the function
which creates the functor to be API-specific.

Change-Id: Ib304a376710a59ddde7afa72b9583a0e2243ddc9
Reviewed-on: https://chromium-review.googlesource.com/c/1352036Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611473}

Add the GWP-ASan crash handler hook to the list of user stream data
sources in the Windows crashpad process. The GWP-ASan crash handler
inspects crashes, and if they are related to a GWP-ASan allocation, adds
additional debugging data to the minidump.

CQ-DEPEND=CL:1330283

Bug: 896019
Change-Id: I0b38c60cd46c029200240560fdb714fbd2087f70
Reviewed-on: https://chromium-review.googlesource.com/c/1338324
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611472}

Change-Id: I534829c0717dc7c85d008459be9b1ffff3deb577
Reviewed-on: https://chromium-review.googlesource.com/c/1338951
Commit-Queue: Ben Greenstein <bengr@chromium.org>
Reviewed-by: Ben Greenstein <bengr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611471}

Added OzonePlatform::IsNativePixmapConfigSupported() which is now used to
verify that the current ozone platform supports particular image format.
It replaces PlatformProperties::supported_buffer_format and
ClientNativePixmapFactory::IsConfigurationSupported()

Change-Id: I619f8130c09038e44bc558bdf59b816979e228a5
Reviewed-on: https://chromium-review.googlesource.com/c/1347036
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#611470}

R=mmoroz@chromium.org,rch@chromium.org,enne@chromium.org,ajwong@chromium.org,jschin@chromium.org
TBR=tkent@chromium.org

Bug: 907103
Change-Id: Ib93a393e35650233f3c77e32080af048f9b301fb
Reviewed-on: https://chromium-review.googlesource.com/c/1351483
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611469}

Implementing a WebGL spec change:
https://github.com/KhronosGroup/WebGL/pull/2658
Fixes WebGL 2 conformance test:
conformance2/transform_feedback/same-buffer-two-binding-points.html

We want to forbid this for all GL contexts, not just WebGL ones, because
it is also forbidden by DirectX, so ANGLE can't efficiently implement
it.

Bug: 866089
Change-Id: Ibf57adf513eca05b46b93d2139ba038d488c9cc9
Reviewed-on: https://chromium-review.googlesource.com/c/1346994Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611468}

BUG=907487

Change-Id: Ib1343dc9dc93a1b5ca9ecf72658e29de7bd97116
Reviewed-on: https://chromium-review.googlesource.com/c/1348673Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#611467}

Created CreditCardSaveStrikeDatabase implementation of
StrikeDatabase, which is to be used to count strikes for credit
card saves.

Bug: 884817
Change-Id: I96b2b98894d06f97f6ea3bb24f3566cea273133f
Reviewed-on: https://chromium-review.googlesource.com/c/1349169
Commit-Queue: Anne Lim <annelim@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#611466}

Regular roll to the most recent release versions of Daydream and VrCore.

TBR=bajones@chromium.org

Change-Id: I913293ce4ba653d9d57b5062fe94b628f70ac5ef
Reviewed-on: https://chromium-review.googlesource.com/c/1352486Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611465}

Mark dcheck-is-fatal as a special never-expiring flag, since it is used
with special DCHECK-enabled builds to explicitly opt-in (or out) of
crashing when a check fails.

Bug: 901515
Change-Id: I153082352eaaa048db9d4070f802b4ce1ab8c38a
Reviewed-on: https://chromium-review.googlesource.com/c/1351732Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611464}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af1cdca8c140..7f2a2ae33b38


Created with:
  gclient setdep -r src-internal@7f2a2ae33b38

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I8cf1cf853015a2305ae3d7cd55ed92d918a381aa
Reviewed-on: https://chromium-review.googlesource.com/c/1352066Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611463}