- 09 Jan, 2021 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium a8a6d154. With Chromium commits locally applied on WPT: fc8d726c "fix: relax performance API checks for prefetch test" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, smcgruer@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/css-contain external/wpt/css/selectors rsleevi@chromium.org: external/wpt/WebCryptoAPI skobes@chromium.org: external/wpt/css/css-scroll-anchoring NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ic7e149ce731e6a3b80f150363b4ec2cb36908fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616327Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841756}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/128bf6a2b49f..324ea4f154d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dalecurtis@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: dalecurtis@google.com Change-Id: I52358136077c849280c7d17385bb03046c6e9422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617901Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841755}
-
Sam Sebree authored
ForcedColors mode This CL fixes an issue in which, when in ForcedColors mode, options in the select multiple control would lose visibility upon hovering. Bug: 1157173 Change-Id: Ia2f89e9a94cfac37b77fead8becbbdc37e7082a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614851 Commit-Queue: Sam Sebree <sasebree@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#841754}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/a4e3a5aaf64c..b229877c6d2d 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 04cf3fd95555 to f0634ebbb36f (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com Change-Id: Ia815796ff1a005c469c617758c5350cc054730a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617246Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841753}
-
Dale Curtis authored
reporting-popup-same-origin-allow-popups-report-to.https.html is flaking on mac. TBR=wjmaclean Bug: 1164568 Change-Id: I9bbf4dd6c172f505f6725bdb2619fa11d5716671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618767Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#841752}
-
Findit authored
This reverts commit 8c86c0a8. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 841710 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOGM4NmMwYTgxMmQ0OTNjYTJlNjAzYjI0ODUyYmFhNzMzZmExZjNlNgw Sample Failed Build: https://ci.chromium.org/b/8858625648955134400 Sample Failed Step: bf_cache_content_browsertests Sample Flaky Test: SnapshotAXTreeBrowserTest.Timeout Original change's description: > Add additional params to WebContents::RequestAXTreeSnapshot > > WebContents::RequestAXTreeSnapshot is used for several things, including > supporting Assistant on Android and Chrome OS, generating tagged PDFs, > speaking the text of a page on macOS, and determining the page language > for Translate. > > On Android, requests are timing out on large pages; Assistant wants > results in 3 seconds. This change adds additional parameters to > RequestAXTreeSnapshot to enable it to run faster, by limiting the > number of nodes, excluding offscreen nodes, and returning partial > results after a timeout elapses. > > This change adds test coverage but does not change any code to use > these new parameters, so there shouldn't be any side effects of > landing this patch. A follow-up will change the Android callers to > pass different parameters. > > Bug: 1161541 > Change-Id: Ie2394b451a53636d833944448157ae4300dabd7a > AX-Relnotes: N/A > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602697 > Reviewed-by: Emily Stark <estark@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Mark Schillaci <mschillaci@google.com> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841710} Change-Id: Ia2b9a7d3a0a085c4a65b07824913f9e035f6f4f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1161541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618674 Cr-Commit-Position: refs/heads/master@{#841751}
-
Bartek Nowierski authored
This is a just-in-case CL. If things don't go as planned with this week's Dev release, we can consider using the next week's Dev for repeating the 3-way no-PAE/PAE/PAE+PCScan experiment. Note there is a difference from how it was previously configured. The old configuration would correctly report PCScan is always disabled on 32-bit platforms, leading to 33/66/0 population split that it'd had to be adjusted at release time (rather cumbersome and errorprone). The new configuration lies that PCScan is still enabled thus keeping 33/33/33 split and allowing us to easily ignore the PCScan enabled bucket when analyzing results. Bug: 11297512, 1121427 Change-Id: I5843ed1e1dfaddd3a9eb891097096a41077b9483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617526 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#841750}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c4efeef83334..c9a22bcb93db 2021-01-08 hao.x.li@intel.com Disable timestamp query extension on Metal If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: If88f4f912b46808f90e823055b23c9307b442b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617248Reviewed-by:
-
Elaine Chien authored
Mocks: https://docs.google.com/presentation/d/1gJEE-qL8XCst4gIQaAXt0fmlxlHIg7HWtcw0l_ISq-s/edit#slide=id.ga480910b3a_0_40 Notes: - We are changing the name from Chrome Labs to Chrome Beta; "Labs" and the top area of bubble above experiments will be changed. - Icons will be added in a later CL. Bug: 1145666 Change-Id: I344a89efd89aff4f5fd8c782df3e21f6bdb0d419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616490 Commit-Queue: Elaine Chien <elainechien@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#841748}
-
Ian Barkley-Yeung authored
Test that the WebUI JavaScript error reporting system will not report non-WebUI JavaScript errors even if they happen in the same tab. Bug: chromium:1162353, chromium:1121816 Fixed: chromium:1162353 Change-Id: If44d5777b7c4bc955e8101d60cd6029036d6bd1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617529Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#841747}
-
Yuri Wiitala authored
Bug: b/162541648 Change-Id: I057dc7742b7dd8f8e8045484e151106df42f24d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618699 Auto-Submit: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#841746}
-
David Black authored
This CL fixes tooltips for: - Holding space tray - Holding space chips - Holding space screen captures Previously tooltips did not work because descendant views were obstructing the views that implemented the tool tipbehavior or, in the case of screen capture views, because tooltips had not previously been implemented. Bug: 1162050, 1164333 Change-Id: If924ff9e6e6edaa9b2d889c4b46c1180a5844f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618476Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#841745}
-
Evan Stade authored
Bug: 1158940 Change-Id: I60e4b83dcb79bd3aae694c7cffed9ff7e0027f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611698 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841744}
-
Yuri Wiitala authored
Bug: b/162541648 Change-Id: I2ee5c166fb34109fe0fd0470da428b71e836555b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618700 Auto-Submit: Yuri Wiitala <miu@chromium.org> Reviewed-by:
-
Gordon Seto authored
Add UI for confirmation code page and installing profile using a confirmation code. Screenshot: https://screenshot.googleplex.com/BECB5ziR3vFEt6a.png Bug: 1093185 Change-Id: Iec4fcfb08f501495b640834e404f34dc69b5f9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616733 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#841742}
-
Yury Khmel authored
As above BUG=1164478 TEST=None Change-Id: I36de164195bc99ae0d760db9ce093df9c1bce233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618583Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Auto-Submit: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#841741}
-
Benjamin Beaudry authored
In some cases as the one described in https://crbug.com/1151383, non-fragmented OOF are not painted. The computed |offset_from_root| seems to be invalid and this CL fixes it. Bug: 1151383 Change-Id: Ib85440577442782a1f09f704d2224214d4822232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607670 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#841740}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610128749-54768dc60943741e5d54665b25111b4653768898.profdata to chrome-win64-master-1610139561-9d7df42b937a5193cd789e89275356fd04ecc110.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I807ceaa29f33c112bf1c7a1617cacb898c648146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617004Reviewed-by:
-
Peng Huang authored
drawn_fn::ContextManager is used for creating native EGLContext, so it should not use chromium GL EGL bindings which could be connected to ANGLE library instead of OS libraries. Bug: 1157501 Change-Id: I8b6fd3ab1ab0182f929be2a7eefed1ad733c8dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618184 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#841738}
-
Yuwei Huang authored
This CL adds silence detection logic for AudioCapturerMac so that it doesn't send empty audio packets and waste the bandwidth. Bug: 1161363 Change-Id: I891355b0ca31fb12eb40feb4f9b189645d36193c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618473Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#841737}
-
Yuheng Huang authored
story_test.StoryTest.WillRunStory in catapult The current CL needs to land before the following one https://chromium-review.googlesource.com/c/catapult/+/2618527 Bug: 1164464 Change-Id: Ibc25dbbf7ea1f0e5987a0146cd4ab806fa0e4325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618391Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#841736}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/61125414310a..affdce7627b1 2021-01-08 treehugger-gerrit@google.com Merge "Remove unnecessary dlog while parsing track event" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I09e430ac16da8cbaee3f8b6fb0d9e2032bfe5ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617245Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/00e43df25bea..6bf6963198aa 2021-01-08 johnstiles@google.com Remove context argument from short_circuit_boolean. 2021-01-08 robertphillips@google.com Improve flush-time op spew (esp. for DDL tasks) 2021-01-08 brianosman@google.com Fix 'out' and 'inout' params in user-defined runtime effect functions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: Ib9571c1cee2a7dc63f3394fd316556eee9e95192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618534Reviewed-by:
-
Michael Lippautz authored
Bug: 1056170 Change-Id: Ibbde34d16df541c287f8542dec81e15d4664b05c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616203 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#841733}
-
Bartek Nowierski authored
IsPartitionAllocPCScanBrowserOnlyEnabled used to return false unconditionally on 32-bit architectures. This led to necessity to set up different populations in Omaha for each architecture, which is error prone. After changing this, the responsibility for checking the bitness falls now on EnablePCScanForMallocPartitionsInBrowserProcessIfNeeded. The caveat is that the population with PartitionAllocPCScanBrowserOnly turned on on 32-bit systems will now have to be ignored. This is ok because we get enough data on Windows. Make a similar change to EnablePCScanForMallocPartitionsIfNeeded for consistency, and overall clean up the code to look more symmetrical, while at it. Bug: 11297512 Change-Id: Ia4eccdbea149389e3a192c5b618cb938a701c388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597240Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Xiaoqian Dai authored
Looks like kEmbeddedWindowEnsureNotInRect was introduced for mus and has been cleaned up partially. Clean up the remaining part. Bug: None Change-Id: I390338677625c8b12aa8d0016a8d32e40acb456b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600326 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#841731}
-
Ken Rockot authored
Tests set up Local Storage in a temporary directory. If the directory has opened files during test shutdown, temp directory deletion can fail on Windows and cause test flake. This properly reorders LocalStorageImpl's shutdown synchronization logic so that we can ensure no LevelDB files remain open once the shutdown callback is invoked. Fixed: 1151226 Change-Id: Id9cad4ae8a305e12c965e1fb3d8908b739050cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617869Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#841730}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/11e6cfe60a92..61125414310a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If8e708789a5ede5640bf4760085119196516c63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617872Reviewed-by:
-
Charlie Reis authored
We don't need to allow the CloudPrint hosted app to use restricted APIs after r841133. Bug: 1103302, 1100748 Change-Id: If8965b276a53cd00fa6822f870b7db78d77dfef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617873 Commit-Queue: Charlie Reis <creis@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
cfredric authored
This cl adds 3 use counters: * one for use of the SameParty attribute; * one for when a cookie was excluded solely for SameParty reasons (i.e. in a cross-party context); * one for when a cookie was included by SameParty but excluded by SameSite. While I'm at it, this cl also: * renames the misleadingly-named `excluded_cookie` variable, since the cookie could be either included or excluded; * renames the EmitSameSiteCookiesDeprecationWarning, since the method does more than that; * and introduces a helper variable to make the loop body slightly more readable. Change-Id: I388e032651212769c2547ae64b426903ff7be0b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616422 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#841727}
-
Daniel Hosseinian authored
Setup the frontend pipeline for showing document properties and show some basic ones for now, including: - Title - Author - Subject - Application - PDF Producer Reshape the 'metadata' message to have a `DocumentMetadata` object in its 'metadataData' field, which can be directly passed to the `ViewerPropertiesDialogElement` without further processing on the frontend. Bug: 93619 Change-Id: Iffb8691f443781a700fc06a439506dd546f46865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610048 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#841726}
-
Dale Curtis authored
This reverts commit 57cebabc. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1164561 Original change's description: > DLP: Change DragDropDelegate::OnDragUpdated return type > > - Changed the return type of DragDropDelegate::OnDragUpdated > to return a struct of DragOperation and DataTransferEndpoint. > - The returned DataTransferEndpoint should be used in > DragDropController for allowing/disallowing dropping the > data according to the policy rules, See crrev.com/c/2595382. > > Bug: 1139886 > Change-Id: Ic80f2d55bf1df350d24778f01a43c8cba0ff67cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595411 > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841675} TBR=sky@chromium.org,oshima@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,ayaelattar@chromium.org Change-Id: I205a8bd3b7bdfdcddf74ccfdebfdf371ccc7b103 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1139886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617055Reviewed-by:
-
Torne (Richard Coles) authored
This expired in M85 and we don't need any more data; delete the implementation and mark it obsolete. Fixed: 1088547 Change-Id: I9cf662751a746201a7fd921b5873c75d30d4acc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618503 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#841724}
-
Dale Curtis authored
This reverts commit 5a849c90. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1164560 Original change's description: > [LanguageDetection] Pass language model to TranslateAgent. > > This change provides the file for the language detection model needed > in the TranslateAgent. > > Bug: 1151422 > Change-Id: I24870758adf8b00ee378ca7ccc55bd45edb164d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599580 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Scott Little <sclittle@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Trevor Perrier <perrier@chromium.org> > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841678} TBR=dcheng@chromium.org,jam@chromium.org,sclittle@chromium.org,sophiechang@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,perrier@chromium.org Change-Id: I7d33ec2acd918141ae310911550e3ffb86f336b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1151422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618475Reviewed-by:
-
Aleks Totic authored
Test used to be flaky and there was a bug. Marking it as no flaky to close the bug. Ran the test for 100 tries on linux, no flakiness. Bug: 918664 Change-Id: Ibb92506852cb09747b757dfa1fcfbb3fd4f428ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617510 Commit-Queue: Aleks Totic <atotic@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#841722}
-
Dale Curtis authored
This reverts commit 50bc0376. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1164559 Original change's description: > Remove the app related full restore data when the app is removed. > > Add the class FullRestoreDataHandler to observe AppRegistryCache. When > the app is removed, remove the full restore data from both > FullRestoreReadHandler and FullRestoreSaveHandler. > > BUG=1146900 > > Change-Id: Ie55b6310e3e302ac4829b7c76c10880928266651 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608045 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841611} TBR=xiyuan@chromium.org,dominickn@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,nancylingwang@chromium.org Change-Id: Ib46d03a047b6c8145805ed2ba40e5c48c12d5d17 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1146900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618763Reviewed-by:
-
Michael Checo authored
Screenshot: http://shortn/_ldNJuxuRhF Spec: https://carbon.googleplex.com/cros-ux/pages/diagnostics/mvp#dd35f9cb-3d67-452e-a98c-89635d8c31c3 Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I4756e38037d8ba4ba9ed9435f2f6a6a21d0e4b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557728 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#841720}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4f67a285e221..f3b585e8edf5 2021-01-08 tsepez@chromium.org Avoid integer overflow in RelocateTableRowCells(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1164158 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I41efdd60480e820072c4fcefc6ad6f41bb0b6654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618535Reviewed-by:
-
Daniel Cheng authored
Change-Id: I9d4c9bf676be75bc2b6bec5d18515de092b99d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616946 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#841718}
-
Dale Curtis authored
Since software overlays are controlled by a base::Feature, we need a new static method on DirectCompositionSurfaceWin for disabling the software overlay path using an internal static variable. R=zmo Bug: 1161215, 1160217 Change-Id: I3299a4f80881d45444dfbebaaf4bce2b581f2322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617000 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#841717}
-
