- 31 Jul, 2020 40 commits
-
-
Haiyang Pan authored
And update the related AVD creation textpb files Assigning larger memory size via ram_size might help mitigate crbug.com/1105697 Bug: 922145, 1105697 Change-Id: I05c765cffb50b2196cdb99963f1d4a2cf3476c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146136 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#793677}
-
Patrick Noland authored
Bug: 1111201 Change-Id: Iac335d42a332e4a6bee7bcda5c588c9d74de679a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331070Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#793676}
-
Tommy Martino authored
This feature splits the scroll to text functionality off of the Shared Highlighting flag. This is needed because: * The Scroll-to-text portion will be launching first * The Scroll-to-text portion is being built in //ios/web to enable external usage. Bug: 1099268 Change-Id: I60cbe5d20907d4889aa46a051ec335dfe55b59b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329947Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#793675}
-
Tanmoy Mollik authored
This preference will be used to show personalized sync promo in main settings page Screenshot: https://crbug.com/1106378#c2 Bug: 1106378 Change-Id: Iae286ef61f8b1d9166c9174a2fe964a12f6cf0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310412 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#793674}
-
Devlin Cronin authored
Update remaining tests under //content/browser/device_sensors to use WebContentsConsoleObserver instead of ConsoleObserverDelegate. This allows us to observe console messages added without overriding the existing delegate of the WebContents. Bug: 1034150 Change-Id: I422e3b5573d568f3694cc95a0056b16f0a1d5a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319342Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793673}
-
David Grogan authored
I filed some bugs and added the new bug numbers where appropriate. This only messes with lines in flex directories, there are flex tests in other specs' directories that remain untouched. Fixed: 467127 Change-Id: I90b17600bcdad862099041494d1b92aeda9fd3fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332556Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#793672}
-
Sergey Poromov authored
DlpContentTabHelper is being attached to WebContents and tracks all the frames inside and visibility of WebContents. This information is reported to DlpContentManager that collects it from all WebContents and tracks whether any of confidential data is currently visible. Bug: 1104884 Test: Unit tests added. Change-Id: I02ae3d1bec7485569592e7fa746f6e6c06c991d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288104 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
-
Andrey Zaytsev authored
Screenshot: https://screenshot.googleplex.com/4AkKd8rHMgB.png Bug: 1070620 Change-Id: I132b669082b09243301927b1f74d3d9809e8d684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329166 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#793670}
-
Emily Stark authored
This CL fixes a few oddities in the omnibox tests for the simplified domain field trials. - The main fix is to make ExpectElidedToSimplifiedDomain() not sensitive to the rounding behavior of GetSubstringBounds(), which is changing in a follow-up CL (https://chromium-review.googlesource.com/c/chromium/src/+/2317820). Previously we were checking that the display offset is correct by comparing it to the width of the string that should be scrolled offscreen, but that won't work when GetSubstringBounds() is subsequently changed to round outwards so that adjacent substrings' bounds can overlap slightly -- this makes the width of the portion scrolled offscreen slightly larger than the actual display offset. Instead, we now compare the x value of what should be visible with the x value of what should be offscreen to check that the display offset is correct. - Along the way I noticed that one of the checks in ExpectElidedToSimplifiedDomain() was bogus, so I fixed that. - And I noticed that the URL wasn't set properly (it had an extra scheme appended to it) in SetUpSimplifiedDomainTest(). This didn't really matter because all the code looks at the display URL (which was set properly) rather than the actual URL, but I fixed it anyway. Bug: 1108045 Change-Id: I4c233ce8485b5e09613cac7f268f4b3abc87b142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332581Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#793669}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4470ba1491e5..d7c4f9d06425 2020-07-31 brianosman@google.com Add missing <memory> include 2020-07-31 bsalomon@google.com Don't define SK_GL when no other GPU backends are enabled If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I60696b6201e7f03f5461b67b8d0ea4d1f799786e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331921Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793668}
-
Saurabh Nijhara authored
If an update is required as per DeviceMinimumVersion policy but the device cannot be updated as it has reached end of life or auto update expiration, the product requirement is to show a banner on the top of Chrome OS Settings page. This banner is to inform the user that device needs to be returned back within the specified time frame. After this time frame has expired, the user would not be able to use the device and hence, the close button on the banner does not dismiss it forever but for just current Settings page. Screenshots: https://screenshot.googleplex.com/PnKQdspE7G9 https://screenshot.googleplex.com/MGFnpRJSvrr https://screenshot.googleplex.com/Ab2GT9bZcXH Bug: 1110976 Change-Id: I69686b019eea524d162316d32ef483606e5154f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314496Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#793667}
-
Haiyang Pan authored
This reverts commit 4019e30a. Reason for revert: Need to create new AVDs for crrev.com/c/2146136 and crrev.com/c/2321088. Revert this CL to avoid affect from emulator/system image change. Original change's description: > android: Roll latest releases of emulator and system image for AVD creation > > API 23: > emulator version: 29.0.11 -> 30.0.12 > system image: 31 -> 32 > API 28: > emulator version: 29.0.11 -> 30.0.12 > system image: 9 -> 10 > API 28 with playstore: > emulator version: 30.0.0 -> 30.0.12 > > Change-Id: I1baa0354767f3fed5b52a4bcb31dc2df09500760 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251167 > Auto-Submit: Haiyang Pan <hypan@google.com> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779655} TBR=liaoyuke@chromium.org,hypan@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I093b5e2168d3a002e32510c443655f1b7d893d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332565Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
-
Daniel McArdle authored
Change-Id: Iba9ee450e3800c4cc2514f6067f900453b8ed7c8 Bug: 1111804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332680Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#793665}
-
Andy Lu authored
The Siri shortcut accepts a list of URLs and open them in Incognito mode. Also able to accept inputs from scripting actions (i.e. a list) and open the URLs in it successfully. Deletions of lines in intentdefinition are auto-generated during build. No intentional deletion was done. Bug: 1091764 Change-Id: I7de200803f93434db8608b87d693e84802515d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236243 Commit-Queue: Andy Lu <andyhylu@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#793664}
-
Aaron Krajeski authored
With deferred rendering it's possible for a drawImage operation on a canvas to trigger a copy-on-write if another canvas has a read reference to it. This can cause serious regressions due to extra allocations. FlushForImageListener keeps a list of all active 2d contexts on a thread and notifies them when one is attempting copy-on write. If the notified context has a read reference to the canvas attempting a copy-on-write it then flushes so as to make the copy-on-write unnecessary. Results are promising! https://aaronhk.users.x20web.corp.google.com/flush-for-image-performance.html?r=baseline&s=%25%CE%94avg&g=name&c=0 Bug: 1030108 Change-Id: Idc176053224634156b4775545dc56e8af54b0b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304251 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#793663}
-
Yao Xiao authored
Allow for more flexibility in the FLoC PoC privacy analysis. Bug: 1111818 Change-Id: I99944a052fe4a5f54e38fe20ce6cd8bc24dc17ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332117Reviewed-by:
Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#793662}
-
Rouslan Solomakhin authored
Before this patch, Chrome on Android supported invoking its own TWA for an app store billing payment method, without an ability to turn this feature off. This patch adds an "AppStoreBilling" feature flag that is enabled by default on Android and checks this feature flag before looking up payment support in the TWA. The feature flag is disabled on other platforms where app store billing is not implemented yet. After this patch, it's possible to turn off the feature of Chrome invoking its own TWA for an app store billing payment method. Bug: 1110494 Change-Id: I3c50acdb2949debcbf0d3162a14cb9a3fbeed673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329991Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#793661}
-
Bo Liu authored
Follow up to last CL. Need to catch the timeout exception and retry. Bug: 1107812 Change-Id: I03136cd8f7cb4418da2e63631020c6f7751562d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332678Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793660}
-
Devlin Cronin authored
Update //content/browser/download/mhtml_generation_browsertest.cc to use WebContentsConsoleObserver instead of ConsoleObserverDelegate. This allows us to observe console messages added without overriding the existing delegate of the WebContents. Bug: 1034150 Change-Id: I79d7d6b8174e5e24c4a9ad776a94e2636ec6a9b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327287Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793659}
-
Josh Nohle authored
A NearbySharePrivateCertificate copy constructor will be necessary for testing. Change-Id: Ib82c7be478b6a27218e7fad13832da74db285fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330049 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#793658}
-
Jonathan Ross authored
This reverts commit 3bd0e5ef. Reason for revert: I incorrectly identified this as the cause of crbug.com/1111764 Original change's description: > Revert "vulkan: reuse gl semaphores" > > This reverts commit 5c8c9a69. > > Reason for revert: Two Vulkan angle_perftests have begun crashing consistently with this change in the blame range. Reverting to confirm if this is the cause. > > Otherwise there is also an Angle roll in the range. > > crbug.com/1111764 > > > Original change's description: > > vulkan: reuse gl semaphores > > > > For passthrough, with extension EGL_ANGLE_display_semaphore_share_group, > > semaphores are shared globally. > > For GLES2Decoder, all GL contexts are in the same shared group, so > > semaphores are also shared globally. > > So we can reused GL semaphores cross GL contexts. > > > > Bug: 1004772 > > Change-Id: I1d23cdc991b2e99d6fe70fdd0560c97dafe73e7c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319368 > > Commit-Queue: Peng Huang <penghuang@chromium.org> > > Reviewed-by: Jonathan Backer <backer@chromium.org> > > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#793398} > > TBR=penghuang@chromium.org,backer@chromium.org,vasilyt@chromium.org > > Change-Id: I63953b02f7f06a6e77a3266e3fc4eadee2f882f3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1004772 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332677 > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793591} TBR=penghuang@chromium.org,backer@chromium.org,jonross@chromium.org,vasilyt@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1004772 Change-Id: I06ccd88922ba2f7163fe553e86529fc550689a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332837Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#793657}
-
Numfor Mbiziwo-Tiapo authored
This change updates the existing putAll implementation to match the explainer more. It does not yet support the put-all-or-none behavior, but it does only return one request now. Design Doc: https://docs.google.com/document/d/1wawQ8Pl-Vi6GQN5-y2UVkcghipcOGg0WRAC0ZyBkezg/edit# Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1087927 Change-Id: I2c5e9d2d71801eaab3c1c9e94a3968afb8d109b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310110 Commit-Queue: Numfor Mbiziwo-tiapo <nums@google.com> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#793656}
-
Viktor Semeniuk authored
This change updates string according with the latest mocks. Bug: 1075494 Change-Id: Ief7e24cc8810895652ca893149370d36eb028c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332619Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/07ef703f1646..be774187b1ce 2020-07-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 08a3cc4cfbaa to aa5bd7657e6c (3 revisions) 2020-07-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 4400cab64b22 to 71573c7f64cb (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I39e17675a0262f30e79d1cda86dcf8bb6d6c1c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332551Reviewed-by:
-
Viviane Yang authored
This CL enables Push Subscriptions to support a expiration time, set by Chrome in push_messaging_constants.h (currently 90 days). This feature is disabled by default, so to try it out you must set --enable-features= PushSubscriptionWithExpirationTime. 3 BrowserTests are added to check the expiration time behaviour when the flag is set or not set. The expiration time is set in PushMessagingServiceImpl when a subscription is made and saved by PushMessagingAppIdentifier in the browser preference. The following CLs prepare for this change: 1. 2292292: [Push] Add expirationTime attribute to PushSubscription https://chromium-review.googlesource.com/c/chromium/src/+/2292292 2. 2302192: [Push] Pass expirationTime attribute from PushMessagingService to PushManager https://chromium-review.googlesource.com/c/chromium/src/+/2302192 3. 2315682: [Push] Add expiration time property in app identifier https://chromium-review.googlesource.com/c/chromium/src/+/2315682 Bug: 1104215 Change-Id: I341f05096fa57246fa18cb338a1a59f7a1ae01ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302610Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Viviane Yang <viviy@google.com> Cr-Commit-Position: refs/heads/master@{#793653}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bf47d2ef673b..de0ed93bda63 2020-07-31 mmortensen@google.com BuildAPI: Improve exception processing in service.UnmountPath. 2020-07-31 vapier@chromium.org licensing: add ustreamer to Google-TOS list 2020-07-31 tcwang@google.com toolchain: Cleanup tmp directory for artifact during prepare If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I3510835f6d40a8e56e78696925ca442749f9bd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331917Reviewed-by:
-
Himanshu Jaju authored
- Implements mutual accept alarm - Address other small TODOs Bug: 1085068 Change-Id: I1f13e2e766f12e29cb69dde291e8b8098207e0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332178Reviewed-by:
-
ckitagawa authored
Link rects were previously recorded in a naive way that failed to account for the overall transformation matrix that needs to be applied to the rect. This CL rectifies that behavior by relying on Annotations in the PaintOpBuffer and tracking transforms while walking the buffer. A similar fix for subframe rects might be needed (in a follow-up CL). Bug: 1110227 Change-Id: I73cca7e4e398d724731f091c68910066d7b91785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327251 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#793650}
-
Danil Chapovalov authored
To be more sure it is safe to use absl::variant in chromium Abseil already uses EXPECT_DEATH_IF_SUPPORTED instead of EXPECT_DEATH thus the only blocker for these test was already resolved. Bug: 1073011 Change-Id: I3103fd558253aa80d6e770bd2cbf29840a5f768c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332439Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#793649}
-
Alex Rudenko authored
When we position the labels using absolute coordinates we don't need to subtract the first track position for the subsequent track positions. Bug: 1106681 Change-Id: I0c6f11d9c9277d5911af3cc3ef642f6868e56827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332256 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#793648}
-
John Chen authored
Fix a typo that causes sizes.py to fail on Mac. Bug: 1097180 Change-Id: I5d375aa25d6fe9925b889bbd3ea7b061bd0f7473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330823 Auto-Submit: John Chen <johnchen@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#793647}
-
Tim Volodine authored
Flaky on Lollipop Phone Tester BUG=1111816 NOTRY=true TBR=skyostil@chromium.org Change-Id: Ia1176f4ec57495aaef0dfd107a494c940a533b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332621Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#793646}
-
Sean McAllister authored
This migrates is_linux (which is also set for chromeos) to explicitly include chromeos as is_linux || is_chromeos in preparation for separating those flags. Bug: 1110266 Change-Id: I51be3638dab55a4b2bc933a1bb48ace81be51761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326291Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#793645}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596185080-c872132dd1db16f5ff75ea8e09512987a9ceadc2.profdata to chrome-win32-master-1596192746-6fea58b93463f5fc9ccbb164a8054cb0a38af6db.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I1bdaff1048622448eaf6536769697276d3cae664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332553Reviewed-by:
-
Sebastien Marchand authored
This finishes the LocalDB migration to PerformanceManager. This migration has been done by copying the code and now that the migration is done it's also time to remove the previous version (it's hard to keep both versions at the same time and to then remove the old version in a later CL). Most of these files are owned by chrisha@, except for the following ones: wfh: chrome/browser/ui/webui/discards/site_data.mojom avi: chrome/browser/profiles/DEPS chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc chrome/browser/usb/usb_tab_helper_unittest.cc bcwhite: tools/metrics/histograms/histograms.xml Bug: 961336, 1089370, 1049469, 977554 Change-Id: Id11ea6204d402204dd1f36a013e54bb64e7973b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251747Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#793643}
-
Olivier Li authored
This CL introduces the "OptOutZeroTimeoutTimersFromThrottling" which disables all types of throttling for Javascript timers whose timeout is zero. Why is this needed? ------------------- A page may use setTimeout(..., 0) to post continuation tasks, which improves main thread responsiveness by breaking down a long task into multiple shorter tasks. For example, a page could receive a chat message in a XHR handler and play a sound to notify the user in a continuation task. If intensive throttling is enabled and all timer tasks are throttled, irrespective of their delay, the continuation task is delayed by up to 1 minute. If throttling is disabled when the timeout is zero, the continuation task can run immediately. This doesn't increase the number of idle wake ups, as the continuation task is posted and runs within the same wake up (almost - see https://crbug.com/402694). Implementation: --------------- The TaskType kJavascriptTimer is split into two TaskTypes: kJavascriptTimerDelayed and kJavascriptTimerImmediate. DOMTimer selects the appropriate TaskType depending on the timeout computed by the algorithm at https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html kJavascriptTimerDelayed is for timers with timeout > 0 (either because the argument is > 0 or the nesting level > 5) kJavascriptTimerImmediate is for timers with timeout == 0 (the argument is <= 0 and the nesting level is <= 5) FrameSchedulerImpl uses the "can be throttled" queue trait when selecting a TaskQueue for kJavascriptTimerDelayed, but not when selecting a TaskQueue for kJavascriptTimerImmediate. Alternative implementation: --------------------------- It is possible to implement this without introducing a new TaskType, by having a TaskRunner that selects the TaskQueue at post time depending on the delay. However, this means that the assumption that there is a 1:1 mapping between TaskType and TaskQueue is broken (what should FrameSchedulerImpl::GetTaskQueue(TaskType::kJavascriptTaskRunner) return?). Also, DOMTimer currently rounds up a 0ms delay to 1ms, making it harder for the TaskRunner to determine whether a task is immediate or not. See alternative implementation: http://crrev.com/c/2304155. Bug: 1075553 Change-Id: I6e61b535f7377755ed002b69e6a93dabd6c6e795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305111 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793642}
-
Changwan Ryu authored
This helps debug ProxyView behavior by providng more detailed information about window focus. Bug: 1108237 Change-Id: Ibcbdf7e0751b78d9cd0d52f1abf2edcc4bd23849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332036Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/03677716c86d..3186e69eb799 2020-07-31 jacktfranklin@chromium.org Component bridges: export the generated class 2020-07-31 pfaffe@chromium.org [eslint] Ensure that linting doesn't crash on a custom it.skip 2020-07-31 sadym@chromium.org Allow simulating Idle Detection in the Sensors tab 2020-07-31 janscheffler@chromium.org Migrate `front_end/changes` to `devtools_entrypoint` 2020-07-31 petermarshall@chromium.org tests: Use source maps for better error output for e2e tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1090802,chromium:1101738,chromium:1104096 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie63690a06288e08e8955545cecdfe10e7e2c50f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332555Reviewed-by:
-
Richard Knoll authored
This implements success and failure notifications and adds the optional token to connection request notifications. Bug: 1102348 Change-Id: Ie2509d23f399a9a905a79100732697b3608563ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327490 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
-
Hans Wennborg authored
LLD will sort the binary section based on a call-graph profile when such profile information is available in the object files. Since the last Clang roll, that information gets written to the object files when building with a profile (as is done on Android). Since call-graph sorting leads to larger binaries on Android, and we already have good section order files there, tell the linker to disable it. Bug: 1110413, 1107461 Change-Id: I4f37c57dd65437c4269b0e216f64102ae233aeeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332398Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#793638}
-
