- 23 Jul, 2019 40 commits
-
-
Jeffrey Cohen authored
Bug: 985972 Change-Id: Ic1455724636fadb0374fd43bb4e5ae8907315481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713239Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#680010}
-
Huanzhong Huang authored
Current implementation of the cache counter has a stability issue that might crash the app due to certain timing of events. This is an attempt to fix the issue. Bug: 963006 Change-Id: I9da00ee138196286863a51d6d695c5434aa6f69a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698540Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#680009}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5207f35f33b1..21a940d42fee git log 5207f35f33b1..21a940d42fee --date=short --no-merges --format='%ad %ae %s' 2019-07-23 reed@google.com refactor paragraph samples 2019-07-23 bsalomon@google.com Add driver workaround to avoid noperspective on QC with ver 3.1 or earlier 2019-07-23 reed@google.com remove default looper flag, rely on clients to opt-in 2019-07-23 fmalita@chromium.org [sksg] Fix setVisible() invalidation 2019-07-23 bsalomon@google.com Lift GrRenderTargetContext::rescale to GrSufaceContext 2019-07-23 brianosman@google.com Fix a couple potential bugs when adding sampler info to a program key 2019-07-23 bsalomon@google.com Remove sample count from GrSurfaceDesc. Created with: gclient setdep -r src/third_party/skia@21a940d42fee The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: chromium:986581 Change-Id: I32b65bc06ee0b851fbd1e404b7c2cd201d73f7c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714918Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680008}
-
Mario Sanchez Prada authored
This class is now only used from blink::SurroundingTextImpl, so we can move it down into renderer/core/editing and remove it from the public API. Also, make the most of this move to make the new blink::SurroundingText class use internal Blink types (i.e. WTF::String, LocalFrame) instead of the public Web* types (i.e. WebString, WebLocalFrame), which will allow migrating blink::EditingImpl away from WebLocalFrame on a follow-up CL. Bug: 980151, 919392 Change-Id: I2a6ba1aa9e00603d40b4ccb9acb69f46baf5931b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699608 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#680007}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/12c06467..a2f0a34a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib1196a951e44b3f9e93501e02a66dfdbe51d22d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713152Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680006}
-
Leonard Grey authored
Bug: 969105 Change-Id: I01ac278560bb29b708fa79927a0bb026d8a34d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709782Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#680005}
-
John Delaney authored
This CL adds the PeakWindowedUsage metric to AdFrameLoad UKM. This can be used alongside the existing CpuTime metrics to better determine the type of ads with high CPU usage. Bug: 978030 Change-Id: I4175c87d149003b040260a837c2a5de3e2ca1633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653390Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#680004}
-
Jihwan Marc Kim authored
No longer pursuing an intervention with the 1050 KB threshold. Remove the associated metrics and code. Bug: 962616 Change-Id: Id4e199dfc398b10121d4bbcea3102e94d0af4a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686971Reviewed-by:
-
Joe Mason authored
timeSinceLastEngagement_shouldReportElapsedTimeBetweenTimestamps gets the current time twice. If the system time ticks over between calls it will register 1 ms more than the test expects. R=yusufo@chromium.org Bug: 947572 Change-Id: Ic5b1bcda2300e217b66567ba54a9ccaa5e515374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708844 Auto-Submit: Joe Mason <joenotcharles@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#680002}
-
Egor Pasko authored
While reworking ChromiumAndroidLinker.{BrowserStates,RendererStates} I noticed that "RelinkerFallbackCount" is not recorded in renderers. This is also observable on the UMA dashboard: for my time interval I see these sample counts: ChromiumAndroidLinker.RendererLoadTime: N samples ChromiumAndroidLinker.BrowserLoadTime: (0.8 * N) samples ChromiumAndroidLinker.RelinkerFallbackCount: only about N samples, but expected to be closer to 2 * N. I *think* that "RelinkerFallbackCount" is the only renderer-side histogram that is recorded with CachedMetrics currently, and in my rough testing this change helps recording more samples. Removing this histogram to re-introduce it as part of another metric. Tests TBD as part of another change where the new histogram is introduced. There is a way to call commitCachedMetrics() for the browser process as well, but I'd like to postpone it now because it may significantly affect a number of metrics (see https://crbug.com/986796). Bug: 981599 Change-Id: I69799f96278fe5c6ea8661055aa153a8b7f4fb46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713535Reviewed-by:Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#680001}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/50d644e41333..0ecadc16190a Created with: gclient setdep -r src-internal@0ecadc16190a The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: If8e8b0ca29321b378ab6a9c81371fd08374e58c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714917Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680000}
-
Yoshifumi Inoue authored
This patch makes |LayoutText::GetTextBoxInfo()| to handle truncated text, e.g. "overflow-x: hidden", by using "hidden-for-paint" fragments[1]. Before this patch, we attempt to handle ellipsis character as part of DOM text then we produce wrong value or crash. [1] http://crrev.com/c/1678915 [LayoutNG] Keep truncated fragments for `text-overflow: ellipsis` Bug: 985488 Change-Id: If0287a6dd6db8f8b9022bedd5ef8d207db524f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714394 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#679999}
-
Friedrich Horschig authored
Currently, we hide the autofill UI when the focused field was cleared. For the Autofill popup, hiding is correct. For the keyboard accessory, there is no additional UI that would pop up so we want to show all suggestions again. Bug: 942492 Change-Id: Ia8507e8e6cfb4e93dff69e9c967a74218e691184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713517Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#679998}
-
Miyoung Shin authored
This CL replaces all ::identity namespace with ::signin namespace in //components/signin and updates all related codes. TBR=jochen@chromium.org Bug: 984884 Change-Id: I14a74f2288b0eee1c039881596461558bd27e4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712045 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#679997}
-
Thomas Tangl authored
The session duration is tracked and recorded per profile. The duration is recorded when one of the following events happens: - The user switches to a browser of another profile. - The browser is inactive for a while. Bug: 965469 Change-Id: Ieb7a5fc7047060f4c525557a184122d87b5ca98a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679705Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#679996}
-
Rune Lillesveen authored
Left-over from [1] which no longer makes sense since the layout parent is already ensured by either being the same as the parent or through the parent recursively ensuring it. Also remove incorrect comment about computing style for disconnected elements. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1464580 Change-Id: I1f25f1af8b4853ba964e0e60b90cdf04ea12ecb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714598Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#679995}
-
Michael van Ouwerkerk authored
Bug: 974816 Change-Id: Ic5ca3b0f2838fe81100f2e9e45230e5277f46b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710567 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
-
Sky Malice authored
Change-Id: I1fcece3836ecd23f162ec8ea1cb87f40a5ab4d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709731Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c53c2f80508e..5f008e96a17f git log c53c2f80508e..5f008e96a17f --date=short --no-merges --format='%ad %ae %s' 2019-07-23 treehugger-gerrit@google.com Merge "perfetto-ui: Fix record page" 2019-07-23 fmayer@google.com Merge "Remove go link." Created with: gclient setdep -r src/third_party/perfetto@5f008e96a17f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I3a6a278839389f4cd8f3ca7e27bd29046b3334aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714338Reviewed-by:
-
Robbie Gibson authored
Before, when compiling with iOS 12, but running with iOS 13, nothing ended up running in these cases. Now, in this case, we fall back to the iOS 12 logic. Bug: 976681, 976666 Change-Id: If659155521ff2d8a13320aa2174e78e35476593a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712875 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
danakj authored
The WebLayerTreeView is a shortcut past the WebWidgetClient that is not needed now that we always composite. This works toward eliminating this extra API layer. More importantly this helps us Close/Restart the WebWidget parts of WebViewImpl by not requiring plumbing 2 pointers with slightly different lifetimes (WebLayerTreeView is created inside the Init of the WebWidgetClient). This will help avoid a bunch of complexity in creating WebFrameWidgets and other WebWidgets. Also stop making round-trips through WebViewImpl->DevToolsEmulator->WebViewImpl and just have DevToolsEmulator return the value WebViewImpl wants to use for its emulation transform. And clean up some some TODOs/comments/DCHECKs around MainFrameImpl() because devtools emulation only works for the main frame, but it should be working in WebViews without a local main frame, and emulating in all local root frames, across all frame trees, equally. Make the private APIs of WebViewImpl and DevToolsEmulator actually private. Have tests go through EnableDeviceEmulation() instead of short-cutting. R=dcheng@chromium.org Bug: 912193 Change-Id: I0ff7bdefeeb9970eaa9981a023352e7ebb532ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713297Reviewed-by:
-
Javier Ernesto Flores Robles authored
Update background color of LaunchScreen.xib with a dynamic color, which supports dark mode. Xcode modified some other values when opening the file, these changes are neglectable. Bug: 976640 Change-Id: I09899dc098d333ffcc59f03c0b4bd5454ad96e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713511Reviewed-by:
-
Pâris Meuleman authored
This reverts commit 454a3530. Reason for revert: As we are going towards layering into AuthenticationService instead of componentization of SigninManager.java, there is no need to remove the dependency on UiThreadTaskTraits anymore. Design doc regarding the new code structure: https://docs.google.com/document/d/171FRUtA_FlU2ZIReQL8cZuZwAeBk0wHymN2w2h01eso/edit?usp=sharing Original change's description: > Use ThreadUtils.postOnUiThread in SigninManager.java > > Use ThreadUtils instead of PostTask and UiThreadTaskTraits. Remove > content_public dependency. Enabling the componentization of > SigninManager. As agreed with ksolt@, see crbug.com/981470. Change was > originally introduced in: crrev.com/c/1432841. Follow up migration will > be to return to PostTask, but using current thread traits. It is an > ongoing work for Ksolt@: crrev.com/c/1645836, crbug.com/981470. > > Bug: 981470, 963408 > Change-Id: Ia7a0fa54fd022182c973230e3356671c90bbb655 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687244 > Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#675187} TBR=sdefresne@chromium.org,bsazonov@chromium.org,pmeuleman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 981470, 963408 Change-Id: Iacff2103b5d3c0353b650fabb9a97d72e95f7ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708072 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#679988}
-
Kai Ninomiya authored
Bug: 985608 Change-Id: I5f46486511ce60fda2d34a962f115069eb2b4191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711097Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#679987}
-
Anders Hartvoll Ruud authored
According to a recent spec change, the syntax of a registered custom property must be ignored until computed-value time. This means that CSS.supports must treat all custom properties as unregistered. This effectively reverts 9646ae2d (except the test). Bug: 641877 Change-Id: I6d24fc23534636b88167121b73b28455f563d501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713508Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#679986}
-
Jamie Madill authored
conformance/textures/image_bitmap_from_video/tex-2d-rgba-rgba-unsigned_short_5_5_5_1.html conformance/textures/misc/texture-corner-case-videos.html Bug: 986808 Tbr: ynovikov@chromium.org Change-Id: I0d6733208b9edac595c374f46b65d123c124370d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714946Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#679985}
-
Tanmoy Mollik authored
For accounts that have sync disabled by enterprise policy syncing option should not be available. For those accounts show the message "Sync is disabled by your administrator" Screenshot: https://crbug.com/933649#c20, https://crbug.com/933649#c27 Bug: 933649 Change-Id: I199d81b0c315ccc9773fe4d9629f1ed0d53dd075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695311 Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Reviewed-by:
-
Ben Kirchman authored
FakeCronetController is used to create fake CronetEngines and control responses to UrlRequests that the fake CronetEngine makes. Primarily, the test should instantiate a FakeCronetController and from that instance generate CronetEngine.Builders which will use their FakeCronetController for responses once they are built. The FakeCronetController can also be used statically to retrieve a FakeCrontroller that is created by the production code, such as via FakeCronetProvider. To do this, it maintains a static list of all fake CronetEngines in order of creation. This list can be retrieved and the desired CronetEngine can be passed back to the FakeCronetController's static method getControllerForFakeEngine() in order for the test to get a pointer to the controller for it's production code's CronetEngine. It should be noted that a CronetEngine.Builder can build multiple fake CronetEngines which will all point to the same controller. This is also true for multiple calls of getFakeCronetEngineBuilder: the created CronetEngines will all use the same controller. Design Doc: https://docs.google.com/document/d/1IsBwiqR5f6ksvmHPq5skV802C02We8zjK-c552Tp4lE/edit#heading=h.7nki9mck5t64 Bug: 669707 Change-Id: I8955a97e4a4a6dd8040b5b30fea3c5cbeae30221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701534 Commit-Queue: Benjamin Kirchman <kirchman@google.com> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#679983}
-
François Beaufort authored
Following WebGPU spec change at https://github.com/gpuweb/gpuweb/issues/326, the GPUFenceDescriptor parameter from GPUQueue.createFence() should be optional. Bug: 877147 Change-Id: Icee75ccfb21449041254506c3560a86aa67f9437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713555 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#679982}
-
Mario Sanchez Prada authored
Move this method from the content.mojom.Frame Mojo interface into Blink, as part of a new blink.mojom.SurroundingText Mojo interface, and add a new class there to implement such interface (i.e. blink::SurroundingTextImpl), to replace usages of content.mojom.Frame's GetTextSurroundingSelection() from the browser process. Note that this SurroundingTextImpl class still relies on WebSurroundingText and WebLocalFrame to keep the change smaller, but this is a temporary step that will be corrected once WebSurroundingText has been moved out of the public API and into renderer/core, which will happen on a follow-up CL. Bug: 980151 Change-Id: I62fb2d5b24a98773c1acddbe1c58217c1a2d53e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696968 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
-
Mike Dougherty authored
Xcode parallelization may be causing clearBrowsingData test failures. Disable it for now to comare test runs. Example failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8907218548939539872/+/steps/ios_chrome_ui_egtests__iPhone_X_iOS_13.0__shard_2__with_patch__on_Mac-10.14.4/0/logs/SigninInteractionControllerTestCase__x2f_testSignInCancelIdentityPicker/0 Change-Id: I253ec52254dc259f90768c5556f3b547eb1b5ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710006 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/85ef3eab9407..61689ab0630a git log 85ef3eab9407..61689ab0630a --date=short --no-merges --format='%ad %ae %s' 2019-07-23 mbonadei@webrtc.org Make api/video:encoded_image public. 2019-07-23 titovartem@google.com Improve low bandwidth audio test instrumentatin, fix PC test Created with: gclient setdep -r src/third_party/webrtc@61689ab0630a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ie0b81d336b4eaa6152d1577edf4c9806bad1b88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714337Reviewed-by:
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. First, it changes the parameter of ExtractCredentials() to PO2TS from O2TS and moves O2TSDelegate and FakeOAuth2TokenServiceDelegate to components/signin/internal/identity_manager along with PO2TS. And it makes separate LoadCredentialsState from O2TSDelegate to components/signin/public/identity_manager/credential_state.h to expose it to AboutSigninInternals. Last, it moves GetDelegate() to PO2TS and cleans up O2TS. Bug: 967598 Change-Id: I36ad430ee9405ec30d4e5fe41e2ffc1df6e7ac9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712560 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Andrew Grieve authored
As suggested by r8 team. Bug: 985372 Change-Id: I2ca93568d06800a7bf82476ef0ca106492084fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711251Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#679977}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fc854c30fb5c..5207f35f33b1 git log fc854c30fb5c..5207f35f33b1 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 jlavrova@google.com The current version... Created with: gclient setdep -r src/third_party/skia@5207f35f33b1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: I9760e9888d98f908740142dbfd53e57eae962b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714336Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 475fb228. Reason for revert: It may cause test failures (not sure about dependence). Build: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/78019 [1676:8220:0723/051724.438:FATAL:feature_list.cc(396)] Check failed: field_trial_list_ == FieldTrialList::GetInstance() (1F64EEE0 vs. 1F64EAA0) Backtrace: base::debug::CollectStackTrace [0x6F1004CC+60] (o:\base\debug\stack_trace_win.cc:284) base::debug::StackTrace::StackTrace [0x6F0FF56E+78] (o:\base\debug\stack_trace.cc:206) base::debug::StackTrace::StackTrace [0x6F0FF4E2+34] (o:\base\debug\stack_trace.cc:203) logging::LogMessage::~LogMessage [0x6F14E994+132] (o:\base\logging.cc:625) base::FeatureList::GetFeatureOverridesImpl [0x6F107588+408] (o:\base\feature_list.cc:396) base::FeatureList::GetCommandLineFeatureOverrides [0x6F1077C4+52] (o:\base\feature_list.cc:197) base::FieldTrialList::CopyFieldTrialStateToFlags [0x6F183561+273] (o:\base\metrics\field_trial.cc:896) content::BrowserChildProcessHostImpl::CopyFeatureAndFieldTrialFlags [0x5F687066+54] (o:\content\browser\browser_child_process_host_impl.cc:215) content::UtilityProcessHost::StartProcess [0x60B50B06+1222] (o:\content\browser\utility_process_host.cc:365) content::UtilityProcessHost::Start [0x60B5139F+15] (o:\content\browser\utility_process_host.cc:260) content::`anonymous namespace'::ContentChildServiceProcessHost::Launch [0x607FAB47+919] (o:\content\browser\service_manager\service_manager_context.cc:209) service_manager::ServiceInstance::StartWithProcessHost [0x612FB5E5+1029] (o:\services\service_manager\service_instance.cc:263) service_manager::ServiceManager::FindOrCreateMatchingTargetInstance [0x6131D62F+2895] (o:\services\service_manager\service_manager.cc:312) service_manager::ServiceInstance::BindInterface [0x612FDB0A+282] (o:\services\service_manager\service_instance.cc:482) Original change's description: > Move histogram(_test).[cc|h] to platform/instrumentation > > They're much better placed there than directly under platform/ > > Bug: 919385 > Change-Id: I9583741da31e28217a9f331322ca8246984b94eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713190 > Commit-Queue: Sergio Villar <svillar@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#679926} TBR=svillar@igalia.com,haraken@chromium.org,mkwst@chromium.org Change-Id: I78428e66cc8bb69c35459af7f3b206b943db3cb6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713518Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#679975}
-
Sergey Ulanov authored
Previously Viz ran in-process when Vulkan is disabled. Now it will always run in GPU process. This makes it more consistent with other platforms and the way Fuchsia will work in the future. Also reverted crrev.com/678470 since it's no longer needed. Bug: 962617 Change-Id: I8ba03b0ab8b7707f81ee3bba59eddb12a11015b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711050Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#679974}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It moves to kInvalidRefreshToken from OAuthTokenServiceDelegate to GaiaConstants not to include oauth2_token_service_delegate.h from AccountManager. Bug: 967598 Change-Id: I22542afd976a66e4137b14fd63a3dc7ae98e67f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712425Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e1edd548c20f..ec869c11c79d git log e1edd548c20f..ec869c11c79d --date=short --no-merges --format='%ad %ae %s' 2019-07-23 saklein@chromium.org board_build_dependency: Simplify naming. Created with: gclient setdep -r src/third_party/chromite@ec869c11c79d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia440b51bdaae2ec04cc73cfcdfc8e9e556f5e6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714334Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e22412aeb9a3..50d644e41333 Created with: gclient setdep -r src-internal@50d644e41333 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Change-Id: I4bc035c81f3b98ec737d44ca48a1f1e74eb3f84f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714133Reviewed-by:
-
