GitLab

This fixes a bug of https://chromium-review.googlesource.com/c/chromium/src/+/2418631

Bug: 998048
Change-Id: Iffb7b291d3e0689781e5dea7d011e74b68f186bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437668
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812640}

This CL adds a vector of pending fetchers that enable handling parallel requests.
It uses a new struct FetchInfo to group together the fetcher, dedicated  callback and requested origins, which facilitates processing each response.


Bug: 1117045
Change-Id: I0f7529d02266f2cc20e8e0e4f4c77638483ce1b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436329
Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812639}

This CL moves:

- TRACE_EVENT
- v8::TryCatch and related exception handling
- RethrowErrorsOption

from ScriptController/WorkerOrWorkletScriptController
to V8ScriptRunner.

This CL doesn't change the behavior.

Bug: 1111134, 1129743
Change-Id: I62db5643acdf362a44420e7cf5694839bca4c4a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351605
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812638}

A follow-up to crrev.com/c/2440869, now going through non-capitalized
occurrences of 'directory' as well. They are all at least capitalized so
they are easy to find. In the process some dead code is found and
removed.

Occurrences in code that will soon be removed (mostly crbug.com/1102849)
are left untouched.

[1] https://source.chromium.org/search?q=f:(components%7Cchrome).*sync%2F%20directory%20-f:%5Eout&sq=&ss=chromium%2Fchromium%2Fsrc

Bug: None
Change-Id: I86e94baae1e7547a24f5d8743ccf3f00d8d3127c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440601Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#812637}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
TBR=chrome-os-gardeners@google.com

Change-Id: Ia81c857c40ee9b486ceabff14ba43347fc24c2ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442591Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812636}

ComputeBlockSizeForFragment does not take a fixed block size into account,
so ComputeInlineSizeFromAspectRatio needs to check for it separately.

R=ikilpatrick@chromium.org, mstensho@chromium.org

Bug: 1045668
Change-Id: I7c3548881f8139681de7c8f1dcaf47cf2924a519
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441067
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812635}

...PAGE_TRANSITION_LINK. The WellKnownChangePasswordTabHelper should
only be active if triggered from within the PasswordCheck, which has
a ui::PageTransition of PAGE_TRANSITION_TYPED.

Fixed: 1133795
Change-Id: I2d66be7c7236a050c8532835f401a94cd94d4b0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440892Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812634}

This is a trivial follow-up to the patch that had been landed in August
[1].  It turned out that the new parameter that had been introduced with
that patch had not been registered properly in the IPC parameter traits,
so its value is not transported properly.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2307234

Change-Id: Idd45ac735c4dd952d4e4a2587175ee6dd5246a4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438498
Auto-Submit: Alexander Dunaev <adunaev@igalia.com>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812633}

DevTools frontend CL: https://crrev.com/c/2438385

Bug: chromium:1133675
Change-Id: I47220215232540c94733bec2ceb64e40c1021d12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440664Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812632}

This is to make the use of HeaderView consistent between
browser and non browser windows.

Bug: 1126857
Change-Id: I453ae3c063e93276f6ec9da0aae05244d5e28ed5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363504
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812631}

Add CreateTextControlInnerEditor(), CreateTextControlMultiLine(),
CreateTextControlSingleLine() to blink::LayoutObjectFactory so that we
can switch text control's LayoutObject to LayoutNGTextContorl*.

- Change the constructor arguments of LayoutTextControl*Line to
|Element*|. It's a requirement of LayoutObjectFactory.

This CL has no behavior changes because their LegacyLayout arguments
are always kForce.

Bug: 1040826
Change-Id: I5960d5c9163c1c975a3ddc195dad177ae9380a23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440000
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812630}

This reverts commit 0cac1ce3.

Reason for revert: it brakes viz_unittests, see crbug.com/1134091

Original change's description:
> Roll Skia from c73bff39bd21 to a87c5076a876 (21 revisions)
>
> https://skia.googlesource.com/skia.git/+log/c73bff39bd21..a87c5076a876
>
> 2020-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 44be0942f9a8 to b042f4e70879 (15 revisions)
> 2020-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from b2a4e87ad274 to ad421a248adb (2 revisions)
> 2020-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 339e4ec2 to cc47e0cd (351 revisions)
> 2020-09-30 johnstiles@google.com Allow more types of expressions to be directly inlined.
> 2020-09-30 ethannicholas@google.com Revert "Revert "moved SkSL Enum data into IRNode""
> 2020-09-29 robertphillips@google.com Make GrRRectBlurEffect use the thread-safe uniquely-keyed view cache
> 2020-09-29 kjlubick@google.com [canvaskit] Add Initial Typescript definitions/types.
> 2020-09-29 ethannicholas@google.com moved SkSL ExpressionStatement's data into IRNode
> 2020-09-29 robertphillips@google.com Make the SW blurred mask path use the thread-safe uniquely-keyed view cache
> 2020-09-29 johnstiles@google.com Revert "moved SkSL Enum data into IRNode"
> 2020-09-29 ethannicholas@google.com moved SkSL Enum data into IRNode
> 2020-09-29 brianosman@google.com Fix swizzle-of-swizzle lvalues in ByteCodeGenerator
> 2020-09-29 brianosman@google.com Add a benchmark that measures SkSL::Compiler startup time
> 2020-09-29 jsimmons@google.com Add an API for clearing the SkParagraph font and paragraph caches
> 2020-09-29 ethannicholas@google.com moved SkSL Constructor's data into IRNode
> 2020-09-29 robertphillips@google.com Have GrCircleBlurFragmentProcessor make use of thread safe view cache
> 2020-09-29 bsalomon@google.com Add sample count to GrVkImageInfo.
> 2020-09-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2a09e89113af to ec42b1438fd2 (63 revisions)
> 2020-09-29 herb@google.com minimize includes and forwards for remote glyph cache
> 2020-09-29 ethannicholas@google.com moved SkSL FloatLiteral data into IRNode
> 2020-09-29 jvanverth@google.com Move MacOS 10.13 Metal jobs to 10.15.
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/skia-autoroll
> Please CC brianosman@google.com on the revert to ensure that a human
> is aware of the problem.
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
>
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Cq-Do-Not-Cancel-Tryjobs: true
> Bug: chromium:1018739,chromium:1096746,chromium:1108408,chromium:1130678,chromium:1132366
> Tbr: brianosman@google.com
> Test: Test: Test:Test: Test: CQTest: Test: ContextNoErrorTest31.DrawWithPPOTest: Test: Manual verification of Skia 'gn gen' on WindowsTest: Test: ProgramPipelineTest31.VerifyPpoLinkErrorSignalledCorrectlyTest: Test: angle_end2end_test --gtest_filter=*ETC1CompressedImageNPOT*Test: Test: angle_end2end_tests --gtest_filter=*ETC1CompressedImageDraws*Test: Test: dEQP.GLES31/functional_separate_shader_validation_es31_*
> Change-Id: I944383c547ca321da3fd774ca61e7e085537b6e1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439391
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#811984}

TBR=brianosman@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com

Change-Id: If6cedf659b6405fea9f4cdf435e5d0b8881ed2da
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1018739
Bug: chromium:1096746
Bug: chromium:1108408
Bug: chromium:1130678
Bug: chromium:1132366
Bug: chromium:1134091
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442729Reviewed-by: Michael Ershov <miersh@google.com>
Commit-Queue: Michael Ershov <miersh@google.com>
Auto-Submit: Michael Ershov <miersh@google.com>
Cr-Commit-Position: refs/heads/master@{#812629}

We currently have a bug where :is/:where/:-webkit-any(.a, div)
doesn't cause 'div' to enter the type rule invalidation set.
This CL fixes that bug by tracking the emitted tag names separately.
The idea is that you can look at the features returned from
UpdateInvalidationSetsForComplex, and if has_features_for_rule_-
set_invalidation is false, then the (regular) tag names are the ones
that need to be added to the type rule invalidation set, and the
emitted tag names can be ignored.

It was necessary to change how has_features_for_rule_set_invalidation
is set during feature extraction. We currently set this to true if
we have _any_ id/class/attribute feature after list extraction, but
this means we consider :is(.a, div) to have features for type rule
purposes, so that doesn't work. This CL changes that such that all
selectors in the nested list need to have features for the flag to
be set for the outer selector.

Bug: 568705
Change-Id: Ibbfa8166a1bbb27d7e90f48f44bfe7bc9c6e6851
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433928
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812628}

https://webrtc.googlesource.com/src.git/+log/e39b378d4a92..59f1d1e36d26

2020-09-30 alessiob@webrtc.org AGC2 adaptive digital controller config: new params
2020-09-30 alessiob@webrtc.org AGC2 adaptive digital controller config: new param
2020-09-30 alessiob@webrtc.org AGC2: gain increase allowed once enough adjacent speech frames observed
2020-09-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f9788a96..97f841d7 (811959:812293)
2020-09-30 mbonadei@webrtc.org Revert "Reduce the amount of howling reduction in AEC3"
2020-09-30 hta@webrtc.org Add a test for transceivers being removed when stopped.
2020-09-30 peah@webrtc.org Revert "Activating AVX2 support by default"
2020-09-30 peah@webrtc.org Reduce the amount of howling reduction in AEC3
2020-09-30 handellm@webrtc.org Mutex: remove mutex reentrancy crasher.
2020-09-30 gustaf@webrtc.org Remove unused enums and members
2020-09-30 alessiob@webrtc.org AGC2 Saturation Protector always on
2020-09-30 nisse@webrtc.org Delete stringize macros.
2020-09-30 peah@webrtc.org Revert "Clean up the AVX2 activation in the gni file"
2020-09-30 peah@webrtc.org Revert "Deactivating AVX2 support by default"
2020-09-30 alessiob@webrtc.org AGC2 AdaptiveDigitalGainApplier and AdaptiveAgc code improvements
2020-09-30 alessiob@webrtc.org AGC2 AdaptiveModeLevelEstimator min consecutive speech frames (3/3)
2020-09-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 01b26f76..f9788a96 (811724:811959)
2020-09-30 mbonadei@webrtc.org Revert "Begin implementing WGC CaptureFrame"
2020-09-30 alessiob@webrtc.org AGC2 AdaptiveModeLevelEstimator: minor code improvements
2020-09-30 mbonadei@webrtc.org Introduce RTC_NO_UNIQUE_ADDRESS.
2020-09-30 yunz@fb.com Don't trigger key frame when encoder is not reset during reconfigure
2020-09-30 kwiberg@webrtc.org Optimize RoboCaller::AddReceiver() for code size
2020-09-30 philipp.hancke@googlemail.com android: add rollback RTCSdpType
2020-09-29 henrik.lundin@webrtc.org Improve neteq_rtp_fuzzer
2020-09-29 perkj@webrtc.org Ensure FakeVp8Encoder::GetEncoderInfo() writes EncoderInfo.fps_allocation:
2020-09-29 auorion@microsoft.com Begin implementing WGC CaptureFrame
2020-09-29 philipp.hancke@googlemail.com red: ensure minimum amount of header bytes
2020-09-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 82e79a8a..01b26f76 (811607:811724)
2020-09-29 alessiob@webrtc.org AGC2 AdaptiveModeLevelEstimator: cache last level estimate
2020-09-29 jleconte@webrtc.org Create isolated output directory when creating the output file.
2020-09-29 hta@webrtc.org Break out separate compile targets for various classes
2020-09-29 titovartem@google.com Report sent_packets_queue_wait_time_us in PC level framework network debug mode
2020-09-29 titovartem@google.com Improve perf metrics plotter
2020-09-29 sprang@webrtc.org Default-enables WebRTC-DeferredFecGeneration.
2020-09-29 peah@webrtc.org Deactivating AVX2 support by default
2020-09-29 alessiob@webrtc.org AGC2 remove incorrect field trial parsing functions
2020-09-29 hta@webrtc.org Factor out the transceiver list into a separate object.
2020-09-29 tommi@webrtc.org Remove locks from BufferQueue (not needed).
2020-09-29 sprang@webrtc.org Deferred FEC: Prevents duplicate FEC addition of non-RTX retransmission.
2020-09-29 alessiob@webrtc.org AGC2 AdaptiveModeLevelEstimator min consecutive speech frames (2/3)
2020-09-29 ilnik@webrtc.org Add NV12 to libvpx wrappers output
2020-09-29 nisse@webrtc.org Delete macros RTC_DISALLOW_ASSIGN and RTC_DISALLOW_IMPLICIT_CONSTRUCTORS
2020-09-29 gustaf@webrtc.org Remove echo suppression in transparent mode
2020-09-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8276edf4..82e79a8a (811503:811607)
2020-09-29 nisse@webrtc.org Delete unused header file sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec+Private.h
2020-09-29 eshr@google.com Accept NV12 frames into VP9
2020-09-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5db2d14d..8276edf4 (811347:811503)
2020-09-28 natim@webrtc.org Start/stop ProcessThread as first/last audio channel is added/removed.
2020-09-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3274067a..5db2d14d (811217:811347)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:980879
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I6c6ff15eb7379088c467c8b3248780910ccd09a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440992Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812627}

This CL changes HIDCollectionInfo, HIDReportInfo, and HIDReportItem
interfaces to dictionaries for easier logging with JSON and to avoid
polluting the window web namespace.

Spec: https://github.com/WICG/webhid/issues/22
Test: https://webhid-collections.glitch.me/

Change-Id: Ife8d089505312bba9f42e5d8fb1c466f44bd8e45
Bug: 890096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398541Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#812626}

This CL adds metrics about passwords weakness check.

Bug: 1119752
Change-Id: I20ff20dde480c84ebd5d252ce7684cecc4fc4c87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434336
Commit-Queue: Irina Fedorova <irfedorova@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812625}

Split the behavior of left/right from up/down when focused on
thumbnails. The behavior of up/down stay the same, and they will only
change the focus to an adjacent thumbnail when pressed.

Left/right when focused on a thumbnail now also change the page of the
contents, regardless of the presence of a horizontal zoom bar on the
contents.

Additionally, when the page of the contents change while focused on a
thumbnail, the focus is forwarded to the thumbnail of the new most
visible page.

Bug: 652400
Change-Id: I4da7caadbf6eb25899f8f4091047727b3d719daa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438984Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812624}

Create and make available mojo interface for chrome://.

Add implementation in chrome://.

Add implementation in chrome-untrusted://.

Add implementation for cros_healthd fake onLidOpened event emitter.

Add browser test for lid event listener.

Bug: b:167523716
Change-Id: I4281778d451264f57154913330d8cd5ba83cb4f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389981Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Laurențiu Olteanu <lolteanu@google.com>
Cr-Commit-Position: refs/heads/master@{#812623}

Bug: 1132230
Change-Id: Ibae4da2522b4df619ad0848217cf3382b35c81f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438454
Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812622}

When Referrer-Policy is `origin`, we should expect the URL in the
Referer header to be document's origin with a trailing '/', see
https://w3c.github.io/webappsec-referrer-policy/#referrer-policy-origin

Change-Id: I720dbf0892701b380aebab8d7b8c4aa55098c88c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438423Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812621}

The test is to check |NeedsLayout| when outline is applied,
but the current test may set |NeedsLayout| because it changes
a culled inline box to a non-culled inline box.

This patch changes the test to make sure the inline box is
not culled before applying the outline.

This patch does not fix the issue, but makes sure to change
the test result when we fix this problem for outline.

Bug: 1128199
Change-Id: I92262fa77d29b239c23362cf10edbb9da51382dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442395
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812620}

This turns out to have been added in error, as while the mouse does have
key codes in its descriptor, it doesn't have the set of common keys (ESC
to D) that would cause it to be identified as a keyboard. Because the
product ID 0xC534 is shared by the Logitech MK240 Nano keyboard, this
mistake was causing the virtual keyboard to pop up when it shouldn't
have.

Bug: 1130254
Test: none
Change-Id: I6ef3f168c3caf0776d9df02d1269f9898e7ee706
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440969
Auto-Submit: Harry Cutts <hcutts@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812619}

Subresource filter navigation throttle creation is currently distributed
between //chrome and //components. This CL moves the //chrome-level
logic into the //components-level logic in anticipation of reusing this
logic in WebLayer's subresource filter bringup. Without this change,
this logic would need to be duplicated unnecessarily in //weblayer.

As part of this change, I add a SubresourceFilterClient method to get
the SafeBrowsingDatabaseManager. Note that the conditional on whether
the safe browsing throttle is created would seem to be slightly
changed: currently it is done if the (//chrome-level)
SafeBrowsingService is not null, whereas in this CL it is changed to be
gated on whether the database manager returned by the
SafeBrowsingService is not null. However, the created throttle already
assumes that the database manager passed in from SafeBrowsingService is
not null (cf. SubresourceFilterSafeBrowsingClient), so the new check is
actually functionally equivalent to the old check (i.e., the database
manager will be null iff the safe browsing service is null).

Bug: 1116095
Change-Id: If71e59db4212482d05eb5eb49e50a7bebfee47cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440096
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812618}

This CL will help to implement intrinsic sizes of LayoutNGTextControl*.

- Change the argument of the function to |const ComputedStyle&| in order
to avoid using StyleRef() member function.

This CL has no behavior changes.

Bug: 1040826
Change-Id: Ic66b5a25d28806bfc71ab0011357571924d1e189
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440725
Commit-Queue: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812617}

Document that the rollback feature relies on install attributes to be
backwards compatible.

Bug: 1124428
Change-Id: I0a9de16aa5bd749300a05751562fe7c6436c9e38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435192Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Miriam Polzer <mpolzer@google.com>
Cr-Commit-Position: refs/heads/master@{#812616}

This is a reland of fbe2ef31
The revert was because of some test failures, but the failures
are unrelated, and were not fixed by the revert. So relanding
the CL without any additional changes.

Original change's description:
> [smoothness] Revamp UKM reporting for smoothness.
>
> Set up a shared memory for the smoothness data, so that the renderer
> can keep updating the data (which can happen many times every second),
> without incurring cost of thread-hops from the compositor thread to
> the main-thread, or IPC costs from the renderer process to the browser
> process.
>
> https://docs.google.com/document/d/1E91V41tssxOhTjujaT7BoJ0A4TNabR7Vgd9k2eg7fMY/edit
>
> BUG=1115139
>
> Change-Id: If4fe22035620faed3875f2026558cb5b03e62723
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393531
> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: Steve Kobes <skobes@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#812097}

TBR=avi@chromium.org,sadrul@chromium.org,dcheng@chromium.org,rockot@google.com,skobes@chromium.org,bmcquade@chromium.org

Bug: 1115139
Change-Id: Ifde2105e63ca1f969c1773c4d5075490b92148a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440835
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812615}

Document that the path to the oobe-completed flag should be changed in
the file for rollback constants as well if it is changed in Chromium.

Bug: 1124428
Change-Id: Ie817dcb534ef6a326076995923db310f2b170f10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435389Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Miriam Polzer <mpolzer@google.com>
Cr-Commit-Position: refs/heads/master@{#812614}

Shows 'Not signed in' in SignInPreference if 'Allow Chrome sign-in'
toggle has been turned off.
Screenshot: https://crbug.com/1133780#c1.

Bug: 1133780
Change-Id: Iea5ad78e1fd6ce42c4244821bdfdf2651d0a7e3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440757
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812613}

We avoid the check failure
Check failed: GetMultiLine()
in Label::SetMaximumWidth(),
called by SharesheetTargetButton::SetLabelProperties()


Bug: 1132748
Change-Id: I9d5c12e01954f1abb80592a70967218ab37c8d2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440724
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Melissa Zhang <melzhang@chromium.org>
Reviewed-by: Melissa Zhang <melzhang@chromium.org>
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812612}

Roll Chrome Mac PGO profile from chrome-mac-master-1601510378-f7e9b1850f70afb6dc30da9584475e1f2dba0196.profdata to chrome-mac-master-1601531335-6ddc6aeaa45d1043385555e19eae524fbb6fe60e.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I26a046be99da0a0bf26898bb940e6f6670e25394
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442491Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812611}

Using wpt-import in Chromium 849a4f27.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma@google.com

No-Export: true
Change-Id: Iebdb268215ae84329643a66dbac128eaebf89f3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441262Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812610}

Roll Chrome Linux PGO profile from chrome-linux-master-1601510378-740bdb3f5f06d5ae4b11a44692e04cf48dbd56ce.profdata to chrome-linux-master-1601531335-92722dc44bbb5dcb3fdddbecff6eb0d1b4a38ee3.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com
Change-Id: I728652ee9ab5b5655b64eab918d1e56785228825
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441132Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812609}

This is a reland of 773b24b9

Reland reason: the tests failure of the original CL is fixed
in https://crrev.com/c/2438500.

Original change's description:
> [Android] Implement tests for SyncErrorCardPreference
>
> This cl adds render tests for different types of sync errors in
> SyncErrorCardPreference.
>
> Bug: 1107420
> Change-Id: I3ebc308932eadb677310ea041559bb54bbb1765c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353255
> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Reviewed-by: Alice Wang <aliceywang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811273}

Bug: 1107420
Change-Id: Icdea13a04e71b55cf5ba0f99c8b24951c9666e16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440662
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812608}

Previously the media app was unable to perform a save as operation on a
file obtained from a drag and drop or from a paste event. This was
because the logic surrounding the operation was encapsulated in
ReceivedFile which is a class the media app does not have access to.
This cl updates the requestSaveFile IPC to return a ReceivedFile
instead of returning a file token, allowing the media app to obtain a
native file, overwrite it and copy over it's functions so future saves
can happen in place.

The google3 side of this change is @ cl/334717684.

Bug: b/165769056, b/169630668
Change-Id: Ied8dd540f9f319b18b427e6566851bc628ed3204
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439969Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: dstockwell <dstockwell@google.com>
Commit-Queue: Zain Afzal <zafzal@google.com>
Cr-Commit-Position: refs/heads/master@{#812607}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fae3f2841bd0..95949e4c8ae8

2020-10-01 changhaohan@chromium.org Refactor away ad hoc treeElementSymbol field in DOMNode
2020-10-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I55e17cac84d6ed76252d28c5ec1ac75dbd18f399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442420Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812606}

- Updates the list of generated files
- Includes v8_foo.h instead of foo.h for IDL dictionaries
- Uses hasXxxNonNull() and XxxNonNull() APIs to access a nullable
  vector properly


Bug: 839389
Change-Id: I1c8fbb1e3cadc5568c231315b58c9a20f59951ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439999
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Auto-Submit: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812605}

The histogram is called "UpgradeDetector", not "UpgradeDetecter".

Bug: None
Change-Id: I06f74a35ead4b17d81eb155b38b6f620f2d42bd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440038Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Miriam Polzer <mpolzer@google.com>
Cr-Commit-Position: refs/heads/master@{#812604}

And deprecate GPUBindGroupLayoutEntry.multisampled.

Bug: dawn:517
Change-Id: I0959d46f603c2c7741dc2288098ca119d38b344e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440655Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812603}

As the last step to convert ViewMsg_UpdateWebPreferences
IPC message to Mojo, this CL moves ViewMsg_UpdateWebPreferences
to PageBroacast Mojo interface.

  - Introduce web_preferences.mojom which has WebPreferences
    Mojo struct with needed enum types.
  - Add web_preferences_mojom_traits.h/cc files to map Mojo fields
    to the proper native types.
  - Remove IPC legacy stuff regarding the IPC message in //content.

Bug: 1097943
Change-Id: I3a4286b106b7f0a0b38cb7482f1f0f8f7fbf590f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426070Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#812602}

This CL fixes the settings issue introduced by the CL below:
https://chromium-review.googlesource.com/c/chromium/src/+/2363914/comment/81a70101_1ab41885/

We now move the logic of updating weather settings inside the
|OnSettingsAndAlbumsFetched|, where the previous user settings stored on
the server side have been retrieved. We then check the |show_weather|
field and update the weather settings if necessary.

Bug: b/158630188
Change-Id: Ifcd66699ca483a88d119afc5182539e508639c82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389416Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812601}