- 20 Sep, 2019 40 commits
-
-
arthursonzogni authored
Make about:srcdoc to inherit CSP from its parent. Bug: 1001982 Change-Id: I5e750a8d821e6a8e8cc81e6c8a0feeb7583de020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789541Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#698438}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b819e877d74f..2126635fbb7e Created with: gclient setdep -r src-internal@2126635fbb7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib9245bcbfb86342f45730833bed5d29d8bfe6555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816577Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698437}
-
Mohamed Abdelhalim authored
This is the 8th CL of multiple CLs to remove the usages of NavigationHandleImpl completely and replace it with NavigationRequest. This CL removes usages of NavigationHandleImpl::frame_tree_node(). Bug: 995268 Change-Id: I1069073c64f2faa8cc3ef707a92460cd61a67d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810958 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#698436}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a7a721e7. With Chromium commits locally applied on WPT: cc2a9ab7 "Add missing step_func in wpt/svg/animations/scripted/onhover-syncbases.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I634b8d3931fd29ddd7cbc84c222c9c042f5902e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816382Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698435}
-
Anton Bikineev authored
GarbageCollectedFinalized class was removed from BlinkGC in afdb2e7a. Now finalization of GCed type relies solely on C++ type system without the need to manually specify it. This change removes all the checks related to incorrect use of GarbageCollectedFinalized from the plugin. Bug: 990913 Change-Id: I53c73b59a51de407afc6d38fb873f607fec056d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814819Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#698434}
-
Marina Ciocea authored
When the shared tab navigates to a new URL, update the label on the tab sharing infobars to reflect the new name of the shared tab. Bug: 999170 Change-Id: I025a8bb2a958bf73cd921a5337c7dc64ee6428ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816537Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#698433}
-
Javier Ernesto Flores Robles authored
Get the original browser state so the user can save credit cards while on incognito. Bug: 1005912 Change-Id: If683a7ae9cf1b9a9da24eebcfd6c50f2f27e838c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816500 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#698432}
-
Sigurd Schneider authored
Both Bindings.cssWorkspaceBinding.uiLocationToRawLocations and well as Bindings.debuggerWorkspaceBinding.uiLocationToRawLocations resolve locations to non-existing CSS and Script locations. This patch fixes Bindings.debuggerWorkspaceBinding.uiLocationToRawLocations to not do this anymore, and hacks Bindings.cssWorkspaceBinding.uiLocationToRawLocations to not do it for formatted sources anymore. For the ultimate fix, we need to get the end position for inline CSS from the back-end. This will allow us to clean-up the hack as well. The significance of this change is that it enables precise coverage gutters for inline CSS and inline scripts. Bug: chromium:1004203, chromium:1005708, chromium:1005789 Change-Id: Ieadb2aef7e610ecec35e28f5f1cc4516a28a0780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814299 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#698431}
-
Hiroki Nakagawa authored
After https://crrev.com/c/1813638, CreateForTesting() no longer touches any private stuff of WebEmbeddedWorkerImpl, and just calls the constructor with null values. That should be inlined in the test for code simplicity. Bug: n/a Change-Id: I329931ff7fc1bb1365ea2028477ec80f8256e114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813797Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#698430}
-
Alex Chau authored
- As part of DeviceInfo migration work we have created a enum in sync proto, which should be used as the source of truth - Migrated all usage of SharingDeviceCapability to proto enum, and replaced bitmask with Set<Enum> - GetDeviceCandidates now takes a single required_feature instead of bitmask, as it's now per feature so only one is required Bug: 991971 Change-Id: I0f2516d71321ab69928d474418deca33e9ad58f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814359Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#698429}
-
Finnur Thorarinsson authored
Bug: 1004762, 860467 Change-Id: I2b86eb3011805b33db45e2447b49524527164ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813326Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#698428}
-
redatawfik authored
- Allow the tool bar to be shown only if "AutofillCreditCardTableViewController" is presented. Bug: 1003899 Change-Id: Id3661216af02eeb3f0365398b56ab59f9b977727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813497 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the media.mojom.AudioOutputStreamProviderClient interface, and adapt unit tests. Bug: 955171 Change-Id: I8791ab3d52f134d7ec29ea9703709641e40edc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803286 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#698426}
-
Marc Treib authored
This reverts commit d76a27dd. Reason for revert: Seems to have broken ~all the browser_tests and interactive_ui_tests on ChromeOS, see crbug.com/1006165 Original change's description: > Enable the flag of scrollable shelf by default > > This CL enables scrollable shelf as default. It will be landed after > discussion with other team members. > > Bug: 1002576 > Change-Id: I4dab5b81bf6418d5cc066f2763b4b5862ebff716 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790755 > Commit-Queue: Andrew Xu <andrewxu@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698284} TBR=manucornet@chromium.org,andrewxu@chromium.org Change-Id: Ie19273c5fd4187c67dc0646278e04eb04fce3eb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1002576, 1006165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816540Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#698425}
-
Fredrik Söderquist authored
Add a small helper class to set/reset the |prevent_scheduled_animations_changes_| flag in SMILTimeContainer as well as a method to check if it is clear. This reduces the amount of ifdeffery to check if we are allowed to check or not. Bug: 998526 Change-Id: I8583693e88751df56f16c46d7073139ba94dc253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811000Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#698424}
-
Mikel Astiz authored
The code is still behind a feature toggle and not fully implemented. Follow-up patches will introduce interactions with the browser process via Mojo. Independently of the browser process enforcing security origin checks, the Javascript API itself should also be exposed only to the Gaia origin. Bug: 1000146 Change-Id: Ib95bf8e66db6643352c92939d7c3444fe0231247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813304Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#698423}
-
Mugdha Lakhani authored
This paves way for deleting BackgroundSyncLauncher code, which is the old way of waking up Chrome on Android to process Background Sync registrations, and is no longer being used. The logic that is still being used is to check whether Google Play Services is up to date, which is checked at Chrome start up. This CL refactors that out in to a separate class and updates C++ logic to use the new class. Bug: 924490 Change-Id: I4c412738e496c250a556d00408169ace1223a4a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804484 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#698422}
-
Raphael Kubo da Costa authored
Use "Mac" rather than "Mac10.13" in an attempt to mark the tests as flaky on the mac bots. Even though the failures are usually on Mac 10.13 bots, the previous expectations were still causing failures such as https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/19638 This also reverts some changes done by the WPT bot in https://chromium-review.googlesource.com/c/chromium/src/+/1815796 that will likely cause more problems in the future. TBR=reillyg, wanming.lin@intel.com Bug: 731018 Change-Id: I11323fbc1558692e365e61d23f95c6c1ee912abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816557 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#698421}
-
Eric Willigers authored
The test WebAppUiManagerImplBrowserTest no longer references extensions. The helper function browsertest_util::InstallWebApp is extracted from WebAppControllerBrowserTest. Bug: 966290 Change-Id: Ifff8e054293e627aa085d51671c6092d161a06e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787487 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#698420}
-
Fredrik Söderquist authored
Set window.onload in the test step not from the async_test() return value (which is a Test object). Change-Id: I0fd9b5a939a6b1ad8f87862f1008ffc2b79c16e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807119Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2051b8bf0523..e24557f51eec git log 2051b8bf0523..e24557f51eec --date=short --no-merges --format='%ad %ae %s' 2019-09-20 nisse@webrtc.org Declare api:libjingle_peerconnection_api dependency on media:media_base Created with: gclient setdep -r src/third_party/webrtc@e24557f51eec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I0e7c07f5beef0ac3be534a4cfc2f14f59f23e3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815671Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698418}
-
Marina Sakai authored
To access private properties of a V8 object, we need a v8::Private as a key for each property. V8PrivateProperty provides its wrapper class "Symbol" as a shorthand API. Currently, V8PrivateProperty has two types of APIs to get Symbol. One is a macro-generated function, which needs to be managed by hand. And the other is string-based mapping, which defers the management of the mapping to V8. This CL adds a new API to get a Symbol (wired with a unique v8::Private) from a key pointer. All the current Symbol getters will be replaced with this new API. Also uses it to access private properties to keep-alive objects. Bug: 715418, 1005601 Change-Id: I29735fdf5b8748c6dc7f57f91f8c5ebd5e5991b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810511 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#698417}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6c4ff5ddab07..8f2d41d1be9d git log 6c4ff5ddab07..8f2d41d1be9d --date=short --no-merges --format='%ad %ae %s' 2019-09-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src caca1d1cc46e..f7a48b153f2a (1 commits) Created with: gclient setdep -r src/third_party/angle@8f2d41d1be9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: chromium:None Change-Id: I024f35ec1dac5dc27f1e86f5a36ee4626bcd99fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815672Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/052b14753bfa..b819e877d74f Created with: gclient setdep -r src-internal@b819e877d74f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie64cd68d76beb49c4ad5943f693e552dc8dcc1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816180Reviewed-by:
-
Jeonghee Ahn authored
Fixed bug where adjacent elements were incorrectly get HOVER. The left-top position of an element is not perfect coordinates for fake mouse hover. So I added 1 pixel. I'm not sure this solution is correct for all cases. But, I can't leave this bug. If there is a better way, please guide me. Bug: 982187 Change-Id: I60501ffeb07baba85e97e52fa9a4c69cea7ca1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782206Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jeonghee Ahn <jeonghee27.ahn@lge.com> Cr-Commit-Position: refs/heads/master@{#698414}
-
Thomas Tangl authored
The outer margins view is replaced by specifying the outer margins using the property kMarginsKey. Bug: 995720 Change-Id: I1c2ad9414dd24188aa528f85aa367872672cfdd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813356Reviewed-by:
-
Ian Struiksma authored
renderframe count updates. new cipd version update to DEPS as well as made some fixes to recipe files Enabled: modcloth timberland collage newegg ticket_master walmart_ca worldmarket (re-recorded) Bug: 996478,984664 Change-Id: I59d76f0e7e55997614938e31e857b5b7003a83a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815500 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#698412}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b5272dd9. With Chromium commits locally applied on WPT: cc2a9ab7 "Add missing step_func in wpt/svg/animations/scripted/onhover-syncbases.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: If9b44d0c9f8a66ad5b9c9f4195b57b4fec5a7243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815796Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/debdeb70..e3d2c1e9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1148d6243d1394bff388d554573f844b4dbdd2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815795Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698410}
-
Wei-Yin Chen (陳威尹) authored
This is an identical reland of 1dc90fac after http://crbug.com/1004663 is fixed. Original change's description: > Populate the distilled content slightly earlier > > Before this CL, the distilled content is injected on DidFinishLoad(), > or when the distillation finishes if it's later than DidFinishLoad(). > When the DidFinishLoad() event propagates to TalkBack, the distilled > content is usually not there yet, so TalkBack would announce the > content of the place-holding page. > > This CL populates the distilled content in DocumentLoadedInFrame() > instead of DidFinishLoad(). DocumentLoadedInFrame() is late enough to > execute JavaScript, and is early enough so that it's more likely that > the title and content can be picked up by TalkBack instead of the > placeholder. > > If distillation is finished by DocumentLoadedInFrame(), onload() event > would also be delayed, so that the accessibility focus is more likely > to be on the web content. Otherwise, the focus is usually on the close > button of the CustomTab (CCT), or nowhere. > > Note that this CL doesn't guarantee the distilled title is announced > by TalkBack. If distillation finishes later than > DocumentLoadedInFrame(), or if for some reason the accessibility focus > is on the close button of the CCT, the title would go unannounced like > before. > > Bug: 811417, 803474 > Change-Id: Iaf2ff988b427ca9af582622597b505e7a8aca8e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791048 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697074} TBR=mdjones@chromium.org Bug: 811417, 803474, 1004663 Change-Id: Icbb871422ff3e173179d4250c26985081d9fa22d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809967Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#698409}
-
Eric Willigers authored
Test helper functions are introduced in web_app_browsertest_util.h BookmarkAppTest is renamed to WebAppEngagementBrowserTest. The test no longer references extensions. TBR=calamity@chromium.org Bug: 966290 Change-Id: I630fa2873766a5a2955fe96f91008fd3bb9bc84e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787761Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Austin Tankiang authored
The old logic for constructing these paths were taken from the legacy drive client code, and returned completely wrong paths for DriveFS. It turns out this doesn't matter because nothing uses these paths. In any case, change it to return relative drive paths for now. Bug: 1003238 Change-Id: I6ff75ca18c80acc7af976dc97801f7ac66bf70e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808981 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#698407}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/04ebb2a000ee..5327092bb28b git log 04ebb2a000ee..5327092bb28b --date=short --no-merges --format='%ad %ae %s' 2019-09-20 ramakrishnan.nikhil@gmail.com [woff2] Fix memory leaks. Created with: gclient setdep -r src/third_party/freetype/src@5327092bb28b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I19b4f293d3599fbea68f1f218bf8f967252fcb9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816179Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#698406}
-
Alex Danilo authored
Bug: 980452 Change-Id: I1676eb50d52df6976a12ec940a66a25ed3032ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814584 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ie3456782bf7055fbc1a2c6d07724fda50513bf36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808311 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#698404}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I61b0a36ee57a983ccbdb68160cc0b11f13fbba2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808172 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#698403}
-
rajendrant authored
This CL implements a heuristic to eagerly fetch the first K images in a document, which is needed to alleviate delays caused by intersection observer firing only after first render event. Bug: 996963 Change-Id: Ide96665ba836d423ba0c370cd4a075d1650c4b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769304 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#698402}
-
Fredrik Söderquist authored
* FindInstanceTime(kEnd, ...) will return "indefinite" for an empty, so always call that. * Sink the call to ResolveActiveEnd(...) since it can be shared between the two cases. * Drop the redundant "!end_times_.IsEmpty()" check. Bug: 998526 Change-Id: Idf6431e4313ee9ebec917759dba10c457443aa97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813502Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#698401}
-
Etienne Bergeron authored
The call to GetFirstMatchingFont(...) may fail. The matched_font will be unset and can be null. As stated on the doc: https://docs.microsoft.com/en-us/windows/win32/api/dwrite/nf-dwrite-idwritefontfamily-getfirstmatchingfont The return value may be fail. Type: HRESULT If this method succeeds, it returns S_OK. Otherwise, it returns an HRESULT error code. StackFrame: content::FontFallback::GetCachedFont(std::__1::basic_string<wchar_t,std::__1::char_traits<wchar_t>,std::__1::allocator<wchar_t> > const &,wchar_t const *,wchar_t const *,DWRITE_FONT_WEIGHT,DWRITE_FONT_STYLE,DWRITE_FONT_STRETCH,IDWriteFont * *,unsigned int *) content::FontFallback::MapCharacters(IDWriteTextAnalysisSource *,unsigned int,unsigned int,IDWriteFontCollection *,wchar_t const *,DWRITE_FONT_WEIGHT,DWRITE_FONT_STYLE,DWRITE_FONT_STRETCH,unsigned int *,IDWriteFont * *,float *) SkFontMgr_DirectWrite::fallback(wchar_t const *,DWriteStyle,wchar_t const *,unsigned int) SkFontMgr_DirectWrite::onMatchFamilyStyleCharacter(char const * const,SkFontStyle const &,char const * * const,int,int) blink::FontCache::GetDWriteFallbackFamily(blink::FontDescription const &,int,blink::FontFallbackPriority) blink::FontCache::PlatformFallbackFontForCharacter(blink::FontDescription const &,int,blink::SimpleFontData const *,blink::FontFallbackPriority) blink::FontCache::FallbackFontForCharacter(blink::FontDescription const &,int,blink::S R=drott@chromium.org, fdoray@chromium.org CC=eae@chromium.org Bug: 997081 Change-Id: I3c007f3a7d9bba5dba78ae1a5e1eaaa7f8e8a7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814703Reviewed-by:
-
Rika Fujimaki authored
This reverts commit 6dfea7f4. This CL just adds Trace methods for ScriptValue and ScriptPromise, and it wouldn't cause regression. So we conclude that the test is flaky. Further discussion in crbug.com/1003130 Original change's description: > [Resolve Leak Error]Make ScriptValue Traceable > > We made ScriptValue Traceable to replace SharedPersistent > with TraceWrapperV8Reference in a follow-up CL. > > In this CL, most of the changes are just: > - Replace Vector<ScriptValue> with HeapVector<ScriptValue> because > ScriptValue has a Trace method. > - Add a trace method for ScriptValue and ScriptPromise since > they have objects to Trace. > > We recommend you to mainly check > - script_value.h where I add VectorTraits. > - script_promise.h where I add VectorTraits. > - v8_callback_function.py where I add a code to generate HeapVector. > - v8_types.py > * Add ScriptValue and ScriptPromise to "is_traceable==True" > which is used to generate Trace method & HeapVector. > > + I removed code to detect leak around ScriptPromise because > ScriptPromise no longer has persistent which may cause memory leak. > > Bug: 998994 > Change-Id: I63fcbf01de099577fe14045785b3072c615d78c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792583 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Rika Fujimaki <rikaf@google.com> > Cr-Commit-Position: refs/heads/master@{#695505} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,keishi@chromium.org,kouhei@chromium.org,rikaf@google.com Bug: 1003130, 998994 Change-Id: I92abf0b0cfd6965c700b86009f03d1aed8f4c56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809204Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#698399}
-
