- 30 Oct, 2020 40 commits
-
-
Jeffrey Young authored
Multi profile tests were previously passing because second user had ambient mode pref turned off. Set up test case better so that non-primary users are blocked from ambient mode during test. Move test_ambient_client to //ash/ambient/test BUG=none TEST=ash_unittests --gtest_filter=AmbientControllerTest* Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: Iee0766e036833e47b10294b7c60be28a89ffc631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506068Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#822477}
-
Theresa Wellington authored
Bug: 956260 Change-Id: I413af5a27ee6401cf28124eea39a9af04af88fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490665Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#822476}
-
Alexander Timin authored
extended_tracing_support is a one-stop solution for enabling additional trace events. Ensure that it enables blink binding tracing. R=haraken@chromium.org BUG=1043616 Change-Id: I37f6556b690090ceb7e3f2fa33b14b06e54ac4fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507772 Auto-Submit: Alexander Timin <altimin@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#822475}
-
Jeff Yoon authored
Set enable_chrome_android_internal=false GN argument for Lorenz builder such that internal clank code is not included for the public graphs. Bug: 1143778 Change-Id: If0af240b14f7c8dc032e36f8ed11e483d34e71a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508796Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#822474}
-
Yulun Wu authored
Bug: 1134432 Change-Id: I9d1137094970d35039b37fcfa379c655cbc0d0c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506571Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822473}
-
Brandon Wylie authored
Bug: 1123209 Change-Id: Ic53ad58d163b471c5064110034155db95bd510a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463856 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#822472}
-
Nate Fischer authored
This reverts commit 9dde9c01. Reason for revert: breaking downstream compile (https://crbug.com/1144005) Original change's description: > [WebLayer] Refactor AutofillPaymentAppFactory > > Changes: > * Removed the autofill logic from PaymentAppFactoryDelegate > * Refactored AutofillPaymentAppFactory.Creator so that > onAutofillPaymentAppCreatorAvailable can be done in ChromePRService. > * PaymentAppService adds factories in ChromePRService because going > forwards, WebLayerPRService will have its own set of factories. > > Bug: 1129572 > > Change-Id: I2810c204920d8d5eab8d1fedeaebc268be78c085 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503890 > Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822412} TBR=rouslan@chromium.org,maxlg@chromium.org Change-Id: Icae92dd007836a36595fe23d948c360d880f1f66 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129572 Bug: 1144005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508954Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#822471}
-
Nate Chapin authored
* Don't use document() when the needed state/functionality is available on the window itself. * Don't null-check it in most places, since document() should only be nullptr in the middle of commit, and with one exception these shouldn't be reachable during commit. Change-Id: I74d49671a0c462c90f1e1af45ff1949e49f669b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505881 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb758b5641d2..af5f5d291abd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com,dhoss@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1117663,chromium:1142990 Tbr: johannkoenig@google.com,dhoss@google.com Change-Id: I6289657c3660523437ee09a06d327219c7e764ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508712Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822469}
-
James Vecore authored
Bug: 1135840 Change-Id: I653e6af063a36f2695d21c0d9cf8cb9ce697ac6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506361 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#822468}
-
John Lee authored
Use parseFloat instead of Number to get more accurate opacity values. For example, Number("0.9999999999999999999") is 1. There still seems to be a millisecond of a difference from when the opacity reaches its final value and when the transitionend event fires, so wait until the final assertion is met instead of immediately checking it. Fixed: 1143970 Change-Id: I6aaa7c12d45d370d7499f36bd25d73b2ed42816a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508950Reviewed-by:Luciano Pacheco <lucmult@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#822467}
-
Peter Kasting authored
Bug: 772945 Change-Id: I09d2f65a1be410549b63b9657695a6f43907232b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508629 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#822466}
-
Zentaro Kavanagh authored
- Wires up the routine result list and section to run tests - Add tests for both Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I92e5e033b861b65ce49f16940210e29135ed0bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469877Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#822465}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1603907949-4ffda8056377a01132d9724a51a14693bc70ab3c.profdata to chrome-win64-master-1603983512-c60ff6e0a6baf9584b1a93640671c446cc84aec9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic5fe0e9a3b37fab660728c7274b3f40290e1118a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508490Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822464}
-
Shakti Sahu authored
Change-Id: Ia029f3547656ac36742fbda97f69be1aab4a77b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499165Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822463}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f71e0be97097..624482861e16 2020-10-29 michaelludwig@google.com Improve GrTBlockList capabilities/correctness 2020-10-29 johnstiles@google.com Add unit test to demonstrate error with modulo in FP files. 2020-10-29 freiling@google.com [flutter][fuchsia] Enable Effect Deserialization in Flutter on Fuchsia If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: Ib5b5e7b9c49b094d37b136475c7fb7a25f2a66d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508535Reviewed-by:
-
Alex Turner authored
Use of base::Bind, ::Callback, etc. is deprecated in favor of the more explicit Once/Repeating versions. Despite being marked as fixed, a few directories have some remaining uses that were missed in the conversion. This cl fixes those stragglers in the ios/web and ios/web_view directories. The presubmit is also enabled for these directories to avoid any future regressions. Bug: 1141533, 1007796, 1007795 Change-Id: I99e6b873fcdfa36577b3c8fa66335e746ad8b75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505584 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#822461}
-
Yoshifumi Inoue authored
This patch changes |GetImeTextSpansAroundPosition()| to take |Position| instead of offset in root editable element to avoid using |PalinTextRange|, to avoid redundant calculation for improving performance. Note: Even if this change, large content editable is still slow due by |PlainTextRange| uses |TextIterator| to collect text from root editable element and map DOM position to offset for every frame or 16ms. For every frame, we call * InputMethodController::TextInputInfo() - PlainText() for root editable elements - TextIterator for end of selection - TextIterator for end of composition * InputMethodController::GetSelectionOffsets() - TextIterator for end of selection Mapping time depends of number of DOM node between start of root editable and position. When selection or IME composition are far from start of root editable element, mapping takes time. Bug: 892513 Change-Id: Id2f6694e3fee2b23b697a1aaf1830cd0d897d61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507129 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#822460}
-
Johann authored
ExternalProtocolHandlerBrowserTest.ProtocolLaunchEmitsConsoleLog Flaky on Mac TBR=meacer@chromium.org Bug: 1143762 Change-Id: I606a4202693aebc8e0408f79cda771400de6418d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507299Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#822459}
-
Allen Bauer authored
Bug: 819294 Change-Id: I362653b106e6907ebf72a1da2f8b2227bc5b0550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508032 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#822458}
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and a follow up will remove warning exemption. Bug: 999886 Test: no errors building Change-Id: Idc737e3d9124893f5bb56eeabb12f7c75bba7b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508185 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#822457}
-
Aga Wronska authored
Bug: 1142867 Change-Id: Ib6f722f9a5df6b686a98b0968ad19fe6de9377d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502573 Auto-Submit: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#822456}
-
Alexander Alekseev authored
This Cl fixes an issue in StateImpl::InitFrom() and cleans up code. - input_view_url_overridden field is missing in InitFrom() method. - input_view_url_overridden in Dump() method. - Update InitFrom() and Dump() to match declaration order. Bug: 1143657 Change-Id: Ibb2aaf67e391b50f7583e07c7051d95bcf7e8d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507390 Auto-Submit: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#822455}
-
Darin Fisher authored
Bug: 1141261 Change-Id: I73710b07c82ebd8bfe76bea23251df505c5cc300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508850 Commit-Queue: Darin Fisher <darin@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#822454}
-
Nate Fischer authored
No change to logic. This disables FeedNewTabPageTest.testArticleSectionHeaderWithMenu because this is failing when DisableSigninPromo is 'true'. Tbr: chili@chromium.org Bug: 1143974 Test: None Change-Id: Ie4162a12a78d799c9ce337f839405c450cf1735c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508202Reviewed-by:
-
Kenichi Ishibashi authored
This CL adds wrappers for these methods to ServiceWorkerRegistry so that we can retry these methods when the underlying mojo channel is disconnected. This CL doesn't implement retry mechanism. Subsequent CLs will implement it. Bug: 1133143 Change-Id: I4a229b63737d406e03654c172547126109c358dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505364 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#822452}
-
Roman Arora authored
Tab search WebUI source migration effort. Final step involving a rename of the tab_search_merge directories to tab_search. Bug: 1134167 Change-Id: I417214c807e9c921fef9f77ac58872d4af6f8e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508215Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#822451}
-
David Dorwin authored
This was added in https://crrev.com/c/1529685, but the tests using it have since been removed. Change-Id: I2857f88d486731ac8e588dfa761213d2a654059c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494080 Commit-Queue: David Dorwin <ddorwin@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#822450}
-
Nate Fischer authored
No change to logic. This disables AutofillAssistantInputActionIntegrationTest.fillFormFieldWithText because this was flaky on the Marshmallow x86 bot. I see some flakes on other bots, so I'm disabling this test completely. Tbr: mcarlen@chromium.org Bug: 1143805 Test: N/A Change-Id: Id8407b63fa884eccc33d1891c5e4b78a3cfdda90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508897 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Eugene But authored
Recorded when app starts after Unexplained Termination Event (UTE) or Explained Termination Event (XTE). UTEs/XTEs can happen when app did not finish writing prefs. This histogram should help to understand if prefs did not get written during normal app termination sequence when ApplicationWillTerminate notification was called. Bug: 1143795 Change-Id: Iedf0b0a0ad6f60bf779d3ca55cd8251b19ba518b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503853 Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#822448}
-
Alan Cutter authored
This CL: - puts the entries in default_web_app_ids.h in alphabetical order. - gives extra context around the call to GenerateAppIdFromURL(). - formats the individual entry comments to have a consistent indentation for the start_url. Bug: 1143967 Change-Id: I2460202db1344f34555406b46f9d61ffa10c833d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507296 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#822447}
-
Daniel Libby authored
crrev.com/25da0a8d added code to hit test the main frame's overflow controls before any other content, since they always draw on top. However, skipping to PaintLayerScrollableArea::HitTestOverflowControls was not the right way to perform the hit test, as it doesn't call HitTestResult::SetNodeAndPosition. This resulted in a 0,0 local point on hit testing, which selection code reads and unexpectedly flips the selection when the mouse is moved over the scrollbars. Additionally, the unit test was incorrectly authored (the perspective and rotation transforms were not forcing scrollbars), so updating that to actually validate the scrollbar hit test as well as the local point of the hit test result. Bug: 1127641 Change-Id: I213d396b6fb7ab9477152a23f4d9c87545467aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503656 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#822446}
-
Rachel Carpenter authored
This now uses the new HelpAppProvider which accurately records views and doesn't need to mutate the Explore app launcher result to show the chip. Also remove the check for the icon - this doesn't seem to be available in tests. Bug: b/169711884 Change-Id: Ie7c0362915caca033b220b119a5d22a0baba96ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501102 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#822445}
-
shivanigithub authored
This CL enables the split cache feature if it's not already overridden in ChromeMainDelegate::PostFieldTrialInitialization. This is done instead of enabling the feature in it's definition in net/ so that non-Chrome embedders like Cronet, Webview do not have a changed behavior of the cache. Note that the feature list is set at this point in time and cannot be changed, therefore introducing the need of a new flag g_enable_split_cache. Eventually the net/base feature flag will be removed and also g_enable_split_cache be replaced by a network service level flag that will govern not just the cache but other network components as well. Change-Id: Ib6b3a67854d0b4edb6d1809f34552ea10ff8d83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503343Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#822444}
-
Nate Fischer authored
This reverts commit 483ed255. Reason for revert: WebView CTS tests crashing, see https://crbug.com/1143984 Original change's description: > aw: Add missed GL state restoration > > SkiaRenderer (especially when we remove ES2 downgrade) changes more > state then before. This CL adds missed state tracking to > ScopedAppGLStateRestorer and AwGLSurfaceExternalStencil. > > Bug: 1136975 > Change-Id: I55be2bec69c18bff33a3cb18a313a93da10ba088 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506116 > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822211} TBR=boliu@chromium.org,vasilyt@chromium.org Change-Id: I8d22dbc3e1d19c954fca45668ab144de3b6d323e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1136975 Bug: 1143984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508951Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/68b95b6330b4..a653a9badb55 2020-10-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 87b0951f8dba to a72e7b987746 (3 revisions) 2020-10-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 8308d6744d50 to 428654245ad3 (1 revision) 2020-10-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 483a71c5130e to e69b9b7294af (10 revisions) 2020-10-29 jonahr@google.com Remove include of nonexistant directory 2020-10-29 jmadill@chromium.org Skia Gold: Fix Android stdout parsing. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I93dc5b0baf4431c2529552d2490dc812ae3515fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508263Reviewed-by:
-
Shakti Sahu authored
Change-Id: I1244888c257c058d6116fbc20b4ab1b2c2e4ff4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497434Reviewed-by:
-
Kehuang Li authored
Otherwise, we will have dup symbol if more than one file in an exectuable target includes this header. Bug: NONE. Test: Compile. Change-Id: I691142b93f0d40c3ce560530cadf69664ba764c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507831 Auto-Submit: Kehuang Li <kehuangli@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#822440}
-
Ye Kuang authored
This reverts commit 8181b37c. Reason for revert: Create a reland CL for me to work on Original change's description: > Revert "Add --use-swarming-go to the custom trigger scripts" > > This reverts commit 0d7be96e. > > Reason for revert: Suspected of causing failures on CrOS device bots, see https://crbug.com/1143224 > > Original change's description: > > Add --use-swarming-go to the custom trigger scripts > > > > Design doc: http://go/roll-go-swarming-to-trigger-scripts > > > > Bug: 1127205 > > Change-Id: I8ca8e2bb381f340fc23b91339cdb56374f8eead8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500976 > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > > Commit-Queue: Ye Kuang <yekuang@google.com> > > Cr-Commit-Position: refs/heads/master@{#821619} > > TBR=tikuta@chromium.org,wenbinzhang@google.com,yekuang@google.com > > Change-Id: I017fc7ef2947a7d0f2e077e6d8eafd98b7f2865f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1127205 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505509 > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821687} TBR=drott@chromium.org,tikuta@chromium.org,wenbinzhang@google.com,yekuang@google.com # Not skipping CQ checks because this is a reland. Bug: 1127205 Change-Id: Ia2cdab1fd79b79641a6243e42558a5553dbf20fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505355Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#822439}
-
Tess Eisenberger authored
This test was failing to synchronize with the semantic nodes being added, and was checking for an exact match on node ID when it cared more about label match. These changes together should make the test reliable. Fixed: 1050049 Change-Id: Icf4c89a4c737e4a831e3acbd72c9cfa465729bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508157Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822438}
-
