- 08 Apr, 2019 40 commits
-
-
Christian Fremerey authored
Before this CL, class FrameSinkVideoCapturerImpl uses a somewhat hard-to-follow protocol with InterprocessFramePool for resurrecting video frames in case that the source content did not change. This CL changes this protocol to a simpler-to-follow mechanism, which also can reduce the cases where content is re-captured even though it is already available in a previously captured buffer. Change-Id: I635e3cf0dce61f704a6b613702791f03ff0c217a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479154 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#648688}
-
Greg Fiorentino authored
This change adds a new_tab_url for the DuckDuckGo search engine. Change-Id: I37be02e07eb7e4aa90f115455ce7a21832ff4eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555048Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#648687}
-
Francois Doray authored
When the --no-sandbox flag is used, hanging child processes can outlive a browser process that gets killed. This results in leftover processes on bots when the process launcher sequence is made CONTINUE_ON_SHUTDOWN (see https://crbug.com/830954#c18). With this CL, all child processes are part of a "Kill on Job Close" job and are guaranteed not to outlive the browser process. This is a prerequisite to make the process launcher sequence CONTINUE_ON_SHUTDOWN, which will fix ~12% of shutdown hangs on Windows. Bug: 830954 Change-Id: Ieec2b0a4cfc7db93dfffde947cae9fdb46fedb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548839Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#648686}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e06c7e9a515b..0527c9db8148 git log e06c7e9a515b..0527c9db8148 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 johnkslang@users.noreply.github.com Merge pull request #1752 from dgkoch/dkoch_build_fix18 Created with: gclient setdep -r src/third_party/glslang/src@0527c9db8148 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic782049349a48f153dfa74da527fc9aff618c152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557883Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648685}
-
Xianda Sun authored
This is a reland of ea1cc855 Original change's description: > Merge cc layer's hit test bits > > This patch merges all cc layer's hit test bits into one: |hit_testable|. > Now the bit is true if layer draws its content or is always hit testable > according to layer types. > > In the follow-up patch, ui::Layers will be able to set if they want to > accept events or not, so whether a layer is hit testable depends on: > > hit_testable = accept_events && (draws_content || > hit_testable_without_draws_content). > > Bug: 924294 > Change-Id: If455182790154451bec35fdd7c533b727cee96cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1427788 > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianda Sun <sunxd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#645761} Bug: 924294, 949564 Change-Id: I5f6be11291ccc007076db82b479deef26ef379a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551685 Commit-Queue: Xianda Sun <sunxd@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#648684}
-
Josh Karlin authored
What: This CL dramatically speeds up pretty printing of xml files. It speeds up 'git cl format' for CLs with histograms.xml changes from 9 seconds to 3 seconds. This also speeds up other common operations like 'git cl upload'. How: The pretty printer now processes an instance of ElementTree instead of minidom (and will convert minidom to etree if necessary). There is overhead converting minidom to etree but it's still an improvement for those cases where clients only speak minidom. The histograms pretty printer has been rewritten to speak ElementTree. The others (rappor, ukm, actions) still speak minidom and they should be converted in followup CLs but it's less important since their XML files are much smaller. Note: Top-level comments aren't supported by ElementTree, so I've written a SAX parser to copy everything above the first tag in the document and paste it into the result of pretty printing. This is in etree_util.py Otherwise, pretty printing should behave identically. I've improved the testing to catch any mistakes I may have made, but given this involves parsing I wouldn't be surprised if a follow-up CL or two isn't required. Bug: 945354 Change-Id: I28990d245f5d471203f6430e08c8a98e3ba70d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538783 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#648683}
-
Dominic Battre authored
This CL disables the http/tests/devtools/sxg/sxg-prefetch-fail.js and http/tests/devtools/sxg/sxg-prefetch.js for virtual/sxg-with-network-service as well. TBR=horo@chromium.org Bug: 851363,950083 Change-Id: Ifc5d93e7637179cb3774dd9192f8829f5211198b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556791Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#648682}
-
Miguel Casas authored
Couple of OWNERS fixes: - mcasas@chromium.org is marked as legacy owner. - The inexistent TEAM: media-capture-and-streams@grotations.appspotmail.com is substituted with the correct one: webrtc-dev@chromium.org - The component Blink>Location was renamed to Geolocation. Change-Id: Iccc7ca04f36ff216e1584d08e5efa214634de6d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554298 Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#648681}
-
Leonard Grey authored
This gets called enough while painting that I think it's worth it. Bug: 950063 Change-Id: I11c84087b9bb04fb0d4ba26b4eec4ada050e65e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555040Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#648680}
-
Haojian Wu authored
Now we have a docs/clangd.md for how to setup clangd. Remove the duplicated instructions in vscode.md, and redirect to clangd.md. Change-Id: Ic35bbe86d5b8495abb20c71d0e037fad4b63f63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555273Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Haojian Wu <hokein.wu@gmail.com> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#648679}
-
Sidney San Martín authored
AppKit calls acceptsFirstResponder when computing drag regions for the window *and* when handling mouse clicks. If BridgedContentView always returns YES, then it's consistently undraggable but clicking always takes first responder. The check in becomesFirstResponder: was supposed to help with that, but in reality the window itself becomes first responder when it returns YES from acceptsFirstResponder and NO from becomeFirstResponder. r578642 broke this and suggested the alternate approach below. The comment above acceptsFirstResponder is almost verbatim what was there *before* that change. Bug: 900527 Change-Id: I16913e2e5084185b8d49c0342fcf89a9edd6cf65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555509 Auto-Submit: Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#648678}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d3c9245454ed..ccdd6a14ac44 git log d3c9245454ed..ccdd6a14ac44 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 mtklein@google.com fix -script parsing 2019-04-08 masonfreed@chromium.org Added the ability to set the entire matrix at once 2019-04-08 jvanverth@google.com Enable fixed tests on Metal 2019-04-08 robertphillips@google.com Reland "Revert "Reland "GPU support for SkMixers""" Created with: gclient setdep -r src/third_party/skia@ccdd6a14ac44 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950253 TBR=egdaniel@chromium.org Change-Id: Idea7831a785ea0ae1c5bba9dca43e4d70e525d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557882Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648677}
-
Xiyuan Xia authored
This is a reland of ee9ec691 Fix the failure on classic because mouse move event is held by WindowTreeHost. Added WaitForNoPointerHoldLock before sending mouse move events. Original change's description: > chromeos: Add test to drag a window/tab to overview in tablet mode > > - Add tests to drag window/tab to overview in tablet mode; > - Fix UIControlsOzone to use host dips instead of host pixels > with EventInjector and use PointF to avoid rounding errors; > > Bug: 942599 > Change-Id: I0325749cdd95d4b0c213d09f349083336ec3f3b0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546718 > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647147} Bug: 942599 Change-Id: I4a609cad7b872353f2087914406840624111b1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550632Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#648676}
-
Ryan Sturm authored
This is multi-arm experiment, but it should move to a single arm experiment with parameter set to 60 seconds. Change-Id: Ibbbac52e4f9583eb858bc8724364850afcfd94cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554799 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#648675}
-
Marc Treib authored
Bug: 934333 Change-Id: If517ddf3da2e3a47f07cda70a13e4b68e4b3d11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556800 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#648674}
-
Etienne Pierre-Doray authored
This reverts commit 5d4c05db. Reason for revert: Issue 950383 Original change's description: > [TaskScheduler]: Simplify sequence preemption logic. > > This CL removes preempted sequences from TaskTracker, > removing need for CanScheduleSequenceObserver and > simplifying shutdown. > A CanRunPolicy enum is used instead, specifying whether > or not tasks at a given priority can run. > When CanRunPolicy is updated, wakeup workers needs > to be done as appropriate. > > In addition, Shutdown was split in 2 phases start + complete > to allow caller (TaskScheduler) to update CanRunPolicy after > shutdown was started. > > This CL was recycled from: > https://chromium-review.googlesource.com/c/chromium/src/+/1478007 > I took ownership because simplifying Sequence lifecycle > will simplify implementation of job API. > > TBR=gab@chromium.org > > Bug: 889029 > Change-Id: Ie5dbc226705880c5e598e013aa2dd3e7e874158b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531161 > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648346} TBR=gab@chromium.org,fdoray@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 889029 Change-Id: Id15ef90caa4ddec43db925968268d2942a11fc1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557785Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#648673}
-
Allen Bauer authored
Change-Id: I999dd8229c484a3f9046aef794df3344711eab93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553104 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#648672}
-
Samuel Huang authored
This CL adds the following targets for 64-bit biulds: trichrome_64_32_chrome_bundle trichrome_64_chrome_bundle These complemnent existing Monochrome targets. Also rename template monochrome_public_bundle_tmpl to monochrome_or_trichrome_public_bundle_tmpl. Change-Id: I1773085c82e2dbf068c9bfbd1ca03a7175fee1c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553913Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#648671}
-
Bo Liu authored
App zygote will only be supplied with ApplicationInfo, not Application. So refactor LibraryLoader to use ApplicationInfo where applicable. Add a LibraryLoader.loadNowInZygote method meant to be called from the zygote. This method also marks process as being loaded by zygote so skips code in other places that would otherwise load the library without the zygote. Bug: 949155 Change-Id: I0d09e9261331e12fd26b6b468a0cfd473c0b7f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551259Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#648670}
-
Sigurdur Asgeirsson authored
The only user of this interface was the ProcessMemoryMetricsEmitter, which now simply posts to the PerformanceManager and walks the graph for the data it needs. Bug: 910288 Change-Id: Ife9b43a67afeb36084f5e98c7d19740e1c92e7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554786 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#648669}
-
jonross authored
We currrently are running a set of tests in order to detect regressions within our Vulkan implementation. (vulkan_content_browsertests) We are also looking into adding more expansive testing of Vulkan in blink_web_tests. However the GPU process will fallback to GL if Vulkan initialization fails. We want this behaviour in release, however this prevents tests that are looking for Vulkan regressions from failing. This change adds --disable-vulkan-fallback-to-gl-for-testing which will crash the GPU process upon failure to initialize Vulkan. Combined with the existing --disable-software-compositing-fallback allows us to have tests fail if either Vulkan or the GPU fail. Bug: 947057 Change-Id: I070f8b0d4964c418b046cbb74c7e073bbf12ce99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554103Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#648668}
-
Giovanni Ortuño Urquidi authored
1. Adds a method to WebAppPolicyManager to check if we just navigated to a URL for a policy app. 2. Adds a method to PendingAppManager to update a placeholder app if there is one. 3. Adds code to WebAppTabHelperBase that notifies WebAppPolicyManager that a navigation just finished. Bug: 844278 Change-Id: I9946108092670f3bd86cc3e8aa0d6287eb3dc12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552210Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#648667}
-
Sebastien Lalancette authored
Overwrite the overall predicted field type to UNKNOWN_TYPE when there is no server data for this field, and the autocomplete attribute is set to off. Testing: Added unit tests with flag ON and OFF. Tested manually to see that the issue seen in crbug.com/867995 is fixed. Bug: 949783 Change-Id: I0f3071edf30019aba5c374a866c3f9506090d715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554048 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#648666}
-
Caitlin Fischer authored
Change-Id: I9f2bb110d5014be315af698ad65f0030c38acfd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557697 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#648665}
-
Nina Satragno authored
This CL replaces the UI for the webauthn authentication attestation permission prompt with a new sheet on the authentication dialog. Bug: 850955 Change-Id: I83f39f470e308474a4a67744dd0675eaef18e188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547344 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#648664}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ce224208..eec47f93 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaa71ee74037019eaf489be26012ea1da51cafbcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557012Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648663}
-
Huanzhong Huang authored
Changes the code so that when the new-clear-browsing-data-ui flag is on, the path through Settings that used to present a CBD CollectionView will instead present a CBD TableView. Change-Id: I75f6742099fc62a6c6553cbefef65cb351de87df Bug: 935350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554497Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#648662}
-
Nikita Podguzov authored
Change policies values from {"secure", "unsecure"} to {"pin", "no_pin"} not to confuse users with "*secure" values. Bug: 848942 Change-Id: I08f8a54fecbff2ea4521b478d34c7e6bef4c62f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554493 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#648661}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/65611b197df1..3c8363e80d5f Created with: gclient setdep -r src-internal@3c8363e80d5f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I92f4276a1c4f06cf4556f8ba32ca7e252ee36252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557880Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648660}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/439ae2de32db..cb0a4cdcabe1 git log 439ae2de32db..cb0a4cdcabe1 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 fmayer@google.com Merge "Check return value of fnctl when sealing fds." 2019-04-08 rsavitski@google.com Merge "no_destructor_unittest: assert flag setting instead of death tests" 2019-04-08 lalitm@google.com Merge "trace_processor: replace vector<string> with StringPool in storage" Created with: gclient setdep -r src/third_party/perfetto@cb0a4cdcabe1 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I3973884e56a3bd63d1cb2cd22788d5f2ae723ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557881Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648659}
-
Becca Hughes authored
Add a Media.Notification.Source histogram that records the source of the media session when a media notification is shown. BUG=949303 Change-Id: I36880667d1911845187d192bb46afa2c4c4dcc45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552239 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#648658}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/webaudio, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I0556290c2f89e7210aecc9644490344145b3a4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556661Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#648657}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/webdatabase, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ic675c3325b66468b4686f69e0f950cc8d99034b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556964Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#648656}
-
Rayan Kanso authored
Changes: - Previously we were only exposing whether the event succeeded or failed. Now we also include whether it timed out, was rejected, or aborted. - Add an event for when a sync is re-registered. - Restore UMA logging and add a test for it. Bug: 940450 Change-Id: I2f920b0b5adcf4374e9cfb4f3edd57658cd83021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549085 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#648655}
-
Amr Aboelkher authored
Bug: 949184 Change-Id: I8a101256662676ac7bcc1c9ddc9e9c5fb0ace8af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556838 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#648654}
-
Denis Kuznetsov authored
Bug: 950471 Change-Id: Ic3ae509848884bb8349543fda157edbb35c70cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556801 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#648653}
-
Edwin Joe authored
Do not allocate a new Local Surface ID if the RWHI is hidden when it receives DidUpdateVisualProperties from the RW. Currently, when the RWHI receive a DidUpdateVisualProperties from the RenderWidget, it always allocate a new Local Surface ID no matter what its visibility state is if it currently do not have a valid Local Surface Id Allocation. This causes us to allocate a new local surface id even though we do not need it, and we will not send this to the Renderer until we are visible, which is when we switch back to this tab. When we switch back, we will use the previously allocated local surface id (which could possibly be allocated a long time ago, depending on how long it takes before switching back to the tab) and send it to the Renderer. Since the Viz.DisplayCompositor.SurfaceEmbeddingTime metric tracks the delta between allocation time and Surface::OnWillBeDrawn, this means that we are uploading inflated surface embedding time metric. Bug: 936858 Change-Id: Ibd42f687b66d623eaf265fa5ab6e959cf492c125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541580Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Edwin Joe <ejoe@google.com> Cr-Commit-Position: refs/heads/master@{#648652}
-
Huanzhong Huang authored
- Previously in Clear Browsing Data, a selection of a cell is immediately followed by a deselection along with UI update (checkmark in accessory view). - With the new CBD UI being introduced, the selection state of cells becomes relevant and should be handled and maintained. Detail outline: - Reconfigure instead of reload a cell upon browsing data counter finish counting, as a reload clears a cell's selection state. - Cell pre-selection according to browser state, whenever |viewWillAppear:| is invoked. - Have separate |tableView:didSelect...| and |tableView:didDeselect...| implementations. - Should introduce no effect when new-clear-browsing-data-ui is disabled. Bug: 935346 Change-Id: I6b224e5d6ac05f5a3506668f8d6a68d3353fc897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551779 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#648651}
-
PKH authored
[Android Refactor] Rename WebApkSharedPreferences#SHARED_PREF_REQUEST_HOST_BROWSER_RELAUNCH_TIMESTAMP This CL renames WebApkSharedPreferences#SHARED_PREF_REQUEST_HOST_BROWSER_RELAUNCH_TIMESTAMP to WebApkSharedPreferences#PREF_REQUEST_HOST_BROWSER_RELAUNCH_TIMESTAMP in order to be more consistent with the other constants in WebApkSharedPreferences BUG=None Change-Id: Ic909032eefa2198c3ce7ef618c68feb5beaa302f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556448Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#648650}
-
Michael Thiessen authored
Exposes the native NQE observer to java. Bug: 948233 Change-Id: I78d44cd65a57f019e7cd2b3cbc0308514d1ee29a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553643Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#648649}
-