- 13 Oct, 2020 40 commits
-
-
Ted Meyer authored
libva is dlopened regardless Change-Id: Ice577ef78ea15ab7041db4b386eb91237d46a3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442189Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#816663}
-
Yashar Dabiran authored
Reland "[Paint Preview] Split PaintPreviewCompositor memory metrics from the general Utility process metrics" This is a reland of 8711fb9a //components/services/paint_preview_compositor/public/mojom:mojom is now added to process_memory_metrics_emitter.cc dependencies in chrome/browser/BUILD.gn to fix the dependency error. Original change's description: > [Paint Preview] Split PaintPreviewCompositor memory metrics from the general Utility process metrics > > Change-Id: I6067aad3959c054181389c1e1b82e464eacd9a4b > Bug: 1135217 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441263 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org> > Commit-Queue: Yashar Dabiran <yashard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815285} Bug: 1135217 Change-Id: I7c72463b23060b5e352c4421be5b14d1fee4c574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462640Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Yashar Dabiran <yashard@chromium.org> Cr-Commit-Position: refs/heads/master@{#816662}
-
George Steel authored
As of https://chromium-review.googlesource.com/c/chromium/src/+/1986325 we no longer replace nested <use/> elements with <g> elements when populating shadow trees and instead support <use/> inside shadow trees directly (as per the current spec). Remove the check for this case from LayoutSVGTransformableContainer as it has been dead for a while. Change-Id: Iad3a09fe4779cdd54edd0ae98aaaac07fc1bcfb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462227 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816661}
-
Xiaocheng Hu authored
This patch adds a new descriptor to change the glyph advances by a given percentage. For example, the following makes all glyph advances 50% larger than before: advance-proportional-override: 150% The implementation is almost identical to 'advance-override', except in ShapeResultSpacing::ComputeSpacing() where we calculate the delta to each glyph advance. Note: The spec discussion hasn't settled. This patch is only for making experiments easier, so that it's easier to find a better solution to reduce font-caused CLS. Bug: 1137633 Change-Id: I24c9d25f11c07f897eb37f07b75cbc3dd4ec6574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467017Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#816660}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 158 histograms that show frequent access in the past 90 days. These are the 93% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-01-11. TBR=chromium-metrics-reviews@google.com Change-Id: I766b6816bc90876675c821ddec807dc2df22fe1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467760Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#816659}
-
Kartik Hegde authored
Tests whether a firewall is blocking HTTPS port 443. TEST=unit_tests --gtest_filter=HttpsFirewallRoutineTest.* BUG=chromium:956783 Change-Id: I43d91fc87b52ef303beb18ec06bff18f055a5eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391419Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#816658}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 506099f5. With Chromium commits locally applied on WPT: 099c04c7 "[layout] Fix -webkit-line-clamp with text-overflow: ellipsis" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ia087639196af6db7500d5d4ea737b3fd32ebbf0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467687Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816657}
-
Elly Fong-Jones authored
This change just renames that namespace everywhere. Bug: 1097204 Change-Id: I45f9bc9b0e44386e2b7b80f99bf43f57a7b81cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453869Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#816656}
-
Azeem Arshad authored
This CL fixes issue with bluetooth device list items in tray menu losing focus and reading out device name repeatedly. This was caused because all item views in the list are recreated every time the device list updates. Fixed this by re-using and re-ordering existing view items instead of deleting and re-creating every time. Fixed: 1111166, 1007371 Change-Id: I38c31e80fafec0bc80dd62bf37ff1b926ccf0014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465518 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#816655}
-
rbpotter authored
Bug: 1132403 Change-Id: I414ca14eb4b4b8f39231969d62e0f8c09e37e80e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467296Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#816654}
-
Bruce Dawson authored
32-bit Chrome continues to hit out-of-memory crashes. Some of these are presumed to be out-of-address-space crashes which are particularly easy to hit when running on 32-bit Windows where 32-bit Chrome will only get 2 GiB of address space. This change lowers the default stack size for Chrome to 0.5 MiB. This will not affect Chrome's main thread (it uses a fiber to create a larger stack) but it will affect Windows thread pool worker threads and a few other threads that we do not directly control. This change also lowers the stack size for threads that Chrome creates, but to minimize risk this is only done when running on 32-bit Windows, where the risk of running out of address space is most severe. This has been seen to save 25 MiB of address space (50 threads going from 1 MiB to 0.5 MiB). Bug: 981238, 1023804 Change-Id: Ia7fc03e0d4b79550cb67cb491892beaae08d5c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461589Reviewed-by:
-
Dylan Cutler authored
identifiability study. This API is suspected of leaking information to sites about users' machines that can be used to help track their identitiy across different domains. The IDL instrumentation reports digests of the return values of this method to UKM for analysis. Bug: 973801 Change-Id: I4dcb3519c784b2f103c87744187ee15cb21fb3bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463326Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#816652}
-
Peng Huang authored
The problem is because damage of a frame may not contain the whole render pass area, and then the overlay backing will not be drawn completely. Fix the problem by ignoring the frame damage area. This CL also fixes some sync token issues. Bug: 1135727 Change-Id: I6354b235fb9a7ffdeffe9c9270576ee648a7ba4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464914 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#816651}
-
Sharon Yang authored
In AXTreeConverter, use ConvertToFuchsiaNodeId to handle node id edge cases. Test: AXTreeConverterTest Bug: fuchsia:60692 Change-Id: I2fe50a5f522d2a58d8cb88bf3f086173a6c6ea62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466617 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816650}
-
Willie Koomson authored
This is a reland of 4bf05b95 with updated ArcVmClientAdapterTest unitests. Original change's description: > arc: Only call StopVm() if ARCVM is running > > This change adds a check in ArcVmClientAdapter::StopArcInstance() to see > if a VM is running (current_cid_ is set). If not, skip calling > ConciergeClient::StopVm() and notify observers that ARCVM is stopped > right away. > > BUG=b:169893632 > TEST=arc.AuthPerf.unmanaged_vm > > Change-Id: Ic927f122cacea0e89cacffbbcd67a217772dba43 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462573 > Commit-Queue: Willie Koomson <wvk@google.com> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816221} BUG=b:169893632 TEST=components_unittests --gtest_filter="ArcVmClientAdapterTest.*" Change-Id: I3f9440333f7339687e3a4bd36799de06376b9351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466559Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Willie Koomson <wvk@google.com> Cr-Commit-Position: refs/heads/master@{#816649}
-
Xianzhu Wang authored
The step in LocalFrameView has been merged into CompositingCommit (PaintArtifactCompositor::Update) in http://crrev.com/815947. Bug: 1132717 Change-Id: I69417ad86ae3b7507641ad693255aca9e58958ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462068Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 32 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2021-01-11. TBR=chromium-metrics-reviews@google.com Change-Id: I5b4b211108beb83581913b1937703415dd1a8600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467759Reviewed-by:
-
Andre Le authored
- Add customized notification view to phone hub notification controller. - Add "From Phone" to the notification's header. - Add IDs to NotificationViewMD to access the header in the view. Screenshot: https://screenshot.googleplex.com/3kW99Ch5wGvVrGz BUG=1106937,1126208 Change-Id: I0d0726d0d05c967384db702a557ba7a2895d77c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464163 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#816646}
-
Nicolás Peña Moreno authored
Privacy review: https://docs.google.com/document/d/1L93H6TYrtq4qRWzvEa3H7uKZhwWCtTTJ_bT6QFdg_ys/edit#heading=h.k5jx6iluw4yt Bug: 1133883 Change-Id: I07a89ebca144e8ee7d5600f2b5eba79b7069a64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450610 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816645}
-
Bao-Duy Tran authored
Despite what the current name implies, ComponentExtensionIMEManagerImpl is NOT an implementation of ComponentExtensionIMEManager interface (that's actually a concrete class, only ever subclassed by its mock). This is extremely confusing in terms of readability. In fact, ComponentExtensionIMEManagerImpl [sic] is an implementation of ComponentExtensionIMEManagerDelegate interface. An instance of the latter is dependency-injected for use by ComponentExtensionIMEManager itself. The already confusing misnomer is thus exacerbated, as both ComponentExtensionIMEManager and ComponentExtensionIMEManagerImpl [sic] tend to appear together while bearing no inheritance relationship. In this patch, ComponentExtensionIMEManagerImpl [sic] is renamed to ComponentExtensionIMEManagerDelegateImpl to reflect what it really is. Descriptiveness and conciseness improvements are out of scope. Also: - Extract ComponentExtensionIMEManagerDelegate to its own .h file. - Fix pre-existing std::unique_ptr usage as flagged by presubmit errors. - Replace pre-existing NULL with nullptr as flagged by presubmit errors. Bug: 1134465 Change-Id: If36b7d4c17ee19cdfc773c22ad4f384779b2a4fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440381 Auto-Submit: Bao-Duy Tran <tranbaoduy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#816644}
-
Peter E Conn authored
When the app is backgrounded and foregrounded again, DisclosureNotification#onStartWithNative is called again, but DisclosureController hasn't updated the model to reflect that the notification has already been shown. Change-Id: I96463c61e6e611528f47dd68f7c5a0cc4e34ec54 Bug: 1136477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467978Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#816643}
-
Alexander Dunaev authored
This CL extracts code that tests X11-specific event logic into test binaries that only run on X11 bots. Bug: 1109112 Change-Id: I3ff177c911e170a4899455e98437da7aa3615238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466245 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#816642}
-
Oriol Brufau authored
Consider this code: <style>i { white-space: pre-line }</style> X<i> </i><i> </i> The first time that NGInlineNode::CollectInlines runs, the text data will be "X", then "X ", and then AppendForcedBreakCollapseWhitespace will remove the trailing whitespace before inserting the forced break, so we get "X\n". But if some text is appended dynamically, CollectInlines will run again, and this time it will try to reuse existing items in AppendTextReusing. Before this patch, this would produce "X \n", which would trigger a DCHECK failure in ComputeOffsetMapping because it's a different string. Therefore, this patch prevents AppendTextReusing from reusing existing items if the last item to collapse with ends with collapsible spaces and the first item to reuse has 'white-space:pre' and begins with a newline. Bug: 1136688 TEST=external/wpt/css/css-text/white-space/pre-line-with-space-and-newline.html Change-Id: I0ff71b125b66256ec3b5c263605c3c116f9ac55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466279Reviewed-by: -
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d1bca09f4ab3..ccaef8525710 2020-10-13 rharrison@chromium.org Add running spirv-val on output of Tint If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: Ia7ffaa02a5368ca3e365f350ad88e198187fb013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468140Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816640}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8567edac4fdf..c0568abaca2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tnagel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tnagel@google.com Change-Id: I39cf9325ed7a8af8e312cd0928b5313a41f0d45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466922Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816639}
-
Dave Tapuska authored
These histograms are now logged inside blink and the appropriate tests should move as well. BUG=1097816 Change-Id: Ic84798cf223bf0dafe73bd813952d6678ba066aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461986 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#816638}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie167bdcfa494f7b6a7aaa0345c245167fcc9cded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466732Reviewed-by:
-
Anthony Vallee-Dubois authored
1/ RemoteCommandsInvalidator needs its Shutdown method called before destruction. 2/ RemoteCommandsInvalidator calls Start() itself after initialization is complete, no need to call it manually. Bug: 1137832 Change-Id: I4a76369100c2bc1d599ddb8b43fc055d6fd301d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463715Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#816636}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4fe1d403a22d..7c9f31beb6db 2020-10-13 inglorion@chromium.org cros_sdk: inform and raise vm.max_map_count if too low 2020-10-12 saklein@chromium.org Revert "deploy: Refactor SplitCPV to parse." 2020-10-12 saklein@chromium.org api/tutorials: Add part 4, faux decorators. 2020-10-12 jettrink@chromium.org build_api: add handlers for tot fw builder API 2020-10-12 jettrink@chromium.org generate: initial commit of firmware proto file 2020-10-12 manojgupta@chromium.org config_lib.py: Add hwtests for trogdor64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: If4857d6142f47d4d1db7674cfd5c220aa8701837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466929Reviewed-by:
-
Joon Ahn authored
Obtained via `wget https://unpkg.com/d3@5.16.0/` on corp network Bug: 1136195 Change-Id: I786c7a1e6a21f84392d455d15feeba5011cf231d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458847Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#816634}
-
Roman Sorokin authored
Fixes the issue when the user does not have the stored hour clock type preference - it uses the previous user preference. Bug: b/168759134 Change-Id: I415b85456dd578ac0565b42c819ef9d0b3590d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443009Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Chris Lu authored
Removes all confirm Messages and any unused classes from the legacy implementation. Bug: 1024288, 961343 Change-Id: I60ac68d040e33b08b677665670186631054d37ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416940 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#816632}
-
Weiliang Chen authored
When the display compositor is offscreen, and the passed in surface handle is null, return a stub class for overlay processor. This removes enable_overlay and could_overlay bools from other overlay processor classes. R=Khushal Bug: 898680 Change-Id: I75f72ba3dfabcc3ab0e2fe80509bb6cad7a74910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446463Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#816631}
-
Hitoshi Yoshida authored
A flag to check if a new RenderFrameHost is really new in WebTestControlHost::HandleNewRenderFrameHost(), we check if its RenderViewHost is already contained in |main_window_render_view_hosts_|. This detection is based on our past design that we don't delete RenderViewHosts in a web test, and we don't erase entries of |main_window_render_view_hosts_|. But it can happen if we start to swap RenderFrameHosts and RenderViewHosts with Browsing Instance Swap and/or Back-Forward Cache. After deleting an old RenderViewHost, a new RenderViewHost can be created on the address where the old one was allocated. This address conflict can lead a misjudge of the check of new RenderFrameHosts. This CL handles delete events of RenderViewHosts for main windows on WebTestControlHost, and removes their addresses from the list. Bug: 1136383, 1132180 Change-Id: I442ad67d2207a822dec37fb676d623dd035f0b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462997 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#816630}
-
Siyu An authored
In browsertests we don't wait for the bubble to be actually shown before verifying the view. Fix it by having the tests wait for extra events. Bug: 1133332 Change-Id: I898ae939a7b604dff6d170d54d136566ad34799f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464025 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#816629}
-
Xiaocheng Hu authored
crrev.com/c/2415244 introduced a new runtime flag for 'advance-override' but didn't properly handle it in the parser. As a result, the descriptor is leaked to web. This patch fixes the parser to make sure it's properly hidden behind the flag. Bug: 1137624 Change-Id: I69f161932aede553b1cb31b181187e687eba1df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466979Reviewed-by:
-
Morten Stenshorne authored
As part of bug 800764 I'm working on getting rid of BUILD.gn files in core sub-directories, and merge (almost) everything into one large core target. This was the only fuzzer whose target wasn't defined in core/BUILD.gn, so I moved it there. Bug: 800764 Change-Id: I468dc316795a2cc4e17fe424e35c7fea8da1de21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467856Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#816627}
-
Lan Wei authored
When we are using gpuBenchmarking.PointerActionSequence to simulate three mouse click, it only set the click count to 2, not 3. It should keep the mouse click count and decide if we should increase the count or set to 1 when we have a mouse press based on the interval of two mouse presses and difference between the current mouse positions and the last one. Bug: 1119679 Change-Id: If95c4da4aa62ae897204badfe1b1035f5240e0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446637Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#816626}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4159ffc366a3..320cf8513172 2020-10-13 bmeurer@chromium.org [third_party] Roll wasmparser 3.2.0 2020-10-13 sigurds@chromium.org Refactor static member to proper accessors 2020-10-13 tvanderlippe@chromium.org Use Node module resolution for tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1135143 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7cbe3e1f1e9164262e138fb983cd34d2534d9512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468138Reviewed-by:
-
Alexandre Courbot authored
BUG=b:153935975 TEST=Chromium builds for arm-generic. Change-Id: I633a3b6df23fc097920dc1101fd08bc89ed71e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460753 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#816624}
-
