- 04 Oct, 2017 40 commits
-
-
Mustafa Emre Acer authored
It was marked as flaky in 2011. Things have changed since then. Bug: 84729 Change-Id: I638f9c26e9636dff8f27903df5e64ff911d10a03 Reviewed-on: https://chromium-review.googlesource.com/700954Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#506513}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/fa8c08044989..0078e912718c $ git log fa8c08044..0078e9127 --date=short --no-merges --format='%ad %ae %s' 2017-10-04 angle-deps-roller Roll skia/third_party/externals/angle2/ a99ed554c..baf5d9458 (1 commit) 2017-10-04 csmartdalton Rename GrOpList::reset to endFlush 2017-10-03 benjaminwagner Add more detail to Swarming bot doc. Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I0516a7cca7bd2500a1425be30de1e82ebd15d74c Reviewed-on: https://chromium-review.googlesource.com/700755Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506512}
-
Marijn Kruisselbrink authored
This is a reland of 419b66b5 Original change's description: > Fix behavior around closed message ports. > > Connect a closed message port to a dangling message pipe to make sure > messages posted to the port end up getting lost, even after the message > port is transferred to a different process. > > Bug: 673526 > Change-Id: I95467bf5c3e1af316c8781bcca6dfdda29936fe8 > Reviewed-on: https://chromium-review.googlesource.com/690981 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505760} Conflicts: TBR=jbroman@chromium.org Bug: 673526 Change-Id: Iafdcc3e8891e80c120d270f6f04bb79a55092067 Reviewed-on: https://chromium-review.googlesource.com/700323Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#506511}
-
Mikel Astiz authored
When updating icon->page URL mappings, the code has historically associated icons to both the original page URL as well as the fragment-stripped page URL (for page URLs that contain a fragment/ref). This can cause "orphan" entries in the favicon database, i.e. mappings that don't have a corresponding history entry (because the page URL without a fragment was never actually visited). This means the history expirer will never take care of cleaning them up, leaking until the user clears all history. The original logic was introduced to fix crbug.com/498618 which is no longer reproducible even after this patch. With recent improvements in client-side redirect handling (e.g. https://chromium-review.googlesource.com/569760 or https://chromium-review.googlesource.com/595977), it is conceivable that these historical heuristics are no longer needed. Since this is hard to prove, we put the new behavior behind a feature than can be experimented via Chrome variations. Bug: 746268 Change-Id: Ieefb0fdb175d8858f1055af2dcc54df2e6f00a9a Reviewed-on: https://chromium-review.googlesource.com/649691 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#506510}
-
Wenzhao Zang authored
This is a superficial fix by checking |this.webview_.contentWindow|, but it's unknown why it is null. Two different scenarios were observed: 1) |Authenticator.onContentLoad_| is called with a non-null contentWindow (expected). 2) |Authenticator.onContentLoad_| is called with a null contentWindow, and is immediately called a second time with a non-null contentWindow. However, the first call already results in a failure and the page fails to load. This patch will temporarily fix this case. It's never observed that |Authenticator.onContentLoad_| is called only once with a null contentWindow . If that case happens, then this CL will make the page load successfully but without a |postMessage| call, and create additional issues. Bug: 711486 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieec4ac33673df9b393792ec82ea034546b165b0f Reviewed-on: https://chromium-review.googlesource.com/700034 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506509}
-
James Cook authored
We have not shipped Windows Ash for years. There is a 1:1 mapping between "use_ash" and "chromeos", so consolidate them. TBR=oshima@chromium.org for theme_resources.grd Bug: 673826 Test: compiles, bots Change-Id: If76122c1089cde2ec2b7d8822a4ca0adde25e5f3 Reviewed-on: https://chromium-review.googlesource.com/699663Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#506508}
-
Walter Korman authored
Bug: 771620 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2dc798906f16528b4e56b9f7c6bb7869327afb54 Reviewed-on: https://chromium-review.googlesource.com/700734Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Walter Korman <wkorman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506507}
-
Mike Reed authored
TBR= Bug: Change-Id: I2e837413ced0b2befa77e6c8cff4b548cc574198 Reviewed-on: https://chromium-review.googlesource.com/685586 Commit-Queue: Mike Reed <reed@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
-
Michael Thiessen authored
This CL adds a VrDisplayHost with bindings to the renderer to route requests for presentation through the browser. (The next CL will move the focus-checking code from VrShellDelegate into the new VRDisplayHost) Bug: 768923 Change-Id: I88ae9797ebe8cbf182b117c2cd07cf91d8d09361 Reviewed-on: https://chromium-review.googlesource.com/692505 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#506505}
-
chrome://net-internals/#bandwidthThanh Le authored
Bug: 764371 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I39faede4afe5fd094805d35dbccf847ac8d6c2b7 Reviewed-on: https://chromium-review.googlesource.com/692595Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
Philippe Hamel authored
Decouple overrides for MATCHES_PREVIOUS_LANGUAGE and LANGUAGE_DISABLED_BY_AUTO_BLACKLIST event types. This will allow to run experiments on heuristics override indepedently for each case. Bug: 769767 Change-Id: I24fffee57f0718575999b0ae88028be9dc19b895 Reviewed-on: https://chromium-review.googlesource.com/690437Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Philippe Hamel <hamelphi@chromium.org> Cr-Commit-Position: refs/heads/master@{#506503}
-
Max Moroz authored
TBR=brettw@chromium.org,inferno@chromium.org Bug: 771718, 759794 Change-Id: I1fc3ab8b054ce6eeee24d0c1c0599be216b2e386 Reviewed-on: https://chromium-review.googlesource.com/700974Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#506502}
-
Kenneth Russell authored
This should eliminate a synchronous IPC. Also change location of Mac-specific GPU back-pressure code. BUG=770924 Change-Id: Id44286f3359662ec3122b1e421d22f860ea24463 Reviewed-on: https://chromium-review.googlesource.com/696666Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#506501}
-
Sergey Ulanov authored
Added AudioOutputStreamFuchsia which implemented audio output using Fuchsia's media_client library. Also updated AudioManagerFuchsia to enumerate output devices and create AudioOutputStream. Bug: 737802 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I344ed5ad885d602574dd03ad31e85d7b76e0c2b8 Reviewed-on: https://chromium-review.googlesource.com/690622 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#506500}
-
Eric Willigers authored
Instead of using setTimeout to hope for a style recalculation, we now read offsetTop to force a style recalculation. Bug: 770362 Change-Id: Ic4918cd336aef56641e483ce2ae8d31ceb29acc9 Reviewed-on: https://chromium-review.googlesource.com/700154Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#506499}
-
Theresa Wellington authored
* Update content description for expand button * Update promo dialog text when accessibility is enabled BUG=767738 Change-Id: I0d33304803855e6fe894f26a83d10d9c3c361244 Reviewed-on: https://chromium-review.googlesource.com/699916Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#506498}
-
Eric Willigers authored
animations/unanimated-style.html was using setTimout(0) to wait for the initial style calculations before starting the animation. This isn't a reliable method. We now force style recalc explicitly by reading an element's offsetTop. BUG=770362 Change-Id: Icf518b3a43b51d854de81cc2fab371922e271e16 Reviewed-on: https://chromium-review.googlesource.com/699974Reviewed-by:
-
Eric Willigers authored
The test would previously fail if a rAF callback occurred 0.3s later than anticipated. We increase the animation duration, so that the animation will still be in progress if the callback occurs later that anticipated. The entry in TestExpectations is no longer needed. BUG=248938 Change-Id: Ida03745d18bd5a8ac4d454fc0e3fbdae5254d20a Reviewed-on: https://chromium-review.googlesource.com/699954Reviewed-by:
-
Daniel Murphy authored
This reduces the size of the extra large backing store class, and leads towards a smaller class in the future as other classes can now call the appropriate leveldb operations. R: cmumford@chromium.org, pwnall@chromium.org Bug: 725565 Change-Id: I29e7c72970b47801a51db4548f9e0a1b3ae26d4b Reviewed-on: https://chromium-review.googlesource.com/693382Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#506495}
-
Lucas Garron authored
TBR=palmer@chromium.org Bug: Change-Id: I14ff5597d1482fe56836ba49dcee6f6755c303c5 Reviewed-on: https://chromium-review.googlesource.com/673127Reviewed-by:
Lucas Garron <lgarron@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#506494}
-
Mike Wasserman authored
Bug: 771381 Change-Id: I42a1b5c2d691e9973f21ac0de8fc441aa9fe3e21 Reviewed-on: https://chromium-review.googlesource.com/699940Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#506493}
-
dpapad authored
This is a necessary preparatory step for optimizing the MD Extensions page with polymer-bundler. Side benefits of this change: - No need for the repeated "resources/md_extensions" prefix on every file's path declaration in the grd file. - Faster build times when a file is touched (no longer need to rebuild the gigantic browser_resources.pak) - No longer need to call source->AddResourcePath() repeatedly in extensions_ui.cc. Also moved two HTML files that were misplaced in the old Extensions folder even though they are only used in the new MD version. Bug: 764126 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie9b13ed4f46fa14f27d9280eca40c9cd79a6d4b4 Reviewed-on: https://chromium-review.googlesource.com/696670 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506492}
-
Ke He authored
Define the mojom::InputDeviceInfo. Simply replace the old native InputDeviceInfo. Make sure all the existed test cases pass. In next CL we'll do the mojofication. The InputServiceProxy will be removed then. BUG=767309 Change-Id: Ic307a794592e74d73fb016c56ec24c027441c41b Reviewed-on: https://chromium-review.googlesource.com/676944Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#506491}
-
Lucas Garron authored
content::SSLManager previously contained some logic for computing whether/how an interstitial should be bypassable, which it then passed into ContentBrowserClient::AllowCertificateError(), though only ChromeContentBrowserClient's implementation was using it. This presents a problem for the interstitial refactor because this logic is needed for interstitial display, but SSLManager/ChromeContentBrowserClient::AllowCertificateError() is no longer going to be the point that triggers interstitial display. We're moving this logic into //chrome's SSLErrorHandler, which is a more convenient place for the logic to live because both the old and new interstitial display codepaths pass through that point. This change moves the calculation of the following into ssl_error_handler.cc: 1. The mapping of cert_error -> fatal (opposite of "soft overridable"). - Moves from SSLManager::OnCertError() and into an anonymous namespace in `ssl_error_handler.cc`. 2. The calculation of an SSLErrorUI::SSLErrorOptionsMask mask for SSLBlockingPage::Create(). - Moves from ChromeContentBrowserClient::AllowCertificateError(). In addition, this change removes the SSLManager::OnCertErrorInternalOptionsMask enum, since its use would be reduced to a passing a single bool from SSLManager::OnCertError() to SSLManager::OnCertErrorInternal(). (Also, it was confusingly similar to SSLErrorUI::SSLErrorOptionsMask.) This change leaves the `overridable` parameter in ContentBrowserClient::AllowCertificateError() unused. The followup CL at crrev.com/c/680114 will remove it. Bug: 768105 Change-Id: Iffbd56d944fc96427cb41a691aecd04236bb4cb6 Reviewed-on: https://chromium-review.googlesource.com/679937 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#506490}
-
Vladimir Levin authored
This patch changes the approximate scale math to use rect bounds instead of a vector, which yields more accurate results. This means that if a layer is effectively shrunk after the transformation we won't use a larger scale which could have been the case with the scale math. R=chrishtr@chromium.org Bug: 766021 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I42aea3e7b9900b2a1e5499c8c24d7264b7bd6d3f Reviewed-on: https://chromium-review.googlesource.com/693303 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#506489}
-
Andrew Grieve authored
And add tests :) Change-Id: Ic26d1c3d27c0af101d9c2ea94284f85dc21b2027 Reviewed-on: https://chromium-review.googlesource.com/700656 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#506488}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 570b9f37. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2551 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: Ia2f1f2872d20cfb83f655db2b3716a9f5a8d9f8f Reviewed-on: https://chromium-review.googlesource.com/700716 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506487}
-
Dave Schuyler authored
This CL adds a listener to the settings subpage that will allow setting the filter value. The filter may be cleared by setting the value to ''. Bug: 770423 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If4ac8e4bb1f1b38224b52e970f549293ff9b5e9d Reviewed-on: https://chromium-review.googlesource.com/693390 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#506486}
-
Tibor Goldschwendt authored
Bug: Change-Id: Ib0c511a7e032b05d9b3644966419520aa18160c3 Reviewed-on: https://chromium-review.googlesource.com/699702Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#506485}
-
Tom Sepez authored
This is another step towards normalizing (somewhat) the InitializeSandbox() API across the various platforms. Change-Id: I86279c2f5c26c9c1bd0b7586b7ac882c3667f6e5 Reviewed-on: https://chromium-review.googlesource.com/699154 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#506484}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/aafdc153a2b7..3e3a78b68c31 $ git log aafdc153a..3e3a78b68 --date=short --no-merges --format='%ad %ae %s' 2017-09-13 art-snake Improve readability for CPDF_LinearizedHeader. 2017-10-04 hnakashima Fix UAF in SetVisible(). 2017-10-02 art-snake Unify parsing of cross ref table v4. 2017-10-02 art-snake Simplify CPDF_DataAvail::ParseIndirectObjectAt Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I581e223cbaa4d2fc0e2410fd567fdad0d91ff96a Reviewed-on: https://chromium-review.googlesource.com/699644 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506483}
-
Scott Little authored
Bug: Change-Id: I9f792d5b74dd28ee9442725a182a69de62c4f66e Reviewed-on: https://chromium-review.googlesource.com/700794Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#506482}
-
rbpotter authored
Bug: 770851 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idc4fc5ac44534f51305f6573ba1a1f00c55d5672 Reviewed-on: https://chromium-review.googlesource.com/699638Reviewed-by:
-
Alan Bram authored
Change-Id: Iaf4d6035552698559e56b1459d5b3e4c4e47ac38 Reviewed-on: https://chromium-review.googlesource.com/699934 Commit-Queue: Alan Bram <flyboy@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#506480}
-
Devlin Cronin authored
It looks like many of the strings from the old delete browsing data interface are unused, but still included (the rest of the old browsing data settings UI was removed in crrev.com/1f2b58d7). Remove them. Bug: None Change-Id: Idb3c724430c626d5ae262f55e147107f6de34f60 Reviewed-on: https://chromium-review.googlesource.com/699804 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/672cabd12c68..d0b91b8f3a17 $ git log 672cabd12..d0b91b8f3 --date=short --no-merges --format='%ad %ae %s' 2017-10-04 nednguyen Add snap-it tests to Catapult CQ Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I55dd57a09a38178eb2437fd9298ac940df0b92ae Reviewed-on: https://chromium-review.googlesource.com/700795 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506478}
-
Tom Anderson authored
This CL: * Fixes some manpage syntax. * Compresses the manpages. * Adds manpage entries for google-chrome-stable and google-chrome for the stable channel. * Fixes a reference to google-chrome in the RPM spec. * Handles rpmlint suppressions using a conf file instead of just filtering out what we don't want. This fixes the following lint errors: * lintian: * E: chromium-browser-stable: manpage-not-compressed usr/share/man/man1/chromium-browser.1 * W: chromium-browser-stable: manpage-has-errors-from-man usr/share/man/man1/chromium-browser.1 1: warning: macro `"' not defined * rpmlint: * chromium-browser-stable.x86_64: W: manpage-not-compressed bz2 /usr/share/man/man1/chromium-browser.1 * chromium-browser-stable.x86_64: W: manual-page-warning /usr/share/man/man1/chromium-browser.1 1: warning: macro `"' not defined * chromium-browser-stable.x86_64: W: no-manual-page-for-binary google-chrome * chromium-browser-stable.x86_64: W: no-manual-page-for-binary chromium-browser-stable BUG=771373 R=thestig@chromium.org Change-Id: I5d1921150945123b72b5f2a50714c3094a526648 Reviewed-on: https://chromium-review.googlesource.com/699855Reviewed-by: -
Scott Violet authored
For OOPIF we want the parent renderer to embed the child. This is mediated by the browser. That is, we want something like the following: 1. Browser obtains WindowTreeClient from child renderer (cWTC). 2. Browser passes cWTC to parent renderer. 3. Parent renderer creates Window in mus and calls Embed() with cWTC. Unfortunately in step 2 if the parent renderer were compromised then it could directly call functions on cWTC, such as spoofing events. This is a security problem. To avoid this scenario I'm adding the option of a two phase embed. This results in the following: 1. Browser obtains WindowTreeClient from child renderer (cWTC). 2. Browser calls ScheduleEmbed() on it's WindowTree connection. ScheduleEmbed is a new function that takes a WindowTreeClient and returns a token. 3. Browser waits for token. 4. Browser passes token to parent renderer. 5. Parent renderer creates Window in mus and calls Embed() passing token. With this flow renderers don't end up with a WindowTreeClient from a different client. BUG=758387 TEST=covered by tests Change-Id: I819a57cd811d4939cbeecec8aeb8273eefca64f5 Reviewed-on: https://chromium-review.googlesource.com/699519Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#506476}
-
Andrew Grieve authored
This reverts commit 1dd22ad0. Reason for revert: Breaks when lint_suppressions_file is assigned within //build_overrides/build.gni Original change's description: > Android: Allow per-target lint suppression configuration > > This change allows for Android lint suppression configurations > to be defined on a per-target basis (assuming said target is > "Android lint capable") rather than having one global config. > This will allow embedders to keep upstream's lint config for > Chromium targets (w/o patching), while using a separate config > for the embedding application. > > Bug: 737897 > Change-Id: Ieccb95767e0ce541522d7a53edbe734c5bbfe6dc > Reviewed-on: https://chromium-review.googlesource.com/698297 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506393} TBR=agrieve@chromium.org,justmoto@amazon.com Change-Id: Ib15a61731179cc9ffc8d415844cfe8fbbc8e68eb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737897 Reviewed-on: https://chromium-review.googlesource.com/701014Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#506475}
-
Justin DeWitt authored
This enables the Downloads Home integration as well as the notification background task. The UI can still be disabled manually in chrome://flags. Bug: 701939 Change-Id: Ifd38830b4442465287bb47f6440afeb499e3e234 Reviewed-on: https://chromium-review.googlesource.com/699578Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#506474}
-
