- 05 Apr, 2019 40 commits
-
-
Eric Karl authored
Small cleanup now that all Skia representaitons have a SharedContextState - no need to pass in GrContext. Change-Id: I05aafe172d05bceeb36247ee5005ac8cfdf00b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554297 Commit-Queue: Eric Karl <ericrk@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#648378}
-
Alexander Alekseev authored
Chrome OS OOBE Welcome screen was incorrectly shown after restart to Gaia screen. This Cl fixes the issue. Bug: 949768 Change-Id: I3399b2bf8e5700dbb3a0228fe4a6bc8b961b9c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555045 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#648377}
-
Xiaocheng Hu authored
The function and its two callers are defined but not used. Hence, this patch removes them. This also makes it easier to change PreviousLinePosition to a hit test based approach (*) (*) http://bit.ly/2WB70oR Bug: 947179 Change-Id: I3c5cc306c973cfd61b75269b666be1dc871870b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554134Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#648376}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I1b2803a254e06187d2693fc6d71b405e8cdc2e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553919Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648375}
-
Mustafa Emre Acer authored
Bug: 941488 Change-Id: I16a2db2e2dfdf2bd0ec8ec448038d8eb701740c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552408Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#648374}
-
Karandeep Bhatia authored
Fix a crash in PluginManager::UnregisterNaClModule which happens since OnExtensionUnloaded can be called twice in succession for an extension (which is itself a bug). Also, remove an incorrect DCHECK in PluginManager::RegisterNaClModule (Extension manifests are free to add duplicate module paths). Add a regression test. BUG=460699, 708230 Change-Id: Ie89b73d57cf3d02c4b300cc082f22a928c780f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549852 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#648373}
-
Avi Drissman authored
This reverts commit 2806da1a. Reason for revert: Reverting as suspect for https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux%20(dbg) breakage. Original change's description: > [traffic_annotation] use {link,proto}_deps instead of deps > > I will deprecate deps in proto_library for improved build throughput. > > Instead, > * use proto_deps for proto file generating task dependency > * use link_deps for link/compile time dependency > > Bug: 938011 > Change-Id: Ieb1281a9653fdfdd1add3594b2b19a138aff37ff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503275 > Commit-Queue: Ramin Halavati <rhalavati@chromium.org> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637670} TBR=thakis@chromium.org,tikuta@chromium.org,rhalavati@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 938011 Change-Id: I6b3725b8e1b68fbc280a8b8be87b4825b526e4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555334Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#648372}
-
Dominik Laskowski authored
This CL consolidates the bitmasks in the QueryContentProtectionTask response, and factors out the mapping of connection type to content protection method for reuse in ApplyContentProtectionTask. Bug: 929449 Test: display_unittests Change-Id: I14fa63e8cdb0dc70df3745cd5324b8c54643eb40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553582 Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#648371}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c7755d947084..7340124746df git log c7755d947084..7340124746df --date=short --no-merges --format='%ad %ae %s' 2019-04-05 halcanary@google.com SkString: simplify impl 2019-04-05 khushalsagar@chromium.org remote fonts: Validate format on deserialized glyph. 2019-04-05 jvanverth@google.com Fix WritePixels and ReadPixels for MacOS Metal 2019-04-05 michaelludwig@google.com Support clip masks for SaveLayerRec and drawSpecial in Ganesh 2019-04-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-05 halcanary@google.com SkPDF: Add regression benchmark for multiple path clips 2019-04-05 nifong@google.com Add helper for loading files, use let Created with: gclient setdep -r src/third_party/skia@7340124746df The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:949000,chromium:947381 TBR=jlavrova@chromium.org Change-Id: Ic3dd3b5f8c277896587fcaa73770d0c19340a98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554594Reviewed-by:
-
Alexei Filippov authored
BUG=937880 Change-Id: I165c6de88f4d63080287704a066728757c2a5c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531561 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#648369}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b9a71427efd2..5f388c245293 git log b9a71427efd2..5f388c245293 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 timvp@google.com Vulkan: dEQP-EGL.functional.image.modify.* Created with: gclient setdep -r src/third_party/angle@5f388c245293 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: Ic09a0ec00333fd843e818693990c50594650d739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554596Reviewed-by:
-
Ian Kilpatrick authored
This is the same as the container builder's layout object, so use that instead. Also moves where we set the margins to the "post-layout" site along with other copy-back calls. There should be no behaviour change. Change-Id: I198dc1548592ccb26553438cab6a2488d395b144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554792Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#648367}
-
David Valleau authored
Now that mdns resolutions is supported in CUPS, we don't need to hold the resolved uri in the printer object anymore. BUG=758018,936251 TEST=Able to configure and print using mdns resolution in CUPS Change-Id: I2f149e6558be4689e7b13122a5853feba7ea6b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551683 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#648366}
-
Peter K. Lee authored
This is from current origin/stable label. commit 2cacdff921fb067d93cf476a10f7decb1a9fb766 (tag: v81.0.0, origin/stable) Bug: 947496 Change-Id: I50b84317caf2fdb9ef8e68d56d6cc6c691986880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554133Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#648365}
-
Fabrice de Gans-Riberi authored
The //fuchsia/engine:test_support target was depended upon by multiple targets while it was only actually used by the //fuchsia/engine:web_engine_unittests target. Bug: 922635 Change-Id: I5b943e30629c934c7bdfdb8db0894933d66c7d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555373Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#648364}
-
Mei Liang authored
The cause is TabModel#setIndex() event is fired when undoing the first tab, before the tab actually undo in TabGroupModelFilter. This CL is a band-aid fix for M74. We cache the selected tab that is not exist in the TabGroupFilterModel. And try to select that tab on the next addTab()/undo call. This will fix the current crash and will not causing any side effects on TabGroupModelFilter normal usage. Bug: 948518 Change-Id: Ic65e521baebe65c54b1033f6be35dd2dbdd1a676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552281Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#648363}
-
Eric Willigers authored
Web Share now rejects share attempts if a file with a non-approved MIME type is being shared. Design doc: https://docs.google.com/document/d/1wfcy-hVjEbSuxlBjj_2azqmov8s9ECG1Fm7XoS_XUus/edit?usp=sharing Also, ensure temporary files are created with "." before the extension. Bug: 903010 Change-Id: I318e9c908bd9816df35d1d2d64679c984f6bdff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554465Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#648362}
-
Xiyuan Xia authored
Revert https://crrev.com/c/1504434 since it is not an app list only problem. Fix it in MoveWindowToEnsureCaretNotInRect so that it does not move a window beyond work area top. Bug: 936381 Test: Additionally test with a browser window using the repo steps. Change-Id: I4be2ee7173748af10acefb7ed880514424644ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555245 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#648361}
-
Joey Arhar authored
Bug: 899386 Change-Id: I5e9157be89a2965bb5261898ed03d843bfbf189b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536685Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#648360}
-
Hitoshi Yoshida authored
Bug: 781257 Change-Id: I4fbebdd57a03ca5329d7020dcaf47150fd3ec928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551728 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#648359}
-
Nektarios Paisios authored
Removed the use of std::map and checked all Blink accessibility code for any usage of std containers. R=dmazzoni@chromium.org Change-Id: I9a285b1aa018d973b3d75d738ab6f2b492a3df2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554144 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
-
Jun Mukai authored
This is a reland of 402ea29b Original change was reverted due to msan failures. Indeed it didn't take care of the case of window destruction during move. This CL includes its fix. Original change's description: > Process touch events during the tab-dragging window move > > When the touch events move very quickly on detaching, some > touch events are already queued, those queued touch events > aren't processed properly. > > - Detach() aren't releasing the capture on the source widget. > This means those queued touch events are targeted to the > source widget instead of the moving widget, but the touch > history is already transferred to the moving widget, which > makes troubles on gesture recognition. We can release the > capture on the detach on this specific situation. > - the recognized gestures are sent to the root window of > the moving widget and nobody can handle. The new class > RemainingGestureEventHandler handles them. > - RemainingGestureEventHandler should not handle events > originated from ET_TOUCH_CANCELLED -- some test cases > actually fail if so. ET_TOUCH_CANCELLED can happen internally > within the browser (like Window::CleanupGestureState()), > but that's not the intention of this class. > > Bug: 943316 > Test: the new test case in interactive_ui_tests > Change-Id: I679562d7707342874960dd7ff4d70d749f1ad437 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545113 > Reviewed-by: Jun Mukai <mukai@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Jun Mukai <mukai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647789} Bug: 943316 Change-Id: Ice077b4e53309a2a59b254581da7e6dd0f3b409c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553171 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
-
Austin Eng authored
Bug: 877147 Change-Id: I9bd31a9f9731e3cd50f43e246f9d0565f107bd9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546058Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#648356}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dbc721d65f0d..9198ef8ede66 git log dbc721d65f0d..9198ef8ede66 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 nodir@google.com [bot_update] Default to refs/heads/master 2019-04-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@9198ef8ede66 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:940214 TBR=agable@chromium.org Change-Id: I30e05bb762b0cbb9c78c4cf47c5aecfd16ad45bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553455Reviewed-by:
-
Alex Cooper authored
Currently, the test pages only check once (on page load) if the specific session type is supported. If a device is disconnected while a user is on the page, the "Enter VR" button does not update with that change. This change enables support within the button to listen to device change events and update it's state based on whether the specified session types are supported, and changes all of the pages to consume this new option. Given the nature of xr-barebones, it implements this directly as well rather than relying on the button. Bug: 873409 Change-Id: I4be8a50f88f796b2e4d7d9f0834d4d77cda7d586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554643Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#648354}
-
Dominic Mazzoni authored
This slipped through the cracks earlier. Our approved strings include a string to use when no description is available. We decided to use the same string if the result was empty, and if there was a server failure. Bug: 905419 Change-Id: I7c8692f550999428ba2f08ecbc14e3fed6b05a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552444Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#648353}
-
Mustafa Emre Acer authored
Bug: 950081 Change-Id: I6a2fb232edaa4f04f761d64e5d223f5fc0471176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555044 Auto-Submit: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#648352}
-
Aran Gilman authored
This mostly entailed running clang-format -i * followed by git cl format. I also manually edited some if statements to reduce nesting. Change-Id: Ibfd24d1d763435e590a93a7fc5d05572e7fa35d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548068Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#648351}
-
Peter K. Lee authored
This experiment has been defaulted to true for a while now. Simplified the code. Bug: 884724 Change-Id: I47fb608b703f292ad8edfe8a91ab9a446fe4d6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554295Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#648350}
-
Theresa authored
The padding should alwas be the height of the tab strip, as set in XML. BUG=946991 Change-Id: Ifd701988a90ec4289979df4632b2999ae4f14d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553827Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#648349}
-
Robert Sesek authored
isolate: isolate …/out/Release/browser_tests.isolate: partitioning deps: lstat …/out/Release/gen/ui/login/login_resources.pak: no such file or directory https://ci.chromium.org/p/chrome/builders/try/linux-chromeos-chrome/676 Remove test references to login_resources.pak. It was deleted in I66ea89bd1f240933c9053da5a722b848df79ce40. Tbr: rsorokin@chromium.org Bug: 934224 Change-Id: Id5f84da2a0b1d01fdcafda7480a1e29ab336d442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554781Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#648348}
-
Wei-Yin Chen (陳威尹) authored
Add the whole team to the watch list. Bug: None Change-Id: I810a37552ab73ab0a128e36879da2847084d2199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554314Reviewed-by:
-
Etienne Pierre-Doray authored
This CL removes preempted sequences from TaskTracker, removing need for CanScheduleSequenceObserver and simplifying shutdown. A CanRunPolicy enum is used instead, specifying whether or not tasks at a given priority can run. When CanRunPolicy is updated, wakeup workers needs to be done as appropriate. In addition, Shutdown was split in 2 phases start + complete to allow caller (TaskScheduler) to update CanRunPolicy after shutdown was started. This CL was recycled from: https://chromium-review.googlesource.com/c/chromium/src/+/1478007 I took ownership because simplifying Sequence lifecycle will simplify implementation of job API. TBR=gab@chromium.org Bug: 889029 Change-Id: Ie5dbc226705880c5e598e013aa2dd3e7e874158b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531161Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#648346}
-
James Lissiak authored
This patch adds a new setting to the Elements category which toggles showing the styles information on the overlay tooltip when the user is in inspect mode. You can see the difference enabled by the new setting in the following screenshot: https://imgur.com/a/BjQPwe9 This fixes #948417 Bug: 948417 Change-Id: If15bc5d73fb1571079697bfccd9e5a74e975bd59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553465 Commit-Queue: James Lissiak <jalissia@microsoft.com> Reviewed-by:
-
Dominic Mazzoni authored
Bug: 931902 Change-Id: I5fdb90494bbe719f1310f88f9426323edaf4f341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1471269 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#648344}
-
Yue Li authored
Update the status sync logic: we used to do the status sync on hotword change, but it triggers the flow at some unexpected cases. Thus now we only do the sync on service start and hotword change from settings menu. Bug: b/128603723, 941566 Test: Manual Test Change-Id: I078ae442fe173a00c6d6808fadc621a4e1052c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497199 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#648343}
-
Yue Li authored
Bug: b/129157032 Test: Manual Test Change-Id: I2745579fbc1ed6e3d7316d046b53eea145e12130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542778 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
-
danakj authored
The WebLayerTreeView is a shortcut past the WebWidgetClient that is not needed now that we always composite. This works toward eliminating this extra API layer. More importantly this helps us Close/Restart the WebWidget parts of WebViewImpl by not requiring plumbing 2 pointers with slightly different lifetimes (WebLayerTreeView is created inside the Init of the WebWidgetClient). This will help avoid a bunch of complexity in creating WebFrameWidgets and other WebWidgets. The RequestNewLayerTreeFrameSink() method is added to CompositorDependencies so that RenderWidget unittests can run the compositor without needing a real RenderThreadImpl. R=pdr@chromium.org, piman@chromium.org Bug: 912193 Change-Id: Ieae414387f347e065ab48f536c770e7c55f4d337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546148 Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#648341}
-
David Valleau authored
In preparation for the removal of the effective_uri field, this change updates the HandleAddDiscoveredPrinter function to perform mDNS resolution on the printer before attempting to query it for ipp attributes. This resolution will be redundant for the time being, but a future change will remove the effective_uri field so that this is necessary. BUG=758018 Change-Id: Ie899fd55cd7742e948660ecd19daa0054bc965b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551931 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#648340}
-
Toni Barzic authored
This updates reset_browsertests to use views based login instead of deprecated web UI login. Portion of the tests check that reset screen is shown on restart if local state suggests that reset was requested in the previous session - web UI account picker UI is not expected to show up in that scenario, so there is no value in testing it. BUG=944345 Change-Id: I3953472130878b048ea5b86caaafb1962e1bef96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553874 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#648339}
-
