- 16 Sep, 2019 40 commits
-
-
Tim van der Lippe authored
The new compiler caught a lot of pre-existing issues in the codebase. Sadly, the old compiler version was not smart enough to understand the new changes. Therefore, the changes have be included in the same CL as the compiler update. Most of the changes are related to better handling of prototype and class inheritance, as well as handling of null/undefined tracking. Change-Id: I3941a3a240a4d09c4945e1e20d2521090ef837c9 Bug: 991710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762081Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@google.com> Auto-Submit: Tim van der Lippe <tvanderlippe@google.com> Cr-Commit-Position: refs/heads/master@{#696761}
-
Ioana Pandele authored
TBR=estade@chromium.org Bug: 1004228 Change-Id: I1ac3a8dc1bad8b53a02dd83648337f1355f8c552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806873Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#696760}
-
Ioana Pandele authored
This reverts commit 41edd5e1. Reason for revert: external/wpt/orientation-sensor/AbsoluteOrientationSensor.https.html external/wpt/orientation-sensor/RelativeOrientationSensor.https.html are consistently failing on Mac. Bug:1004253 Original change's description: > Use computed font-size for em/rem resolution. > > This makes us match how Firefox applies minimum font-size and makes us > not break relative length computation when pages use a font-size less > than the user's minimum font-size as a basis for widths, heights, > margins, padding, etc. > > This is a behavioral change for relative lengths for the following > cases: > > - minimum-font-size does not affect em lengths > - minimum-logical-font-size does not affect em lengths > - text autosizing does not affect em lengths > - text scaling accessibility setting in Chrome for Android does not > affect em lengths > > Test expectation changes and reasons: > > Text scaling no longer applies to relative lengths (text zoom set from testRunner): > > svg/zoom/text/zoom-hixie-mixed-008.xml > svg/zoom/text/zoom-hixie-rendering-model-004.xhtml > svg/zoom/text/zoom-svg-float-border-padding.xml > > Minimum logical font-size not applying to relative lengths (minimum logical font-size set to > 9px when running layout tests): > > fast/backgrounds/background-position-parsing.html > virtual/controls-refresh/fast/forms/controls-new-ui/password/password-eye-icon-zoom-0.5x.html > http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm > > Bug: 308862 > Change-Id: I5e5fb99e69b516c9c0c3758d232cbae8f7f5894a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803281 > Reviewed-by: Emil A Eklund <eae@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696694} TBR=pdr@chromium.org,eae@chromium.org,drott@chromium.org,futhark@chromium.org Change-Id: Iaca7d3c69056f1b8f77ea4f212bf4abd08c613d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 308862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804478Reviewed-by:
-
Mikhail Khokhlov authored
This CL splits the processor module into two: * command_line module which is responsible for defining and processing command-line options. * processor module which is responsible for processing of intermediate results. Bug: 981349 Change-Id: I408697751e2425eeaa2cacecc0e15ab04f99c284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795765 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#696758}
-
Nico Weber authored
On x86_64 Windows, asm volatile("int3"); __builtin_unreachable(); now produces just "int3" instead of "int3; ud2" previously, so change immediate_crash.h to make sure TRAP_SEQUENCE() keeps expanding to "int3; ud2". The Windows code now matches the code we use for other x86_64 platforms (except macOS which is still different). Ran `./tools/clang/scripts/upload_revision.py b4160cb94c54f0b31d0ce14694950dac7b6cd83f`. Bug: 1002492,958373,1002498 Change-Id: I3c0c553fecb02468c62e8ee14ebd803aae966861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802536 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#696757}
-
Henrique Ferreiro authored
Migrate the remaining interface from input_handler.mojom. Bug: 955171 Change-Id: Ie384350201e81bd5c0a3e6869dbbb0c5c3f123c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798351 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#696756}
-
arthursonzogni authored
It was content/public exported, but not used at all. TBR: clamy@chromium.org Bug: None. Change-Id: I357f8190f6c24f772edb7f4e7b426976cbc59a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798607Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#696755}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/899716dc3240..746bc59b27a5 git log 899716dc3240..746bc59b27a5 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 fmayer@google.com Merge "Update docs about x86 known issue." Created with: gclient setdep -r src/third_party/perfetto@746bc59b27a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic5373b2ce1724d816577e113e33c5b40a544af38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806416Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696754}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f02b13925471..11fbf615cfd5 Created with: gclient setdep -r src-internal@11fbf615cfd5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I461d56710cb93446c0af51b3554b37033a75330a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805483Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696753}
-
Morten Stenshorne authored
This will set temporary proper override sizes. We already use this mechanism in NGBlockNode::RunLegacyLayout(), but that one only has an effect for things that are done from within legacy layout (LayoutObject::Layout()). Overflow calculation happens after layout, and is done by the legacy engine, even for NG objects. Bug: 908083 Change-Id: I2b4e88c096f138aa820856e3c79e1ddcef07a3da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801770Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#696752}
-
Clemens Arbesser authored
The UMA histogram AutofillAssistant.DropOutReason is currently showing incorrect data, because the number of autobot drop-outs adds up to more than the number of autobot starts. This likely happens because the shutdown procedure for autobot is different between closing autobot from the user interface versus closing Chrome entirely. As a consequence, dropout reasons are logged in two different places in code. We might be able to refactor such that we can avoid this in the future. For now and as a hotfix, this CL ensures that every instance of autobot can record at most one dropout reason. Bug: b/140371674 Change-Id: I17b882e1327be6228867321b4ba6536b45a6822f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780834Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#696751}
-
Alex Clarke authored
Previously the executors where using OnceCallbacks. The problem with that is we're going to redundantly invoke the callback destructor when we run the callback. This is redundant because the executor will overwrite itself (and the callback it contains) with the promise result. This patch takes advantage of the way Callbacks operate in chromium and casts the callback to the repeating version and passes a const ref to the executor. This eliminates the overhead of passing a scoped_refptr<Callback> by r-value. We still respect the once-ness of these callbacks despite these binary size shenanigans. Note Promises are experimental, not used in production code at this time. We are landing this only to make it easier to experiment with binary size. Bug: 906125 Change-Id: Ifd8f53e6dfdc6a65921b53222e05bdf384ac8df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803135 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#696750}
-
Jan Scheffler authored
This patch invertes the color of checkboxes in the inspector style panel while in dark mode. Bug: chromium:950769 Change-Id: Iabdd235dcaa0d592db15afeba869f9c43815de45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786641 Commit-Queue: Jan Scheffler <janscheffler@google.com> Reviewed-by:
-
Yang Guo authored
This reverts commit fe3aa7f1. Reason for revert: Original culprit for the failing tests has been reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1806414 Original change's description: > sheriff: Disable devtools accessibility tests > > Tests are failing on linux: > > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/83157 > > TBR=pfeldman@chromium.org > > Bug: 1004150 > Change-Id: I4bf6d6a10d60c7659a23b6aba1884a5995957531 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804709 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696729} TBR=pfeldman@chromium.org,ortuno@chromium.org Change-Id: I24340b26d513d1013077eca1189003e55824f7e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1004150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804476Reviewed-by:
-
Mike Jackson authored
This reverts commit b1540bd6. Reason for revert: Breaks http/tests/devtools/a11y-axe-core/basic-a11y-test.js and 5 other(s), see issue 1004150 (on Linux) Original change's description: > Reland "Update axe-core to v3.3.2" > > This is a reland of 0f435b65 > > Original change's description: > > Update axe-core to v3.3.2 > > > > This change updates the version of axe-core to the latest released > > version. As part of picking up the latest version, the following > > additional changes were made: > > > > 1) axe-core removed the 'href-no-hash' rule, so that been removed > > from the test list. > > > > 2) Several 'link-in-text-block' tests started failing with > > axe-core v3.0.2 (and later). These tests do pass in v3.0.1, but > > are disabled as part of this change. > > - CrManagementA11yTest.SimpleTest_link_in_text_block > > - CrManagementA11yTestWithExtension. > > ExtensionSection_link_in_text_block > > - CrostiniAccessibilityTest.CROSTINI_link_in_text_block > > - CrExtensionsA11yTest.NoExtensions_link_in_text_block > > - MultideviceA11yTest.MULTIDEVICE_link_in_text_block > > - MultideviceFeaturesA11yTest. > > MULTIDEVICE_FEATURES_ACCESSIBILITY_link_in_text_block > > > > 3) One 'heading-order' test started failing in v3.0.0 (and later). > > This tests does pass in V2.4.2, but is disabled as part of this > > change. > > - CrExtensionsA11yTestWithMultipleExensions. > > WithExtensions_heading_order > > > > I spent some time investigating the test failures, and it looks > > like axe-core is highlighting legitimate product issues. > > > > Change-Id: I99c1f85087aea873e29b413dca967864fc93c786 > > Bug: 984817 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790125 > > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > > Commit-Queue: Mike Jackson <mjackson@microsoft.com> > > Cr-Commit-Position: refs/heads/master@{#695885} > > The original change caused failures in the Deterministic Linux builds. > This was due to devtools tests taking a dependency on axe.js, but not > declaring that dependency in the build.gn file. This has been fixed > in this change. > > Bug: 984817 > Change-Id: I0e55bae8014654ba92afb69bb6ff8d553c018126 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800003 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Commit-Queue: Mike Jackson <mjackson@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#696545} TBR=aboxhall@chromium.org,pfeldman@chromium.org,hcarmona@chromium.org,luoe@chromium.org,mjackson@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 984817, 1004150 Change-Id: I5dc2d939ebcf338d8bd6a5ca95d41a25afc5d57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806414 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#696747}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d32dae1bb37c..8f08fed925c5 git log d32dae1bb37c..8f08fed925c5 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src ad7f2c5c4c7f..1e146e8a3485 (2 commits) Created with: gclient setdep -r src/third_party/angle@8f08fed925c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: chromium:None Change-Id: I2ea016f72897bdd394f6b04b1bd4102cc13f178a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805484Reviewed-by:
-
Mugdha Lakhani authored
for one-off tasks, both for one-shot and periodic Background Sync. Update unit tests to verify that we pass the correct parameters to BackgroundTaskScheduler. Bug: 1000021, 996166 Change-Id: If47e77d5747c1e7d4a2aef1fc1c28c5e1064e58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782619Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#696745}
-
Fredrik Söderquist authored
This eliminates implicit conversions to SMILTime. Adds FromSecondsD and FromMicroseconds to SMILTime. This is otherwise mostly s/0/SMILTime()/ and adding From{SecondsD,Microseconds} where needed. Bug: 1003338 Change-Id: I164c644a3b6161e9546af0049de9563d2c7beae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803313 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#696744}
-
Pâris MEULEMAN authored
Avoid exposing getIdentityMutator in IdentityManager.java by passing the IdentityMutator reference directly in SigninManagerAndroid's and SigninManager.java's constructors. Bug: 934688 Change-Id: I02667bfe89fe2e3925363f2bf0075ef53b0bd8ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800405 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#696743}
-
Fredrik Söderquist authored
'repeatCount' was previously shoehorned into a SMILTime since it was a reasonable match semantically. This makes less sense when storing SMILTimes as integers though, so rework it to use a small helper class that stores a double and exposes the various states that repeat count can have. Add a SMILTime::Repeat(SMILRepeatCount) helper to compute the repeated duration. SVGSMILElement::ParseCondition is reworked to use negation to add the sign to an offset value. With this operator* on SMILTime can be eliminated. operator-() (unary -) is added to be able to implement the negation. Bug: 1003338 Change-Id: I2827ff994b10194be8132e9db02dd7593b0a9d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803307 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Alex Clarke authored
We want to prioritize compositing and loading tasks until FCP which causes this test to flake. The problem is the test isn't waiting for the load event to fire whch means it's sometimes running the asset before the style sheet has loaded. This patch makes it wait. Bug: 971191 Change-Id: Ic7a53b2cbd52812e31de98c567d8d399c8b445b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800771 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#696741}
-
Koji Ishii authored
This patch adds a DCHECK to detect when |NGLineBreaker| goes infinite loop by |HandleOverflow()|, |Rewind()|, but failed to find appropriate secondary break point and |Rewind()| to the same point again and again. Change-Id: I9963fb5252f61fcfd0e5d768da8a4968f1f7c9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801474Reviewed-by:
-
Emil A Eklund authored
Bug: 1002317 Change-Id: I14d4bde5f59897f5d5649ef37428a477a5e7eb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804948 Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
-
Marc Treib authored
Bug: none Change-Id: Iba2184b7e8cdf119aaac971fd5325ccee23a71d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803275 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#696738}
-
Thomas Tangl authored
Account feature buttons are added at the bottom of the bordered box. Screenshot: https://drive.google.com/file/d/17tsNrV3HmOZD9yVNp6VwfbJ46GOAuvQu/view?usp=sharing Flag: profile-menu-revamp Bug: 995720 Change-Id: Icbd286cdf388742d710688e6c93cd44d1ad16e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803438 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#696737}
-
Omer Katz authored
Using atomic version of accessors whenever concurrent markers can be active. Bug: 986235 Change-Id: I111ee70e05419803a19ed119b30e1265dfa97d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803296Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#696736}
-
Victor Costan authored
IDBTransactionCommit has been "stable" since M76. At this point, it is a permanent part of the Web platform. Bug: 898257 Change-Id: I8fbb5574c01a5f36dc1d785451f5f4cf7b21510c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806163 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#696735}
-
Ioana Pandele authored
This reverts commit 588d7e15. Reason for revert: This is likely causing TabletModeWindowmanagerWithClamshellSplitViewTest.ClamshellTabletTransitionTest to consistently fail on multiple ChromeOS bots. Bug:1004195 Original change's description: > split view: Remove window activation in SplitViewController's snap logic > > SplitViewController::OnWindowSnapped shall no longer activate the newly > snapped window. In many workflows, such window activation is redundant > or inappropriate (see the referenced issues on Monorail). Window > activation shall be done separately by code for workflows where the > snapped window actually does need to be activated. > > Bug: 982954, 983227, 991611, 995946 > Change-Id: Ie111d90786764f0612aea73ba9cfa4ce640fe1f2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738338 > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Mitsuru Oshima (slow - perfing & gardening) <oshima@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Avery Musbach <amusbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696599} TBR=sky@chromium.org,oshima@chromium.org,xdai@chromium.org,amusbach@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 982954, 983227, 991611, 995946 Change-Id: Ie6760645dd3ded55bf1190341155da63176d6f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803926Reviewed-by:
-
Maksim Sisov authored
This CL removes the setup of WindowEventFilter in the DWTHX11 and uses the one already implemented in the DWTHPlatform. However, to make move/resize work with non-Ozone X11, the WMResizeHandler is subclassed by the X11Window instead of X11WindowOzone now. Bug: 990756 Change-Id: I9e95bf56adcf21267246c45264d8a801ee9f45cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776027 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Tanisha Mandre authored
- MobileAddCreditCard.AddPaymentMethodButton - Entry point from settings. - Modify ManualFallback_CreditCard_OpenAddPaymentMethod - Entry point from manual fallback. - MobileAddCreditCard.AddButton - Save a new card using the 'Add' button. Bug:1002512 Change-Id: I20ab8faf3b40345b21e00a37d801d6ae666b557b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796357Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Cr-Commit-Position: refs/heads/master@{#696732}
-
Jan Scheffler authored
This patch adds a min width to the debug panel in the sources panel to keep it from overflowing. Bug: chrome:841745 Change-Id: Id33fb70555a1d12a732c803fdf398a165a507ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786442 Commit-Queue: Jan Scheffler <janscheffler@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ecd10922eec5..914862e8ec8a git log ecd10922eec5..914862e8ec8a --date=short --no-merges --format='%ad %ae %s' 2019-09-16 dberris@chromium.org PinpointScheduler: Port of find_isolate to Tasks Created with: gclient setdep -r src/third_party/catapult@914862e8ec8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@chromium.org Bug: chromium:988912 Change-Id: I3521c035e1e2327ef09d8cd8134ad4e584191322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806326Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Tests are failing on linux: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/83157 TBR=pfeldman@chromium.org Bug: 1004150 Change-Id: I4bf6d6a10d60c7659a23b6aba1884a5995957531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804709Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#696729}
-
Tanisha Mandre authored
- Test that if a card with an invalid expiry date is added, an alert is shown. - Test that the 'Cancel' button dismisses the screen. Bug:1000669 Change-Id: Ie5f22fbcb4e8aecb9955c21d35a0bffbb55522e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786646 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
-
Benedikt Meurer authored
The color selection for code coverage (red+green) is not ideal for developers that are impacted by color blindness. This changes the colors to a brighter red and some blueish green that, a combination that is known to work well enough for people impacted by different kinds of color blindness. https://pbs.twimg.com/media/EEU9fCzUUAItz4n?format=jpg shows an example of how these two colors look like now. Bug: chromium:1003671 Change-Id: I9c3e08fb350a6086624d63f44e069813c618588e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801762 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/561b90bd1d76..86c48abc94f3 git log 561b90bd1d76..86c48abc94f3 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b1580a276713..d32dae1bb37c (5 commits) 2019-09-16 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader adb0d51ca672..30847688f059 (2 commits) Created with: gclient setdep -r src/third_party/skia@86c48abc94f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: chromium:None,chromium:None Change-Id: I55ce7cc4f987c7ac46f7d1bdd8ff821a9b523a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805719Reviewed-by:
-
Jason Lin authored
* Remove extra inset for a few crostini dialogs * Do not show the close button for CrostiniUpgradeContainerView so that it is consistent with other crostini dialogs. Bug: 965185 Change-Id: Idf3934116ea73ef9153e05b8370cd67f4d64a6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803943Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#696725}
-
Koji Ishii authored
When `word-break: break-all` or `keep-all` is specified, this patch fixes `overflow-/word-wrap: break-word` to be effective. Before this patch, it was forced to be `normal`. Bug: 1001378 Change-Id: I73f5956a6856f2cbd0944461a0aa7a2929e722cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806162 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bdf64c9f6d8e..f02b13925471 Created with: gclient setdep -r src-internal@f02b13925471 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3efd12057c6ef0b6c30a0fba2a63014eff4e95d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805904Reviewed-by:
-
Renato Silva authored
ChromeOS update logo was chopped of on the tip of the arrow. This commit replaces the image with a proper one. Bug: 936616 Change-Id: I5943f187fb421b3ab70728344dc48590dda3e324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803284Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#696722}
-
