- 30 Sep, 2019 11 commits
-
-
Miguel Casas authored
This CL has a few cleanups that were punted during crrev.com/c/1772642 - Using UniqueID ISO int - Use base::small_map - cleanup includes - forward declare some classes - using base::Location in OnError() Bug: 998279 Change-Id: I654411ab5f7dbc6527e3805d76887eb202ddd40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819681 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#701020}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I5d6441a474e250fab7f15afbbb8d7c6265cda963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829578Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701019}
-
Adam Rice authored
ChildProcessSecurityPolicyImpl::CanAccessDataForWebSocket is no longer used. Remove it. Change-Id: I5fdd3577c5280aaf29b3b836c005e956f7a6188e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828768Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#701018}
-
Hiroshi Ichikawa authored
The app crashes if the method is called after |_webState| is deallocated. Change-Id: I8c06cddc8ea3a39fd2c8c5d05d4c17fa0bd071d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830251Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#701017}
-
Stephen McGruer authored
Previously additive composition was implemented as something close to accumulate, using a pairwise addition. This CL changes it to the by-spec behavior of concatenating the lists. Unfortunately due to underlying issues in the way Chromium handles 0%/100% Animations (we fast-path through the interpolation code), things get weird at those points and we end up dropping the addition - against spec. This could be a serious problem, for example for fill-forward animations, so will warrant further CLs to fix. See https://drafts.fxtf.org/filter-effects-1/#addition Bug: 1005828 Change-Id: I941c986627c57738c65fb67674bfbce6dc437155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822021 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701016}
-
Jay Harris authored
This is part of a series of CLs redesigning the Badging API based on TPAC feedback: https://github.com/WICG/badging/issues/55 In a followup CL, the scope member will no longer be exposed to the web: https://chromium-review.googlesource.com/c/chromium/src/+/1816002 Note: The scope parameter was ignored in a previous CL, which is why there are no unit/browser test changes. Bug: 1006665 Change-Id: I176dfc28abaf661aaeaa1622e059c2b8cc851e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818892 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#701015}
-
Tetsui Ohkubo authored
BUG=None TEST=None Change-Id: Ia27fc34352eee14d97f56e7af6a01fdd9274ae32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828777Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#701014}
-
Trent Apted authored
Bug: 996088 Change-Id: I4dcf297374afcb06abbd94b988ed39c0cad14967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828668 Auto-Submit: Trent Apted <tapted@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Reviewed-by:
dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#701013}
-
Darren Shen authored
AltGr is a valid modifier state according to W3C [1]. Currently, the chrome.input.ime.KeyboardEvent does not provide the status of AltGr to extensions. This means that extensions has to manually track the status of AltGr. It would be much simpler for extensions if we provided the status of AltGr in the KeyboardEvent API, since we already do this for other modifier keys like Control and Alt. [1] https://w3c.github.io/uievents/#dom-eventmodifierinit-modifieraltgraph BUG=1005619 Change-Id: I420d3505a894e175fba70db2652175883ede25cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824697 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701012}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/945aedd37169..07156a46610b Created with: gclient setdep -r src-internal@07156a46610b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I425efc2995f3f5df25604e8f362dfa3278db7979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830591Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701011}
-
Daniele Castagna authored
VAAPI usage in Chrome has a global lock that is acquired for each vaapi call. The assumption was that vaapi calls would not block on the CPU, but they do. In particular, vaEndPicture seems to take a significant amount of wall time during encoding. When multiple encodings are happening, we might end up interleaving parts of the encodings of different streams and serialize them. This causes wall time for one encoding to sometimes take into account wall time of other encodings too. This CL tries to mitigate that issue in a few different ways: - In VaapiVideoEncodeAccelerator::ReturnBitstreamBuffer the client is notified that the encoding is ready before destroying the surface, since destroying the surface reacquires the lock that might be taken by another vaapi call in another thread. - ExecuteAndDestroyPendingBuffers acquires the lock only once, so that another vaapi client can block in between execute and destroy. - DownloadFromVABuffer doesn't unlock and relock during the copy to shmem, since the copy takes in the order of .1ms for a VGA stream and gives the chances to another VAAPI client to acquire the lock once the encoding is done and before we notify the client. Bug: 1005592 Test: on meet.google.com, record average WebRTC encoding times, observe it drops by ~10% Change-Id: I807e281ba501b5d05d53902c8257010725730966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819518 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#701010}
-
- 29 Sep, 2019 29 commits
-
-
Kent Tamura authored
- Rename many things Use 'control' instead of 'form' to represent a form control element to avoid confusion with <form>. - Add some comments - Share code of RestoreControlStateFor() and RestoreControlStateIn(). This CL has no behavior changes. Change-Id: Ic03bce6c1052efd42edc93cb413c757c1bb88543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827275Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#701009}
-
Jinsuk Kim authored
This CL a partial revert of https://crrev.com/c/1771638 so that the removed vector drawable can be used on KitKat instead of 9-patch drawable. KitKit doesn't seem to handle scaling 9-patch drawable well. Using the vector drawable gets around the issue. Bug: 993506 Change-Id: Id7b8db13ea2e19e3e3e3fed83b42c84cea9a95d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826748 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#701008}
-
Daniele Castagna authored
While investigating if we have any lock contention in VaapiWrapper we noticed in VaapiVideoEncodeAccelerator many parts of the decoding are not taken into account. This CL adds traces on parts that accounts for the total encode time and that were not traced already. in particular: - VaapiWrapper::DownloadFromVABuffer that is the time it takes to copy the encoded stream into shared memory. - VaapiWrapper::CreateVABuffer, needed to create a buffer to decode into, while it's fast by itself, this might be waiting on another encode to finish. - VaapiWrapper::DestroyPendingBuffers, that is called before dowloading the buffer and it's in the critical path. - VAVEA::FromExecuteToReturn, it's the time from VAAPI::Execute to when we call the callback to notify the encode has finished. - VAVEA::FromCreateEncodeJobToReturn, is the time from when we start trying to process the encoding to when we notify the client the encode is done. We additionally added a few "Locked" traces, like for example VaapiWrapper::Execute and VaapiWrapper::ExecuteLocked, with the second one starting tracing after the Lock is acquired, in this way it's easy to see where we're waiting for vaapi and where we're waiting to acquire a lock. https://screenshot.googleplex.com/maVPXzKd7v0 makes clear how we were not accounting for all the decoding. VAVEA:: Execute trackes only a tiny percentange of the decoding wall time and DownloadFromVABuffer might take significantly longer. Bug: 1005592 Test: Trace a video a encode and look at it. Change-Id: Ic7e5d58442238241b573d05c4ad86c2443aed74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815951 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Tab.nativeInit and nativeDestroy come in pair. This CL ensures that the latter is executed only when |mIsInitialized| is true by |nativeInit| beforehand. This helps Tab hide |initializeNative| API from public interface. Also added a few asserts against mNativeTabAndroid to make sure Tab is used in native-initialized state. Bug: 995903 Change-Id: I8178a4cd064f48dddd330cc5a314f946e579dd50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818010 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#701006}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/60d4fa65326b..945aedd37169 Created with: gclient setdep -r src-internal@945aedd37169 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia826d668fffa03e41af37e7ae17e586941760dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830460Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iebc863e3ebfa8571c9f458b49f6ec68931e343bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830459Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701004}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5efc9bd8e009..60d4fa65326b Created with: gclient setdep -r src-internal@60d4fa65326b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I3024626539826766b57dec899756d979c609c749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831096Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0e3517d55865..578270d9d23a git log 0e3517d55865..578270d9d23a --date=short --no-merges --format='%ad %ae %s' 2019-09-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 929ce7df..bd70e4cf (700900:701000) Created with: gclient setdep -r src/third_party/webrtc@578270d9d23a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I43f8741536d4abd02089c52b1ac744e8a287a63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831257Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 41157b83. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ksakamoto@chromium.org: external/wpt/resource-timing NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I830abeae1fb1f734549de4d8dfcc5cdbde93cfd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831198Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701001}
-
Gyuyoung Kim authored
This CL converts old Mojo types to new Mojo types in WiFiDisplaySessionService interface. pending_remote is applied to SetClient function. Bug: 955171 Change-Id: I38b885f05881657ecac4f49de41bea5a83d1fd72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827101 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 171b1c35. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3674f491f7678a227563e45c6c2dc09e8084b985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831177Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I8fe83b1b581cf6331c6aeb2d74aa8d8a8dd71cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830735Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dc34b23879d4..7aeabcfa6a73 git log dc34b23879d4..7aeabcfa6a73 --date=short --no-merges --format='%ad %ae %s' 2019-09-29 kjlubick@google.com [SkParagraph] Require len if using addText(const char*) 2019-09-29 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@7aeabcfa6a73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I2b40ec2a67150227b1ed64448133fbf7c6e435af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830734Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 821ddc47. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4612aefd9e9aa115f90a1fff82b0662590cf88e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829516Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/39058571f71e..0081c0ff173c git log 39058571f71e..0081c0ff173c --date=short --no-merges --format='%ad %ae %s' 2019-09-29 iannucci@chromium.org [git-cache] Add option to update_bootstrap to skip the populate step. Created with: gclient setdep -r src/third_party/depot_tools@0081c0ff173c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I8319e87b7fa55a1cbf8dc83e97f2410c8c7fc071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830306Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6a4fb5cc39ce..5efc9bd8e009 Created with: gclient setdep -r src-internal@5efc9bd8e009 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I739e5ef3729261bfa87ec5b33f45e65cefff56c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830356Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be971636cf9b..dc34b23879d4 git log be971636cf9b..dc34b23879d4 --date=short --no-merges --format='%ad %ae %s' 2019-09-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@dc34b23879d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I285e1f0d03b9cb88cb797687f459d7a752de1321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830355Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/78bfba29d183..6a4fb5cc39ce Created with: gclient setdep -r src-internal@6a4fb5cc39ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ib34b8d5075484239f8adffbe4ab575746117e04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831057Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2e856451654d..be971636cf9b git log 2e856451654d..be971636cf9b --date=short --no-merges --format='%ad %ae %s' 2019-09-29 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@be971636cf9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I5c108a6b115c40d11d4c23ee8bb5c2092c92f6d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831060Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/28884d465c09..d9d7419a45d6 git log 28884d465c09..d9d7419a45d6 --date=short --no-merges --format='%ad %ae %s' 2019-09-29 vapier@chromium.org lint: enable more Python 3 checks 2019-09-29 vapier@chromium.org cros_build_lib: rename RunCommand to run 2019-09-29 vapier@chromium.org git_unittest: move manifest tests here 2019-09-28 vapier@chromium.org run_tests: run a bunch of tests under Python 3 too Created with: gclient setdep -r src/third_party/chromite@d9d7419a45d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Id997e3f72af41164adb8f8798c2c723e993878f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831061Reviewed-by:
-
Christopher Cameron authored
The AvatarMenu is out-living ProfileAttributesStorage, and causing a use after free. Disable its allocation for the moment. There are a menu of follow-up fixes available: - Ensure ExtensionAppShimHandler be terminated before ProfileAttributesStorage (and consider using a CheckedObserver instead of an UncheckedObserver). - Make AvatarMenu use a weak pointer to ProfileAttributesStorage and allow ExtensionAppShimHandler to outlive ProfileAttributesStorage. TBR=dominickn Bug: 1008947 Change-Id: I0419c7427c4fd37c4a5fa583155ddf06ccf93d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830917Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#700989}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Icf1b448c255f3f398155a76e9b876c660510e656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831059Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3651981a..656e25f9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3bae2c504af13a54d96fd9aa19173796246621b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829514Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700987}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I6769813afeac3eeef63626fefcac71ad820cd407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830070Reviewed-by:
-
Matt Falkenhagen authored
This is intended to be a verbatim copy of https://www.chromium.org/developers/content-module and will be revised later. An exception is the diagram isn't copied to the repository as it'll need to replaced anyway. Also, the existing link in the README to the Bluetooth doc is kept. Change-Id: I6f1652ae5fe3dc5f55d852769bd0a769a0ffb5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826744Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#700985}
-
Wez authored
TBR=rockot, pwnall Bug: 1008697 Change-Id: Id446de794341306a4c65555324e988abcb420383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830055Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#700984}
-
François Beaufort authored
Following spec change at https://github.com/gpuweb/gpuweb/pull/444, this CL makes sure typedef GPUBufferSize is used in all IDL files. It also change occurrences of "unsigned long" to the appropriate GPU{}Flags. Bug: 877147 Change-Id: I267b4427b5df288ca4095208eb0f1bf4b02077f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821597 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#700983}
-
Mike Frysinger authored
Change-Id: I0eab90e068cb3caf31f0e87f134a79e2573c8aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738009Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#700982}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/26f76bb41209..78bfba29d183 Created with: gclient setdep -r src-internal@78bfba29d183 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I30a559e593b206e22075e7f9b86e9c9901fd502c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830351Reviewed-by:
-
