GitLab

This CL adds checkbox to animation tests inside WebView system shell
that enables external stencil by adding rounded corners clip path to
WebView.

Bug: 956709

Change-Id: Ia918bf2fa6af522bdda90d559eddf24c48172dbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075970
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745068}

This CL starts the componentization of URLUtilities.java and its native
counterpart in order for sharing with WebLayer (specifically, this code
is used by //chrome's launching of external intents). As this class is
used internally we structure the componentization as a 3-sided patch:
this patch just copies the existing //chrome code and deprecates the
//chrome code, while a followup will remove the //chrome code once the
internal code has been ported.

An immediate followup CL will componentize ShadowUrlUtilities.java.

TBR=mmenke@chromium.org

Bug: 1031465
Change-Id: I73d29744808a33e86b277f2d88c19e76f18ff10d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077681
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745067}

https://chromium.googlesource.com/external/github.com/google/re2.git/+log/36f7f246a827..572d6abf7f22

$ git log 36f7f246a..572d6abf7 --date=short --no-merges --format='%ad %ae %s'
2020-02-26 junyer Don't break the RE2 object when compiling the reverse Prog fails.

Created with:
  roll-dep src/third_party/re2/src

R=mmoroz@chromium.org

Change-Id: I582e0c47696cf5d156cc93a5b2e6b43c83a0c3ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077588Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745066}

Follow up change to make PaintPreviewBaseService use DirectoryKey for
accessing protos. Also move the access methods to FileManager.


Bug: 1055505
Change-Id: I322998cbd5d7d6d78d9aa541ac81a8f292059235
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075043
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745065}

A trace is uploaded via "slow reports" when a long input delay
is detected (for opted-in clients). This trace event will make
it easier to identify the location of the long input delay when
analyzing the trace.

Bug: 1055890
Change-Id: Iba0e818b9c1a245da0099f44cc1224c437c8df97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072665
Commit-Queue: Hailey Wang <haileywang@google.com>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745064}

When the passthrough command decoder is destroyed, the callback needs
to be un-registered from ANGLE. That way if the ANGLE context is used
elsewhere, it won't dereferences an invalid pointer.

Bug: chromium:1048205
Change-Id: Icf1b9969fa2bbc53d449e1b73ef66853303e94c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055423Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cr-Commit-Position: refs/heads/master@{#745063}

TraceAfterDispatch is used avoid adding vtables to types. Instead a
flag in the object is used to choose the right Trace method. This CL
changes all the non-const flags used for dispatching to const.

Change-Id: I29b1817b56808360c27b31dd41b98c5ae5ece1a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078533Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745062}

If the webstate is nil or if it's not the active webstate, then
it is likely that the BadgeTabHelper is not valid, so return early.

This change also ensures that all InfobarCoordinator blocks
use weakSelf in calls of InfobarContainerMediator

Fixed: 1055908
Change-Id: Ic68ee9950ce928f1143981425cbac934057bbe64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075300
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745061}

Bug: 1032561
Change-Id: I77d1aeba69c58c88d19fb9a239f2ec4b912539ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077739Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745060}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bc110cba..f4467316

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6a83693816b373441924e03290f5fa694c4741d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078551Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745059}

Removed remaining use of global NativeTheme accessor from profile
menu and added color update capability on theme change.

Fixed spacing on HoverButtons taking image views for consistency with
other constructors.

Bug: None
Change-Id: I717a45fb068a3bd35b992797e38e729da1cd3521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072998
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745058}

Missed removing arguments from iOS' WPR test runner constructor

Bug: 1055330
Change-Id: I21faef3071ce28a0d3c7e4f3e51c20d987b3af4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076764Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745057}

This reverts commit 0e5a5146.

Reason for revert: Fixed errors in AppLaunchController. Time refactor all of this.

Original change's description:
> Revert "[Kiosk] Refactor AppLaunchSplashScreenHandler so it works more reliably"
>
> This reverts commit cdce07c9.
>
> Reason for revert: KioskTest.LaunchAppWithNetworkConfigAccelerator has been failing on msan fairly consistently since this landed:
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17653
>
> Original change's description:
> > [Kiosk] Refactor AppLaunchSplashScreenHandler so it works more reliably
> >
> > This handler was little bit overcomplicated. This led to a bug in web
> > kiosk mode when we update network state, but do not update the handler.
> >
> > Because of this convolution, in web kiosks, the network configure
> > screen did not update itself when connected to network(which is what
> > client will expect from the handler which observes network state).
> > Now it behaves more logically and predictably.
> >
> > Bug: 1015383
> > Change-Id: I78b024b1d51b54b0d01d0a5a5694f6ae3f5ac19e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031406
> > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#739128}
>
> TBR=xiyuan@chromium.org,rsorokin@chromium.org,apotapchuk@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1015383
> Change-Id: Ibc08de19048d9c8af95c3f517b748d09e37c7597
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045479
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739735}

TBR=xiyuan@chromium.org,thakis@chromium.org,rsorokin@chromium.org,apotapchuk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1015383
Change-Id: Ie77ba40fa6bf3bc94a22c97a8d2b0764ef0614d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047225Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745056}

While checking an unrelated piece, I found the element_finder to still
be very confusing. This should CL should clean it up and make it a bit
more understandable.

It also fixes a minor bug, where the container_frame_selector_index was
not correctly set for OOPIF.

Bug: none
Change-Id: I49965dcbc5378a0f73812489b68790b5db9f888f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072386Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#745055}

This reverts commit 77288e6f.

Reason for revert: All/DeclarativeNetRequestBrowserTest.AllowAllRequests_SrcDoc/0 is
consistently failing, and this change touches that test and is in the
blamelist, so I expect reverting it will be the fix. First failing build:
https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/44692

Original change's description:
> DNR: Speculatively fix flaky DeclarativeNetRequestBrowserTest.AllowAllRequests_SrcDoc.
> 
> Wait for the fetch to complete before checking whether xhr request was
> seen by the browser. This should hopefully fix the flakiness since page
> load won't necessarily wait for the fetch to complete.
> 
> BUG=1050536, 1056031
> 
> Change-Id: I9c043d69c4d619e00737303d2aaa3c15dc587ae2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076658
> Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#744926}

TBR=lazyboy@chromium.org,karandeepb@chromium.org

Change-Id: I032be2858ed91613891949a5540a8875b56d5d04
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1050536, 1056031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078595Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745054}

This reverts commit a9df7cc8.

Reason for revert: Seems to be causing compile failures on multiple builders:
[2431/2474] CXX obj/chromeos/services/assistant/audio_decoder/lib/ipc_data_source.o
FAILED: obj/chromeos/services/assistant/audio_decoder/lib/ipc_data_source.o
../../build/cros_cache/chrome-sdk/symlinks/eve+12933.0.0+target_toolchain/bin/x86_64-cros-linux-gnu-...(too long)
In file included from ../../chromeos/services/assistant/audio_decoder/ipc_data_source.cc:5:
../../chromeos/services/assistant/audio_decoder/ipc_data_source.h:37:37: error: non-virtual member function marked 'override' hides virtual member function
const ReadCB& callback) override;
^

Original change's description:
> media: Migrate DataSource::ReadCB to once callback.
> 
> This callback is used to signal completion of the read operation,
> therefore, it's a once callback:
> * https://cs.chromium.org/chromium/src/media/base/data_source.h?rcl=6e8610f8f31aa3bb8266660380a66c6c25b2e64a&l=27
> 
> This is part of the base::Callback migration.
> 
> Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40
> 
> Bug: 714018
> Change-Id: Ie43febda1247be065f9f22cc4aec0d8412873491
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056729
> Reviewed-by: Marc Treib <treib@chromium.org>
> Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Commit-Queue: Jose Lopes <jabolopes@google.com>
> Cr-Commit-Position: refs/heads/master@{#745018}

TBR=danakj@chromium.org,xhwang@chromium.org,treib@chromium.org,jabolopes@google.com

Change-Id: I29a9ef7f049320a36dcd52212b7f5ac80e6fc02b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 714018,1056660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078593Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745053}

Update SkiaOutputDeviceDawn to match the change from
Capabilities::flipped_output_surface to output_surface_origin.

Change-Id: Ifce77d6ed142edbd5e1bcfe80154ddf8de0c328e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076378
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Auto-Submit: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745052}

Adds another experiment arm for preserving the Tap gesture, in case
users get confused during the transition to long-press.  This will
let us evaluate the difference between preserving and just switching.

This changes the default to ONLY recognize longpress rather than both.

Note that Privacy wants only one gesture to fully launch, so we are
doing this as a fallback in case both need to be supported during a
user-education timeframe.

BUG=956277

Change-Id: I1b42d86bbd9cdc7e0a58bafb8a796601ae0cb353
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076338
Auto-Submit: Donn Denman <donnd@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745051}

Refactor FileManager to accept a DirectoryKey rather than a GURL. This
makes it more ammenable to possibly supporting other keys for creating
directories such as tab id, UnguessableTokens, etc.

Bug: 1055505
Change-Id: Id93cc1bcbfdfdd69baf0f57764636dcbcd62c3f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070737Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745050}

The mojo identity service (//services/identity) is not used in
production. However, a variety of chrome code uses the typedef
identity::ScopeSet when talking to the C++ IdentityManager and
related auth-token code.

Introduce signin::ScopeSet for these use cases.  It's just a
copy of identity::ScopeSet, which is a std::set<std::string>.
I didn't eliminate identity::ScopeSet in this CL due to existing
usage in //services/identity as well as typemapping code.

I'll delete the identity::ScopeSet version when I delete the
rest of the identity service.

TBR=rockot@chromium.org
TBR=droger@chromium.org

Bug: none

Change-Id: Ib938f08763eda81de22a1a79b460011e012a81ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076426Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745049}

Removed the need to use the global GetInstanceForNativeUi() call
to get required colors when constructing avatars and sync icons
for profile menu views.

Also updated the profile menus such that their sync and avatar
icons are updated appropriately on theme changes.

Performed some basic cleanup, moved some functions into the base
class.

Bug: None
Change-Id: Ia3566c77653c3209265d077e64b524b7bde9c8e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070377
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745048}

This knocks ~5% off the total runtime of unit_tests on my workstation, since
most tests in this suite otherwise take multiple seconds to run.

Bug: 1055824
Change-Id: Id911e97ce55efed11f6ee5fb34eaf5409426f19d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072660Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745047}

The former wraps the later with two additional bits:

- request_id
- is_processing_user_gesture

This CL adds accessor methods to both bits in UserMediaRequest,
and uses it directly instead of the UserMediaRequestInfo.

BUG=704136
R=guidou@chromium.org

Change-Id: Iee9cef6b20293a71fb8b35ba655642355b1841fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075639Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#745046}

The sign-in interaction coordinator is active when it is used with
the sign-in coordinator.

Bug: 971989
Change-Id: Ic199eb9e7628d6f4195f7bbc5637827eccc38cfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077933
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745045}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1468dd8d57f8..091710f87c8c

git log 1468dd8d57f8..091710f87c8c --date=short --first-parent --format='%ad %ae %s'
2020-02-27 almuthanna@chromium.org Refactor Console E2E test to use helpers
2020-02-27 jacktfranklin@chromium.org Typecheck Common/JavaScriptMetaData.js
2020-02-27 changhaohan@chromium.org migrate debugger/script-formatter-breakpoints-4.js to e2e test
2020-02-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-02-27 jacktfranklin@chromium.org Reland "Extract `toBase64` into `StringUtilities`"
2020-02-27 tvanderlippe@chromium.org Typecheck common/Worker.js

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@091710f87c8c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1011811,chromium:1044632,chromium:1050549
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I1be8db4bad2275ba8486db55ae41601bac4c993c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078291Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745044}

We used to skip the whole base computed style optimization and just
compare the new style with the old stored base, but used the newly
computed style always when DCHECK was enabled.

This CL always computes the computed style without the base, but then,
after verifying it matches the base, use the base computed style.

Bug: 669790
Change-Id: Ifc82de4644fae104d69d8abf91261ba1cfe52f73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074399Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745043}

It was removed in:
  https://webrtc-review.googlesource.com/c/src/+/154344

Bug: internal b/144781004
Test: CQ
Change-Id: I5b4ab99107f1fc3db72fb0ec279f3e9bb3c92445
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076742
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Auto-Submit: Bang-Cheng Wang <bcwang@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745042}

https://skia.googlesource.com/skia.git/+log/1412b3e47c6f..66adad7d3726

git log 1412b3e47c6f..66adad7d3726 --date=short --first-parent --format='%ad %ae %s'
2020-02-27 mtklein@google.com turn on mem2reg, set mcpu
2020-02-27 mtklein@google.com basic JIT support?
2020-02-27 mtklein@google.com little steps forward

Created with:
  gclient setdep -r src/third_party/skia@66adad7d3726

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jlavrova@google.com
Change-Id: I8b1913b23d5adb0cc1d11751251e7d644dbfa088
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078076Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745041}

These flags are used when creating NodeRareData. Making them const
serves to indicate that they are never changed and clarifies the
process of choosing which NodeRareData type to create.
(this was suggested by mlippautz@ on issue 1055194)

This also requires refactoring the initialization a bit.

Change-Id: Ie17684e3050e59c1f6bf16c1e37832e1064be5b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074881Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745040}

* Adds the safety check extensions child element
* On an update state change, adapts the child icon, icon color,
  secondary label, and user action UI components accordingly

Bug: 1015841
Change-Id: I9f24f7211c3aea7036ca46fe4fa3387321b3dbc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072241
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745039}

Sometimes network timer was timing out and we were going into
network configure screen. This screen is orthogonal to the purpose of
this test. Let's disable network handling in this test.

Bug: 964333
Change-Id: Ic93568970b7af07f4703c9474868aaefabccf1cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075457
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745038}

The CL introduces a new security token request controller similar to the
parent access controller, which was the only user of the PIN UI until
now.

This CL also adds small bits of functionality to the UI that is required
for the new use-case: Disabling input and clearing the input field.

The new UI applies to login and lock screen, but not in-session or for
OOBE, which use different UIs.

Bug: 1001288
Change-Id: I8c69064a0d944bb6b5a7dac13a2ec2bd968deece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020968
Commit-Queue: Fabian Sommer <fabiansommer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745037}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/61b1c84d5157..e9fa76827a5a


Created with:
  gclient setdep -r src-internal@e9fa76827a5a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I9f5e8cdbe4b4173866033e4f864780e3644af236
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078073Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745036}

As described in the linked bug, on iOS 13, in Settings.app, after the
keyboard is opened, the scroll view doesn't adjust and the bottom rows
are hidden beneath the keyboard.

This workaround adds a bunch of blank lines to the end of the settings
so the actual content can still be seen above the keyboard.

Bug: 1056606
Change-Id: If34ae9356a42898f5616fde8cafdd6ea00ccb2e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077932Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#745035}

This CL enables SyncUSSNigori by default, because it should be launched
soon and removes one Directory-specific test, which is not relevant
once USS implementation is enabled for all datatypes.

Bug: 922900
Change-Id: I0f6c71a4a1a6a06a3fed510e11d28b770972c6c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074700
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745034}

Fixed: 1045321
Change-Id: Ic50d44b76861b691100cd207edcf24b3d591150d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076597
Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745033}

Using wpt-import in Chromium b09f7d51.
With Chromium commits locally applied on WPT:
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I7983b35bd4630f6ad6560566d50d150d7ee9c96d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077399Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745032}

This CL componentizes //chrome's UrlConstants.java for reuse by
WebLayer. Specifically, this file is used by //chrome's external
navigation launching code, which we are in the process of componentizing
for reuse by WebLayer.

As this file references concepts that are conceptually above the
//content level (e.g., browser-level features), it makes sense for it to
live in //components. Rather than create a small component just for
this we placed it in //components/embedder_support. It will shortly be
joined by UrlUtilities.java.

Bug: 1031465
Change-Id: I2f24f625d9dc1b5e977ecb5dcbe3dc98a26e67ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073938
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745031}

This reverts commit ea358e18.

Reason for revert: Suspect for causing rare crashes.

Original change's description:
> Reland "[devtools] Don't continue execution after reload on breakpoint"
>
> This is a clean reland of 4276111d
>
> The original patch was reverted due to an unrelated timeout, see
> https://bugs.chromium.org/p/chromium/issues/detail?id=1049444
>
> Original change's description:
> > [devtools] Don't continue execution after reload on breakpoint
> >
> > This CL fixes an issue where JavaScript execution would continue
> > after reloading on a breakpoint. See design doc:
> > https://docs.google.com/document/d/1aO9v0YhoKNqKleqfACGUpwrBUayLFGqktz9ltdgKHMk
> >
> > The CL depens on V8 change in crrev.com/c/1924366 and tests should fail until
> > that change is landed+rolled to chromium.
> >
> > Fixed: 1004038
> > Fixed: 1014415
> > Change-Id: I182393ebd4c68588163dda7c607be8bb09a3eda3
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926502
> > Reviewed-by: Yang Guo <yangguo@chromium.org>
> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#738522}
>
> Change-Id: Id6ada47ff10df164ca7ead387907a0a2fff03e4c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041623
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739296}

TBR=dgozman@chromium.org,yangguo@chromium.org,sigurds@chromium.org

Change-Id: Iecc1a863b0aad16157c272dae9c8b3a3167ade9c
Bug: chromium:1056246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075337Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745030}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5ba8c6c1..bc110cba

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I924a6d29de6a2a087f744c1e249240190073a56c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077400Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745029}