- 26 Aug, 2015 40 commits
-
-
mnaganov@chromium.org authored
BUG=521764 git-svn-id: svn://svn.chromium.org/blink/trunk@201235 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
scheib@chromium.org authored
Developers are expressing confusion when passing invalid service names, sometimes because they pass an invalid UUID that nearly looks correct. Explain more explicitly in the error message what is accepted. BUG=491441 Review URL: https://codereview.chromium.org/1315443007 git-svn-id: svn://svn.chromium.org/blink/trunk@201234 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mlamouri@chromium.org authored
Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/YKVnS429hns BUG=412331 NOTRY=true Review URL: https://codereview.chromium.org/1315103002 git-svn-id: svn://svn.chromium.org/blink/trunk@201233 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
esprehn@chromium.org authored
Revert of Centralize deferred commit conditions. (patchset #1 id:1 of https://codereview.chromium.org/1300043003/ ) Reason for revert: Perf regression due to an error. willInsertBody is actually before the body is available which means the check for body() in this patch would not succeed and we'd end up not resuming commits until we finished parsing if all sheets were done loading before we got to the <body>. BUG=524172 Original issue's description: > Centralize deferred commit conditions. > > Instead of having many callbacks that implicitly have conditions for when the > blink frame pipeline should run, have a function on Document that checks them > explicitly and make WebViewImpl call it. > > This will allow checking if iframes are ready to begin running their lifecycle > phases when iterating the frame tree in ::beginFrame and ::layout(). > > BUG=521692 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200783 TBR=ojan@chromium.org,dglazkov@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=521692 Review URL: https://codereview.chromium.org/1317883002 git-svn-id: svn://svn.chromium.org/blink/trunk@201232 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
joelo@chromium.org authored
BUG=521764 TBR=ojan@chromium.org Review URL: https://codereview.chromium.org/1313353002 git-svn-id: svn://svn.chromium.org/blink/trunk@201231 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
iclelland@chromium.org authored
This patch removes the requirement for the caller of a BackgroundSync manager method to be either a service worker or a controlled client. Now, uncontrolled clients are also able to access the manager, and Blink informs the browser whether a registration request came from a Service Worker or not. (Service Workers are still required to have at least one active window client in order to register sync events; this is enforced in the browser). This is part 1 of a three-part blink-chromium-blink dance. Part 1: https://codereview.chromium.org/1309393003 (this patch) Part 2: https://codereview.chromium.org/1316743002 Part 3: https://codereview.chromium.org/1314453003 BUG=518884 Review URL: https://codereview.chromium.org/1309393003 git-svn-id: svn://svn.chromium.org/blink/trunk@201230 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
caryclark@google.com authored
TBR=bungeman@chromium.org BUG=525050 Review URL: https://codereview.chromium.org/1313733009 git-svn-id: svn://svn.chromium.org/blink/trunk@201229 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
joelo@chromium.org authored
http://src.chromium.org/viewvc/blink?view=revision&revision=201202 BUG=524859 TBR=trchen@chromium.org Review URL: https://codereview.chromium.org/1317863002 . git-svn-id: svn://svn.chromium.org/blink/trunk@201228 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
peter@chromium.org authored
- domactivate-sets-underlying-click-event-as-handled.html (Issue 520173) - audionode-disconnect-audioparam.html (Issue 525065) NOTRY=true TBR=mnaganov BUG=520173, 525065 Review URL: https://codereview.chromium.org/1308263003 git-svn-id: svn://svn.chromium.org/blink/trunk@201227 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
caryclark@google.com authored
TBR=bungeman@chromium.org BUG=524623 Review URL: https://codereview.chromium.org/1315133002 git-svn-id: svn://svn.chromium.org/blink/trunk@201226 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yukishiino@chromium.org authored
Other attributes have already been using V8's named property interceptor. Window is only an exception. Let's use it for Window, too. This CL intentionally changes the look-up behavior. Sample code: iframe = document.createElement('iframe'); iframe.name = 'alert'; document.body.appendChild(iframe); Before: window.alert => iframe with the name 'alert' After: window.alert => built-in alert function According to the spec, (non-named, regular) attributes/methods must have priority over named properties. See "The named property visibility algorithm" at http://heycam.github.io/webidl/#indexed-and-named-properties The order of look-up for non-[OverrideBuiltins] interfaces (including Window) must be: 1. Own properties. 2. Properties from the prototype chain. 3. Named properties. The Intent-to-Implement-and-Ship is here: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/jlmsE3fDCNg BUG=43394,516274 Review URL: https://codereview.chromium.org/1121703002 git-svn-id: svn://svn.chromium.org/blink/trunk@201225 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
peter@chromium.org authored
R=johnme BUG= Review URL: https://codereview.chromium.org/1311673008 git-svn-id: svn://svn.chromium.org/blink/trunk@201224 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ssid@chromium.org authored
This is a fix for the data race in GCInfoAtBase::index. The GCInfo is defined as static local and this causes race while allocating new objects. This CL reduces the initialization time by using function pointer to get the class name instead of string parsing. BUG=524237 Review URL: https://codereview.chromium.org/1312963002 git-svn-id: svn://svn.chromium.org/blink/trunk@201223 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
joelo@chromium.org authored
http://src.chromium.org/viewvc/blink?view=revision&revision=201181 BUG=518347 TBR=kojii@chromium.org Review URL: https://codereview.chromium.org/1320633003 . git-svn-id: svn://svn.chromium.org/blink/trunk@201222 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kouhei@chromium.org authored
Before this CL, SegmentedSubstring::{m_length,m_data} was declared public. This CL makes them private and adds public accessors to them. BUG=None TESTS=Refactoring only. Shouldn't change any behaviour. Review URL: https://codereview.chromium.org/1317693006 git-svn-id: svn://svn.chromium.org/blink/trunk@201221 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yosin@chromium.org authored
This patch introduces |firstEditablePositionAfterPositionInRoot()| as pair of |lastEditablePositionBeforePositionInRoot()| to make debugging easier for improving code health. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; No behavior changes Review URL: https://codereview.chromium.org/1316063002 git-svn-id: svn://svn.chromium.org/blink/trunk@201220 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
nhiroki@chromium.org authored
Before the CL[1], Chromium could pass an existing WebServiceWorkerRegistration to ServiceWorkerRegistration, so ServiceWorkerRegistration needed to confirm whether its ownership was passed. After the CL, Chromium always passes ownership and ServiceWorkerRegistration does not have to worry about it. This CL removes codes for the case that ownership is not passed from Chromium. [1] https://codereview.chromium.org/1307133003/ BUG=523904 Review URL: https://codereview.chromium.org/1317473002 git-svn-id: svn://svn.chromium.org/blink/trunk@201219 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
battre@chromium.org authored
Reland of move javaEnabled setting. (patchset #1 id:1 of https://codereview.chromium.org/1318703002/ ) Reason for revert: Relanding because this had no impact. The bug disappeared and re-appeared regardless of this CL. Original issue's description: > Revert of Remove javaEnabled setting. (patchset #1 id:1 of https://codereview.chromium.org/1306403003/ ) > > Reason for revert: > Reverting to see whether this fixes the compilation. > > Original issue's description: > > Remove javaEnabled setting. > > > > As of M45, NPAPI support is (almost) completely gone, so Java will never > > be supported anyway. > > > > BUG=none > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201211 > > TBR=haraken@chromium.org,dcheng@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=none > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201217 TBR=haraken@chromium.org,dcheng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/1319673003 git-svn-id: svn://svn.chromium.org/blink/trunk@201218 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
battre@chromium.org authored
Revert of Remove javaEnabled setting. (patchset #1 id:1 of https://codereview.chromium.org/1306403003/ ) Reason for revert: Reverting to see whether this fixes the compilation. Original issue's description: > Remove javaEnabled setting. > > As of M45, NPAPI support is (almost) completely gone, so Java will never > be supported anyway. > > BUG=none > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201211 TBR=haraken@chromium.org,dcheng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/1318703002 git-svn-id: svn://svn.chromium.org/blink/trunk@201217 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yosin@chromium.org authored
This patch moves global function |isInline()| defined in "EditingUtilities.{cpp,h}" to "IndentOutdentCommand.cpp" to reduce number of global functions for improving code health since |isInline()| is used only in "IndentOutdentCommand.cpp". BUG=n/a TEST=n/a; No behavior changes Review URL: https://codereview.chromium.org/1315073002 git-svn-id: svn://svn.chromium.org/blink/trunk@201216 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yosin@chromium.org authored
This patch replaces forward class declarations |VisibleSelection| to include directive of "VisibleSelection.h" as preparation of introducing |VisibleSelectionTemplate<Strategy>|, like |PositionAlgorithm<Strategy>|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; No behavior changes Review URL: https://codereview.chromium.org/1314843003 git-svn-id: svn://svn.chromium.org/blink/trunk@201215 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dstockwell@chromium.org authored
CompositedDeprecatedPaintLayerMapping contains logic to suppress redundant changes to layers while composited animations are running. The order of operations (composted animations are updated after layers) meant that a compositing update that resulted in the cancelling of compositor animations would still suppress these values. BUG=501297 Review URL: https://codereview.chromium.org/1319653002 git-svn-id: svn://svn.chromium.org/blink/trunk@201214 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yosin@chromium.org authored
Use EditingStrategy as template parameter to lastEditablePositionBeforePositionInRootAlgorithm template function This patch changes template parameter of |lastEditablePositionBeforePositionInRootAlgorithm()| to |EditingStrategy| or |EditingInComposedTreeStrategy| instead of |Position| or |PositionInComposedTre| to match other implementation of editing template functions for improving readability. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; No behavior changes Review URL: https://codereview.chromium.org/1304353003 git-svn-id: svn://svn.chromium.org/blink/trunk@201213 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sigbjornf@opera.com authored
The pre-allocation of the StringBuilder is redundant if the range is empty, hence avoid. While here, simplify empty string builder testing also. R=yosin BUG= Review URL: https://codereview.chromium.org/1317593003 git-svn-id: svn://svn.chromium.org/blink/trunk@201212 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
As of M45, NPAPI support is (almost) completely gone, so Java will never be supported anyway. BUG=none Review URL: https://codereview.chromium.org/1306403003 git-svn-id: svn://svn.chromium.org/blink/trunk@201211 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yutak@chromium.org authored
An accessor function called frameLoaderClientImpl(), added in https://codereview.chromium.org/1314703003/, was actually not necessary. BUG=509911 R=haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com Review URL: https://codereview.chromium.org/1313083005 git-svn-id: svn://svn.chromium.org/blink/trunk@201210 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
haraken@chromium.org authored
The PerfBot is not happy. http://build.chromium.org/p/chromium/buildstatus?builder=Linux%20x64&number=8587 PERF_REGRESS: chrome-bss/bss (1.93%), chrome-bss/bss (1.93%) https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux-64&tests=sizes&rev=345536 > [bindings] Compact ConstantConfiguration by using |union| > > This patch uses |union| to store the constant values to reduce space required. > > This patch saves about ~4 Kbytes of in |.data.rel.ro.local| with component build on linux platform. > Also the size of V8DOMConfiguration::ConstantConfiguration is down to 24 bytes from > 40 bytes on 64bit linux build. > > BUG=469961 > > Review URL: https://codereview.chromium.org/1310443005 TBR=vivek.vg@samsung.com Review URL: https://codereview.chromium.org/1314133002 git-svn-id: svn://svn.chromium.org/blink/trunk@201209 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
meade@chromium.org authored
This allows caching of styles that may be affected by LayoutThemes as the data is now available even when cached. Now with shiny new layout tests to make sure http://crbug/517567 doesn't happen again BUG=259995 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199708 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200094 Review URL: https://codereview.chromium.org/1251523003 git-svn-id: svn://svn.chromium.org/blink/trunk@201208 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yosin@chromium.org authored
This patch is inspired by http://crrev.com/1257203002, which makes printer for |WTFString| in GTest. This patch re-introduces printers for Node, Position and PositionAnchorType in GTest rather than printing address of pointer by fixing ODR violation for improving test authoring experience. In http://crrev.com/1095913003, we introduced |Node| and |Position| printers for GTest in "CoreTestHelpers.h". However, due by ODR violation, these printers aren't used in GTest, since some test files uses |Node| as parameters for GTest macros without including "CoreTestHelpers.h". Note: ODR stands for One Definition Rule. See details explanation in http://crrev.com/1257203002. BUG=514330 TEST=webkit_unit_tests --gtest_fitler=EditingUtilitiesTest.*,VisibleUnitsTest.* Review URL: https://codereview.chromium.org/1313283002 git-svn-id: svn://svn.chromium.org/blink/trunk@201207 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yosin@chromium.org authored
Get rid of unused member function toNormalizedRange() from FrameSelection and VisibleSelection classes This patch gets rid of unused member function |toNormalizedRange()| from |FrameSelection| and |VisibleSelection| classes with re-formatting an associated comment for improving code health. BUG=n/a TEST=n/a; no behavior changes Review URL: https://codereview.chromium.org/1315513005 git-svn-id: svn://svn.chromium.org/blink/trunk@201206 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tasak@google.com authored
Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible. BUG=523249 Review URL: https://codereview.chromium.org/1315783003 git-svn-id: svn://svn.chromium.org/blink/trunk@201205 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tasak@google.com authored
Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible. BUG=523249 Review URL: https://codereview.chromium.org/1306413003 git-svn-id: svn://svn.chromium.org/blink/trunk@201204 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tasak@google.com authored
Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible. BUG=523249 Review URL: https://codereview.chromium.org/1310643003 git-svn-id: svn://svn.chromium.org/blink/trunk@201203 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
trchen@chromium.org authored
The purpose of the transparency clip is to give Skia raster hints so that a transparent layer can be sized according to the bounding box of contents being composited. The clip itself should be no-op, but will actually cause anti-alias artifact for transformed contents. Removing the transparency clip and use compositing bound will allow Skia to take account of anti-aliasing to properly size the transparent layer. BUG=524859 Review URL: https://codereview.chromium.org/1311633004 git-svn-id: svn://svn.chromium.org/blink/trunk@201202 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yosin@chromium.org authored
This patch introduces composed tree version of |enclosingNodeOfType()| as a preparation of introducing composed tree version of |enclosingBlock()| for templatizing |VisiblePosition| class. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=webkit_unit_tests --gtest_fitler=EditingUtilitiesTest.enclosingNodeOfType Review URL: https://codereview.chromium.org/1309903003 git-svn-id: svn://svn.chromium.org/blink/trunk@201201 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
bashi@chromium.org authored
Supporting deprecated Dictionary enables us to do step-by-step refactoring. Note for tests: Since Dictionary instances cannot outlive an event loop, DictionaryTest stores its properties intead of instances itself. Added getDictionaryMemberProperties() to retrieve these properties. BUG=524357 Review URL: https://codereview.chromium.org/1316833003 git-svn-id: svn://svn.chromium.org/blink/trunk@201199 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sashab@chromium.org authored
Remove the failure expectation for fast/css/word-spacing-characters-complex-text.html on Linux, since it is no longer failing. BUG=419769 Review URL: https://codereview.chromium.org/1312873003 git-svn-id: svn://svn.chromium.org/blink/trunk@201198 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jbroman@chromium.org authored
This file does not use RetainPtr. Review URL: https://codereview.chromium.org/1309283002 git-svn-id: svn://svn.chromium.org/blink/trunk@201197 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
timloh@chromium.org authored
Since 'all' is a CSS property (a shorthand for almost every other property), we shouldn't need special logic to handle it during parsing. For efficiency, it is still special-cased when we compute which transitions to start. Review URL: https://codereview.chromium.org/1308073007 git-svn-id: svn://svn.chromium.org/blink/trunk@201196 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jbroman@chromium.org authored
This file does not use RetainPtr. Review URL: https://codereview.chromium.org/1313733002 git-svn-id: svn://svn.chromium.org/blink/trunk@201195 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-