- 19 Apr, 2013 40 commits
-
-
felipeg@chromium.org authored
We restore the index from enumerating the entries on disk when the dir mtime doesnt match the index file mtime. Using the mtime we can reliably detect the stale index on every new entry that has been added or an old entry deleted on disk, since the index file must always the last file created (renamed) in the directory. BUG=233536 Review URL: https://chromiumcodereview.appspot.com/13933029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195197 0039d316-1c4b-4281-b951-d872f2087c98
-
rogerm@chromium.org authored
- The check to see if the dynamic key slots were all in use was comparing the wrong value. - The lengths of the key and value being set wasn't being validated. The lower-level code capturing the values subsequently terminate the process if a key or value is too long for the CustomInfoEntry record. R= cpu@chromium.org, rsesek@chromium.org BUG=77656 Review URL: https://chromiumcodereview.appspot.com/14262014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195196 0039d316-1c4b-4281-b951-d872f2087c98
-
kenneth.r.christiansen@intel.com authored
This only affects the printing module. Current Ubuntu versions ships with CUPS 1.6 which complains about use of deprecated CUPS methods. As we need to continue supporting platforms using older CUPS versions such as Linux and Mac OS, we ignore the warning as an error for now. BUG=226176 Review URL: https://chromiumcodereview.appspot.com/14262006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195195 0039d316-1c4b-4281-b951-d872f2087c98
-
mtomasz@chromium.org authored
This patch verifies if there are no Javascript errors at the end of each test. Along the way it removes callbackPass instances, which are not reliable and can cause false positives. TEST=Run browser_tests --test_filter="*FileManagerBrowser*" BUG=233142, 233141 Review URL: https://chromiumcodereview.appspot.com/14241010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195194 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
To move some non-regular MountPointProviders out of webkit/fileapi, we should not: - Require FileAPI code change for a new MountPointProvider to get/set provider-specific operation context value (e.g. MediaPathFilter) - Require a new MountPointProvider type to be listed as a 'frined' of FileAPI code To avoid having these dependencies, this change: - Makes FileSystemOperationContext inherit from SupportsUserData so that MountPointProviders can get/set arbitrary user values with string keys. - Makes some private methods public (with proper comments) and remove the friend list of MountPointProviders This patch is a part of following change plan (internal only doc): https://docs.google.com/a/google.com/document/d/1XEtX0OO_RIA_c0KuKvd9yqK5l3XtsTulwXs3c-mAQ1o/view BUG=175936 TEST=content_unittests:*File* TEST=browser_tests:*MediaGalleries* Review URL: https://codereview.chromium.org/14341004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195193 0039d316-1c4b-4281-b951-d872f2087c98
-
alexeypa@chromium.org authored
Changes in this CL: - The version of the control channel is increased to 3. This allows the host and client to tell if the peer supports capabilities negotiation or not. - The client and host negotiate supported capabilities by sending each other a list of the supported capabilities. Capabilities supported by both client and host are assumed to be enabled. - The client plugin and webapp negotiate the list of capabilities supported by the client. The webapp has the final word. - The DesktopEnvironment interface was extended to provide the list of all supported capabilities and receive the results of negotiation with the client. - Added the 'sendInitialResolution' capability. When it is enabled the client sends its screen resolution to the host once the connection has been established. - DesktopSessionProxy now waits for the client screen resolution when the 'sendInitialResolution' capability is enabled. BUG=230893 Review URL: https://chromiumcodereview.appspot.com/13932020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195192 0039d316-1c4b-4281-b951-d872f2087c98
-
hidehiko@chromium.org authored
Removed unnecessary query parameter "include-installed-apps=true" from AddFeedUrlParams. Use base::IntToString instead of StringPrintf for trivial case. This is a preparation to add new method into GDataWapiUrlGenerator to support "search by title exact match". BUG=232352 TEST=Ran unit_tests Review URL: https://chromiumcodereview.appspot.com/14240004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195191 0039d316-1c4b-4281-b951-d872f2087c98
-
bsy@google.com authored
The outer sandbox on Linux and OSX was preventing sysconf(_SC_NPROCESSORS_ONLN) from succeeding, so that NaCl applications that need the number of threads were getting a bogus value (-1 when using newlib, and 1 when using glibc). TEST= run_sysconf_nprocessors_onln_test BUG= 176522 Review URL: https://chromiumcodereview.appspot.com/14238013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195190 0039d316-1c4b-4281-b951-d872f2087c98
-
raymes@chromium.org authored
This hooks up the rewritten RawVarData implementation with SerializedVar. It also fixes tests to make sure that shmem ArrayBuffers are actually tested. Previously, no testing of shmem ArrayBuffers was happening because OS_LINUX is never defined in ppapi/tests and none of the other ArrayBuffer test sizes were above the threshhold to invoke that code path. This CL adds a PPB_Testing function to set the threshhold to a lower value, which permits this code path to be taken while still having fast tests. BUG= Review URL: https://chromiumcodereview.appspot.com/14208016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195189 0039d316-1c4b-4281-b951-d872f2087c98
-
cdn@chromium.org authored
BUG=N/A TEST=N/A Review URL: https://chromiumcodereview.appspot.com/14311004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195188 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
Small perf regression. > Prevent chrome.app JSON schema from loading on every page > > The app API along with app.window and app.runtime have been converted to use > the feature system. Bindings are not added to the chrome object for unavailable > APIs that are children of available APIs. For example, if chrome.app is > available, we will not add lazy bindings to chrome for app.window and > app.runtime. This eliminates the need to load the app schema, because we no > longer need to get chrome.app to add the app.runtime and app.window bindings. > > BUG=55316 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194837 > > Review URL: https://chromiumcodereview.appspot.com/13604005 TBR=cduvall@chromium.org Review URL: https://codereview.chromium.org/14241030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195187 0039d316-1c4b-4281-b951-d872f2087c98
-
perkj@chromium.org authored
This implement an observer of a remote webrtc MediaStream and propagates changes to a WebKit MediaStream. It propagates adding and removing of remote tracks to existing mediastreams as well as if a remote track has ended. https://code.google.com/p/webrtc/issues/detail?id=872 BUG=233514 Review URL: https://chromiumcodereview.appspot.com/14200016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195186 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
auth_service.cc has already switched to use the new chromeos/login/ code. BUG=None TEST=git try Review URL: https://chromiumcodereview.appspot.com/14192013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195185 0039d316-1c4b-4281-b951-d872f2087c98
-
lazyboy@chromium.org authored
BUG=None TEST=Test clean up. Review URL: https://chromiumcodereview.appspot.com/14189014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195184 0039d316-1c4b-4281-b951-d872f2087c98
-
keybuk@chromium.org authored
BUG=none TEST=bluetooth pairing works Review URL: https://chromiumcodereview.appspot.com/14163005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195183 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=179904 TEST=Compile locally. Still waiting for the bots to be updated. Review URL: https://chromiumcodereview.appspot.com/14141003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195181 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
This gets rid of some code duplication, and rewrites functions in thunk files which return void to an alternate, equivalent form. BUG= Review URL: https://codereview.chromium.org/14161017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195180 0039d316-1c4b-4281-b951-d872f2087c98
-
pasko@google.com authored
GetEntryCount() was implemented recently with: http://crrev.com/14295013 Now addressing the forgotten TODO. BUG=230306 Review URL: https://chromiumcodereview.appspot.com/14134005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195179 0039d316-1c4b-4281-b951-d872f2087c98
-
justinlin@chromium.org authored
BUG=230911 Review URL: https://chromiumcodereview.appspot.com/14107010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195178 0039d316-1c4b-4281-b951-d872f2087c98
-
nasko@chromium.org authored
The problem is that one of the variables was incorrectly placed in the android ifdef. Also, moving the plugins specific section before Misc. BUG= Review URL: https://chromiumcodereview.appspot.com/13831008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195177 0039d316-1c4b-4281-b951-d872f2087c98
-
grt@chromium.org authored
> Add a short delay before showing the first run bubble. > > R=grt@chromium.org > BUG=223939 > > > Review URL: https://chromiumcodereview.appspot.com/13958003 TBR=macourteau@chromium.org Review URL: https://codereview.chromium.org/14362030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195176 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195175 0039d316-1c4b-4281-b951-d872f2087c98
-
robertphillips@google.com authored
Please see https://codereview.chromium.org/14192019/ Review URL: https://codereview.chromium.org/14241028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195174 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
BUG=233549 TBR=oshima Review URL: https://codereview.chromium.org/14241026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195173 0039d316-1c4b-4281-b951-d872f2087c98
-
yoshinori.sano@gmail.com authored
BUG=231019 Review URL: https://chromiumcodereview.appspot.com/14145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195172 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
BUG=233029 Review URL: https://chromiumcodereview.appspot.com/14079005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195171 0039d316-1c4b-4281-b951-d872f2087c98
-
alexeypa@chromium.org authored
BUG=233213 Review URL: https://chromiumcodereview.appspot.com/14076010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195170 0039d316-1c4b-4281-b951-d872f2087c98
-
bartfab@chromium.org authored
Per the CSS spec, marking part of a user pod as visibility:visible will make it accessible even if the entire account picker has visibility:hidden. BUG=232967 TEST=Manual Review URL: https://chromiumcodereview.appspot.com/13852033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195169 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195168 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195167 0039d316-1c4b-4281-b951-d872f2087c98
-
newt@chromium.org authored
Summary of changes: * Addressing Java warnings * Miscellaneous Java changes BUG=230645 Review URL: https://chromiumcodereview.appspot.com/14230019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195166 0039d316-1c4b-4281-b951-d872f2087c98
-
miletus@chromium.org authored
I just realized that an external battery-backed input device with battery level around 15% can actually last a very long time (like one week ?). So change kLowBatteryLevel to 5% seems making more sense for "Low" battery notification. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/14361004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195165 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@chromium.org authored
BUG=229950 Review URL: https://chromiumcodereview.appspot.com/14057016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195164 0039d316-1c4b-4281-b951-d872f2087c98
-
dconnelly@chromium.org authored
BUG=232048 Review URL: https://chromiumcodereview.appspot.com/14057007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195163 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
The on-screen path will be by Android WebView for hardware draws. BUG=166777 Review URL: https://chromiumcodereview.appspot.com/14048018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195162 0039d316-1c4b-4281-b951-d872f2087c98
-
fangjue23303@gmail.com authored
API proposal: https://docs.google.com/document/d/1joXXu06G3XtvJf8fSNVVvB7UCMadVO07E_v3EulPB00/edit BUG=226915 TEST=browser_tests Review URL: https://chromiumcodereview.appspot.com/14027005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195161 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
Some clients need to distiniguish successful return and failure, for example, to show different notification icon. BUG=128079 Review URL: https://chromiumcodereview.appspot.com/14188035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195160 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
BUG=232231 TEST=manually Review URL: https://chromiumcodereview.appspot.com/14017014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195159 0039d316-1c4b-4281-b951-d872f2087c98
-
calamity@chromium.org authored
The app launcher now adds itself to the start menu on the first run of chrome past this patch. The webstore enable of the app launcher will create shortcuts on the desktop and pin an icon to the taskbar. The app launcher should never be disabled after it is enabled. BUG=233434 TBR=benwells@chromium.org Review URL: https://chromiumcodereview.appspot.com/13940006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195158 0039d316-1c4b-4281-b951-d872f2087c98
-
glotov@chromium.org authored
BUG=178009 TEST=for i in {1..20}; do \ out/Debug/interactive_ui_tests --gtest_filter=OobeTest.NewUser --disable-test-compositor; \ if [ $? != 0 ]; then break; fi; \ done; Review URL: https://chromiumcodereview.appspot.com/13895008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195157 0039d316-1c4b-4281-b951-d872f2087c98
-