- 29 Sep, 2020 40 commits
-
-
Sebastien Lalancette authored
- Fixed the Copy Link test that wouldn't pass on devices. - Reused helper function for Open In New Tab and Incognito actions. - Added test coverage the new context menu actions: - Share - Delete Bug: 1131831,1067812 Change-Id: Ic5b6e4487aea4bd7c972f5ca8caf6632e4c6dbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435329Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#811680}
-
Viktor Semeniuk authored
This change adds metrics for the Password Edit dialog. It records what exectly user updated. Bug: 377410 Change-Id: I8940bb9960eaf79b569cae2130246ea043e1adda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426594 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#811679}
-
Swapnil authored
Analysing the statistics, we observed that we get BAD_APP_STATUS error with "unknown-app" error in the app status in the update manifest. This means that the server has no record of the extension or that there are visibility rules preventing it from disclosing the existence of such a record (e.g. extension is only visible internally for Google, and the request is from outside Google). This is a misconfiguration from the admin side. Bug: 1130609 Change-Id: I5fb7bee74a564635ffa67bc218906576db27e133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421602 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#811678}
-
sandromaggi authored
This allows the SelectOptionAction to use a value from a previously selected profile. If the profile is not available the action will terminate with an error. If the value expression cannot be resolved the action will terminate with an error. Bug: b/169521597 Change-Id: Ibd34fa922b9c7d1ac2846e0327caf194697e5f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437810Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#811677}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/88c194fccd3b..76404b01d531 2020-09-29 treehugger-gerrit@google.com Merge "Fix typescript error" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iff22b6c7c1ddf212c14f484c7ec9f4ecad67c8fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438151Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811676}
-
My Nguyen authored
list-frame default padding is 60px, update to 40px because top-level spell check title has a 20px padding, spell check languages title has 60px padding, making it a 40px visual indentation. Old view: http://screen/7REeFrimicVBjWM New view: http://screen/6kZ4if6qVnZjKso Bug: 1113439 Change-Id: I24bb4e805d64f1adb5772355a3de9823a079a23a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437544Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#811675}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/95c0414b..fa4bfe45 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic9601fa5406391df8f809261a6a4afa59875f0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437969Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#811674}
-
Aga Wronska authored
Extends the histogram expiration and updates owners. Bug: 1088897 Change-Id: Id0ac5473c4065f5e8de9b3eb5a93e32976d4829f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434464Reviewed-by:
-
Dominick Ng authored
Crash reports indicate that ChromeLauncherController::InsertAppLauncherItem seems to be called to insert an item that already exists in the shelf. This CHECK has been around for a long time. Convert it to a conditional DumpWithoutCrashing, and return the ID of the existing item. Adding the return doesn't functionally change behaviour since no callsite uses the returned value. Additionally, since the item must already exist in the shelf model, presumably this preserves the desired behaviour, though the desired pin position may be changed. Further investigation is needed to see what exact train of events led to this CHECK being violated. BUG=1090134 Change-Id: I9dc5d37e82663f6a80b25f8747a62ad2a11f8607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437336Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#811672}
-
Aya ElAttar authored
- Added kArc as a data endpoint type of the clipboard data. - Changed the notification strings of the toast shown when the clipboard data sharing with ARC++ fails. Bug: 1129345 Change-Id: I8e61ddbb1dc9ea9f36d1965152fe57e471787479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428970 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811671}
-
Titouan Rigoudy authored
For subresource URL requests, the renderer URLLoader uses its factory's parameters to determine the client security state of the request initiator. Navigations however use a central URLLoaderFactory in the browser process. This change propagates the client security state in the ResourceRequest to the URLLoader as a trusted parameter, and acts on this state in URLLoader. It only improves the situation for non-top-level navigation requests. The latter need some thought given to the UX first, see: https://crbug.com/1129326. Bug: chromium:1124346 Change-Id: I8736706ef402831375f34f9c7f2a96d3059c25be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410406Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811670}
-
Yi Gu authored
This reverts commit ceada96f. Reason for revert: The tests are still flaky. e.g. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=AccountManagerUIHandlerTestSuite%2FAccountManagerUIHandlerTest.OnGetAccountsWithSecondaryAccounts%2F0&testType=browser_tests Original change's description: > Re-enable AccountManagerUIHandlerTest tests > > AccountManagerUIHandlerTest tests were disabled in > https://bugs.chromium.org/p/chromium/issues/detail?id=1131834 > due to flakiness with ExternalWebAppManager. This is due to > https://chromium-review.googlesource.com/c/chromium/src/+/2423823 > altering the behaviour of when > chromeos::ProfileHelper::IsPrimaryProfile() gets called uncovering > an incompatiblity between the profile created by these tests and > IsPrimaryProfile(). > > This CL disables ExternalWebAppManager's start up flow to avoid > triggering the IsPrimaryProfile() incompatibility so we can > re-enable these tests. > > Bug: 1131834 > Change-Id: Ia4d15785a64b45689f742d3604c10e1b8502cafd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434412 > Auto-Submit: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811404} TBR=michaelpg@chromium.org,alancutter@chromium.org Change-Id: I6b783ce2797fd5e88e5a1a131782a1598ab2f1b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437171Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811669}
-
Viktor Semeniuk authored
This change rewrites Passwords tests with new Password Details screen. Obsolete tests are deleted. Fixed flakiness for testSearchAndDeleteAllPasswords. Bug: 1075494, 1129441 Change-Id: Id6d44a2f77c20edb1788f1d3dcaa04e9e645cdb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418853 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#811668}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/18d69fb4e7b2..0f6ed710764d 2020-09-29 fancl@chromium.org auto-triage: Don't update closed issue when all alerts recovered If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1132463 Tbr: rmhasan@google.com Change-Id: I93fcd4735e66f24e25c7ddad564942d59232cde8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437939Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ead81e2ba233..991ead187c14 2020-09-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I7e7bab48bd1a344cbe22b41624c2fed52baed7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437647 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Nohemi Fernandez authored
We display the account consistency promo on top of Google web sign-in to allow users to dismiss the promo and only sign-in on the web. Bug: 1125631 Change-Id: Ife6da5203a3bff8e72fe79a9be06cefd902cc5ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416376 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#811665}
-
Austin Tankiang authored
Bug: 1067346 Change-Id: Ie7c5503754d1e2a1808e11230b9f6c6916c97269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426063 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#811664}
-
Michael Ershov authored
Enable the check that AttestationEnabledForUser policy is configured from cloud and the level is "Mandatory". This CL reverts https://crrev.com/c/1865340 because the values in the corp policies were fixed. Bug: 1000589 Test: *TpmChallenge* Change-Id: I17058e673100673023c3e8f0f759e0b4b92afac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436822 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#811663}
-
Mohamed Heikal authored
Also: - updates build/protoc_java.py to use argparse instead of optparse. - removes deprecated references to proto nano Bug: 1114836 Change-Id: I184e6e262159ecb79cdf980a8c48e9d7f28c7d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434908 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#811662}
-
Bartek Nowierski authored
There are a couple reasons for this change: 1. Avoid copying a struct larger than a pointer. 2. If the pointer in the struct gets replaced by CheckedPtr with a non-trivial constructor, the compiler will complain. See go/miracleptr for more details on the experimental CheckedPtr project. Bug: 1080832 Change-Id: I520614995dcbae3bdab69a1423d288b2eeea9189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437991 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#811661}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e96cdd18ac5f..842805ced156 2020-09-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 8563523f to 339e4ec2 (471 revisions) 2020-09-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ed2b465f8607 to b2a4e87ad274 (8 revisions) 2020-09-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b94db86cf9b3 to 44be0942f9a8 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I8ffc2738d595e9c71d305c40e39f236f3d915bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438149Reviewed-by:
-
Dominik Röttsches authored
Speculative fix for issue 1128434. The mac-arm64 build may be built without DCHECK on, which could be the explanations for why these tests are not actually failing. Bug: 1128434 Change-Id: I1ca705c1429847dde587e6f69e66f22cbbdad59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438050 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#811659}
-
My Nguyen authored
This makes sure line is wrapped appropriately for other languages when the words flow over. No change in view for English: http://screen/5eTsrhmsRX7X4nP Bug: 1113439 Change-Id: Ib8252a4b2f589ddefd4ba7a0ad8e26e16fad0584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437310 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
Paula Vidas authored
If UseSyncInvalidations feature flag is enabled, we don't subscribe to old invalidations for any data types besides Wallet and Offer. And if UseSyncInvalidationsForWalletAndOffer is enabled, we don't register for old invalidations at all. Bug: 1082115, 1050970 Change-Id: Ifbda4e29c4ed22a1469f1482ba7be8f8cccbd881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435224 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#811657}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/62139fcca727..b2a4e87ad274 2020-09-28 enga@chromium.org Un-skip WriteTexture test on Swiftshader 2020-09-28 enga@chromium.org Roll third_party/swiftshader/ e8dd233c7..2014e7b92 (79 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I1a60ad81c61a443fba512b8a70a0052931871aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437933Reviewed-by:
-
Mohammed Abdon authored
The saml user will be forced to re-authenticate through online flow in the lockscreen. This feature is enable by setting kDefaultSamlLockScreenReauthenticationEnabled to true. Bug: 1113295 Change-Id: I7f89408aca31de9137006d5cbb96cfc91ee708d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339359Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Mohammed Abdon <mohammedabdon@chromium.org> Cr-Commit-Position: refs/heads/master@{#811655}
-
Christoph Schwering authored
This reverts commit b622082c. Reason for revert: The CL seems to cause flakiness of VariationsHttpHeadersBrowserTestWithRestrictedVisibility.TestRestrictGoogleWebVisibilityInThirdPartyContexts, crbug.com/1133291 Original change's description: > Prevent deadlock by checking kRestrictGoogleWebVisibility sooner. > > More specifically, check the feature's state after field trials have > been created from the variations seed and before the variations > header is updated. > > Checking the state for the first time in > VariationsIdsProvider::GenerateBase64EncodedProto() could cause a > deadlock. > > Bug: 1094303 > Change-Id: I53fe3446e3a4567d4b9122b54642b5744eb8b46e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431556 > Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811566} TBR=jwd@chromium.org,asvitkine@chromium.org,caitlinfischer@google.com Change-Id: I8cbc093f9bd9d978a13eb881d7dc319309a808fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1094303, 1133291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438057Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#811654}
-
edchin authored
Handles synchronous localObject drops differently from asynchronous drops from another app. Bug: 1128531, 1128656 Change-Id: I45b124f1f8bb887a465a753e40a9fa5cc74c5e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438011 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#811653}
-
sandromaggi authored
This allows the SetFormFieldValueAction to use a value from a previously selected profile. If the profile is not available the action will terminate with an error. If the value expression cannot be resolved the action will terminate with an error. Bug: b/169521597 Change-Id: Id2502d366d42a085103261bb35e30b0e701410fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435084 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#811652}
-
Ravjit Singh Uppal authored
Extending the expiry time of these histograms until M89, to give us extra time to decide about them. Bug: 1125795, 1125794, 1125793, 1125792, 1125657 Change-Id: If2da7f73bdbbebdda596dc7d16974dc2c9143193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435306Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
Henrik Boström authored
The pixel buffer pool is a light-weight wrapper for CVPixelBufferPool. It takes care of configuring the pool, which avoids working with some cumbersome Core Foundation objects. This CL also adds tests to make sure the pool is behaving as expected, since the Apple documentation is rather poor in details. The intent is to use the PixelBufferPool in future CLs in order to use the VTPixelTransferSession for more efficient (hopefully) scaling and pixel format conversions. // Guido is OOO today so TBR-landing for BUILD.gn changes. TBR=guidou@chromium.org Bug: chromium:1132299 Change-Id: I28ffa7d75dbffd4fcf44c7fb2b22e89e19d6a0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431427Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#811650}
-
Jochen Eisinger authored
Bug: 1131759 Change-Id: Ic46050d835b76a9f972c262fb8f9e3958412541f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436336Reviewed-by:
-
Kent Tamura authored
from LayoutTextControlSingleLine to PasswordInputType. LayoutObject should not store such a UI state. This CL will help LayoutNG transition. * Moves the followings from LayoutTextControlSingleLine to PasswordInputType: - should_draw_caps_lock_indicator_ flag - CapsLockStateMayHaveChanged() - ShouldDrawCapsLockIndicator() * Moves CapsLockStateMayHaveChanged() calsites in TextFieldInputType to PasswordInputType. Make TextFieldInputType::ForwardEvent() protected for this. This CL has no behavior changes. Bug: 1040826 Change-Id: I47df60b4e38184ad81b75a52ce8835e9af4ed3ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437077 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#811648}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Iaf46f81d987f049093a8bae7454ac9e3bd1ddc53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437931Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4b07d50cd9a0..c6ca885c0b4a 2020-09-28 dj2@everburning.com [spirv-dis] Add some context comments to disassembly. (#3847) 2020-09-28 emaxx@google.com Fix use-after-move in val/validate.cpp (#3848) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I46cd20df34235f25daf78025e6565d34ae6f5dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438109Reviewed-by:
-
Maksim Sisov (GMT+3) authored
This reverts commit aa21781d. Reason for revert: results in not visually focused browser window on ozone/linux + mouse highlights no longer work. Also, client view area doesn't show any contents. See https://crbug.com/1133195. Original change's description: > [ozone/wayland] Use 4x4 opaque background and stack underlay correctly > > Using a 4x4 sized opaque background will not regress performance in > underlay cases because the root surface is still opaque. The background > will be stretched out by wayland viewporter extension. > > This is 6/? CL for overlay forwarding using wl_subsurface. > > Change-Id: I59b0d4cdbfbb6727d578e286c9d19cf69a9bff32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352523 > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#810527} TBR=rjkroege@chromium.org,msisov@igalia.com,fangzhoug@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1133195 Change-Id: I4d2e7d7e7b94743bf29a932bd37264ccff45b585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438129Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#811645}
-
Andrei-Laurențiu Olteanu authored
Add implementation to chrome://. Add implementation to chrome-untrusted://. Restrict maxFileSize to 10GB. Add tests. Bug: b:162051831 Change-Id: Ia011da2289e1808e2bd828ddd9bb82573ed73d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401340 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#811644}
-
Mariia Shvedchenko authored
Applying negative matching, adding finch flag, using vector<MatchingPattern> instead of single matching pattern in FormField::ParseField, and FormField::ParseFieldSpecifics. Change-Id: Id3213ab070267df1c670002effcada174cc85dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431515Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I2756db28b9f5e78d580c7de94263b651d842d900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435719Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#811642}
-
Alan Cutter authored
This CL adds a "launch_query_params" field to default web app JSON configs that causes the web app to launch with the specified query params appended to the app's start_url. Bug: 1045537 Change-Id: Ib6025ae39eac7a6f710b2817a0f2ad30437e29c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377044Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#811641}
-
