- 07 Mar, 2019 40 commits
-
-
Carlos IL authored
This reverts commit 30645e2f. Reason for revert: Failures reproduce locally on commits prior to this CL. Original change's description: > Revert "Refactor SSLCertificateErrorPageController" > > This reverts commit 08c128cd. > > Reason for revert: Reverterd on suspicion of causing build failures on Mac 10.11 > > TBR: carlosil@chromium.org > > failures: > SSLClientSocketReadTest.Read/1 > SSLClientSocketReadTest.Read/0 > HTTPSEVCRLSetTest.FreshCRLSetNotCovered > WebSocketEndToEndTest.BasicSmokeTest > SSLClientSocketReadTest.DumpMemoryStats/0 > SSLClientSocketReadTest.DumpMemoryStats/1 > URLRequestTestFTP.FTPCheckWrongUser > WebSocketEndToEndTest.TruncatedResponse > WebSocketEndToEndTest.HstsWebSocketToWebSocket > WebSocketEndToEndTest.TrailingWhitespace > HTTPSOCSPTest.IntermediateResponseTooOld > URLRequestTestFTP.FTPCheckWrongUserRestart > URLRequestTestFTP.FTPCheckWrongPasswordRestart > HTTPSOCSPTest.Revoked > HTTPSFallbackTest.TLSv1_1NoFallback > HTTPSFallbackTest.TLSv1_3Interference > URLRequestTestFTP.FTPCheckWrongPassword > WebSocketEndToEndTest.HeaderContinuations > HTTPSCRLSetTest.ExpiredCRLSetAndRevoked > HTTPSEVCRLSetTest.FreshCRLSetCovered > SSLClientSocketReadTest.Read_DeleteWhilePendingFullDuplex/1 > SSLClientSocketReadTest.Read_DeleteWhilePendingFullDuplex/0 > OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/18 > HTTPSOCSPTest.Valid > HTTPSEVCRLSetTest.ExpiredCRLSet > OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/12 > OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/13 > OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/10 > OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/11 > OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/16 > … 70 more (100 total) … > > Original change's description: > > Refactor SSLCertificateErrorPageController > > > > SSLCertificateErrorPageController is no longer only used on SSL errors, > > renamed it to SecurityInterstitialErrorPageController, and removed the > > net::Error code passed to EnablePageHelperFunctions since it's no > > longer used. > > > > Bug: 910794 > > Change-Id: I718e0fcbcb2643cb0c47818dda1f317aef4e75cc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503910 > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Carlos IL <carlosil@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#638232} > > TBR=sky@chromium.org,mmenke@chromium.org,carlosil@chromium.org > > Change-Id: I39489effa3e0029b5ff65f5bc9cbd991aef1ddea > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 910794 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507039 > Reviewed-by: Peter Williamson <petewil@chromium.org> > Commit-Queue: Peter Williamson <petewil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638363} TBR=sky@chromium.org,petewil@chromium.org,mmenke@chromium.org,carlosil@chromium.org Change-Id: I5b9048e43ebc60964c44ebfd2c05207a22a549dc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509352Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#638773}
-
Dominic Mazzoni authored
NOTRY=true Bug: none Change-Id: I858c72418af41bf72404ed168e2817b4afd1edb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509370 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#638772}
-
Dominic Mazzoni authored
NOTRY=true Bug: none Change-Id: I49f929bb9806d49a356c686fa913acce4a55c47a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509456 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
tby authored
Bug: 938680 Change-Id: I7813371dbe0bd0586e1b2343d7e3964b4f319b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504610Reviewed-by:
Michael Martis <martis@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#638770}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b139178fb593..2f3c820ae30d git log b139178fb593..2f3c820ae30d --date=short --no-merges --format='%ad %ae %s' 2019-03-07 spang@chromium.org Simplify GIT.IsValidRevision Created with: gclient setdep -r src/third_party/depot_tools@2f3c820ae30d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:938627 TBR=agable@chromium.org Change-Id: Iec77dfed54bc049fff764d095c0d9bf612569b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509440Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638769}
-
Christian Biesinger authored
Move the |object| declaration closer to where it is used, and only call IsLayoutScrollbarPart when we actually use the result. R=eae@chromium.org Change-Id: I058572f2f2a05d97a481293db3f901e55a1773b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509462 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#638768}
-
Rohit Rao authored
Adds two new headers intended for use by files that are compiled under both EG1 and EG2. These new headers handle importing the appropriate EG headers, consolidating this boilerplate code into a single location. Also consolidates setting eDO include dirs in a single location. BUG=930859 Change-Id: I02141ea18efc38ef534ed043d61e984da1096d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508578Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#638767}
-
Eric Stevenson authored
trichome_library_apk currently doesn't have any strings, which is a requirement of the tool we're going to use to generate stub APKs. This CL adds an android_resources target that contains a single (empty) string. Bug: 937435 Change-Id: I3e1faff60005c4871da9559a8b5f677d601edb11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508233 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#638766}
-
David Trainor authored
Add basic UMA to get a good understanding of how Play and Chrome are interacting. This is set to expire in a few months, when we are sure we will have a good understanding of Play expectations and behavior in the wild. Bug: 934345 Change-Id: Ib70d661c8034acb3fe480620cc7664db29a88060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481856Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#638765}
-
Matt Menke authored
It's already enabled for HTTP proxies, and for most consumers of the NQE output, there's not really much difference between the two, though SOCKS proxies are lower overhead, particularly since they can't sit on top of HTTPS or H2. Bug: none Change-Id: I901066a5a641c82dd386e79da65dd479513ab6c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509371Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#638764}
-
Jarryd authored
Note: I am removing expired histograms in multiple CLs, keeping related histograms in the same CL. These metrics report on a couple members of the because they are also plumbed through to the chrome://quota-internals page. QuotaTemporaryStorageEvictor: :Statistics struct, which I did not remove Change-Id: Ic2d90fd0e9b34ab30e927baa36d921b5946d0c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506385 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Sajjad Mirza authored
This is a fix for crrev.com/c/1496002, which was reverted because of a 1-character mistake. The rest of the CL message is copied from the original: Previously the wrapper script would only be used for coverage builds that required selective instrumentation of specific files. Now it will also be used for any coverage builds. Since the script's job is to remove flags from files that shouldn't have them the default_coverage config now adds to cflags even in a CQ build. Bug: 918215 Change-Id: Ifdb13657c0c7a80d79960b411050e4f8918fa172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508560Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@google.com> Cr-Commit-Position: refs/heads/master@{#638762}
-
Victor Fei authored
This change implements UIA_ClickablePointPropertyId for IRawElementProviderSimple::GetPropertyValue with unit test coverage. We calculate the clickable point's coordinates as the center of the ax node's bounds in screen coordinates. Bug: 844149 Change-Id: I2dc3da3d078188bf469b9beafe8e33d50fe322a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506126Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#638761}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ec255730a818..71008d880f75 git log ec255730a818..71008d880f75 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 bclayton@google.com Reactor: Fix createFCmpUNE (LLVM) Created with: gclient setdep -r src/third_party/swiftshader@71008d880f75 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I48f6a2af9189083bab19297d8151da1a7adf78a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509254Reviewed-by:
-
Alexei Filippov authored
Also retire --memlog-sampling flag as it is always enabled. Add description for --memlog-in-process flag. BUG=923459 Change-Id: Ibea239b2344872df67b649f2dc9cbc0ba347bc32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507197Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#638759}
-
Sajjad Mirza authored
This is a reland of cdc92f96 Original change's description: > Reland "Adding an exclusion list to the coverage wrapper script." > > This is a reland of 6b7213a4 > > Original change's description: > > Adding an exclusion list to the coverage wrapper script. > > > > The script now assumes GN adds coverage flags to the cflags for each > > source file. The script removes the flag if the file is in an exclusion > > list, or if `--files-to-instrument` is set it will also remove flags if > > the file is not listed in that argument. > > > > The script supports multiple exclusion lists that can be selected with > > the `--target-os` flag. > > > > It's expected that GN will set these flags correctly and invoke the > > script in all coverage builds. http://crrev.com/c/1496002 does that. > > > > > > Bug: 918215 > > Change-Id: I4454f67067a083581f31a22cfef85368825789f9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495994 > > Commit-Queue: Sajjad Mirza <sajjadm@google.com> > > Reviewed-by: Max Moroz <mmoroz@chromium.org> > > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > > Reviewed-by: Roberto Carrillo <robertocn@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#637892} > > Bug: 918215 > Change-Id: I1254d288ff263ff94c46b46e6be99738e31b9574 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506974 > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Commit-Queue: Sajjad Mirza <sajjadm@google.com> > Cr-Commit-Position: refs/heads/master@{#638362} Bug: 918215 Change-Id: Ibd1e68a066bddd69e46c9cb32fcd9df209d97a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509459Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@google.com> Cr-Commit-Position: refs/heads/master@{#638758}
-
Robert Ma authored
https://crrev.com/c/1504480 marked the wrong (non-virtual) one. TBR=flackr Bug: 938780 Change-Id: Ia0e0aed2b53ac8c8e775793667a39ea5db97c6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509096Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#638757}
-
Andrew Xu authored
The key code which is created by KeyEvent rewriting is stored in AcceleratorHistory when the key button is pressed. However, there is no code responsible for removing it when the key button is released. Instead only the key code before KeyEvent rewriting is erased. As result, the accelerators relying on the state of AcceleratorHistory often have unexpected behavior when KeyEvent rewriting is triggered (The comment under this issue gives detailed explanation). In this CL, EventRewriterChromeOS stores the pressed keys. Based on it, EventRewriterChromeOS computes the rewritten event and the rewritten status. In addition, the test on edge cases is added. Bug: 913209 Test: unit_tests Change-Id: Ie22fe2ba8a2bd296628032723acc721db2616a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1477959Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#638756}
-
Leonard Grey authored
Bug: 929866 Change-Id: I9d00bbc56040fbeb1973cda37e28af1507842043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509359Reviewed-by:
-
Ian Vollick authored
Creates a script that can be used to generate Java files to expose native strings to Java, giving us a single source of truth for these constants. Bug: 937280 Change-Id: I1f0804bdfff8101dfd149612acd44360ae0dc2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495747 Commit-Queue: Ian Vollick <vollick@chromium.org> Auto-Submit: Ian Vollick <vollick@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/aa9d6ad09d0d..b6a80b321e8f git log aa9d6ad09d0d..b6a80b321e8f --date=short --no-merges --format='%ad %ae %s' 2019-03-07 natlee@microsoft.com Destroy backend implementation for Buffers Created with: gclient setdep -r src/third_party/dawn@b6a80b321e8f The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I1f4ecec1abd2e57d8aae5f707da4eed55c8355d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509257Reviewed-by:
-
Yuri Wiitala authored
This reverts commit c7021cb3. Reason for revert: webkit_layout_test failures were due to flaky tests. The flaky tests have been marked in TestExpectations. Original change's description: > Revert "AudioService: Fixes for loopback underruns/timing issues." > > This reverts commit 4f9a19f1. > > Reason for revert: Suspected in causing webkit_layout_test failures > https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/9784 > * media/video-played-collapse.html > * virtual/video-surface-layer/media/video-played-collapse.html > > Original change's description: > > AudioService: Fixes for loopback underruns/timing issues. > > > > Fixes a "choppy audio" issue on platforms with certain audio timing > > parameters/scenarios. Investigation on crbug.com/934770 led to the > > realization that three related problems needed to be addressed: > > > > 1. Fix the "gap" detection in audio::SnooperNode to check in BOTH > > directions, not just one direction; and on both the input and output > > flows. This accounts for the case where a device-switch in > > audio::OutputController results in a sudden drastic shift in the delay > > timestamps. > > > > 2. Add automatically-increasing capture delay logic to > > audio::LoopbackStream to ensure the reads from all nodes' delay buffer > > will never result in underrun. > > > > 3. Increased the accuracy of media::FakeAudioWorker/OutputStream by: a) > > addressing a subtle source of error in task scheduling delay math due to > > integer truncation; b) exposing timestamps to worker callbacks that > > allow FakeAudioOutputStream to provide a |delay| and |delay_timestamp| > > that behaves just like a real AudioOutputStream. This "lessens the blow" > > of a device-switch to SnooperNode. > > > > Bug: 934770 > > Change-Id: Ia75f18b2be3ad905f27d6ad882df9632764bb81c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504981 > > Commit-Queue: Yuri Wiitala <miu@chromium.org> > > Reviewed-by: Max Morin <maxmorin@chromium.org> > > Reviewed-by: Oskar Sundbom <ossu@chromium.org> > > Reviewed-by: Weiyong Yao <braveyao@chromium.org> > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#638427} > > TBR=dalecurtis@chromium.org,miu@chromium.org,braveyao@chromium.org,maxmorin@chromium.org,ossu@chromium.org > > Change-Id: I845f547c60481ebde0ae24d1a83d59f2f750f7e3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 934770 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509365 > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638708} TBR=dalecurtis@chromium.org,miu@chromium.org,robliao@chromium.org,braveyao@chromium.org,maxmorin@chromium.org,ossu@chromium.org Change-Id: If7d8fcd080f057491ec785173ebbf849d1f3bbdd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509634Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#638752}
-
Yuri Wiitala authored
This test caused a recent good change to be reverted because the flakiness tilted more towards "constant failure" on Mac 10.13 (see https://chromium-review.googlesource.com/c/chromium/src/+/1509365). According to the Flake Portal (and running the test on a clean checkout on my local Linux and Mac machines), the test indeed is flaky. TBR=chcunningham@chromium.org Bug: 931533 Change-Id: I368b171a69ce423e47810c77ab0346bc8286c7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509633Reviewed-by:
-
Jarryd Goodman authored
In the finch confi for the quota expansion experiment, I had to modify the min version to 73, as the FLT bug is approved for beta on M73. As a result, I had to update the experiment group names in the finch GCL since I revised the target of the experiment. This change ensures that the field trial testing config has the right experiment group name. Change-Id: I181f92bb85884c15457a331b5a6af6ca354a0df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509109 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#638750}
-
Dan Beam authored
R=dpapad@chromium.org BUG=926658 Change-Id: I9b64c2a2250f73f2e5ab2d8906c259ceb714503d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506884 Commit-Queue: Dan Beam (slow; perfing) <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam (slow; perfing) <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#638749}
-
Robert Phillips authored
An upcoming Skia CL (see below) needs Viz to know a bit more about Skia's GrContext. https://skia-review.googlesource.com/c/skia/+/198240 (Add GrRecordingContext variants of SkImage makeSubset, makeColorSpace and makeColorTypeAndColorSpace) Change-Id: I5562adc1659e770a99d3abb0e4d045a44edfc782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509052Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#638748}
-
Hiroshige Hayashizaki authored
ProduceCacheInternal()'s |unbount_script| argument can be empty for module scripts and this is causing crash. Bug: 938269, 841466 Change-Id: I2e51702fa243c9e1486511ddbe7e845c2b5b4a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507112 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#638747}
-
Daniel Bratell authored
Everything using Rect in mojom files will indirectly need to include //ui/gfx/geometry/mojo/geometry_struct_traits.h" and for that to be allowed in gn, its build target (//ui/gfx/geometry/mojo:struct_traits) needs to be a public dependency. This fixes about 200 dependency errors as reported by a gn that can check dependencies in generated files (gn:57). Bug: 938893 Change-Id: Ifbe6d0c6a0bc26e158badf751322509e66093252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508467Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#638746}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3cfa438106ff..eb113c10cb35 git log 3cfa438106ff..eb113c10cb35 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 fmayer@google.com Merge "Bump libunwindstack version." 2019-03-07 fmayer@google.com Merge "Allow to skip function names." Created with: gclient setdep -r src/third_party/perfetto@eb113c10cb35 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iea2a0f2d3762c0b0a81ad1b70252758dfd1823e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509258Reviewed-by:
-
John Chen authored
Fix how pointer event locations are calculated in Perform Actions command, in particular, fixing how relative pointer moves are handled. This fixes all failures in WPT test perform_actions/pointer.py. Bug: chromedriver:1897 Change-Id: If0bd79399e9376fe885ef9c26f20d775a4c7d6c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507313Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#638744}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb039b04e175..0086bb261de5 Created with: gclient setdep -r src-internal@0086bb261de5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org Change-Id: Ica4011dfcd15cc4e095a7470f24d64d2a1fa456f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508562Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638743}
-
Dan Harrington authored
We had three nearly identical stores, that only differ meaningfully in the histograms/tracing they report. Added a base class to combine duplicate code. Note that the only difference was that OfflinePageMetadataStore allowed multiple Execute() calls before initialization, whereas the other stores did not. The new SqlStoreBase does allow for this. Additionally, moved some code out of the header file where possible to reduce binary size. Because there's so many Execute() calls in the code, this reduces binary size by about 9KB. Histogram OfflinePages.SQLStorage.CreateDirectoryResult was removed because it wasn't being used. TBR=cmumford@google.com Change-Id: I434655bb7deaa5b9ac7b403c6fc0d65af4b26b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460110 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#638742}
-
Nate Fischer authored
No change to production logic, only tests. The #setAcceptCookie() API should not expose already-set cookies via the "Cookie" header or via document.cookie. Current test coverage only checks WebView does not honor the Set-Cookie header or assignments to document.cookie. So, this adds a test to handle this case. This test does not work (yet) for the network service path, so this adds the test to the filter. This also removes an accidentally duplicated line in another test (which I observed while writing this one). R=tobiasjs@chromium.org Bug: 936317 Test: run_webview_instrumentation_test_apk \ Test: -f=CookieManagerTest.testAcceptCookie_falseDoNotSendCookies Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Ic0ed4b73d6f7fd2275438b63fc2c01a4d76d9c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507282Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#638741}
-
Mitsuru Oshima authored
Added new uma stats to replace old stats: Event.DownEventCount.PerInputFormFactorDestinationCombination2 Bug: 926040 Test: Updated & added new test in PointerMetricsRecorder unittest. Change-Id: Ic2410100428c61bde1c780afd3ee6e04db376063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1443459 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#638740}
-
Leonardo Padilha authored
Bug: 919132 Change-Id: I4db14c49af64028e4c72b493a7988f46d2369c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509312Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Leonardo Padilha <ldaguilar@chromium.org> Cr-Commit-Position: refs/heads/master@{#638739}
-
Joe DeBlasio authored
This reverts commit bfa0a0c5. Reason for revert: Out of an abundance of caution as suspected actual culprit behind https://chromium-review.googlesource.com/c/chromium/src/+/1509333 Original change's description: > Cleanup Lookalike interstitial browser tests. > > This is a cleanup CL to add a few missing, and simplify existing, > interstitial tests. It also includes a few unaddressed nits from earlier > CLs. > > Bug: 927924 > Change-Id: Iaa177d8dfc69d127b6ba2af5c8f508d5e5d8db83 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497756 > Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> > Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638286} TBR=msw@chromium.org,meacer@chromium.org,jdeblasio@chromium.org Change-Id: Ie0b186fd3b3455c13eb1077cb134411416136da2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509463Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#638738}
-
Etienne Pierre-doray authored
TBR=rockot@chromium.org Bug: 939289 Change-Id: I86ad8878e2dcd97589425038fdf0ed2871252ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509492Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#638737}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/699655f07b93..eefd8e8457a3 git log 699655f07b93..eefd8e8457a3 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 benjhayden@chromium.org Add report-controls for spa 2019-03-07 benjhayden@chromium.org Fix empty BatchIterator for spa. 2019-03-07 benjhayden@chromium.org Add a drawer to chromeperf-app 2019-03-07 benjhayden@chromium.org Add chart-timeseries for spa 2019-03-07 mattcary@chromium.org Devil: enable parsing a manifest from an android bundle. 2019-03-07 simonhatch@chromium.org Dashboard - Change Pinpoint stats to 7 days Created with: gclient setdep -r src/third_party/catapult@eefd8e8457a3 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193,chromium:918193,chromium:918193,chromium:918193,chromium:931269,chromium:924564 TBR=sullivan@chromium.org Change-Id: I97f6cef6717206bc26633301c1211187c02a0d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509101Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/db5c5ade84ad..b139178fb593 git log db5c5ade84ad..b139178fb593 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 vadimsh@chromium.org [lucicfg] Bump lucicfg version 1.3.2 -> 1.5.3. 2019-03-07 ehmaldonado@chromium.org Revert "Avoid unnecessary invocations of "git fetch"" Created with: gclient setdep -r src/third_party/depot_tools@b139178fb593 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:938627 TBR=agable@chromium.org Change-Id: I7f31f68119321b0b5b9966fb81cde4b98261cc7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509100Reviewed-by:
-
Kristi Park authored
Bug: 923563 Change-Id: I9b1b3b84f35a312deac8ad8b0b286d64c3b6b2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474674 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638734}
-
