- 17 Jun, 2020 40 commits
-
-
dpapad authored
This is a temporary fix which will be replaced with an assertion in a follow up. Currently there is an assumption in the code that if unpack_pak.py is used the output of that script is placed in a folder that is suffixed with '.unpak', which is not true for NTP which uses a folder named 'unpak' without the dot. This fixes the contents of out/<out_folder>/gen/chrome/browser/resources/new_tab_page/optimized_js.d to not hold unexpected entries for files already in the unpak folder. Bug: 1093405 Change-Id: Ib84b5b0890d1a98e938dcdf691e621b397b8de91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250660Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#779545}
-
Lindsay Pasricha authored
Also updated ios fyi bot def to os=mac 10.15. Bug: 1087433 Change-Id: I348d9b8d9bb637a2c79bb58086cfe6ea8206005a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240459 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#779544}
-
Lexi Stavrakos authored
Bug: 1088004 Change-Id: I4657f338aeec6399e85035c5c800b704ff8b6f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248455 Commit-Queue: Lexi Stavrakos <astavrakos@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#779543}
-
Alex Gough authored
PrivateExtractIcon (underlying the icon loading service) may fail to supply an icon for PE files that do not have one embedded and would display as a blank area when downloaded. This change fetches the default for the file extension prior to fetching the file's embedded icon. It is difficult to do this only on failure as the ownership of IconLoader means it has already been deleted when we learn about the failure. It should be relatively cheap to fetch the default icons as these will be cached by the OS, and this occurs in the main process. Tests: Added LoadDefaultIcon in icon_loader_browser_test Bug: 1032250 Change-Id: Ifad1c9f013d0e4fe87aaec5ec0cdeae08d06799e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242371 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#779542}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/ea4aec9cfcd7..1cdd473e5bca 2020-06-17 rwkeane@google.com Add Operators to ErrorOr If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ib50ce96ce6fa151ffc48a01ef8d4ee7380c42c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250359Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779541}
-
James Cook authored
Based on UI review comments this one has: * Title "You're signed in" * Subtitle "The following services help..." * Buttons "No thanks" and "Got it" See bug for screenshot. Bug: 1074436 Test: updated browser_tests Change-Id: Ifa214522511fadaed7bdf166b2a865632422de7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247327Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#779540}
-
Kyle Horimoto authored
This reverts commit 7ce70f8a. Reason for revert: Breaks Chrome uprev (https://crbug.com/1093405) Bug: 1045266, 1093405 TBR: dpapad@chromium.org TBR: rbpotter@chromium.org Change-Id: I96c8c8f95aa3f3b06b36373790b30b919c59e9da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249595 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Meilin Wang authored
Removed the |UpdateDisplay()| call during test set up, since the effected test cases have been disabled due to flakiness. Bug: b/158617675 Test: manully. Change-Id: I4ff9ec8fd0474bbb85d19e658d5a3aa44e6f435f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250700Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#779538}
-
Chong Gu authored
Currently, stderr of AEMU is overwritten by the Fuchsia system logs when running test packages. Redirect stderr to system stderr to avoid this. Bug: 1095199 Change-Id: Ie4dc997093b94f2db4588ea6ba9e78ad000d427c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246993 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779537}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/70c2cfd61548..ceb64a4f57d1 2020-06-17 eliribble@chromium.org Improve Python-3 compatibility of download_from_google_storage.py 2020-06-17 wnwen@chromium.org Support formatting python3 scripts (reland) 2020-06-17 weiweilin@google.com [lucicfg] Update v1.15.1 -> v1.15.2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1062053,chromium:1066815,chromium:1095581 Tbr: agable@chromium.org Change-Id: I05818a5691cf3f031ac25deb72de6cd05677c491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250481 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Eugene But authored
Logs presentation of HttpAuth dialog, all JS dialogs, App Launching dialog and generic alerts. Also refactor breadcrumb_manager_browser_agent_unittest.mm to have less repetitive code, since this CL adds a lot of new tests. TBR: michaeldo@chromium.org Bug: 1082915 Change-Id: I5727e65717c57cd48bac03922342f6b8eee9b286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240394 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#779535}
-
Charlene Yan authored
Clicking on a tab deselects any other selections, same should happen for the tab group header. This also prevents scenarios where the collapsed group has a selected tab. Bug: 1018230, 1095779 Change-Id: I250323c4e5b2e7d766096140e7fe5284d8c7b2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250878 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#779534}
-
zhaoyangli authored
The EG2 test bundle name has a "-Runner" suffix appended to EG2 test target name. This change adds it to the bundle name check in chrome_test_case.mm for flaky and multitasking suites. Bug: 1093411, 1093981 Change-Id: I78b72f74109c945641ab23c35f09a2506df62a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250550Reviewed-by:
-
Victor Costan authored
The //storage/browser/blob/mojom directory was created to hold mojo interfaces decoupling the Blob subsystem from storage features using it, such as Cache Storage and IndexedDB. This location was chosen because the mojo interfaces conceptually belong in the Storage Service, but at the time the Storage Service did not exist in the source tree. Now that the Storage Service skeleton has been created at //components/services/storage, this CL moves the mojo interfaces there. This CL also adds a final relationship solidifying the dependency graph between the various directories holding storage code. The dependency hierarch, from the lowest to the highest level, is: 1) //components/services/storage 2) //storage/browser/ 3) //content/browser/ Mechanical replacements: * storage/browser/blob/mojom/blob_storage_context.mojom -> components/services/storage/public/mojom/blob_storage_context.mojom * //storage/browser:mojom -> //components/services/storage/public/mojom Bug: 1016063 Change-Id: I456d1f4a7f363d5b0bad73333acd6101860221d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247399Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#779532}
-
Abhijeet Singh authored
The current https go-link is not getting redirected properly. As suggested in go/faq#keep-the-presentation-clean1 as a best practice, the go link should be prefixed by either http or a complete goto URL for the https version. Bug: b:159237992 Test: Tested on Chrome OS VM and Atlas test device. Change-Id: Icb1e60a1dc057b6f5b64f064ac485303ea09edf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250823Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Cr-Commit-Position: refs/heads/master@{#779531}
-
Rune Lillesveen authored
If we cache a ComputedStyle which is computed outside of the flat tree, any pending resources will stay StylePendingImage. That means we cannot use such a ComputedStyle for cached styles for a rendered element. We already did this check for display:none subtree ComputedStyles, but we need the same check for IsEnsuredOutsideFlatTree(). Bug: 1095669 Change-Id: Ide7395207a6d73b78bc793e4ee4c10cf31b9696f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250201Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#779530}
-
Nodir Turakulov authored
R=gbeaty@chromium.org Context: https://chromium-review.googlesource.com/c/chromium/src/+/2248674 Change-Id: I9a11214815aeda0ece8a8c0a2877ee0822852ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249298 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
-
Christoph Schwering authored
This CL makes FormStructure::Encode{Query,Upload}Request() memorise the form and field signatures, including their order, and AutofillDownloadManager assign the field type predictions from the server response to *all* fields of the queried signatures. Before this CL, AutofillDownloadManager relied on (a) forms not changing during communication with the Autofill server, and (b) no FormStructures of a page having identical form signatures. The latter led to only the first of perhaps multiple FormStructures with identical signatures receiving server field type predictions. The bug became apparent only since revision 1bd72869 changed AutofillHandler's FormStructure cache to index by renderer ID instead of form signature, so that distinct forms with identical signatures can be represented by distinct FormStructures. Bug: 1064709 Change-Id: I8e3355c0f3ec9dde4b53cb766ba37b29b2c04397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244252Reviewed-by:Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#779528}
-
Yi Xu authored
canvas/offscreen/the-offscreen-canvas/offscreencanvas.resize.html is renamed to canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.resize.html Bug: 1093709 Change-Id: Ib775d1fec3d18a44ca0927a1c6828cbc594cf810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250779Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#779527}
-
Jose Dapena Paz authored
It breaks compilation of blink::WebServiceRegistrationObjectInfo that includes WebServiceWorkerObjectInfo instance. This one uses default move constructor without noexcept declaration, but has as members CrossVariantMojoAssociatedReceive and CrossVariantMojoAssociatedRemote with noexcept declaration in move constructor. declared noexcept. As resolved in other places, noexcept is not really much useful with -fno-exception and our codebase is not prepare to add it consistently. Clang will not report exception declaration incompatibilities in case -fno-exception is used, but GCC fails. Bug: 819294 Change-Id: Id5c46c271a8a92352d769de9c3c263d3dce4c9c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247791 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#779526}
-
Collin Baker authored
A Profile can be deleted without a preceding OnSessionEnded call. See https://chromium-review.googlesource.com/c/chromium/src/+/2238363/1 and https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8877847700690046144/+/steps/browser_tests__with_patch__on_Windows-10-15063/0/logs/Deterministic_failure:_TouchLocationBarViewBrowserTest.OmniboxViewViewsSize__status_CRASH_/0 for an example of this in action. This CL has ProfileActivityMetricsRecorder observe the currently active Profile to handle its deletion gracefully. Bug: 1094407 Change-Id: Ifaec71ad97671ab74f377ba44695c2e8b34153a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242435 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#779525}
-
Victor Costan authored
The test has a few sync wrappers for QuotaClient's async methods. The wrappers store the async method results as test fixture members. This scope is unnecessarily large, which is an unnecessary mental burden on folks who need to understand the test. This CL stores each async method result as a local variable in the method's sync wrapper and removes the member variables. Change-Id: Ie85aa31688643b4de163a8b0a415b3aec2e54241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247216 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#779524}
-
Noah Rose Ledesma authored
The |accessible_name| passed to MediaNotificationViewImpl::CreateMediaButton is now used as the tooltip text. Bug: 1047294 Change-Id: Ie60dff78aed15159d83ac1d5aa5192d2cf539207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250881 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#779523}
-
Steven Bennetts authored
This includes the following chrome://network cleanup: * Updates network_ui.js to use cr.define. * Replaces local types OncMojo types. * Cleans up html import order. * Eliminates a duplicate string in network_ui.cc. BUG=921726 Change-Id: Ibeb15047b4b0fd7fdfe2ab7fc05ba65dea2b9560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242532 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#779522}
-
Chase Phillips authored
Our metrics showed high error rates for shortcut creation on Mac. While using the file handling feature (FileHandlingAPI), I found that multiple CopyDirectory() calls could sometimes happen at once which could trigger errors. When the CopyDirectory() calls overlapped, one thread would be deleting files while another thread creates them, and this would lead to one CopyDirectory() call failing with an error. This change adds a lock that UpdateShortcuts() acquires before proceeding to ensure that its later CreateShortcutsAt() call is protected against other threads. Bug: 1090548 Change-Id: I6cb439975e3dd51608420a3f2e14de351b88d0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250590 Auto-Submit: Chase Phillips <cmp@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#779521}
-
Chris Harrelson authored
This use counter helps us in two ways: * Find content that uses backface-visibility in certain 3d ways. * Find out how often 3D + backface-visibility happens, to see if it would be web compatible to change semantics of backface-visibility in this situation. Bug: 1008483 Change-Id: Ib83d0167943d52eeedeece27fd21e5a28a5698ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250083 Auto-Submit: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#779520}
-
Becca Hughes authored
This is a reland of b17b2a5b TBR=tsepez@chromium.org Original change's description: > [Media Feeds] Add safe search check at feed level > > We already check the feed items against Safe Search > but we should also check the feed itself so we > can avoid fetching the feed if it is unsafe. > > BUG=1085095 > > Change-Id: I8546c372e6915512c7bb5ddde8ce379cb8cd14c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220275 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778395} Bug: 1085095 Change-Id: Ic3d4668de5c5ca91b29af9d588339c0578fc86ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250087 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592405921-ea7a225ddfaf855aec0c62a2999f900e2d639591.profdata to chrome-win64-master-1592423969-e9cdc767cf2ee2d28a487cba4bbc17ede63357fc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I8121dd0cfd01109b50083ce43d9486f49340f0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250800Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1443609db494..590e8db5d863 2020-06-17 djsollen@google.com Revert "Replace analytic clip stack with chained fragment processors." 2020-06-17 bsalomon@google.com GrCircleBlurFragmentProcessor uses GrTextureEffect for profile texture 2020-06-17 bungeman@google.com Update debugger to new fontmgr selection. 2020-06-17 johnstiles@google.com Replace analytic clip stack with chained fragment processors. 2020-06-17 johnstiles@google.com Update GrRRectEffect to take an input FP and return a MakeResult. 2020-06-17 elliotevans@google.com Add a future_apis folder to canvaskit. future_apis contains notes on 2020-06-17 bsalomon@google.com Make GrGLPerlinNoise::emitCode easier to read. 2020-06-17 jmbetancourt@google.com Convert Skottie build instructions to build an Android Library (AAR) instead of app (APK) 2020-06-17 johnstiles@google.com Support MakeResult in GrOvalEffect. 2020-06-17 johnstiles@google.com Remove HairlineAA from the clip-edge types. 2020-06-17 djsollen@google.com Reland "Update zlib DEPS" 2020-06-17 herb@google.com use joinPossibleEmptyRect for bounding box 2020-06-17 egdaniel@google.com Fix D3D InstanceDataStepRate. 2020-06-17 johnstiles@google.com Revert "roll GN" 2020-06-17 brianosman@google.com Disable program binary caching on AMD + ANGLE D3D9 2020-06-17 egdaniel@google.com Implement set scissor on d3d render pass. 2020-06-17 jlavrova@google.com Cleaning codepoints/grapheme mess; it also helps with ICU API 2020-06-17 fmalita@chromium.org Fix SkParse::FindNamedColor OOB If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1095625 Tbr: djsollen@google.com Change-Id: I8bd22675ba8deb0d39514033cfba1dbafe1818fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250354Reviewed-by:
-
Henrique Ferreiro authored
This code was introduced to support a thread-local CursorFactoryOzone. Now that the factory is a global singleton, it can be removed. This CL also modernizes the code. Bug: 1029142 Change-Id: I2292ccf1d0179f8bf8c3f24507f2e013299b1cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247892 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e2fbb30f588e..e2091446b577 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mmentovai@google.com,alexmos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1005891,chromium:1058147,chromium:1059455,chromium:1085525,chromium:1093380,chromium:1095098 Tbr: mmentovai@google.com,alexmos@google.com Change-Id: I34dea78d1182eeb14321c5b611a6e65c3a0f3ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250484Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779515}
-
David Van Cleve authored
A variable was incorrectly named: the test extracts a timestamp into a variable currently called "retrieved_url_spec". This change fixes this by renaming the variable. TBR=csharrison Change-Id: Iee866ddcc9efce6e85e81e90791f461b96ac7e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250941Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#779514}
-
Dmitry Torokhov authored
Instead of showing empty list when there are no shared folders, let's show dedicated message. Bug: chromium:1094923 Change-Id: I10a886ba4ce48529a07a2f03e7e7f72f78db4527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247160Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592405921-bce006983aa98b323332c89a671c929444d0e708.profdata to chrome-win32-master-1592420122-44e320f5cb874678ca6b77bfdebbccbe803d44fc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iee6a4f6f2030fbf68e8d8cab6b97d5fd0945efbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250798Reviewed-by:
-
Emma Haruka Iwao authored
The gn args command failed to run with Python 3 on Mac because it uses incompatible syntax. Python 2 is no longer maintained and it is recommended we migrate to Python 3. - Use text mode when invoking child processes - Use print() with parenthesis. Bug: 1068191 Change-Id: I2b039d3638447f1b5e50b89c145a06aeeef8359c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238988Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Emma Haruka Iwao <yuryu@chromium.org> Cr-Commit-Position: refs/heads/master@{#779511}
-
Yi Xu authored
offscreencanvas.resize.html is flaky on Mac, Linux and Windows. It was only marked flaky for Mac and Linux. Add Windows to the list. Bug: 1093291 Change-Id: I95c06f2a4c8424a8f7c038473f7975cb4e21b0fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249341Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#779510}
-
Robert Ogden authored
Neither AppCache Manifests or link-rel-search plugins should be fetched during a NoStatePrefetch, but this CL adds tests to check for that in the context of an Isolated Prerender. Bug: 1096109 Change-Id: I852de24f9bd90e575339eb5d8e04e5acf6dd3d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247406Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#779509}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4d5abe756b88..9885512110a7 2020-06-17 fmayer@google.com Bookkeeping for multiple heap spaces. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:141241849 Tbr: perfetto-bugs@google.com Change-Id: I938d2d44df0b8ad6939f4386020ee29ac87c3e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250120Reviewed-by:
-
Antonio Gomes authored
... instead WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules BUG=704136 R=guidou@chromium.org Change-Id: I37023bcd6f1b5fa5f25a475e6a2b19671e8285e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247059 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#779507}
-
Lucas Furukawa Gadani authored
Since portals are pagwa that can be activated, we need to propagate the device emulation to each portals main frame. Bug: 1032625 Change-Id: I90d55c569f580cf42d7a7eb185270192efa11dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237767Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#779506}
-
