GitLab

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/345593003

git-svn-id: svn://svn.chromium.org/blink/trunk@176524 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds async stacks support for the following DOM events:
- audio & video events (play, pause, ratechange, etc.)
- TrackList events: addtrack, removetrack
- MediaSource events (sourceopen and etc.)
- autocomplete and others

BUG=272416
R=yurys, pfeldman@chromium.org

Review URL: https://codereview.chromium.org/335963004

git-svn-id: svn://svn.chromium.org/blink/trunk@176523 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There is no need to do "(m_direction == LTR) ? LTR : RTL".

While here, remove extra parameters from applyFontTransforms.

Review URL: https://codereview.chromium.org/330063005

git-svn-id: svn://svn.chromium.org/blink/trunk@176522 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously this was included in many other source files.
For me, this reduces the number of affected build targets from 889 to 93.

Review URL: https://codereview.chromium.org/344873002

git-svn-id: svn://svn.chromium.org/blink/trunk@176521 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This function should have walked up the containing blocks rather than
the parents. This cl fixes that and removes the useless
ancestorCompositedScrollingLayer.

Note: the layout test here was taken from abarth's patch
https://codereview.chromium.org/340913002/

BUG=None

Review URL: https://codereview.chromium.org/344733003

git-svn-id: svn://svn.chromium.org/blink/trunk@176520 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The spec says that bufferedAmount must not decrease in the task that
send() is called.
Fixed both the new and the old implementation although the old implementaion
is at any rate broken (bufferedAmount in the old implementation includes
the protocol overhead).

BUG=159563

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176298

Review URL: https://codereview.chromium.org/311993006

git-svn-id: svn://svn.chromium.org/blink/trunk@176519 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The ScriptPromiseResolverWithContext destructor is checking if it is misused,
but the current code calls ref() and deref(), which are  invalid in the destructor.
This CL replaces the implementation with a simple assertion.

BUG=386479

Review URL: https://codereview.chromium.org/344733004

git-svn-id: svn://svn.chromium.org/blink/trunk@176518 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Replace the include with forward declarations.

Prior to this patch, KeyframeEffectModel.h had roughly 700 targets
depending on it. After this patch this number has shrunk to around 11.
In the last 90 days, KeyframeEffectModel.h was modified 13 times on
trunk, which is a relatively high number.

KeyframeEffectModel.h also pulls in a large amount of other animation
headers so they should see similar benefits.

Review URL: https://codereview.chromium.org/346803002

git-svn-id: svn://svn.chromium.org/blink/trunk@176517 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/342163002

git-svn-id: svn://svn.chromium.org/blink/trunk@176515 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vsevik@chromium.org

Review URL: https://codereview.chromium.org/345713004

git-svn-id: svn://svn.chromium.org/blink/trunk@176514 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=383435
TBR=reed@google.com

Review URL: https://codereview.chromium.org/348563002

git-svn-id: svn://svn.chromium.org/blink/trunk@176513 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/335103003

git-svn-id: svn://svn.chromium.org/blink/trunk@176512 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376039
R=haraken@chromium.org, sigbjornf@opera.com, tyoshino@chromium.org

Review URL: https://codereview.chromium.org/342103003

git-svn-id: svn://svn.chromium.org/blink/trunk@176511 bbb929c8-8fbe-4397-9dbb-9b2b20218538

So we don't need to include WebLockOrientationCallback in places where
we should only include enums.

BUG=162827
NOTRY=true

Review URL: https://codereview.chromium.org/332493003

git-svn-id: svn://svn.chromium.org/blink/trunk@176510 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This will be used to set offset/scale from DevTools protocol
instead of caluculating them in embedder.

NOTRY=true

Review URL: https://codereview.chromium.org/342953003

git-svn-id: svn://svn.chromium.org/blink/trunk@176509 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/338283004

git-svn-id: svn://svn.chromium.org/blink/trunk@176508 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of [DevTools] Add offset and scale to WebDeviceEmulationParams. (https://codereview.chromium.org/342953003/)

Reason for revert:
Broke compile.

Original issue's description:
> [DevTools] Add offset and scale to WebDeviceEmulationParams.
> 
> This will be used to set offset/scale from DevTools protocol
> instead of caluculating them in embedder.
> 
> BUG=327641
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176506

TBR=pfeldman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=327641

Review URL: https://codereview.chromium.org/342963002

git-svn-id: svn://svn.chromium.org/blink/trunk@176507 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This will be used to set offset/scale from DevTools protocol
instead of caluculating them in embedder.

BUG=327641
NOTRY=true

Review URL: https://codereview.chromium.org/342953003

git-svn-id: svn://svn.chromium.org/blink/trunk@176506 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/333143003

git-svn-id: svn://svn.chromium.org/blink/trunk@176505 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WARNING: should be landed after corresponding chromium patch.

BUG=245436

Review URL: https://codereview.chromium.org/342433002

git-svn-id: svn://svn.chromium.org/blink/trunk@176504 bbb929c8-8fbe-4397-9dbb-9b2b20218538

title is a presentation entity and shouldn't be exposed on model record. TimelineUIUtils should be used to retrieve it.

BUG=361045
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/336183005

git-svn-id: svn://svn.chromium.org/blink/trunk@176503 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When the ExecutionContext is destroyed, the outstanding request is marked as cancelled.

The corresponding chromium side of this change is https://codereview.chromium.org/341923004/

BUG=375430

Review URL: https://codereview.chromium.org/343723003

git-svn-id: svn://svn.chromium.org/blink/trunk@176502 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Clicking on a disabled form control element like a button should not
make it active. This patch adds a check for the disabled element before
setting the activation. This is as per the spec 
http://www.whatwg.org/specs/web-apps/current-work/multipage/selectors.html#selector-active
This matches the behavior on IE. Firefox behavior is same as Chrome.

BUG=385601
TEST=fast/css/disabled-form-control-elements-should-not-be-active.html

Review URL: https://codereview.chromium.org/340143002

git-svn-id: svn://svn.chromium.org/blink/trunk@176501 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is needed for removing --enable-service-worker
(https://codereview.chromium.org/339973003/).  Chromium-side currently
returns ErrorTypeDisabled for both "SW is disabled" and "SWContextCore
was destroyed during shutdown" when handling a registration request.
Since the former will no longer happen, add a generic operation aborted
error for the latter.

BUG=365201

Review URL: https://codereview.chromium.org/342863003

git-svn-id: svn://svn.chromium.org/blink/trunk@176500 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The 'fePointLight' and 'feSpotLight' light-source elements for
'fe{Diffuse,Specular}Lighting' defines positions, and in the case of
the latter a 'look-at' point (implicit direction). When an SVG filter is
declared to use primitiveUnits=objectBoundingBox, these positions/points
needs to be mapped to the user-space of the filter.
This is achieved by adding a new method resolve3dPoint() to Filter, and
perform the coordinate space mapping when creating the various
LightSources.
Open-code SVGFELightElement::findLightSource() in it's sources to avoid
passing the Filter-instance around more than necessary.

BUG=176419

Review URL: https://codereview.chromium.org/337903003

git-svn-id: svn://svn.chromium.org/blink/trunk@176499 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is preparation for removing the --enable-service-worker flag and
removing the virtual/serviceworker test suite.

BUG=365201

Review URL: https://codereview.chromium.org/338853006

git-svn-id: svn://svn.chromium.org/blink/trunk@176498 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |lastEditablePositionBeforePositionInRoot()| to get
to editable |Position| instead of |VisiblePosition| for making
DeletetSelectionCommand to work editable position regardless its visibility.

The root cause of issue 339187 is |DeleteSelectionCommand| shrinks end point of 
selection range, start position is start of "bar", which is hidden editable, 
and end position is "foo", which isn't editable, to editable position but 
|DeleteSelectionCommand| checks both editability and visibility, then it gets 
null position since end point is hidden. 


BUG=339187
TEST=LayoutTests/editing/execCommand/delete-hidden-crash.html

Review URL: https://codereview.chromium.org/340713003

git-svn-id: svn://svn.chromium.org/blink/trunk@176497 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/333073005

git-svn-id: svn://svn.chromium.org/blink/trunk@176496 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Drive-by: removed formatter for counters field which is not in the protocol anymore.

BUG=361045
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/343613004

git-svn-id: svn://svn.chromium.org/blink/trunk@176495 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Required for instantiating the fallback fonts from the sandbox since
this instantiation is not allowed by filename, but only through
Skia's SkFontConfigInterface, where paths are previously kept track
of in the Linux sandbox support process.
Preparation for a Chromium side change which fills fciId.

BUG=285303
R=abarth,eae

Review URL: https://codereview.chromium.org/340073002

git-svn-id: svn://svn.chromium.org/blink/trunk@176494 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/339493006

git-svn-id: svn://svn.chromium.org/blink/trunk@176493 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Border-image and its friend mask-box-image are shorthands that
expand out into 4 css properties[1]. When setting the initial values
for these we would blindly create a new NinePieceBorderImage which
is large and contains non-trivial destructors. This patch first
checks whether the current value is already equal to the initial value
before setting.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/border-image

Review URL: https://codereview.chromium.org/340703004

git-svn-id: svn://svn.chromium.org/blink/trunk@176492 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch renames abbreviated name "p" to "editablePosition" in {first,last}EditableVisiblePosition{After,Before}PositionInRoot for improving readability and ease of maintenance.

This patch is a preparation of introducing |lastEditablePositionBeforePositionInRoot.

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/342553008

git-svn-id: svn://svn.chromium.org/blink/trunk@176491 bbb929c8-8fbe-4397-9dbb-9b2b20218538

HarfBuzzRunCache is a global cache with entries holding |Font| which indirectly hold strong ref to |SVGFontFace|.
In future, the leak detector should clear the cache before counting number of |Document|s.

These "leaks" disappear if following line is commented out:
WebKit/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp
861         runCache.insert(key, new CachedShapingResults(harfBuzzBuffer.get(), m_font, props.direction, localeString));

BUG=366455
TBR=haraken
NOTRY=true

Review URL: https://codereview.chromium.org/342153002

git-svn-id: svn://svn.chromium.org/blink/trunk@176490 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The spec mandates that transition-property (and thus the transition
shorthand) are able to support arbitrary unknown properties, for
backwards and forwards compatibility. This patch adds support for such
unknown properties.

Note that this makes the shorthand strings like "ease" or "ease ease-in"
ambiguous. In this patch we take the first case to refer to a timing
function, and in the second case the first token as a timing function
and the second token as the property name.

This change progresses the w3c transitions test transition-property-002,
although the first two cases of the test are incorrect.

BUG=304020,375098

Review URL: https://codereview.chromium.org/298043007

git-svn-id: svn://svn.chromium.org/blink/trunk@176489 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://codereview.chromium.org/200923002/diff/380001/Source/core/loader/ImageLoader.cpp
moved a document.isActive() check elsewhere, leading to us doing more work
for non-active documents. This caused a big perf regression for the bloat test.

This patch restores that check to fix the regression.

BUG=372971
R=japhet@chromium.org
CC=yoav@yoav.ws

Review URL: https://codereview.chromium.org/343513003

git-svn-id: svn://svn.chromium.org/blink/trunk@176488 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The WebThreadedDataReceiver will now check if the parserthread is still alive before returning it to the ThreadedDataProvider

This fixes a crash when a renderer is shut down while a request is still alive, due to the ResourceDispatcher being shut down after Blink is.

R=abarth
BUG=386383

Review URL: https://codereview.chromium.org/345663002

git-svn-id: svn://svn.chromium.org/blink/trunk@176487 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There's no reason this would ever be called on remote frames.

BUG=386340

Review URL: https://codereview.chromium.org/340213002

git-svn-id: svn://svn.chromium.org/blink/trunk@176486 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes a style recalc that occurred every time
element.animate() was being called regardless of the input.
This is no longer needed now that we are able to defer keyframe
resolution the style recalc using DeferredLegacyStyleInterpolation.

Review URL: https://codereview.chromium.org/343563002

git-svn-id: svn://svn.chromium.org/blink/trunk@176485 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Unnecessary delay is removed

Use js-test.js instead of manual logging, asserts

BUG=27569

Review URL: https://codereview.chromium.org/344533006

git-svn-id: svn://svn.chromium.org/blink/trunk@176484 bbb929c8-8fbe-4397-9dbb-9b2b20218538