GitLab

1) Emphasize the default wallpaper selection order in
   DoSetDefaultWallpaper (renamed to SetDefaultWallpaperImpl).
   Create two additional member variables to store the customized
   default wallpaper file paths to make the distinction with a regular
   default wallpaper (ie. from the command line). Previously, these
   two are mixed in the code.

2) Rename |SetDefaultWallpaperPath| to
   |SetCustomizedDefaultWallpaperImpl|.

3) |SetDefaultWallpaperPathsFromCommandLine| is removed. We don't have
   the need to cache the values which come from the command line.

TBR=oshima@chromium.org, ochang@chromium.org

Test: Manual (device/Linux build), ash_unittests, browser tests
Bug: 792233
Change-Id: I09876e23ea7609c7b7e876d4daf79c4fa35088c5
Reviewed-on: https://chromium-review.googlesource.com/808092Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523324}

This change supports testing of Chrome on bots where we don't want to
install or use real OpenVR/SteamVR, in order to catch regressions in
Chrome.

This change also fixes a few issues found in preliminary tests.

BUG=780668

Change-Id: I885762e18b48961038454856743f9e7ae621001e
Reviewed-on: https://chromium-review.googlesource.com/795056
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523323}

This CL enables composited border radius scrolling.

Bug: 567296
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4753d7c557ea20d716d1a717d8ef867c996830f5
Reviewed-on: https://chromium-review.googlesource.com/760997
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523322}

This CL only covers //components.  Will migrate the other uses in sibling CLs.

R=blundell@chromium.org

Bug: 773850
Change-Id: Ia57dc5c75b5d2ab57436be3264b20c9d2b9b4342
Reviewed-on: https://chromium-review.googlesource.com/818726
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523321}

Bug: 793332

Test: $('speech-container').hidden is false; Search+/; $('speech-container').hidden is true; escape or enter; $('speech-container').hidden is false and $('search-container').hidden is true

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If8a0241140086c4089dc495fd83f8f54db4333a5
Reviewed-on: https://chromium-review.googlesource.com/820044Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523320}

Bug: 793772
Change-Id: Ia9175cf484ba3d26c24d89a4bfcb42b1328b894b
Reviewed-on: https://chromium-review.googlesource.com/818373Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523319}

Removes some casts where they become unnecessary.

New inline variants of NumberToString are provided for long long
which is necessary for some platforms to automatically convert.

process_util_unittest.cc is added to the base namespace and base:: qualifiers
are removed from that file.

All int->string conversions in ipc_message_utils.cc are converted to use
the new style.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I523c879b6e276025dd00414c283022267b3963f9
Reviewed-on: https://chromium-review.googlesource.com/813101
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523318}

This is a behavior change. Call shouldInterceptRequest for
LoadDataWithBaseURL calls. The other two loadData calls both trigger
shouldInterceptRequest. Remove the hack that checks for
loadDataWithBaseURL, which then starts triggering
shouldInterceptRequests as well.

Bug: 769126
Change-Id: Ia6994186bab8cb4647297d49bab6e662b47164af
Reviewed-on: https://chromium-review.googlesource.com/820717Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523317}

This CL ensures that the current DSE matches what is stored in the DSE
settings pref. These things could possibly go out of sync if (for
example) Chrome crashed between changing DSE and writing the DSE pref.
If they are out of sync, we simulate an OnDSEChanged event such that the
content settings for the old/new DSEs will be properly transitioned.

Bug: 799534
Change-Id: I1f9edb44d77c6ddf8204adadda2ed99f496aa78e
Reviewed-on: https://chromium-review.googlesource.com/813435
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523316}

This migrates the remaining elements tests.

Drive-by: fixes the test-summary script to identify non-html tests (there's
a small % of these throughout DevTools's test suite).

Bug: 667560
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib9b7bb4d341d71d6196667167d962f18e5a76c93
Reviewed-on: https://chromium-review.googlesource.com/820936Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Will Chen <chenwilliam@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523315}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6c68f62d..9771aa49

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I3bbd0057014e450fdfc2573a14f10919a5767ec0
Reviewed-on: https://chromium-review.googlesource.com/821253Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523314}

Stumbled upon what seems to be a typo here. Since the file referenced in
the typo'd line is included again later, we can safely remove the line.

BUG=None
TEST=None

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If30006512aaf4b19a7d27484b6e8e3ad0553208d
Reviewed-on: https://chromium-review.googlesource.com/817457Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523313}

Sort properties which is from iterator of StylePropertyMapReadOnly
According to spec,
* normal properties are sorted alphabetically.
* custom properties are sorted by increasing code point order.
* custom properties are sorted after normal properties.

present, normal properties has always lower case.
so to sort alphabetical is same effect with sorting code point

https://drafts.css-houdini.org/css-typed-om-1/#dom-stylepropertymap-getproperties

Bug: 779841
Change-Id: I7532cf2e322073705db2c124fa12116fc38f2345
Reviewed-on: https://chromium-review.googlesource.com/808746Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#523312}

Implement GPUArcVDA working with new VDA-like IPC. GpuArcVDA currently
translates mojo IPC to VDA API, and therefore ChromeArcVDA is deleted.
ChromeArcVDA and GpuArcVDA based on old IPC still exist as deprecated classes
for compatibility, so that the old IPC can be used.

TEST=CTS MediaTest on veyron_minnie and eve
TEST=CTS MediaTest with --mus=viz on veyron_minnie and eve
TEST=Secure Playback test using ExoPlayer
BUG=chromium:745457
CQ-DEPEND=CL:609564

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I9d90a6945c81e20572616c04c1d4f496e2bb3f87
Reviewed-on: https://chromium-review.googlesource.com/648538
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523311}

Bug: 554927
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id61ca6746d9ecacbb6e3787f7afa7f662e89d1fd
Reviewed-on: https://chromium-review.googlesource.com/816020
Commit-Queue: Eugene But <eugenebut@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523310}

Always first try reading/writing immediately to reduce the latency.

Bug: 734672
Change-Id: I8cbeacf5ac643a68916739e894516d0e863fc0cd
Reviewed-on: https://chromium-review.googlesource.com/820594Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523309}

Deprecate current ArcVideoDecodeAccelerator IPC and GpuArcVDA

This CL is the first phase of the migration to a new IPC for ARC
VideoDecodeAccelerator.

To maintain backwards-compatibility during the transition period,
the existing VideoDecodeAccelerator mojo interface is renamed to
VideoDecodeAcceleratorDeprecated,
and its implementation, GpuArcVideoDecodeAccelerator,
to GpuArcVideoDecodeAcceleratorDeprecated.

TEST=CTS MediaTest on veyron_minnie and eve
TEST=CTS MediaTest with --mus on veyron_minnie and eve
TEST=Secure Playback test using ExoPlayer
BUG=chromium:745457

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I591626d651d1b7bed0a03f55fdc64dae93d196c9
Reviewed-on: https://chromium-review.googlesource.com/609564
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Owen Lin <owenlin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523308}

base/memory/ptr_util.h includes are changed with <memory> as well.

Bug: 755727
Change-Id: I640ea7df0e4249400515c8257397ecfd237bea51
Reviewed-on: https://chromium-review.googlesource.com/818674
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523307}

We have a special value kOldLayoutRoot in NGPhysicalFragment::NGBoxType, which
indicates that the box fragment is the root of new layout. However, this
overwrites the actual box type of the fragment. For example, when we have a
box that's both an inline block and an old layout root, we lose the inline
block box type information when checking NGPhysicalFragment::BoxType().

This patch moves the old layout root information out from NGBoxType as a
separate bit flag in NGPhysicalFragment (and also NGFragmentBuilder), so that
we can get rid of the issue.

Bug: 
Change-Id: Icb98481ccafa6cb3226a01c6dab85c17dac22d96
Reviewed-on: https://chromium-review.googlesource.com/818630
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523306}

Example error set:
    (see http://errorprone.info/bugpattern/MissingOverride)
  Did you mean '@Override public AndroidOverlayProvider[] buildArray(int size) {'?
/tmp/tmpXyQKec/java/org/chromium/media/mojom/AudioDecoder_Internal.java:22: warning: [MissingOverride] getName implements method in Manager; expected @Override
        public String getName() {
                      ^
    (see http://errorprone.info/bugpattern/MissingOverride)
  Did you mean '@Override public String getName() {'?
/tmp/tmpXyQKec/java/org/chromium/media/mojom/AudioDecoder_Internal.java:26: warning: [MissingOverride] getVersion implements method in Manager; expected @Override
        public int getVersion() {
                   ^
    (see http://errorprone.info/bugpattern/MissingOverride)
  Did you mean '@Override public int getVersion() {'?
/tmp/tmpXyQKec/java/org/chromium/media/mojom/AudioDecoder_Internal.java:30: warning: [MissingOverride] buildProxy implements method in Manager; expected @Override
        public Proxy buildProxy(org.chromium.mojo.system.Core core,
                     ^
    (see http://errorprone.info/bugpattern/MissingOverride)
  Did you mean '@Override public Proxy buildProxy(org.chromium.mojo.system.Core core,'?
/tmp/tmpXyQKec/java/org/chromium/media/mojom/AudioDecoder_Internal.java:35: warning: [MissingOverride] buildStub implements method in Manager; expected @Override
        public Stub buildStub(org.chromium.mojo.system.Core core, AudioDecoder impl) {
                    ^
    (see http://errorprone.info/bugpattern/MissingOverride)
  Did you mean '@Override public Stub buildStub(org.chromium.mojo.system.Core core, AudioDecoder impl) {'?
/tmp/tmpXyQKec/java/org/chromium/media/mojom/AudioDecoder_Internal.java:39: warning: [MissingOverride] buildArray implements method in Manager; expected @Override
        public AudioDecoder[] buildArray(int size) {

BUG=

Change-Id: Ifab68faf81b4dbcf485cc8f624a7c857edf6c9fa
Reviewed-on: https://chromium-review.googlesource.com/820093Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523305}

Rather than calling the OS cert verifier or attempting
to verify Certificate Transparency information in
unit tests, just use the fakes intended for unittests.

BUG=none

Change-Id: I997957745edf941e985d1f5e2630d3cd24d475e0
Reviewed-on: https://chromium-review.googlesource.com/820335Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523304}

This patch disables title wrapping for search results so that it
doesn't overlay with other results.

BUG=764328
TBR=dgozman

Change-Id: I1023d2888524a94b5bd0132ce5b2399dcc4403d6
Reviewed-on: https://chromium-review.googlesource.com/820617Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523303}

This mirrors
https://chromium-review.googlesource.com/c/crashpad/crashpad/+/807645 in
Crashpad.

Bug: 598854
Change-Id: I1b98dab78df7a30d913be3a476c8b373063e6065
Reviewed-on: https://chromium-review.googlesource.com/820160Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523302}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/7cc5681dafff..49edad6de211

$ git log 7cc5681da..49edad6de --date=short --no-merges --format='%ad %ae %s'
2017-12-11 xixuan cbuildbot: enable fast=True for CQ jobs.
2017-12-07 stevenjb cros chrome-sdk: Make gn-gen the default
2017-12-07 harpreet cbuildbot: add more devices to wificell-pre-cq
2017-12-11 chrome-bot Update config settings by config-updater.
2017-12-06 yunlian chrome_sdk: Disable thinlto on SimpleChrome
2017-11-28 achuith [cros_run_vm_test]: Support for autotest.
2017-10-18 achuith [cros_vm]: Options to run unittests on cros VM.
2017-12-08 chrome-bot Update config settings by config-updater.
2017-12-08 dgarrett scheduler_stages: Fix release waterfall builder names.

Created with:
  roll-dep src/third_party/chromite chromiumos/chromite.git

Bug: 762650
Change-Id: Iead7faad5088249bd388b6dd80593d6a3ab4c024
Reviewed-on: https://chromium-review.googlesource.com/820597
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523301}

The spectrum dragger circle already has cursor: pointer style, but the
user can see flickering between two cursors because the container still
has default pointer.

This CL ensures that the container has cursor: pointer while dragging,
and default pointer when hovering without dragging.

Bug: 769234
Change-Id: I68fb7cbe5fdc0360311fb59d11c434d3aec013ec
Reviewed-on: https://chromium-review.googlesource.com/818283Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523300}

Per UI Review's comment, this CL removes the use of BarBanner for an
In-Product Help for Contextual Search scenario, and replaces it with the more
familiar TextBubble.
Discussion: https://groups.google.com/a/google.com/d/msg/chrome-ui-review/2_I2G2yqLUI/s2AnV5WABwAJ

Bug: 794013
Change-Id: I3b76aadac1dbe5981fb5b3d5fca989ca11157a21
Reviewed-on: https://chromium-review.googlesource.com/821411Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523299}

https://skia.googlesource.com/skia.git/+log/2326177e3499..5ca9413b9bc1

$ git log 2326177e3..5ca9413b9 --date=short --no-merges --format='%ad %ae %s'
2017-12-11 rmistry [Bookmaker bot] Output fiddleout.json earlier and do not send to CQ for now
2017-12-08 halcanary resources:  optionally link them into our binary
2017-12-11 bsalomon Rename GrGLAssembleFooInterface to GrGLMakeAssembledFooInterface.
2017-12-11 caryclark working on image and nightly housekeeping bot
2017-12-11 fmalita Fix fuzzer crash in SkReadBuffer::readTypeface()
2017-12-11 angle-deps-roller Roll skia/third_party/externals/angle2/ 9b88991c7..c7abc0803 (1 commit)
2017-12-11 bsalomon Fix Google3 link errors(?)
2017-12-11 brianosman Filter Windows SDK and Compiler directories
2017-12-11 benjaminwagner Re-add '--gpuThreads 0' tests.
2017-12-11 liyuqian Use first/second instead of min/max in 2pt conical gradient
2017-12-11 reed read signed 32 if we want to treat it as signed
2017-12-11 zhizhouy Turn on PGO for Skia on Android
2017-12-11 reed add virtual to confirm flattenable type
2017-12-11 borenet bin/try: No prompt for a single matching job
2017-12-11 stani Implement a fast path for solid color lattice rectangle
2017-12-11 ethannicholas fixed SkSL optimizing away side effects
2017-12-11 benjaminwagner Remove PixelC CPU jobs.
2017-12-11 bsalomon Add GrGLMakeNativeInterface factory that returns sk_sp<const GrGLInterface>.
2017-12-08 brianosman Move ImGui support code to ImGuiLayer

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: I21726e20109fb8be502e9f6d812198e2b707e986
Reviewed-on: https://chromium-review.googlesource.com/820720Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523298}

This change updates the discovery-succeeds.html test to use the Web
Bluetooth Test interface. This will help us migrate the test to the wpt/
directory, since testRunner is not going to be used anymore.

BUG=509038

Change-Id: Id5d7d72e100c2d477d4690090b715eb549dfad99
Reviewed-on: https://chromium-review.googlesource.com/817754Reviewed-by: Conley Owens <cco3@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523297}

This removes and re-adds a filesystem if it was already added instead
of throwing an error. It makes it easier to work with overrides if
you are coming from an old version of overrides or add the folder to
the wrong type of persistence.

Bug: 760316
Change-Id: I8578fef29eba2529ded714cf8bf8582d616c439d
Reviewed-on: https://chromium-review.googlesource.com/820569Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523296}

This reverts commit a569f96f.

Reason for revert: This CL was designed to detect a potential clean-up race. Race not detected, so reverting.


Original change's description:
> Logging to ensure that non-offscreen surfaces are destroyed as expected
> 
> We're hitting scenarios where it appears that we may be creating an
> EGL window surface for a given window before destroying the previous.
> This leads to errors on Android, and shouldn't be possible. We're
> suspecting that someone may be taking a reference on the glSurface,
> extending the lifetime beyond the expected range. This CL adds logging
> to catch this scenario.
> 
> Bug: 787086
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I31bb0c55fb393a0719486f32f885273ee81ab9f8
> Reviewed-on: https://chromium-review.googlesource.com/802186
> Commit-Queue: Eric Karl <ericrk@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#522293}

TBR=boliu@chromium.org,piman@chromium.org,ericrk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 787086
Change-Id: Ib921aa04c7a3589b514b4b14091989d368cf2202
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/820111Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523295}

BUG=793797
R=thestig@chromium.org,yyanagisawa@chromium.org
CC=milko.leporis@mips.com

Change-Id: I04180e7a59f02b7492cc63159ecf17b7b87cf7f0
Reviewed-on: https://chromium-review.googlesource.com/820293Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523294}

https://pdfium.googlesource.com/pdfium.git/+log/92c8b1a07b01..c00226132679

$ git log 92c8b1a07..c00226132 --date=short --no-merges --format='%ad %ae %s'
2017-12-11 dsinclair [xfa] Move CJX code into fxjs/xfa
2017-12-11 thestig Remove default arguments to CPDF_StreamAcc::LoadAllData().
2017-12-11 thestig Slightly simplify CPDF_StreamAcc::LoadAllData().
2017-12-11 dsinclair [xfa] Refactor CJX method signatures.
2017-12-11 thestig Move some GetDict() calls out of header files.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I1d7b3e10ca2453bc41043e3e6eabf809771ecf78
Reviewed-on: https://chromium-review.googlesource.com/820950
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523293}

Bug: 789897
Change-Id: Idcc3453f2355b1d7506fdc24a833819358902ee8
Reviewed-on: https://chromium-review.googlesource.com/803630
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523292}

Null dereference in CDXGISwapChain::FlipPresentToDWM during Present is
strongly correlated with the presence of MCTUX.dll or MCTU.dll. These
are described as "LDDM User Mode Driver" for Magic Control Technology
Corporation's display adapters.

We use flip model swap chains with direct composition only so
blacklisting it might prevent these crashes.

R=piman,brucedawson
BUG=776403

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8ec6664cad44036646475d48acb3c93c5dbcf220
Reviewed-on: https://chromium-review.googlesource.com/820646Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523291}

This CL removes a couple instance of I18nBehavior being declared by not
being used.

(code health)

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic779231d1cd33d02216a8c7b4bf48e9de33cb62d
Reviewed-on: https://chromium-review.googlesource.com/820457Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523290}

Bug: 781409
Change-Id: I7d41a7ef52df506c6cb11f8c19051a0f5c63f500
Reviewed-on: https://chromium-review.googlesource.com/820812
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#523289}

After https://chromium-review.googlesource.com/c/chromium/src/+/801979, we no
longer need the select_inserted_text functionality on either InsertTextCommand
or InsertIncrementalTextCommand, so we can remove the parameter.

Bug: 784039
Change-Id: Icfb2688a83383cea9e295186f351b6f43ffadf6c
Reviewed-on: https://chromium-review.googlesource.com/807286
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523288}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d638a44a623a..0bf4fdf50244

$ git log d638a44a6..0bf4fdf50 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: I252673f1d5ab2230c7ed37b45698b25be16ea914
Reviewed-on: https://chromium-review.googlesource.com/820896Reviewed-by: src-internal-roller . <src-internal-roller@chromium.org>
Commit-Queue: src-internal-roller . <src-internal-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523287}

Window selector item indicator and drag indicators share some design
so created split_view_constants.h to share constants.

Animate the selector item indicator label, and the drag indicator
widget opacity so they fade in.

Change phantom windows to when selector item dragged over to drag
indicator.

mocks:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQc4sf-S_quE/files/MCEpUArMVI4QsSaRnFNKc4g8wMSJbxAVNpw

screenshots:
https://screenshot.googleplex.com/D6yHyySYLhb
https://screenshot.googleplex.com/zWwVzisZuPC
https://screenshot.googleplex.com/ZiYRYhM6i62

Test: manual, ash_unittests SplitViewWindowSelectorTest
Bug: 786119
Change-Id: Iedd5e9193e73c16f2d0b0c494a86e626b32705f6
Reviewed-on: https://chromium-review.googlesource.com/779940Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523286}

Gconf has been deprecated for several years, with none of the supported
distros even assigning values to the gconf settings. This is part of an
effort to move from using gconf to gsettings.

Bug: 768027
Change-Id: Ifa1a668364e39c05270999c9eea801a2593011f3
Reviewed-on: https://chromium-review.googlesource.com/817759Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523285}