- 23 Jan, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2ea20eae785f..ba163361685f git log 2ea20eae785f..ba163361685f --date=short --first-parent --format='%ad %ae %s' 2020-01-23 benjaminwagner@google.com Reduce binary size of GCC Debug builds 2020-01-22 robertphillips@google.com Add missing 'GrProtected' parameter to createCompressedTexture call chain 2020-01-22 michaelludwig@google.com Account for negative w in GrQuad::bounds Created with: gclient setdep -r src/third_party/skia@ba163361685f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:224618 Tbr: benjaminwagner@google.com Change-Id: Ic95395d63066e4473bfde6302e24790b96df6d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016068Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734334}
-
Fergal Daly authored
Bug: 882574 Change-Id: I08c0f15713bd0cd7db14017de3c0460fa29198d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1249278Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#734333}
-
llin@chromium.org authored
The source language localized name might contain bracket already, for example: Chinese (Traditional). Checked with UX team and update the way we present language name to "[query] · [language name]". Bug: b/144317438 Test: unit tests Change-Id: Iab209a4eb0d2abdb5ce1b298f7528f751e39cfe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013893 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#734332}
-
Fergus Dall authored
This is a reland of 2711d4f7 Fix a use-after-free in the abort callback system Original change's description: > Remove shared ownership of CrostiniRestarter > > It seems to be possible for shared references to CrostiniRestarter to > outlive CrostiniManager. Since all of CrostiniRestarter assumes that > CrostiniManager still exists, this can cause crashes. Switch > CrostiniRestarter to being exclusivly owned by CrostiniManager and > handing out weak pointers to callbacks. > > Bug: 1040797 > Change-Id: Ib65c79c7c81111aad88435b3c95da0c64226e791 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996112 > Reviewed-by: Nic Hollingum <hollingum@google.com> > Commit-Queue: Fergus Dall <sidereal@google.com> > Cr-Commit-Position: refs/heads/master@{#733496} Bug: 1040797 Change-Id: Iabe0809381785bd80f896bb77c69e9142df67255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012203Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#734331}
-
Brian Sheedy authored
Switches the expectation for conformance/textures/misc/texture-size-limit.html from "Skip" to "RetryOnFailure", as the issue the test was causing for subsequent tests has been worked around. TBR=ynovikov@chromium.org Bug: 1043953 Change-Id: Iff573b37d981c8777e8373ebd8fd025ee2beac3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015982Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#734330}
-
Karan Bhatia authored
More documentation/examples will follow once the documentation for generic priority lands. BUG=1038831 Change-Id: I88cf351a6c327c6dbcf8554cf71a17ee82b06933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001755 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734329}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bc9b29411747..6b345995a827 git log bc9b29411747..6b345995a827 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 rmhasan@google.com Revert "[Telemetry] Simplify the timeout condition in CollectTraceData" Created with: gclient setdep -r src/third_party/catapult@6b345995a827 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1039726 Tbr: nuskos@google.com Change-Id: Ic9230ff69066e5852c800eb37a9f0fd7ec90cd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016067Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8ffd3f23331d..c2e16963a9cc git log 8ffd3f23331d..c2e16963a9cc --date=short --first-parent --format='%ad %ae %s' 2020-01-22 cwallez@chromium.org Add SurfaceDescriptorFromHTMLCanvasID Created with: gclient setdep -r src/third_party/dawn@c2e16963a9cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib03d647694ad49f36bd97b62361baa8ec55ecc79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016066Reviewed-by:
-
Jesse McKenna authored
Minor fix to web-app file-handler registration Windows unit tests per comment on crrev.com/c/2002982. Change-Id: I6a00574ac23c244c030455af821987db4f2f78b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016185Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#734326}
-
Tom Anderson authored
The name "libgtkui" is misleading: we don't actually ship a libgtkui.so, although this was planned at some point. Even if we did, it probably still wouldn't make sense to have "lib" in the directory name. This change renames the directory to simply gtk. BUG=None R=sky Change-Id: Ib2380520c8605b4d4e0fd2d6ff9207caa50a406e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011683 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#734325}
-
Jongmok Kim authored
GetTargetTemperature seems not used. Bug: None Change-Id: Ib29a2ac861665eaba30c9ab10af483d8f5892a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014350Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#734324}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a2e07326..92a85446 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5592c70c3d6f795e5a4ddfa1526d1158b4378011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016122Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734323}
-
Jason Chase authored
Update the expiry to M86. We will move the related features to use Document Policy, meaning developers will then need time to experiment/test the policies locally. Bug: 906163 Change-Id: I6d6d524d21e0d177956badb240312ac572f408cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015488Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#734322}
-
Julian Watson authored
Open Plugin VM settings pages should revert back to the top level os settings when Plugin VM is uninstalled. In order accomplish this the top level settings cr-link-row needs to be always visible, as os_settings can't dynamically hide rows. Instead the contents of the row have become dynamic, and will either say Turn On if Plugin VM is not yet installed, or show an arrow if it is installed. The resulting UI is now the same as Google Play Store and Linux (Beta). Bug: 1023256 Change-Id: I9ade77a4dff3e7799732608430f299b400338ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007803Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#734321}
-
Johannes Kron authored
The test Webrtc/ConnectionTest.Audio/0 fails for the ASAN build after a seemingly unrelated change to WebRTC. The estimated frequency is ust outside the specified limits. Bug: none Change-Id: Ic583ce4272ce6bbbbc584d3ef06b786b0b58ddbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015165 Auto-Submit: Johannes Kron <kron@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#734320}
-
Kelvin Jiang authored
This CL restricts the lifespan of matched rules not associated with an active tab to 5 minutes (currently). Change-Id: I8f3d169f822ee3f2f746b765c8956f8ab5849952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994665 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#734319}
-
Scott Haseley authored
This changes the postTask prototype to use semantically meaningful names and reduces the number of priorities. The priorities now match the updated explainer: https://github.com/WICG/main-thread-scheduling/blob/master/PrioritizedPostTask.md The changes are: "immediate" --> removed. We may reconsider if we have use cases. "high" --> "user-blocking" "default" --> "user-visible" "low" --> "background" "idle" --> removed. We may also reconsider this if we have use cases that can be differentiated from "background", but we currently don't. This also avoids conflict w/ requestIdleCallback. Bug: 979017 Change-Id: I58fb68e8bed38d8463d080bb3ff028049a69667b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008426 Commit-Queue: Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#734318}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6589db968634..aa94421bfd1f git log 6589db968634..aa94421bfd1f --date=short --first-parent --format='%ad %ae %s' 2020-01-22 oysteine@google.com Reland "Stack profiling: Don't attempt hex conversion on Breakpad build_ids" Created with: gclient setdep -r src/third_party/perfetto@aa94421bfd1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I36bde5c8049c15e42ea4703e847864ad83fec766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016062Reviewed-by:
-
Findit authored
This reverts commit d8115a08. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 734159 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q4MTE1YTA4NTgzMmFiM2Q4OWNmMjEzNTQxNGZkNGViZDM3ZGFmNTUM Sample Failed Build: https://ci.chromium.org/b/8890523056669518464 Sample Failed Step: interactive_ui_tests Original change's description: > CrOS Shelf: Change hotseat color between in-app and home shelf. > > In this change, the hotseat background will change color for different > shelf states and will animate between colors when changing. When in-app > shelf is shown the hotseat color should have an alpha value of 90%. > When the home shelf is shown the hotseat color should have an alpha > value of 60%. > > Bug: 1041132 > Change-Id: I9459fbb61cbc538029039cd48c04144a98ab82c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003919 > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734159} Change-Id: I55a1fbb925f7c5172f1f45c418cb013216c97d6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1041132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016194 Cr-Commit-Position: refs/heads/master@{#734316}
-
Brandon Wylie authored
Just the feature flag and related setup for now, I'll follow-up with the functionality in another CL. Bug: 1041576 PRD: go/roti-prd Doc: go/roti-chrome-design Change-Id: I51b65fe999c9679201ca28ef8e88eeee9966fef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997652 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#734315}
-
Tom Anderson authored
GTK has a setting to globally disable animations. This CL uses it to disable animations in Chrome when the setting is set to disabled. R=sky Bug: 1043808 Change-Id: Idcaee97fdad3a26bb795d496599c745c83da6d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011442Reviewed-by:
-
Yutaka Hirano authored
Add an end-to-end test as a browser test as at this moment it is difficult to write it as a web platform test. We will covert it into a web platform test in the future. Bug: 1011392 Change-Id: I90e95f265b788042bc21a3cf633849d6ea873c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010740Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#734313}
-
Joel Hockey authored
When no paths have been shared, show a default message in the Crostini shared paths settings page. Bug: 1008172 Change-Id: I67010d015e8e5bf3a51f8cae08bf5c926faec16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014211 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#734312}
-
Julian Watson authored
Bug: 1023256 Change-Id: I35b36c4ca33a88210ff3108410082a607f074bd6 tbr: cpu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012375 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
-
Yoichi Osato authored
This reverts commit 3e49c929. Reason for revert: This is a culprit of ChromiumOS test failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17426 Fixes: 1044826 Original change's description: > [CrOS Printing] Don't send username and filename unencrypted > > This situation may come up if policy was changed after printer was > selected. We reject printing job since silently omitting username and > filename could be confusing. > > Bug: 1042798 > Change-Id: Iba385503d8f7e960291728d6515ca7c236220847 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004992 > Reviewed-by: Sean Kau <skau@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734128} TBR=thestig@chromium.org,vkuzkokov@chromium.org,skau@chromium.org Change-Id: I5edc2769677fc26c5810fe38d77d03700473c8bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015906Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#734310}
-
Weiliang Chen authored
Refactor the SharedImageInterface inside InProcessCommandBuffer so that it could be used for other Viz in process cases. Mainly this will help set up to use viz::BufferQueue for SkiaRenderer. R=ericrk Bug: 1042538 Change-Id: If2e5486d68d38452975fe035a5de59a06bc0a3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998283 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#734309}
-
Karan Bhatia authored
This CL implements the evaluation of allowAllRequests rules. To do this: - Track allowlisted frames in RulesetMatcherBase. We keep track of the highest priority matching allowAllRequests action for each allowlisted frame. This needs plumbing DidFinishNavigation and RenderFrameDeleted to RulesetMatcherBase. - Storing the parent RenderFrameHost ID for each request. This requires plumbing it for navigation requests through ExtensionNavigationUIData. - Modify RulesetMatcherBase::GetBeforeRequestAction to respect requests from allowlisted frames. BUG=1038831 Change-Id: Ie4b34341b59d568dfb94338006f7ace857bf38e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993844 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Scott Violet authored
Which includes open tabs. This should be the core support necessary for the Java side, but java integration (and tests) will be done on top of this. The browser_test does not run on Android as it creates C++ Browser objects from the C++ side, which is not how things are setup to work now. BUG=1033924 TEST=weblayer_browsertests SessionService* Change-Id: I3cc4cbdd51d2baa055457a4a58b210d9e3f1d404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014051Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#734307}
-
Daniel Rubery authored
Token are now unregistered when the BinaryUploadService is done using them. This is useful for privacy, since the GCM device id will reset when there are no active registrations. Bug: 1020418 Change-Id: I3a74203a2817e463fb878ce9a8da20773e58033e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003354Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#734306}
-
Jon Mann authored
This adds the new org.chromium.flimflam.Service.GetWiFiPassphrase method to ShillServiceClient. Bug: 966270 Change-Id: Ica8ed87ae7a10a6f588f42b2e8166ca87987967a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006220 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit 719db867. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 734218 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzcxOWRiODY3ZDFiZDYwNDE5MGM1MjU0NjJkYzIxYTQ0MTM2MGNlY2EM Sample Failed Build: https://ci.chromium.org/b/8890517133911529728 Sample Failed Step: browser_tests Original change's description: > Open captive portal login pages in popup windows in secure mode. > > Secure DNS will be disabled in these windows, allowing users to > complete the captive portal resolution process. > > Future cls will add additional conditions that will trigger captive > portal probes in secure mode. > > Change-Id: I441d17465a9c9d11567775321ed3ddd8532598ab > Bug: 10161646 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984663 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Katharine Daly <dalyk@google.com> > Cr-Commit-Position: refs/heads/master@{#734218} Change-Id: I2f45e00e80a763a605520374a0860d20ddbfcdbb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 10161646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016192 Cr-Commit-Position: refs/heads/master@{#734304}
-
matterchen authored
Port forwarding in Cros will allow users to add new ports and activate, deactivate and remove existing ports. When any of the utilities are called, the port forwarding library will invoke the permission broker client to change the ChromeOS port forwarding settings. In future work we will also save port forwarding preferences such that a user's preferences will persist over container shutdown. Bug: chromium:848127 Test: crostini_port_forwarder_unittest.cc and everything builds Change-Id: I9a0478f1486252fb09fab18ab3261e03d00eb480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999972Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Matthew Chen <matterchen@google.com> Cr-Commit-Position: refs/heads/master@{#734303}
-
Matt Giuca authored
Change-Id: I1aac345b70dab6c6e7850bdc2b31b79fe607eda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016020 Auto-Submit: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734302}
-
Findit authored
This reverts commit 0fdf70f4. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 733959 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMGZkZjcwZjQ4ZGFjZDVlNDA2MzgyYzIwMjBkMzJlZDgzOTZmYWZlNQw Sample Failed Build: https://ci.chromium.org/b/8890523252878393760 Sample Failed Step: webkit_unit_tests on Windows-10-15063 Sample Flaky Test: MediaStreamRemoteVideoSourceTest.ReferenceTimeEqualsTimestampUs Original change's description: > Set PROCESSING_TIME and CAPTURE_BEGIN_TIME of WebRTC video frames > > Bug: chromium:1011581 > Change-Id: I12cc31309f896f6a00802adb5cb1991f8db9b342 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007209 > Commit-Queue: Johannes Kron <kron@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733959} Change-Id: I2d0f1c8439b443a56e3e4d96032927647adf8f51 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1011581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016190 Cr-Commit-Position: refs/heads/master@{#734301}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c518c7f9fe9a..1d7da3cc922f Created with: gclient setdep -r src-internal@1d7da3cc922f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1033656,chromium:945334 Tbr: jbudorick@google.com Change-Id: I9b1e44567e5e078259cfa6d55d011cf728aa41fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015458Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734300}
-
Ryan Sleevi authored
Chromium used to warn if the server negotiated a weak DH key. However, it has since disabled support for DH entirely, so this traces are no longer used. Bug: none Change-Id: I3645cd011287b68bd3343e06faeb5dd9f089862a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012909Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#734299}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Iaa2165aa1be6a10a4466c794c0b034d9c06b0942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015558Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#734298}
-
Fergal Daly authored
This is accessed in a bunch of places include in the constructor where it passes through an extra call to render_manager that seems to be redundant. This is a no-op refactor that just tidies things a little. I'm open to better naming and docs. Change-Id: I954e9ecf46a77de7ea9528eb527c1204b9ada3cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010462 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#734297}
-
Xinghui Lu authored
On focus and password reuse pings are launched in M79. Make them enabled by default after M81. Bug: 995926 Change-Id: I7946a3885ec46e0c51aa72f5f00cd9eae12246c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015561Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734296}
-
Liquan (Max) Gu authored
This CL adds the ExpandablePaymentHandler experiment to the field trial testing. Since this would be enable the Expandable PH in CCT PH tests, this CL also force CCT PH Tests to not pick up the ScrollToExpandPaymentHandler flag. Server side Finch config: https://critique.corp.google.com/#review/290647947 Bug: 1037646 Change-Id: I3e18fbaa34334487cdc84119a46dad73c0a2e8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011293 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#734295}
-
