GitLab

system_health.memory_desktop.browse:news:nytimes.

Mac 10.9 does not run these tests after
https://codereview.chromium.org/2175293002

BUG=630686,630765

Review-Url: https://codereview.chromium.org/2178933002
Cr-Commit-Position: refs/heads/master@{#407600}

According to the C++ standard, the three arguments overload
of std::string::assign accepts an std::basic_string:
http://en.cppreference.com/w/cpp/string/basic_string/assign

Fixing the usage, where char* instead of std::string was passed.

This popped up after libc++ became more standard compliant,
and now it throws a compiler error.

BUG=630681

Review-Url: https://codereview.chromium.org/2177863003
Cr-Commit-Position: refs/heads/master@{#407599}

BUG=630627,615157

Review-Url: https://codereview.chromium.org/2175313003
Cr-Commit-Position: refs/heads/master@{#407598}

I stopped UpdateDeviceList being called every time XISlaveSwitch events occur.

BUG=609748

Review-Url: https://codereview.chromium.org/2077163003
Cr-Commit-Position: refs/heads/master@{#407597}

This changes WebFormControlElement::directionForFormData so it takes into account text-align: left|right while returning the text direction used in autofill dropdown component.

BUG=482339

Review-Url: https://codereview.chromium.org/2161963003
Cr-Commit-Position: refs/heads/master@{#407596}

Mojo C++ bindings: add a presubmit check to disallow adding new mojom targets with use_new_wrapper_types set to false.

BUG=624136

Review-Url: https://codereview.chromium.org/2179113002
Cr-Commit-Position: refs/heads/master@{#407595}

Requires https://codereview.chromium.org/2144103002/

BUG=627939

Review-Url: https://codereview.chromium.org/2144823003
Cr-Commit-Position: refs/heads/master@{#407594}

https://chromium.googlesource.com/webm/libvpx.git/+log/4b073bc39a39..82070ae9393b

$ git log 4b073bc39..82070ae93 --date=short --no-merges --format='%ad %ae %s'
2016-07-25 krasin Fix compilation error under Clang 4.0.
2016-07-22 jzern configure: test for -Wfloat-conversion
2016-07-23 jzern vp8/decodeframe: fix signed/unsigned comparison
2016-07-23 jzern vp9: fix frame-level threaded decode shutdown
2016-07-23 noreply vp8/postproc.c: disable clang-format for RGB_TO_YUV
2016-07-21 jimbankoski vp8:fix threading issues
2016-07-22 jzern vp8/postproc: fix implicit float conversion
2016-07-15 yuryg Add VPX_SWAP macro
2016-07-22 jzern blockiness_test: fix implicit float conversion
2016-07-22 aconverse Minor skip segment simplification.
2016-07-22 jzern resize_test: fix implicit float->int conversion
2016-07-22 marpan vp9 1pass-vbr: Adjust gf setting for nonzero-lag case.
2016-07-21 noreply vpx/: apply clang-format
2016-07-21 slavarnway VP9: get_pred_context_switchable_interp() -- encoder side
2016-07-11 paulwilkins Sample points to reduce encode overhead.
2016-06-10 paulwilkins Noise energy Experiment in first pass.

R=johannkoenig@chromium.org
BUG=631144

Review-Url: https://codereview.chromium.org/2178123002
Cr-Commit-Position: refs/heads/master@{#407593}

BUG=611781
COMPONENT=Chrome OS, HaTS, Unittest

Review-Url: https://codereview.chromium.org/2169223002
Cr-Commit-Position: refs/heads/master@{#407592}

This patch updates the code to prevent auto deducing to a raw pointer.

R=chrisha@chromium.org
BUG=554600

Review-Url: https://codereview.chromium.org/2171123002
Cr-Commit-Position: refs/heads/master@{#407591}

There is no reason to unset bluetooth_adapter_. If the adapter is
not present, making calls to it will simply invoke the error callback.
Just removing this should fix the crash.

BUG=630069
TEST=build

Review-Url: https://codereview.chromium.org/2172063002
Cr-Commit-Position: refs/heads/master@{#407590}

Currently EglThreadContext only creates OpenGL ES 2 context. OpenGL ES 3 is
backward compatible with ES 2 and has new interfaces (e.g. GL_PACK_ROW_LENGTH)
that can improve the performance of the client OpenGL renderer.

This CL makes EglThreadContext create OpenGL ES context of the highest
version supported by the software or hardward of the device.

BUG=385924

Review-Url: https://codereview.chromium.org/2175913002
Cr-Commit-Position: refs/heads/master@{#407589}

Revert of Auto-rebaseline for r407494 (patchset #1 id:1 of https://codereview.chromium.org/2179893002/ )

Reason for revert:
Caused webkit testing failures on Win 10 bot:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/12825

unexpected_failures:
virtual/gpu-rasterization/fast/images/color-profile-reflection.html
virtual/gpu-rasterization/fast/images/png-with-color-profile.html

details:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win10/12825/layout-test-results/results.html

If the bot tries to land the change again and again causes failures, the channel recommends changing the "NeedsRebaseline" entry in TestExpectations to "NeedsManualRebaseline".

Original issue's description:
> Auto-rebaseline for r407494
>
> https://chromium.googlesource.com/chromium/src/+/9ff8991aa
>
> BUG=627844
> TBR=bsalomon@google.com
>
> Committed: https://crrev.com/b7a7ce4683ce455f1624cdd4b3a8bc6aff64d654
> Cr-Commit-Position: refs/heads/master@{#407527}

TBR=bsalomon@google.com,blink-rebaseline-bot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=627844

Review-Url: https://codereview.chromium.org/2182653004
Cr-Commit-Position: refs/heads/master@{#407588}

Implement the following functionality
- Request to read/write Gatt characteristic/descriptor.
- Send response message back for the request read/write.
- Send reply back that response message is sent.

BUG=629210
TEST=manual test using step below
1. Create custom Gatt server in nrF connect app.
2. Connect minnie to ryu via chrome interface.
3. Ryu can correctly see minnie's Gatt server object.
4. Ryu can correctly read / write Gatt server object.

Review-Url: https://codereview.chromium.org/2101283003
Cr-Commit-Position: refs/heads/master@{#407587}

BUG=101395

Review-Url: https://codereview.chromium.org/2165133003
Cr-Commit-Position: refs/heads/master@{#407586}

CancelOnFailureAndDeleteSelf() should be the last call
DownloadTargetDeterminer can make.
After that, it is deleted.
Reporting the UMA first, then call CancelOnFailureAndDeleteSelf().

BUG=630370

Review-Url: https://codereview.chromium.org/2166163003
Cr-Commit-Position: refs/heads/master@{#407585}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/189c4816b033..139402a9056e

$ git log 189c4816b..139402a90 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2178113002
Cr-Commit-Position: refs/heads/master@{#407584}

Minor fixes to the networkingPrivate IDL.
This produces a non-fatal but confusing error in the
Settings UI.

ManagedDOMString[] is invalid, ManagedDOMStringList
should be used instead. (The managed property should
be an objetc with each entry, e.g. 'Active', 'DevicePolicy',
etc, as a separate array of strings, instead of an array of
objects).

BUG=none

Review-Url: https://codereview.chromium.org/2182633002
Cr-Commit-Position: refs/heads/master@{#407583}

Jinja2 and markupsafe will be pulled into v8/third_party/ via DEPS,
while the protocol handler generator will be pulled into
v8/platform/inspector_protocol/. In order for the protocol handler
generator to work when building standalone V8, it needs to include
them correctly.

R=pfeldman@chromium.org
BUG=580337

Review-Url: https://codereview.chromium.org/2174773002
Cr-Commit-Position: refs/heads/master@{#407582}

This CL adds (somewhat) dynamic padding to the end of the MD settings
so that the last item may scroll to the top of the page when selected
in the side nav menu.

BUG=593989
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2090753002
Cr-Commit-Position: refs/heads/master@{#407581}

TBR=mpearson@chromium.org
BUG=630967

Review-Url: https://codereview.chromium.org/2178993003
Cr-Commit-Position: refs/heads/master@{#407580}

https://chromium.googlesource.com/skia.git/+log/d9ddad2952cd..8fe485b793f6

$ git log d9ddad295..8fe485b79 --date=short --no-merges --format='%ad %ae %s'
2016-07-25 brianosman Just pass the draw context to paint conversion
2016-07-25 chrishtr Fix debugger build by specifying nullptr for color space.
2016-07-25 mtklein stages for most xfermodes
2016-07-25 ethannicholas SkSL performance improvements (plus a couple of minor warning fixes) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2131223002

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review-Url: https://codereview.chromium.org/2178973003
Cr-Commit-Position: refs/heads/master@{#407579}

TBR=caseq@chromium.org

BUG=399507

Review-Url: https://codereview.chromium.org/2179053003
Cr-Commit-Position: refs/heads/master@{#407578}

Also move TestIOThread::PostTaskAndWait to those tests as they were the
only user.

BUG=629139

Review-Url: https://codereview.chromium.org/2170953002
Cr-Commit-Position: refs/heads/master@{#407577}

Extremely long running tests can cause timeouts due to lack of output. This
adds a heartbeat message to stop that while tests are still running.

BUG=615157, 630640

Review-Url: https://codereview.chromium.org/2182563002
Cr-Commit-Position: refs/heads/master@{#407576}

In TransportSecurityState, set |enable_static_expect_staple_| to true by default. Update SSLClientSocket to call TransportSecurityState::ProcessExpectStaple.

In ssl_client_socket_impl.cc, this also removes the if (|signed_certificate_timestamps_enabled_) check around extracting the OCSP response and setting the UMA_HISTOGRAM_BOOLEAN("Net.OCSPResponseStapled"). Since SCTs are always enabled, this if statement was a noop.

This does not enable Expect-Staple for QUIC. See https://crbug.com/631101

BUG=598021

Review-Url: https://codereview.chromium.org/2155753002
Cr-Commit-Position: refs/heads/master@{#407575}

The Ozone GBM platform now directly creates GLSurfaces instead of
creating SurfaceOzoneEGL. The base classes for surfaceless and
framebuffer backed GLSurfaces is moved into //ui/ozone/platform/drm.
The old GbmSurfaceless class is replaced entirely despite retaining the
same name. A new GbmSurface class is added for the framebuffer backed
surface.

Add a new version of ChooseEGLConfig() to egl_util.cc/h that doesn't
rely on any callbacks now that deps problem as been fixed. The old
version will be deleted when this refactor is done as it will be unused.

BUG=611142

Review-Url: https://codereview.chromium.org/2165303002
Cr-Commit-Position: refs/heads/master@{#407574}

Just look at BUILD.gn and SystemInfo_test.mm, everything else is consistent with CL 2094583004 (Initial commit for Chrome meta installer https://codereview.chromium.org/2094583004/)

BUG=

patch from issue 2106523002 at patchset 60001 (http://crrev.com/2106523002#ps60001)

Review-Url: https://codereview.chromium.org/2137743002
Cr-Commit-Position: refs/heads/master@{#407573}

When computing the occlusion from a layer, draw_blend_mode rather than
blend_mode needs to be considered, since draw_blend_mode is what's used
when drawing the layer. However, non-default blend modes currently always
trigger surface creation, and then the blend mode gets applied when
drawing the surface. This means that draw_blend_mode is always SrcOver.
This CL replaces the incorrect use of blend_mode in
OcclusionTracker::MarkOcclusionBehindLayer with a DCHECK that
draw_blend_mode is SrcOver.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2176903002
Cr-Commit-Position: refs/heads/master@{#407572}

https://chromium.googlesource.com/chromium/src/+/706d93d0d

BUG=621772
TBR=agrieve@chromium.org

Review URL: https://codereview.chromium.org/2182753002 .

Cr-Commit-Position: refs/heads/master@{#407571}

This can happen in a clean build if the clean_up_old_versions step runs before
bundling, in a parallelized build.

R=mark@chromium.org

Review URL: https://codereview.chromium.org/2184433002 .

Cr-Commit-Position: refs/heads/master@{#407570}

Yes, these three updates are truly interdependent. See
https://crbug.com/629874.

Breakpad was previously on a branch that had cherry-picked 027633792600.
Breakpad 2fcb8afbc807 requires linux-syscall-support 3f6478ac95ed. The
repository for linux-syscall-support has changed locations. Native
Client also depends on linux-syscall-support and must be updated to
412a6e2bb153 for compatibility with this version of
linux-syscall-support.

Update Breakpad to 51db53eec7293a35cb6fc10bd2e333f22dd9d201

220c852dc209 Dump INFO CODE_ID containing Build ID in Linux dump_syms
2fcb8afbc807 linux-syscall-support: pull in latest version
1f7cb2e4c523 Server-side workaround to handle overlapping modules
8c612166fa87 Add a new argument to specify the minidump type to write on
             Windows
2131271ecabd [Android] Guard some NDK workarounds by major version
027633792600 Recover memory mappings before writing dump on ChromeOS
0de9e29cb674 Don't define |r_debug| and |link_map| on Android releases
             21 and later
e55a878d5b74 Add process type to MicroDumpExtraInfo
423e661072aa Add new exception code for OOM generated from Chromium
4dc6be51f90c Revert "Don't define |r_debug| and |link_map| on Android
             releases 21 and later"
51db53eec729 Remove DISALLOW_COPY_AND_ASSIGN from MinidumpStreamInfo

Update linux-syscall-support to 3f6478ac95edf86cd3da300c2c0d34a438f5dbeb

2ce6a9744160 Add codereview.settings for new repo location
cd0177fdded9 Fix VIEW_VC URL in codereview.settings
929203010984 Finally fix VIEW_VC url with proper review
08056836f2b4 migrate site/wiki docs over
348bdf8d32b3 README: clearly document goals/APIs/supported systems
3f6478ac95ed Add s390/s390x support to linux_syscall_support.h

Update Native Client to 412a6e2bb153f39f22b9b3e47bc1ed0abb82df3f

412a6e2bb153 Update linux-syscall-support to 3f6478ac95ed

Update generate_breakpad_symbols.py for Breakpad 220c852dc209.

BUG=629874
TEST=tools/perf/run_tests core.stacktrace_unittest.TabStackTraceTest.

Review-Url: https://codereview.chromium.org/2167703002
Cr-Commit-Position: refs/heads/master@{#407569}

After this change: https://codereview.chromium.org/2176193002/, canvas
drawImage() API call does bleeding, so these two layout tests will fail.

This CL mark them as failure, and once skia change is committed, we should
update the layout tests.

TBR=junov@chromium.org,schenney@chromium.org
BUG=355305

Review-Url: https://codereview.chromium.org/2182663002
Cr-Commit-Position: refs/heads/master@{#407568}

We added a new value for extension bubble actions for dismissing by
deactivation in crrev.com/486b20e7 in
November, but never updated the histogram entry. As a result, the data,
while recording correctly, shows "3" for dismissing by deactivation.
Update the histogram file to correct this.

BUG=None

Review-Url: https://codereview.chromium.org/2174403002
Cr-Commit-Position: refs/heads/master@{#407567}

Implement the following functionality
- Add Gatt service / characteristic / descriptor to Gatt Server
  "Gatt included service" is currently not support in Chrome side.
- Start / Stop Gatt service
- Delete Gatt Service

BUG=629210
TEST=manual test using step below
1. Create custom Gatt server in nrF connect app.
2. Connect minnie to ryu via chrome interface.
3. Ryu can correctly see minnie's Gatt server object.

Review-Url: https://codereview.chromium.org/2104043002
Cr-Commit-Position: refs/heads/master@{#407566}

Comments in CursorDelegateEvdev incorrectly specified thread usage
so update appropriately.

BUG=620927

Review-Url: https://codereview.chromium.org/2179123002
Cr-Commit-Position: refs/heads/master@{#407565}

Updates code to stop using the old mojo::String and mojo::Array types
and instead use the much-cleaner std::string and std::vector types
(a.k.a. the "new" mojo wrapper types for C++ code).

R=imcheng@chromium.org

Review-Url: https://codereview.chromium.org/2173953003
Cr-Commit-Position: refs/heads/master@{#407564}

Don't use the test API to access things that can be directly accessed from
WmShell.

BUG=none
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2183483002
Cr-Commit-Position: refs/heads/master@{#407563}

Added metrics to track which system menu rows are visible in order to
make informed decisions about feature usage.

BUG=620509
TEST=SystemTrayTest.*

Review-Url: https://codereview.chromium.org/2162153002
Cr-Commit-Position: refs/heads/master@{#407562}

This is a bug in how we construct the CALayer tree. The code
originally assumed that we would always re-use the old CALayer
if it existed. This is no longer the case now that we sometimes
use AVSampleBufferDisplayLayers.

With this patch, we ensure that we always put the new CALayer
in the position of the old CALayer.

A unit test for this is coming in another patch, but this one is
being merged back to M52, and the unit test files have changed
dramatically.

BUG=618287

Review-Url: https://codereview.chromium.org/2181713004
Cr-Commit-Position: refs/heads/master@{#407561}