- 19 Jan, 2021 40 commits
-
-
Mohamed Amir Yosef authored
This CL introduces a method in Autofill client that opens the Save Address bubble. No implementation is added in this CL. The method is currently empty. Follow up CLs will add implementation for this on various platforms. Bug: 1135178 Change-Id: I8d67a4a097013785eddc28a0981da71e3fc10ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632587Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#844866}
-
Caitlin Fischer authored
These experiments appear to have launched. Bug: 1126640 Change-Id: I42c346088f392de93d8ca77e0d1988025b52bc3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631926Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844865}
-
Ahmed Mehfooz authored
Bug: 1160929 Change-Id: I1dbcf67108e7e07c2a746610b237870db1b1c386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633724Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#844864}
-
Danila Kuzmin authored
Bug: 1159889 Change-Id: I54ea83b1599f6a732e910f2034c67ccfd038c426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616350Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#844863}
-
Victor Costan authored
The method currently follows an unfortunate maybe-async pattern established in //net whereby operations may either report an outcome synchronously by returning a net::Error other than net::ERR_IO_PENDING, or report the outcome asynchronously by invoking a callback. This CL changes the method to unconditionally run the callback with the operation outcome. This is intended to simplify the mental model and control flow around the method. Change-Id: Iedf252bae4f6dc82c5570ccc5f1d70f8b2e11c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635679 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#844862}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1f6ed1382f51..0d1002c96edb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidvc@google.com,adithyas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: davidvc@google.com,adithyas@google.com Change-Id: I8d0e834957551181c7ed04fcd92890b7c2ba87fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630572Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#844861}
-
Jarryd authored
* Quota.GlobalTemporaryPoolSize * Quota.QuotaForOrigin * Quota.PercentUsedByOrigin Bug: 1165268 Change-Id: I9303197804caa996c9f44845d60f932705c51a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633939 Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#844860}
-
Domenic Denicola authored
The feature's name has changed, so it's ideal for places like https://www.chromestatus.com/metrics/feature/timeline/popularity/3286 to reflect the new name. Bug: 1158853 Change-Id: I17c83d8be38c97e4748b4299f81861ce411bbb34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633374Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#844859}
-
Adam Langley authored
BUG=1002262 Change-Id: I46732a4570ebbfc896e23c86f6689b29e82f0aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636382 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844858}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b28c3b8f..870bd0b9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6419cf6f263ff4c49c47e102323aded0fcfa7d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637328Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844857}
-
Tim Volodine authored
Add kWebViewJavaJsBridgeMojo feature for Android WebView, to enable/disable the new Java/JS bridge code path using mojo. The feature is currently disabled by default. When the feature is enabled the mojo interface for the addJavascriptInterface() API in Android WebView is used. This CL also adds the feature to the ProductionSupportedFlagList and removes the 1-arg version of JavascriptInjector.fromWebContents(). BUG=1164434 Change-Id: Ic4ecdbb78ca18e5455ddbac3367ddbe301bdb67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630905Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#844856}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0bc32f23f69e..f8dfc3b51883 2021-01-19 johnstiles@google.com Generate valid Metal code when globals reference one another. 2021-01-19 adlai@google.com Optimize task clustering, part 1 2021-01-19 fmalita@chromium.org [svg] Cleanup: drop the presentation attribute SkPaint cache 2021-01-19 bungeman@google.com Avoid division by zero when shaping. 2021-01-19 bsalomon@google.com Revert "Test all YUVA image factories with different encoded origins." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I069d44c5d3de7225aa974fc1c682f2a12c62f677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638012Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844855}
-
Victor Costan authored
The member is kept up to date in code, but only read in tests. Change-Id: I2a1fb25e9ac51e2e26d2b38365df55b502d3c7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634861 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Xida Chen authored
This reverts commit 85f5cc53. Reason for revert: Test fails here: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tester%20(Ozone%20Wayland)/4513/overview Original change's description: > Handle sync paste deep scanning crash > > This fixes the crash observed in crbug.com/1166233 and adds tests for > it. See the comments in that bug for more details. > > This fix also removes the dialog for unauthorized users for pasting > after the initial scan that does authentication, so crbug.com/1028133 > is affected. > > Bug: 1166233, 1028133 > Change-Id: Id3c992fdeccfa92a9f88e25c13e7a15bcb1afd8c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633701 > Reviewed-by: anthonyvd <anthonyvd@chromium.org> > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844787} TBR=anthonyvd@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,domfc@chromium.org Change-Id: Ie52bf5a7b9aeaf3871795e0c480cf86d6be8fc0c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1166233 Bug: 1028133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637406Reviewed-by:
Xida Chen <xidachen@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#844853}
-
Sherry Hu authored
Chrome uses ArcAdbdMonitorBridge to control arcvm-adbd. Android notify Chrome over Mojo to make sure arcvm-adbd job start/stop when guest's adbd startup/shutdown. The change is paired with https://crrev.com/c/2600256 and https://crrev.com/c/2600476 TEST=Toggle ADB debugging on Android developer setting, start/stop arcvm-adbd job successfully. TEST=component_unittests --gtest_filter="ArcVmClientAdapterTest.*" TEST=unit_tests --gtest_filter="ArcAdbdMonitorBridgeTest.*" Change-Id: Ib3742fba4854dc20e71ebe09d7a145ea45047101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600436 Commit-Queue: Sherry Hu <shuanghu@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#844852}
-
manukh authored
We're unlikely to further pursue kRichAutocompletionTwoLineOmniboxParam. Bug: 1062446 Change-Id: Ia10ccf122faf94c86c912e0c618d4039bf8da84e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617514Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#844851}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2517afd133f3..0489cc12af57 2021-01-19 ehmaldonado@google.com Reland "presubmit: Use new API to check for owners approval" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: Ieff0ff0a2f88a220f562d59d968d357111186b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638234Reviewed-by:
-
cfredric authored
Change-Id: Id88e7004eb6bb85fcbb8352ee0ff522d88702350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637397 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
-
Patrick Noland authored
Bug: 1147581 Change-Id: If11ef6233939f1c58ffba34b4ab391f7665134d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596115 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#844848}
-
Eugene But authored
Bug: None Change-Id: I637c90a7eec18a18d60b1727fa51e71b5e115832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633969 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#844847}
-
Scott Violet authored
Specifically, if the box has non visible overflow and an overflow-clip-margin. Without this the overflow from contain:paint doesn't take into the account the overflow-clip-margin, and we may end up not painting when we should. BUG=1157843 TEST=third_party/blink/web_tests/external/wpt/css/css-overflow/overflow-clip-margin-007.html Change-Id: Iba11a683f8cc1eb595ef26984c0dce38133fc760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626027Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#844846}
-
Victor Costan authored
The majority of the storage code uses incognito instead of off_the_record. This CL gets WebSQL in line, to reduce cognitive overhead for readers. Change-Id: I8fcce58f82da24e22aa7b14b201dc7ed935b1114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634551 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Chris Mumford authored
Switch the exception message from "GATT Error: Not supported." to "GATT operation not permitted." when attempting to read a non-readable characteristic on macOS. The former is more descriptive, as Web Bluetooth does support reading characteristics, and also aligns with other platform behaviors, e.g. Windows and Linux, which currently set the "... not permitted." message. Bug: none Change-Id: I0023a5ddd35d5783cec253e3a935c295804f731b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633646 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#844844}
-
Sahel Sharify authored
Similar to crbug.com/993223 PaymentRequestSheetController::UpdateHeaderView gets called after the payment request(PR) has been aborted. The fix for crbug.com/993223 early returns in DidFinishNavigation which is the caller of UpdateHeaderView. That's why calling UpdateHeaderView from a different function (e.g. DidChangeVisibleSecurityState in the case of crbug.com/1165624) still reproduces the issue. This CL early returns in all PaymentRequestSheetController's Update...View functions when the PR is being aborted. Bug: 1165624 Change-Id: Ie6f8f8ff6e72ef16878aa8dc3f15e19dea1587e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635074Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#844843}
-
Scott Violet authored
This test shuts down the session service part way through, and then recreates it. The second service ends up with a different task runner (because each session service has its own). This means it's possible for the second one to try reading files that haven't been finished writing. At least that's my theory as to why this test is flaky. I couldn't repro this locally, so this is a best guess. BUG=1154345, 1158715, 1166756 TEST=test only change, SessionRestoreTest.NormalAndPopup Change-Id: I7bf5ea96134179f607ffcf9d882b6bc7b2277da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634013Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#844842}
-
Ben Mason authored
This reverts commit 70b75301. Reason for revert: Incorrect multiple uses of PRODUCT_NAME (crbug.com/1168172) Original change's description: > Update BrowsingDataLifetime policy description > > Update policy description of BrowsingDataLifetime policy to make it more > informative while cutting down on the technical details and complexity. > > Bug: 1163584 > Change-Id: I2764fbf7651625667b9199136f17ea6dc709ae41 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630865 > Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844217} TBR=pastarmovj@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,igorruvinov@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1163584 Change-Id: I80834322e3715c917da54015b70b211d3d70feb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637582Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#844841}
-
Sorin Jianu authored
It would be nice to have a group target that builds all the targets in the chrome/updater so it is easier to build everything locally, when needed. Bug: 1167572 Change-Id: I4ee56b21cd4d461bf7bded3b8dcb5ffc2dce3c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635110Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844840}
-
Jeroen Dhollander authored
This allows us to use prerecorded audio files as Assistant input. Note that the |fake_input_device.cc/h| files are currently copied from the chromeos/services/assistant/platform directory, but they will be removed from there in a follow-up CL (when they are no longer used). Bug: b/171748795 Test: Compiled Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I3f7fa20798885df599db51310a5d6e87e36e6fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605243 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#844839}
-
Jérôme Lebel authored
Making sure there is no unexpected calls to ObserverBridgeDelegate. Bug: 903396 Change-Id: I24861862d71cb361081a1c1dd4f36972448bf98c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632676 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#844838}
-
Stephen McGruer authored
Based on my testing[0], this is a reasonable sweet spot before performance gains diminish substantially (and then actually start to regress near 40 processes). Long term, we should consider the user/bot's cpu_count and calculate something like that, but for now this brings our shard time down from nearly 300m to ~130m. [0]: https://docs.google.com/spreadsheets/d/1hMIoOB1oaC9iyWK5GEy5xIwUJLoDRaI77ReJ1lKjpZk/edit#gid=0 Bug: 1023835 Change-Id: Ifccb39af65f8ac9e785818b3e4cf27138dc61d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633371Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#844837}
-
Toby Huang authored
Legacy supervised users are now deprecated. This CL removes some dead UI code and strings. Bug: 1164090 Change-Id: I895ad42c4c336889aebb57112ca80ef622594e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625803 Auto-Submit: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844836}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 193 histograms that show frequent access in the past 90 days. These are the 95% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-04-19. TBR=chromium-metrics-reviews@google.com Change-Id: Idf34b3691926880bad0be2a5f1c23486d47f297d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638093Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#844835}
-
Wez authored
Include "fallback" languages in the "sec-ch-lang" and "accept-language" headers rather than relying on generic language fallbacks. This allows language/locale combinations that are less commonly supported by sites to be substituted with more appropriate commonly-supported combinations than would otherwise be possible. Bug: 1092804, 1164990 Change-Id: I7827ecbc24c0d2745e53a7c50af01b2c0cda0773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632757 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844834}
-
Moe Ahmadi authored
This code is under active development and these are useful metrics for monitoring regressions. Fixed: 1125723 Change-Id: I6667830a5bac7671624764d5b909c37f11070a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631364Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844833}
-
Marc Treib authored
Most of these were set to expire with M90. As the launch is still ongoing, we'll need these for a bit longer. By M95, we should be able to judge which of these we'll need long-term and which can go away. Bug: 1165277 Change-Id: I03b733fb7f3086af7bf1a356217f77e2af84a991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635155Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Sinan Sahin authored
This is a reland of 6a340039 The SingleActionMessageTest was failing on an L bot because Mockito couldn't mock WindowAndroid because it has a Display.Mode member, which is only available on M+. This reland replaces the WindowAndroid with a Callback<Animator> since we only need one method from that class. Original change's description: > [Messages] Fix clipping of message banner because of SurfaceView hole > > This CL delegates the Animator#start calls in MessageBannerMediator to > WindowAndroid#startAnimationOverContent. > > Bug: 1159429 > Change-Id: I865e62718efa46eae8e1bf733271854475edaa00 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628497 > Commit-Queue: Sinan Sahin <sinansahin@google.com> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Pavel Yatsuk <pavely@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843685} Bug: 1159429 Change-Id: I325340cb845809e963c9df50b217aa9d6f70849e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633526 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#844831}
-
Jeroen Dhollander authored
Bug: b/177328928 Test: compiled and deployed Change-Id: I56b03581f2299812e8114d09f76bd56c44fdcf51 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617516Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6cdb67fb33ed..5eb527cf7fb2 2021-01-19 glahiru@webrtc.org Replace sigslot usages with callback list library. 2021-01-19 tommi@webrtc.org Add DeliverPacketAsync method to PacketReceiver. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7b23c1012e96a85d40e9aa648031da0cf299dd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638003Reviewed-by:
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 15 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2021-04-19. TBR=chromium-metrics-reviews@google.com Change-Id: I89c74efd5548b911e399a790e7f774225372b8bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637258Reviewed-by:
-
Clark DuVall authored
This reduces the base dex size in trichrome by 0.5MB, which should help both memory usage and startup time in child processes with isolated splits enabled. Unfortunately we can't do the same for monochrome at the moment because WebView still needs the full content_java target. Bug: 11674041 Change-Id: I2aa3ba17ef97ab311e23f3ab8f0c0340cee9bfe7 Binary-Size: The method count is inflated because methods are moving Binary-Size: from the base module -> chrome module, and it doesn't look Binary-Size: like these are counted right. The increase in Binary-Size: Combined_unique methods is only +13. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634009 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
