- 30 Jan, 2020 40 commits
-
-
Mikel Astiz authored
Local sync metadata belongs to one user account. Due to the distributed nature of the locally persisted sync metadata, the cache GUID is used as "epoch" to detect mismatched in edge cases like the browser crashing during shutdown and before I/O gets flushed. However, prior to this patch, the cache GUID itself has no safety mechanism to detect it maps to the intended account ID. In this patch, a new SyncPref is introduced to achieve that, in away that both prefs (cache GUID and account ID) are stored atomically. Because the pref is newly-introduced, migration logic is introduced to populate it for the first time if initially empty. Change-Id: I2cdd9f997077c4acd16e9283df8c025f51d40546 Bug: 1046237,1021527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023528Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#736848}
-
Miyoung Shin authored
This is a follow-up CL of https://crrev.com/c/2014720 and adds browser test for PermissionServiceContext after the renderer crashes. Bug: 1036779 Change-Id: I2304622adcc002ed73e4aa4efdf57feca1390430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026561 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#736847}
-
Simon Zünd authored
This CL re-writes a breakpoint web test using a new SourcesTestRunner helper introduced in https://crrev.com/c/2027427. This should not only prepare the test for the upcoming source map asyncification but also reduce the overall flakiness of breakpoint web tests. R=sigurds@chromium.org Bug: chromium:1032016 Change-Id: Id42223f38ec2a3ea68605948f91b45939a0618eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027335 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#736846}
-
Dominique Fauteux-Chapleau authored
Now that the access point is used for something more than just metrics, it should be clear that the existing values should not be used again for other purposes. Change-Id: I92eeba7e9c2ea2605b3d58476a414355f53de6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028167Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#736845}
-
Tommy Steimel authored
This CL adds the Kaleidoscope Closure compilation to the webui_closure_compile target. Bug: 1046370 Change-Id: I779bc88edffda6b722fd049bccbbb071a37eb271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026368Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736844}
-
Finnur Thorarinsson authored
On Android P the onCompletion callback isn't called if the video is super short (like fraction of a second). Bug: 1046347, 895776, 656015 Change-Id: I77673d3045a4b5a89b679a0bc2cef34ab0bedb88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027789Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#736843}
-
Ioana Pandele authored
This reverts commit 19b7b019. Reason for revert: Likely causing failures for TabHoverCardBubbleViewBrowserTest.WidgetNotVisibleOnClick TabHoverCardBubbleViewBrowserTest.WidgetNotVisibleOnMousePressAfterTabFocus on Linux MSan Bug:1047172 Original change's description: > [Tab Groups] Implement time to switch histogram. > > Records the amount of time in ms from the cursor entering the tabstrip > to tapping on a tab to switch. > > Bug: 1040657 > Change-Id: I438f53c3d3a83cead9a3feb0c62356e1322cf1c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023396 > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Connie Wan <connily@chromium.org> > Commit-Queue: Charlene Yan <cyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736721} TBR=jwd@chromium.org,cyan@chromium.org,connily@chromium.org Change-Id: Iff213feb375e247f59ce79c72616abaf164a35d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030664Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#736842}
-
Jazz Xu authored
This CL ensures the global media controls knows whether to show PiP button. Bug: 1045903 Change-Id: I9a9c680dd624c4e25a5c5ad757598c2a0ddaea3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021568Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736841}
-
Oriol Brufau authored
A DCHECK added in r659369 was supposed to check that list markers can have at most 1 child. However, it was actually checking that either there is no children or the first child has no grandchild. This patch fixes the DCHECK and moves it below, since nowadays markers with non-normal content may have more than 1 child. BUG=457718 Change-Id: If742a49ed6ac232644ae99efbf8ad16ccbacc8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028773Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#736840}
-
Clemens Arbesser authored
This CL allows the backend to specify how the autofill_assistant should summarize contacts. If the backend does not specify the new fields, autofill_assistant will fall back to the current default. Bug: b/146114527 Change-Id: I0913a427e84f95e8b8745fe135c3cffc8e26dad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027471 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#736839}
-
Vadym Doroshenko authored
Bug: 1042196 Change-Id: I82441af46e4c1a2e0e547ae47c0c9d5d79ddb90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029514 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#736838}
-
Andrew Grieve authored
Bug: 726475 Change-Id: I6cc99d0d721c1f94203d2b9461e72ce2239b6a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029261 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Simon Que <sque@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#736837}
-
Samuel Huang authored
Previously, if a failed DevUI DFM install attempt (leading to the error page) is followed by a successful install, then the following problems arise: (A) chrome.send() is unavailable for the loaded DevUI page. (B) Addition refreshes trigger CHECK() and crashes browser. It seems that between showing the error page and showing the DevUI page (after successful install), some stale state persisted so that the active instance of NavigationRequest has bindings() holding a value without BINDINGS_POLICY_WEB_UI, so that chrome.send() would not load, leading to (A). Then (B) is triggered as an after effect. This CL is a work-around for the bug for the DevUI DFM. On initial DevUI DFM install, instead of resuming navigation to the intended DevUI page, we visit a small shim page that self-refreshes, so that stale states are cleared. This is not a full fix, since state staleness problem (and crash on refresh) still exists for error pages (in history or other tabs) other than the one that successfully triggers DevUI DFM install. Bug: 1046159 Change-Id: I775491ee165e7d2a809d93d334f93ae4bbf72cb6 Fixed: 1046159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028363 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
This removes the border and shadow around the smart card PIN dialog (the <security-token-pin> Polymer element) when it's shown during OOBE. Bug: 1024251 Test: powerwash Chromebook, enroll under policies with smart card support, start smart card login, check that the PIN dialog has no border or shadow Change-Id: I4355663bbc4f6de60512876282d7fbbf0e82e183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028772Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#736835}
-
Hans Wennborg authored
Bug: 1045592 Change-Id: I12461062f80c114c811858410328de3f06a0033c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028767 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#736834}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cf0595234cf2..81c7a60961cc git log cf0595234cf2..81c7a60961cc --date=short --first-parent --format='%ad %ae %s' 2020-01-30 phoglund@webrtc.org Fix public_deps presubmit and gn format fighting each other. 2020-01-30 phoglund@webrtc.org Make the dashboard upload script read protos instead of JSON. 2020-01-30 mbonadei@webrtc.org Replace some deprecated matchers. Created with: gclient setdep -r src/third_party/webrtc@81c7a60961cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029452 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id30f9d60135e3066b9c8ffd76702b5b3ff1a5d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030585Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736833}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/df2dbba832ad..38ebf200171d git log df2dbba832ad..38ebf200171d --date=short --first-parent --format='%ad %ae %s' 2020-01-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@38ebf200171d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia7253a49fff76a71b92f0b7f1b92b4def95e5cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030130Reviewed-by:
-
Ioana Pandele authored
TBR=johnchen@chromium.org Bug: 1047164 Change-Id: I9f9399ac8f0c4a4a62163e2bb91005f633ebbbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030527Reviewed-by:
-
Mikel Astiz authored
Bookmarks created before 2015 may run into item ID duplicates across devices, so it's not appropriate to dedup based exclusively on the originator client item ID, unless it's a GUID. Change-Id: Ic338fcea59246f2cf4b1f2d7b43b3c4f69c7a1dc Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030407 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
Moving all enums into: ui/authentication/signin/signin_enums.h Bug: 971989 Change-Id: Ie19d7b5db58a8387c640b2d11e5b63b265bb73c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028130Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736829}
-
Michael Hablich authored
This is a roll-back to 8.1.307. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org Change-Id: I85ae6732d8d5869ef68d39aa9481ae6a974d6963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030409Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Auto-Submit: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#736828}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I34af891c79b76867c63adc768e950cb27406d10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030331Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736827}
-
Nicolas Ouellet-payeur authored
The buildbot linux-annotator-rel turned red [1] after this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2012950 extractor.py doesn't like that we use a constant instead of a string-literal in DefinePartialNetworkTrafficAnnotation. This CL simply replaces the constant with a string literal. [1] https://ci.chromium.org/p/chromium/builders/ci/linux-annotator-rel/20744 Bug: 1046794 Change-Id: Iee31bfcdbb2f860b96493a154858cf391b4922ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028288 Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
Robert Flack authored
This adds a WPT test verifying that CSS animations are composited in the order of their name within the animation-name property. Bug: 1045835 Change-Id: I8e746e1841cd4f5ca55e3e067762c2ea93e5c101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022616 Auto-Submit: Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#736825}
-
Tim Volodine authored
Add instrumentation tests for web geolocation api in weblayer. This uses the private version of the WebLayer i.e. TestWebLayer. In particular: - Add aidl and the necessary methods to the TestWebLayer in order to mock-out the geolocation provider and related methods (i.e. setMockLocationProvider and isMockLocationProviderRunning). - Use "weblayer-fake-permissions" switch to enable fake permissions delegate. - Add tests for: getCurrentPosition, watchPosition, tab destruction and insecure origins. BUG=1025625 TEST=run_weblayer_private_instrumentation_test_apk -f GeolocationTest* TBR=blundell@chromium.org Change-Id: Id420ca4a64618e62cd85b46d7759a8c4cd760bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017427Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#736824}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f5303c91c16a..8d2b593996f3 git log f5303c91c16a..8d2b593996f3 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 fmayer@google.com Fix incorrect comment about kError. Created with: gclient setdep -r src/third_party/perfetto@8d2b593996f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I60ed54210cae4767a80236864053af8d1bf1e875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030129Reviewed-by:
-
Guido Urdaneta authored
This feature is not supported on Android, so it is better not to expose it so that JavaScript-side feature detection works correctly. Bug: 1038244 Change-Id: I3faf65062113e164ef37995bc6a556227f72b5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030466 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Marko Ivanovich authored
In case of simplest tests RegisterFrom(Un)ControlledDocument, message from service worker about tag being removed, is sent before promise passed to waitUntil is resolved. There is no guarantee that the tag will be removed before test requests list of tags. So this is race condition, that can be easily verified by adding sleep call to WaitUntilObserver::OnPromiseFulfilled, simulating thread interruption by OS scheduler. That is why we should not expect tag to be removed after we have received message about its removal, by actually wait for it. If test times out, it would fail. Similarly we should change some other tests, to make them future proof. Change-Id: I476acc1bececb01acb2d42db670af1a6cb5afa7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022665Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#736821}
-
Ioana Pandele authored
This reverts commit 9c9b70f9. Reason for revert: This CL causes HomescreenDragTest.DraggingPerformance to be flaky. Bug:1047135 Original change's description: > Disable window dragging from top in tablet mode. > > But tab dragging is still kept enabled. However, it will not be visible > to the user from M81 since they have mohnstrudel (#webui-tab-strip) > enabled. If mohnstrudel is disabled from chrome://flags, then the user > should still be able to do tab dragging. > > Bug: 1041928 > Change-Id: I2bfd2cc677ee82d9088006614ecb4f0d21b61cea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025574 > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736124} TBR=xiyuan@chromium.org,xdai@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1041928 Change-Id: I9b402bac48834fbbf7cb7f431dc88f6e28f7ebdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030486Reviewed-by:
-
Maksim Sisov authored
The observer is redundant and not needed anymore. Thus, remove it. Also, make GlobalCommandsApiTest.GlobalCommand use a normal path instead of waiting for window mapping. This seems to be working fine like that. Bug: 1043089 Change-Id: I9fc6bd8714f143a8a1ecd3871a70b2041ba940e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018942 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#736819}
-
Bret Sepulveda authored
This patch also fixes a race revealed by the new test. When the extension was uninstalled, ExtensionHostQueue::ProcessOneHost would race with ExtensionHostQueue::Remove (called from ~ExtensionHost), and if the former won it would crash trying to get the missing extension's ID. This patch ensures that ExtensionPopup immediately destroys its owned ExtensionHost when the extension is uninstalled, avoiding the race. Bug: 984654 Change-Id: Ib811a6fca559129f235e00f6091086cf7f2f968f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980613Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#736818}
-
Adam Rice authored
Implement the SendStream interface and OutgoingStream mixin from the WebTransport specification. Implement the QuicTransport createSendStream() method to create a SendStream() object. SendStream is trivial as all interfaces are inherited from OutgoingStream. A new interface, WebTransportCloseProxy acts a bridge between QuicTransport and OutgoingStream. It abstracts away that a single stream_id can be shared between an IncomingStream and OutgoingStream in the case of a bidirectional stream. Also add a browser test for the new API. Bug: 1011392 Change-Id: I68731e606527d5dd94d54f9bfed05a22fde4d59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024393Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#736817}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1cf15bfe55a3..cf0595234cf2 git log 1cf15bfe55a3..cf0595234cf2 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 eshr@google.com Move quality scaler into adaptation module Created with: gclient setdep -r src/third_party/webrtc@cf0595234cf2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I52f3482096e2ff2fd279df1a036c5f6415b9ec8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030128Reviewed-by:
-
Adam Rice authored
According to the Fetch Standard, attempting to create a Request object with a body that is a ReadableStream and the keepalive flag set should throw a TypeError exception. Make it do that. Since we don't yet support upload streaming, this doesn't make much functional difference, but it lets us pass the external/wpt/fetch/api/request/request-keepalive.html test. BUG=973659 Change-Id: Ib3919d28a99691cfdde640b2dfb9e695b9e0c8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030349 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
python client is being deprecated. Bug: 984869 Change-Id: I94a7445b903d8806fe520788998e1e0e4b96326c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029566 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#736814}
-
David Roger authored
Before this change, any account added during the extension consent flow was not going through Dice, and thus was not properly added to Chrome. This prevented the account to be properly managed, and in particular it was not possible to refresh the access tokens. This CL attaches Dice headers to requests coming from the extension consent flow, and the account is now added to Chrome. Other guest web views (such as the InlineLoginUI) are still ignored by Dice. It is unclear whether they really need to be ignored, but to minimize the change, this CL doesn't modify this behavior. Change-Id: I869ab5e699b7ee6cb556c17555be502893e3ea67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954387 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#736813}
-
Wenbin Zhang authored
From Pinpoint, end user can launch a job by selecting a benchmark together with a story or a story tag. Though, there's no way to run all stories of a benchmark. The reason behind this is that Pinpoint does not have enough devices so it wants to limit the duration of each job. However, some benchmarks are small and it won't be a big load even running all of their stories. Per Blink team's request, this CL adds "all" tag to two of its benchmarks: blink_perf.dom Bug: chromium:1023451 Change-Id: I334e3d3157b3c29c94e3de342d4d5e060948f712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028120Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#736812}
-
Alice Wang authored
This CL added some checks before the personalized bookmark signin promo is shown and refactored some related code. Bug: 1045480 Change-Id: I408e3e9a90c1c188fd77ab8ddd94158d259313ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022786 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#736811}
-
Colin Blundell authored
When Chrome's captive portal detection service is enabled (as it is on Linux), its SSLErrorHandler requires that CaptivePortalTabHelper be available off of WebContents. This CL makes CaptivePortalTabHelper in this context in WebLayer as preparation for sharing //chrome's SSLErrorHandler in //weblayer. Bug: 1030692 Change-Id: Ib5c2fb5ed2fee54204f32c18a146dfad3a45b428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024851 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#736810}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 60fd8cd3. With Chromium commits locally applied on WPT: b292a7b8 "Separated willValidate check in HTMLInputElement::validationMessage" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib5246995770bf8d84f21b559e9362736d0bbefd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028475Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736809}
-
