GitLab

BUG=76250
TEST=see bug

R=sky@chromium.org

Review URL: http://codereview.chromium.org/7575004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96182 0039d316-1c4b-4281-b951-d872f2087c98

If switched on via a command line flag, the new version of the
enrollment screen is enabled. It uses the authentication extension,
which will fetch an OAuth token that is then used to register for device
policy.

BUG=chromium-os:18203
TEST=Enable flags and test enrollment.

Review URL: http://codereview.chromium.org/7562008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96181 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7497066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96179 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7605024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96177 0039d316-1c4b-4281-b951-d872f2087c98

R=altimofeev@chromium.org
BUG=chromium-os:18916
TEST=Sign in as a new or existing user with different images chosen. Change picture to different ones. Check that each time the appropriate histogram is updated at chrome://histograms.

Review URL: http://codereview.chromium.org/7590002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96176 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96175 0039d316-1c4b-4281-b951-d872f2087c98

R=danno@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7606027

TBR=kmillikin@chromium.org
Review URL: http://codereview.chromium.org/7608025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96174 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96173 0039d316-1c4b-4281-b951-d872f2087c98

R=danno@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7606027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96172 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96171 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7605006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96170 0039d316-1c4b-4281-b951-d872f2087c98

Note: This was a TODO for akalin.

BUG=None
TEST=None

R=akalin@chromium.org

Review URL: http://codereview.chromium.org/7497051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96169 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=try

Review URL: http://codereview.chromium.org/7608019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96168 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96167 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7608021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96166 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92297
TEST=None
TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/7607030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96165 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92292
TEST=None

Review URL: http://codereview.chromium.org/7604030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96163 0039d316-1c4b-4281-b951-d872f2087c98

is selected so that input methods don't eat keyboard shortcuts.

BUG=80772
TEST=manual

Review URL: http://codereview.chromium.org/7554005

TBR=bashi@chromium.org
Review URL: http://codereview.chromium.org/7604029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96162 0039d316-1c4b-4281-b951-d872f2087c98

Some general notes:
 - It's a lot of code for a single review, about 1.5K lines (plus tests, plus those generated docs, = 3.5K).  Apologies.  But it's close to the minimal amount of useful functionality.  I've left some TODOs in the code to fix up soon.
 - No integration-style tests, but I'll start writing those now.  Works from within a browser though.
 - Sync not hooked up yet, of course.
 - Ditto events.
 - Ditto thinking about incognito mode.
 - Ditto fun bugs like what happens if you set key "foo.bar" to "baz".
 - This is the first significant amount of C++ code I've ever written... so don't hold back.
 - The docs (i.e. my changes to extension_api.json) are a little incomplete, and I'm aware of that.

A summary of the implementation:
 - There is an ExtensionSettings factory-type object which hands out ExtensionSettingsStorage areas for extensions.  You may notice that I basically did the same thing that ExtensionPreferences does (so, lives with the profile, etc).
 - ExtensionSettingsStorage is a pure interface, with three implementations.
   - the main leveldb implementation.
   - a caching decorator, designed to sit on top of the leveldb implementation.
   - a "no-op" implementation which gives a trivial in-memory storage area when wrapped with a cache.  This is used in the cases where the leveldb database fails to initialise (ExtensionSettings handles this).
   -  and note that my plan is, when hooking up sync, that this will be implemented as another decorator.
 - ... the code is pretty well documented so not much else to say.

For testing, turns out gtest is pretty snazzy.  There are a bunch of test fixtrues in extension_settings_storage_unittest.h, so that 3 different configurations are tested: leveldb, leveldb + cache, and no-op + cache.

BUG=47327
TEST=unit tests provided


Review URL: http://codereview.chromium.org/7189029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96159 0039d316-1c4b-4281-b951-d872f2087c98

R=hashimoto@chromium.org
BUG=chromium-os:18955
TEST=Manual


Review URL: http://codereview.chromium.org/7607028

TBR=zork@chromium.org
Review URL: http://codereview.chromium.org/7497059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96158 0039d316-1c4b-4281-b951-d872f2087c98

R=hashimoto@chromium.org
BUG=chromium-os:18955
TEST=Manual


Review URL: http://codereview.chromium.org/7607028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96157 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96156 0039d316-1c4b-4281-b951-d872f2087c98

The older code could screw up pending_operations_ in QuotaFileIO when another Write is issued in WriteCallback.  This patch is to fix the issue by always firing callbacks asynchronously.

BUG=86556
TEST=test_shell_tests:QuotaFileIOTest.*

Review URL: http://codereview.chromium.org/7508010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96154 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96151 0039d316-1c4b-4281-b951-d872f2087c98

is selected so that input methods don't eat keyboard shortcuts.

BUG=80772
TEST=manual

Review URL: http://codereview.chromium.org/7554005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96149 0039d316-1c4b-4281-b951-d872f2087c98

Also:
 * fixes drop-down buttons layout.
 * overlay for catching outside the menu clicks is implemented (mimics standard select control behavior).

BUG=chromium-os:18826
TEST=manual

Review URL: http://codereview.chromium.org/7550070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96147 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18897
TEST=Turn on accessibility on the OOBE screen by pressing Ctrl+Alt+z.  Continue to the update page.  Ensure that it's spoken.

Review URL: http://codereview.chromium.org/7606021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96146 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7605025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96145 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92267
TEST=Ran PhishingTermFeatureExtractor unittest under valgrind.

Review URL: http://codereview.chromium.org/7604022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96143 0039d316-1c4b-4281-b951-d872f2087c98

On Windows, when linking non-incrementally the functions that call the
CrOS-only code are dead-stripped so there's no error, but with incremental
linking the link fails.

BUG=92171
TEST=Links on all platforms


Review URL: http://codereview.chromium.org/7497040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96141 0039d316-1c4b-4281-b951-d872f2087c98

R=dmazzoni
BUG=chromium-os:14804
TEST=Press ctrl+alt+z on the OOBE screen to enable accessibility.  Continue to the Terms of service page.  Press tab to move focus to the DOM view.  Press shift + space + down to navigate the EULA.  Ensure that it's spoken.

Review URL: http://codereview.chromium.org/7609001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96136 0039d316-1c4b-4281-b951-d872f2087c98

Extracted
- ProfileImpl::spellcheck_host_ready
- ProfileImpl::spellcheck_host_
- ProfileImpl::spellcheck_host_metrics_
into newly created SpellCheckProfile.
This is a preparation for implementing SyncableService.

TEST=SpellCheckProfileTest.*
BUG=none


Review URL: http://codereview.chromium.org/7583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96135 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/7607012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96134 0039d316-1c4b-4281-b951-d872f2087c98

There are cases where Gaia authentication passed but login still fails, e.g. using a valid Google account that is not in whitelist. We want to reset Gaia UI with an error message when this happens.

BUG=chromium-os:18801
TEST=Verify fix for chromium-os:18801.


Review URL: http://codereview.chromium.org/7607019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96133 0039d316-1c4b-4281-b951-d872f2087c98

Manually unfreezes hosting window until WebUI OOBE/Login tab is rendered the first time to avoid the white screen when transitioning from boot splash.

This CL is based Oshima's r88345 and I have left a TODO to merge the logic.

BUG=chromium-os:18501
TEST=Verify fix for chromium-os:18501.


Review URL: http://codereview.chromium.org/7607011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96132 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92121
TEST=unit_tests --gtest_filter=FormStructureTest.*Autocompletetype*; browser_tests --gtest_filter=FormManagerTest.WebFormControlElementToFormFieldAutocompletetype


Review URL: http://codereview.chromium.org/7602006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96131 0039d316-1c4b-4281-b951-d872f2087c98

Adds suppressions for leaks in ppapi::VarTracker.

BUG=92279
TEST=Valgrind bots go green.
TBR=brettw@chromium.org

Review URL: http://codereview.chromium.org/7606022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96130 0039d316-1c4b-4281-b951-d872f2087c98

Adds further suppressions for PhishingTermFeatureExtractorTest.

BUG=92267
TEST=Valgrind bots go green.
TBR=gcasto@chromium.org

Review URL: http://codereview.chromium.org/7604026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96129 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=rsleevi

Review URL: http://codereview.chromium.org/7590019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96128 0039d316-1c4b-4281-b951-d872f2087c98

views-desktop: Add the desktop-window as an observer for a widget when it gets added to the desktop.

This fixes sending keyboard events to the browser in views-desktop.

TBR=sky@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7604024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96126 0039d316-1c4b-4281-b951-d872f2087c98