- 28 Dec, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e43f269e7aa6..e53a07e855c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC awscreen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: awscreen@google.com Change-Id: I049e236dfa4543b2029d29b55c26e729bebe3bee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605005Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839482}
-
Shubham Aggarwal authored
Migrate uses of the relevant set_* functions on the sql::Database object to use the new DatabaseOptions constructor instead. This change should have no intended behavioral effect. Bug: 1126968 Change-Id: Ia277a910bcc837e89aabdbb26c7a14bfbc0cdaad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595188Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Cr-Commit-Position: refs/heads/master@{#839481}
-
Paul Moy authored
When a client requests PolicyInfo, but Chrome's service hasn't collected any policy info from the device yet, a nullptr is returned. This currently causes an unexpected null validation error in Mojo on the client. Fix this by marking PolicyInfo optional and checking for nullptr in the client before using the returned PolicyInfoPtr. Bug: b:175792552 Change-Id: I409a83364434201c55039078ad9d183bd160cb56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597905 Commit-Queue: Kyle Williams <kdgwill@chromium.org> Reviewed-by:
Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#839480}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c8d5277e86ee..0eb61724c8f1 2020-12-28 jiawei.shao@intel.com Enable CompressedTextureFormatTests on Win/Intel/Vulkan If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: Ia8c0bff72f9c462f28f2e3614e7e4df2eaa78a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605428Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839479}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7a1af10b707b..2813dd74be34 2020-12-28 yueherngl@google.com volteer: add firmware-volteer-13672.B branch builder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I185adaa8867c170fac1a7743185958922eb806e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605427Reviewed-by:
-
Alex Newcomer authored
UX/PM want to see how often placeholder strings are shown in Clipboard History. We may design a better solution if they are seen a lot. Bug: 1156837 Change-Id: If96e86d244cd05abcbd098ea19e9af0234928046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590753 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#839477}
-
Allen Bauer authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Bug: 1159563 TBR: tbergquist@chromium.org Change-Id: Id0cccd96111f5c660bc839e81b40da2ecf72da10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597542 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#839476}
-
Ryan Sturm authored
Previously, this code assumed that OnComplete would only be called after OnReceiveResponse, but it can be called before that as well in the case of a network failure. Change-Id: I86072c1bd0e05521f2688ad1270e5b7246875676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602708Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#839475}
-
Andres Calderon Jaramillo authored
Bug: None. Test: None. Change-Id: I6e9a80823fbc14d93edaecc42b0eea9d5f5d5c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601067Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#839474}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I63c845b18ce21b9195f4a5f059d85562434a2fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605325Reviewed-by:
-
Kyle Williams authored
Bug: b:175644742 Test: N/A Change-Id: I64b50791912d8a74a590459f6038bafa6522c6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605346 Auto-Submit: Kyle Williams <kdgwill@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#839472}
-
Min Qin authored
There are 300 QPS for tiles now, not sure why is it happening. Adding more restrictions are tile fetching. Change-Id: Ie513364d0a072abc3f3d92ae1f09b404bf5df161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601259Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839471}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609156644-42cb6a035b1fe5a631f9a5a0f3f4dab0f809ccfe.profdata to chrome-linux-master-1609173530-a51a44ea42c1ce639e5f65da47d34d0f960968de.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic1f42abcdbb9dfada6297a4a5d2abc1e2b04b415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602863Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a29c88f5..48107c9a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1e9d3b277452df339389729f0111b98ffd70e6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605287Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839469}
-
Jao-ke Chin-Lee authored
BUG=chromium:1062407,b:175909299 Change-Id: I6cb71aa9f13f252bde352a4b558acef1eb354a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601546Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#839468}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609156644-74221c569e797d96fdd58cd45c2be34f02342fb7.profdata to chrome-mac-master-1609173530-9c0c14935df28154f2fe482e167ffd7e8e9a643c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I733549e22e09b9c46f4f3eed960ea3be2d07f6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605433Reviewed-by:
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 87.0.4280.132. R=rmhasan@google.com, tikuta@chromium.org Bug: 1041619 Change-Id: I1bb3dee68f804ab903cba4f8d2a545d52abf0112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602664 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#839466}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.66. R=dpranke@google.com, rmhasan@google.com Bug: 1041619 Change-Id: I1e2579f3dd6ed0b5c8812a16a88a5d57a147f3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602666 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e44afbebcfce..e43f269e7aa6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC awscreen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: awscreen@google.com Change-Id: I88066bb91a5e5b69a084073a1bf7b6b89dfab72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605444Reviewed-by:
-
Ramya Nagarajan authored
Change-Id: I74152abbf1bd6851266fd5c14a3788d595a4ac8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601745Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#839463}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a82fd9788066..05f83d8d5771 2020-12-28 bmeurer@chromium.org [wasm] Don't look into "imports" / "exports" for mouse hover. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1071432,chromium:1162069 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic2ffc4171c59f687e6b9151d1fba0a72a80beb3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604155Reviewed-by:
-
Hui Yingst authored
In OutOfProcessInstance, private methods OnGeometryChanged() and SetZoom() and the local variable `kMinZoom` will be used for drawing graphics by PdfViewWebPlugin in the future. This CL migrates these methods to PdfViewPluginBase as protected methods and moves the definition of `kMinZoom` to PdfViewPluginBase, so that they can be shared by both plugin instances. Bug: 1140629 Change-Id: I4016bf05871c2112b653ce0e043261c94580c534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602518 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#839461}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/70019c6085b5..b5d30dc4142c 2020-12-28 rmistry@google.com Update remaining Skia docs to point to new inclusive rotations 2020-12-28 rmistry@google.com Update rotation docs with inclusive names and point to new rotations 2020-12-28 rmistry@google.com Update task drivers to point to new rotations 2020-12-28 brianosman@google.com Add/test integer versions of vector-relational intrinsics 2020-12-28 jcgregorio@google.com Add Pixel 5 tests to the tree. 2020-12-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c6e63da8ed53 to 5e606e5bfce2 (1 revision) 2020-12-28 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2020-12-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3aea2528 to 6fa6f0c8 (113 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: djsollen@google.com Change-Id: Ie2204eac12dce6775128d9b1d5a284672d28b14c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604154Reviewed-by:
-
Jeroen Dhollander authored
This will prevent bugs from forgetting to take the lock. Bug: b/171748795 Test: chromeos_unittests --gtest_filter="Assistant*" Change-Id: I6571dba49671c7160b383921541f32261b17bd96 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601539 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#839459}
-
Jeroen Dhollander authored
This crash has been happening quite frequently since this summer (see crbug.com/1128031). The crash is at line 41: assistant_extra->url = web_contents->GetLastCommittedURL(); Given that we just created |assistant_extra| the line above, it must be that |web_contents| is invalid. |web_contents| is created at line 94: content::WebContents* web_contents = browser->tab_strip_model()->GetActiveWebContents(); It is surprising that this can be nullptr because we check at line 52 to ensure the browser is active (so you'd assume it has active web content). But irregardless, I added a null check after line 94. Bug: 1128031 Test: N/A Change-Id: Iaabdedf5bb133d608db75a16e96907cc18a0d960 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601276 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by: -
Jeroen Dhollander authored
This CL introduces an implementation of |assistant_client::PlatformApi| in the Libassistant mojom service. This initial implementation simply forwards all work to the existing |CrosPlatformApi| (in //chromeos/services/assistant/platform), but this will allow us to start migrating the individual components one by one to the Libassistant mojom service. This CL also changes the |CrosPlatformApi| so it no longer inherits from |assistant_client::PlatformApi|. This is again done so we can start removing components one by one away from |CrosPlatformApi|. Bug: b/171748795 Test: chromeos_unittests with filter "Assistant*:ServiceController*" Change-Id: I715d25fb13b128d31218ec8a3f727e19feae4bc1 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596254 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
-
sczs authored
The crash from 1145109 seems to happens due to an update from newSuggestionsInCategory triggering a layoutSubviews pass on Discover. Since ContentSuggestionsServiceObserver is used for the old content suggestions system (and not Discover's) this callback will now be ignored if the Discover feed is being used. Bug: 1145109 Change-Id: Iec40e155028f6406e702147371d208dc69471efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605284Reviewed-by:
Javier Flores <javierrobles@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#839456}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/07ae7a3efa65..e44afbebcfce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I12cc64e62e072051348ec40e460a6ded8706fc61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605205Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9a27566e0cbc..70019c6085b5 2020-12-28 kjlubick@google.com [canvaskit] Fix bug if webgl context not available If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: djsollen@google.com Change-Id: I1058633d7271218ea379a4a9cf8fa97eeb44e7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604971Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012280600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/KIiRm3KFqXZdpUq3U-M9LOzTpV0pmYVBi7D66Yc6yhwC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I4d564a846de94a7ed7ba7921c93bf0102033dc94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605204Reviewed-by:
-
Colin Blundell authored
This CL moves the implementation of ChromeSubresourceFilterClient::OnPageActivationDecision() to ProfileInteractionManager, with the former now just calling through to the latter. In subsequent work we will eliminate the callthrough to the client altogether, thus having this logic be shared with WebLayer. In this CL, however, there is no behavioral change. Bug: 1116095 Change-Id: I75d36824906a9869c177481a8c7f844f2f813064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597314 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#839452}
-
Alice Wang authored
This CL refactors the structure of AccountHolder to make it more convenient to use in tests. Bug: 1161437 Change-Id: I97e5c1b9d6ff577630f98c9ea6b219a7b8b9a8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602283 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#839451}
-
Shik Chen authored
This CL adds the metrics for 1. QR code toggle enabled event. 2. QR code detected event with the content type. Bug: b/172879638 Test: Manually Change-Id: Ia4ed19b83bb2970cef424949eb701ad46e72b685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603707 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#839450}
-
Sergey Poromov authored
Revert "DevTools: add a test for chrome.devtools.inspectedWindow.eval using correct execution context" This reverts commit 0e3033a6. Reason for revert: Consistently failing on Linux MSAN builds: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN First failure: https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20MSAN/8844/blamelist Original change's description: > DevTools: add a test for chrome.devtools.inspectedWindow.eval using correct execution context > > See also: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2602710 > > Bug: v8:11268, chromium:1101897 > Change-Id: If57b53a910afe8945453f35689b63168c076db7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602709 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#839375} TBR=caseq@chromium.org,bmeurer@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,pfaffe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:11268 Bug: chromium:1101897 Change-Id: Ie7aaebbd32400ffa5303774840eb7650c0cc1f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602428Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#839449}
-
Shik Chen authored
The barcode toggle is a one-time toggle and should not be preserved after switching modes. This CL would also fixs the mode icon over scan box issue. Bug: b/172879638 Test: Manually enable barcode toggle, switch to video mode and switch back to photo mode. Change-Id: Iaf3bc5341fb641ba5f1308d3883b661140d853e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602960 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#839448}
-
Camillo Bruni authored
- Bail out in ScriptStreamer::TryStartStreamingTask if the response is not a JavaScript mime type (for CSS and JSON modules) - Only initiate script streaming from the main thread (for now this prevents streaming compilation for workers and worklets) - Fix trace event ending for streaming compiled module scripts - Add WPT test with a large CSS module that would previously trigger script streaming Bug: 1061857 Change-Id: I5100e4c12aa3504ea4132b344f7910041270318a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595299 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#839447}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ced220f95690..a82fd9788066 2020-12-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-12-28 mathias@chromium.org Reland "Use AVIF for Node.js icon" 2020-12-28 mathias@chromium.org Use AVIF for CSS Overview icons 2020-12-28 janscheffler@chromium.org Revert "Use AVIF for Node.js icon" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1161667 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7351a8bea8ca9681dd2532e109f1382b629b3962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604968Reviewed-by:
-
Sergey Poromov authored
This reverts commit 78eb032e. Reason for revert: The test is consistently failing on Mac 10.15 and 10.14. First failures: https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/6926/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.14%20Tests/11879/overview Original change's description: > Add dark mode focus ring browsertests > > Focus rings are rendered differently in dark mode, so we need additional > pixel tests for dark mode. > > Fixed: 1067517 > Change-Id: I94ba8b86a03943b7d30cddd44a30ac2cc380e0ff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596019 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Yu Han <yuzhehan@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#839189} TBR=avi@chromium.org,masonfreed@chromium.org,jarhar@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,yuzhehan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I18cd9fbab4531d6811ad095f7938bbf8158d1f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603569Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609133446-028b26ae250e15c83ca9033b0db07ace7a263dfe.profdata to chrome-linux-master-1609156644-42cb6a035b1fe5a631f9a5a0f3f4dab0f809ccfe.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8c71353035d8a4624da938aced7a4d8eef67634e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604967Reviewed-by:
-
Regan Hsu authored
In OS Settings, if the user clicks "Set Up" in the "Connected devices" section to setup multidevice, the window will be brought to the front if it exists already. Fixed: 1157683 Bug: 1106937 Change-Id: Ic96bae2db13403d4274a7031861abc2592443ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600325 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
