GitLab

Refactor disk_mount_manager_unittest by replacing gmock with a dedicated mock class of DiskMountManagerObserver.

This change is based on
https://codereview.chromium.org/2333983004/
which was once merged but reverted by
https://codereview.chromium.org/2343593002/

BUG=641943
TEST=chromeos_unittest build with is_asan and is_lsan = true in gn args, and run with ASAN_OPTIONS="detect_leaks=1 symbolize=1" environment variable.

Review-Url: https://codereview.chromium.org/2341923003
Cr-Commit-Position: refs/heads/master@{#418811}

PR for DOM Standard is: https://github.com/whatwg/dom/pull/329

Note: Blink's IDL uses [Unscopeable], instead of [Unscopable].
I have filed a bug: https://bugs.chromium.org/p/chromium/issues/detail?id=647133.

Let me omit to add a layout test. It should be covered in WPT.

BUG=643869

Review-Url: https://codereview.chromium.org/2343783002
Cr-Commit-Position: refs/heads/master@{#418810}

BUG=636710

Review-Url: https://codereview.chromium.org/2340733002
Cr-Commit-Position: refs/heads/master@{#418809}

BUG=617056
TBR=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2331423006
Cr-Commit-Position: refs/heads/master@{#418808}

This CL fixes an issue where the CBD button would stay grey after the
CBD button was activated via spacebar.

BUG=640894
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2282403002
Cr-Commit-Position: refs/heads/master@{#418807}

I have mistyped the mixin name. Sorry.

BUG=645295
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2331423007
Cr-Commit-Position: refs/heads/master@{#418806}

It seems that for "group" labels GN does not include data of dependencies
declared as "deps", but it would be convenient if we could refer to
chromium_builder_perf group to query all the runtime dependencies of the
test binaries.  This change does not touch dependency logic, though: all
the prerequisites of chromium_builder_perf continue to build as before.

The runtime_deps of this target can then be used, e.g., to make archive
with all the files required to run all (telemetry-based and binary)
performance tests.

R=jochen,thakis

Review-Url: https://codereview.chromium.org/2337153002
Cr-Commit-Position: refs/heads/master@{#418805}

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599

Review-Url: https://codereview.chromium.org/2317123002
Cr-Commit-Position: refs/heads/master@{#418804}

Currently, invalidate_shadow_on_frame_swap_ is not set when a MacViews window is
shown. It is only set when the layer is created, changed or the window resized.
This causes translucent windows like the "Restore Pages" bubble and Find-In-Page
window to not have a shadow, when they are shown after being hidden.

This CL modifies BridgedNativeWidget::OnVisibilityChanged() to trigger shadow
invalidation while showing translucent windows. This fixes the shadow for the
"Restore Pages" bubble and also of the Find-In-Page window on tab switching. A
unit test is also added which demonstrates the problem.

Note that this does not fix the shadow for the Find-In-Page window when it is
displayed initially on pressing Cmd+F.

BUG=636707, 646734

Review-Url: https://codereview.chromium.org/2336983002
Cr-Commit-Position: refs/heads/master@{#418803}

Revert of Magnifier border is now more visible on light backgrounds. (patchset #8 id:180001 of https://codereview.chromium.org/2269383002/ )

Reason for revert:
Caused leaks in unit tests.

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/16164

=================================================================
==1214==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x647f4b in operator new(unsigned long) (/b/swarm_slave/w/irbU0iLK/out/Release/ash_unittests+0x647f4b)
    #1 0x18e142f in ash::PartialMagnificationController::CreateMagnifierWindow(aura::Window*) ash/magnifier/partial_magnification_controller.cc:323:31
    #2 0x18e1fd4 in SetActive ash/magnifier/partial_magnification_controller.cc:236:5
    #3 0x18e1fd4 in ash::PartialMagnificationController::OnLocatedEvent(ui::LocatedEvent*, ui::PointerDetails const&) ash/magnifier/partial_magnification_controller.cc:259
    #4 0x26cab42 in DispatchEvent ui/events/event_dispatcher.cc:191:12
    #5 0x26cab42 in ui::EventDispatcher::DispatchEventToEventHandlers(std::vector<ui::EventHandler*, std::allocator<ui::EventHandler*> >*, ui::Event*) ui/events/event_dispatcher.cc:170
<snip>

Original issue's description:
> chromeos: Magnifier border is now more visible on light backgrounds.
>
> Previously the partial magnifier border was difficult to see on white colored backgrounds. I add a textured layer instead of a solid color, so the border is outlined in black, so that it is visible on all backgrounds.
>
> BUG=638996
> TEST=none
>
> https://screenshot.googleplex.com/htWDLX1Bxdp
>
> Committed: https://crrev.com/da331ee46dfead28a5b2af2379f9fad320509957
> Cr-Commit-Position: refs/heads/master@{#418785}

TBR=jdufault@chromium.org,jamescook@chromium.org,sammiequon@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=638996

Review-Url: https://codereview.chromium.org/2344843002
Cr-Commit-Position: refs/heads/master@{#418802}

Currently the test passes even without the original fix for bug 611679
(https://codereview.chromium.org/1978793002/patch/40001/50002).
I checked that this CL makes the test proper again (it fails without
the bug fix).

Discussed in https://codereview.chromium.org/2225053002/
(see most recent comments).

BUG=611679
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2339133002
Cr-Commit-Position: refs/heads/master@{#418801}

If we're in flipped blocks writing mode (i.e. vertical-rl), the flow thread
block offset we're dealing with may be a logical end point, and end points are
exclusive. This means that we need to pick the previous column, not the next,
if the offset is exactly at a column boundary.

Let flowThreadTranslationAtOffset() and columnIndexAtOffset() take a
PageBoundaryRule argument to handle this.

This makes offsetLeft and offsetTop work properly in vertical-rl writing mode
for elements that end at column boundaries. Added a test for that, and threw in
a vertical-lr test too, for good measure.

Remove ColumnIndexCalculationMode from columnIndexAtOffset(). It was partially
and inaccurately used to make sure we didn't escape the valid column range in
case an exclusive end offset was passed. Have the call sites that really need
to clamp the column index do it themselves. It's up to the callers to decide
how to treat offsets outside the range of columns anyway.

Review-Url: https://codereview.chromium.org/2339973002
Cr-Commit-Position: refs/heads/master@{#418800}

Revert of [worklets] Introduce ThreadedWorkletMessagingProxy and AnimationWorkletMessagaingProxy. (patchset #8 id:180001 of https://codereview.chromium.org/2312493002/ )

Reason for revert:
Caused leaks in a number of layout tests.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/22941

Original issue's description:
> [worklets] Introduce ThreadedWorkletMessagingProxy and AnimationWorkletMessagaingProxy.
>
> This patch does the plumbing from the animationworklet to the globalscope to import scripts etc.
>
> BUG=567358
>
> Committed: https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8
> Cr-Commit-Position: refs/heads/master@{#418765}

TBR=nhiroki@chromium.org,hongchan@chromium.org,yhirano@chromium.org,majidvp@chromium.org,ikilpatrick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567358

Review-Url: https://codereview.chromium.org/2342013002
Cr-Commit-Position: refs/heads/master@{#418799}

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

This CL does two non-trivial changes in addition to the mechanical renaming and reformatting:
* In components/nacl/browser/pnacl_translation_cache_unittest.cc, and
* in chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc
the CL modifies the test code to keep track whether the ScopedTempDir was initialised and can vend the path, or whether it was not, and cannot be asked for the path. In both cases, before this CL, ScopedTempDir needed to trust the test code to not to store any files under the uninitialised path. After the CL, ScopedTempDir can assume that whenever it vends the path, files may be written under it, and the contract of not touching the uninitialised path stays limited to the test and the tested code.

BUG=640599
R=mseaborn@chromium.org, reillyg@chromium.org
TBR=rsesek@chromium.org, blundell@chromium.org, sergeyu@chromium.org

Review-Url: https://codereview.chromium.org/2318033002
Cr-Commit-Position: refs/heads/master@{#418798}

This CL also changes TestVolume::CreateRootDirectory to handle that GetPath()
(unlike path()) cannot be called before initialising the ScopedTempDir. Because
CreateRootDirectory apparently can be called multiple times from
FakeTestVolume, it needs to handle that and not initialise the directory twice.
On the other hand, the directory cannot be initialised from anywhere else, so
this CL made this clear by adding a Boolean member root_initialized_ which is
updated and checked by CreateRootDirectory. Using the Boolean member, unlike
just handling the fact that the directory has been already initialised (this
information is still possible to retrieve via Take()+Set()), makes it clearer
that the assumption is the directory only being initialised where also
root_initialized_ is set.

R=achuith@chromium.org
BUG=640599

Review-Url: https://codereview.chromium.org/2345473002
Cr-Commit-Position: refs/heads/master@{#418797}

Cr-Commit-Position: refs/heads/master@{#418796}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

Miscellaneous minor cleanups were applied.

BUG=637812

Review-Url: https://codereview.chromium.org/2341693002
Cr-Commit-Position: refs/heads/master@{#418795}

Removed ConnectionToClient::OnInputEventReceived(), which was never used.
Removed timestamp from VideoFrame protobuf: it was used only for perf
tests that have been removed.

Review-Url: https://codereview.chromium.org/2334293002
Cr-Commit-Position: refs/heads/master@{#418794}

This reverts commit d0125b8f.

Reason:
Warnings from ServiceWorkerGlobalScope doesn't show up in devtools' console

BUG=594160
TBR=eostroukhov, pfeldman

Review-Url: https://codereview.chromium.org/2344813002
Cr-Commit-Position: refs/heads/master@{#418793}

There isn't much support from platforms and devices for GATT over BR/EDR so
to avoid confusing users and wasting power, perform a LE scan only.

BUG=643625

Review-Url: https://codereview.chromium.org/2339033003
Cr-Commit-Position: refs/heads/master@{#418792}

Revert of Temporary: Detect WebSocket destruction order problem (patchset #2 id:20001 of https://codereview.chromium.org/2315213002/ )

Reason for revert:
We have learnt everything we are going to learn
from this CHECK. Reverting as intended.

This does not need to be relanded.

Original issue's description:
> Temporary: Detect WebSocket destruction order problem
>
> Add a CHECK() to crash the browser if a destruction order problem is
> encountered.
>
> This will be reverted once the information is collected.
>
> BUG=641013
>
> Committed: https://crrev.com/23169a0f5421e6759d89b1feaa83b06b197a7039
> Cr-Commit-Position: refs/heads/master@{#417522}

TBR=yhirano@chromium.org,mmenke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=641013

Review-Url: https://codereview.chromium.org/2340253002
Cr-Commit-Position: refs/heads/master@{#418791}

Revert of Set crash key if WM_QUIT message is received on GPU message loop. (patchset #2 id:20001 of https://codereview.chromium.org/2342713002/ )

Reason for revert:
Forgot key registration.

Original issue's description:
> Set crash key if WM_QUIT message is received on GPU message loop.
>
> Threads seem to be exiting unexpectedly, so to help debugging set a
> crash key if an unexpected WM_QUIT message is received.
>
> BUG=647068
>
> Committed: https://crrev.com/fafd9b39256b14f96283e5155d05e7f8f805689c
> Cr-Commit-Position: refs/heads/master@{#418753}

TBR=dcheng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=647068

Review-Url: https://codereview.chromium.org/2339123003
Cr-Commit-Position: refs/heads/master@{#418790}

Based on the experiments, ThinLTO does not scale beyond that,
and the default setting is the number of cores on a machine, which
is often 32 or more for Chrome devs, where ThinLTO is slower than at 16:
https://docs.google.com/spreadsheets/d/18vi9p8ffIYNVPTyxtJwr-YrP4WJRbaQr_2nZ1AKKBs4/edit?usp=sharing

BUG=645295

Review-Url: https://codereview.chromium.org/2341983002
Cr-Commit-Position: refs/heads/master@{#418789}

This is the first step in making this element usable by WebUI pages
other than MD History.

BUG=642200
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2282403005
Cr-Commit-Position: refs/heads/master@{#418788}

BUG=616322

Review-Url: https://codereview.chromium.org/2344793002
Cr-Commit-Position: refs/heads/master@{#418787}

BUG=402536

Review-Url: https://codereview.chromium.org/2340453002
Cr-Commit-Position: refs/heads/master@{#418786}

Previously the partial magnifier border was difficult to see on white colored backgrounds. I add a textured layer instead of a solid color, so the border is outlined in black, so that it is visible on all backgrounds.

BUG=638996
TEST=none

https://screenshot.googleplex.com/htWDLX1Bxdp

Review-Url: https://codereview.chromium.org/2269383002
Cr-Commit-Position: refs/heads/master@{#418785}

This patch removes NonValidatingReloadOnRefreshContent entry that was
already replaced with V2, and adds NonValidatingReloadOnNormalReload as
I did for desktops before.

BUG=591245

Review-Url: https://codereview.chromium.org/2344503002
Cr-Commit-Position: refs/heads/master@{#418784}

Basically,
- components/memory_coordinator/public/interfaces -> content/common
- components/memory_coordinator/common -> content/common
- components/memory_coordinator/browser -> content/browser
- components/memory_coordinator/child -> content/child

BUG=644022

Review-Url: https://codereview.chromium.org/2321313002
Cr-Commit-Position: refs/heads/master@{#418783}

This is a step towards turning all tree outlines into independent web components,
removing global styles related to it and allowing more components to encapsulate their inner details.

BUG=none

Review-Url: https://codereview.chromium.org/2339683005
Cr-Commit-Position: refs/heads/master@{#418782}

After https://codereview.chromium.org/2270463002,
gl::init::GetAllowedGLImplementations assumes GetSurfaceFactoryOzone to
be non-null on the GPU side. The remaining Ozone platform violating
this assumption is addressed in this CL.

BUG=640613
R=rjkroege@chromium.org

Review-Url: https://codereview.chromium.org/2346433002
Cr-Commit-Position: refs/heads/master@{#418781}

Exiting overview mode may leave overview header widget still animating.
It is important not to attempt any window manipulation such as
re-stacking when the animation completes because the affected windows
may be gone by then.

BUG=646350
TEST=WindowSelectorTest.SafeToDestroyWindowDuringAnimation

Review-Url: https://codereview.chromium.org/2337383003
Cr-Commit-Position: refs/heads/master@{#418780}

This is a temporary fix until Dirk can change the closure_compilation
uses of gyp_chromium correctly.

Stolen from Dirk Pranke <dpranke@chromium.org> and stripped of 'includes':
https://codereview.chromium.org/2331423005/

TBR=brettw@chromium.org, dpranke@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=646969

Review-Url: https://codereview.chromium.org/2345503005
Cr-Commit-Position: refs/heads/master@{#418779}

Only perform media scanning if a scan has not been performed since the file update event.

Building up the timestamp map is also moved off the FILE thread and on to the blocking pool.

BUG=628223
TEST=create a large (~10k) set of files under /home/chronos/user/Downloads
Enable ARC++
create a profiler snapshot at chrome://profiler
create one more new file under Downloads
Create another snapshot in chrome://profiler
Verify that there are no long-running tasks on the FILE thread, and that DelayBuildTimestampMap is only called once.

Review-Url: https://codereview.chromium.org/2310833002
Cr-Commit-Position: refs/heads/master@{#418778}

This patch converts "editing/deleting/delete-to-end-of-paragraph.html" to use
w3c test harness to simplify test script for improving
code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2333193002
Cr-Commit-Position: refs/heads/master@{#418777}

This patch fixes BreakingContext::rewindToMidWordBreak to set
m_currentCharacterIsSpace correctly when it rewinded m_current.

Not doing so sets previousCharacterIsSpace incorrectly, and can
collapse whitespaces that should not be collapsed.

BUG=639781

Review-Url: https://codereview.chromium.org/2334143002
Cr-Commit-Position: refs/heads/master@{#418776}

BUG=642302,28515
TEST=as in bug 642302
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2339673002
Cr-Commit-Position: refs/heads/master@{#418775}

This CL added code to show an icon for connected device in the
chooser, and show "Paired" text below the device name if the
device is paired.

I uploaded some screenshots in the issue page.

BUG=543466

Review-Url: https://codereview.chromium.org/2304213002
Cr-Commit-Position: refs/heads/master@{#418774}

The DesktopEngagementService measures session length times on desktop.
Its name is very similar to the SiteEngagementService, which measures
how much user interaction a site has in total. This CL renames
DesktopEngagement* to DesktopSessionDuration* to clarify its role and
make it more distinct from Site Engagement.

BUG=646216

Review-Url: https://codereview.chromium.org/2333113002
Cr-Commit-Position: refs/heads/master@{#418773}

https://chromium.googlesource.com/skia.git/+log/95573e4865c9..14e7a602d0ca

$ git log 95573e486..14e7a602d --date=short --no-merges --format='%ad %ae %s'
2016-09-14 djsollen Revert of Bundle common arguments to GrGradientEffect creation (patchset #2 id:20001 of https://codereview.chromium.org/2332213007/ )
2016-09-14 fmalita Fix SkDrawTextBlobCommand null blob crash
2016-09-14 egdaniel Update GN droid script
2016-09-14 fmalita [SVGDom] Expose intrinsic size info
2016-09-14 msarett Don't let the compiler complain that |a| is uninit
2016-09-14 egdaniel Disable ignore discard optimization in Vulkan
2016-09-14 mtklein CQ update
2016-09-14 mtklein GN: add is_official_build
2016-09-14 mtklein merge run and check-rc steps
2016-09-14 msarett Store SkColorSpaceXform gamma LUTs in a malloced field
2016-09-14 mtklein 565 is not this important.
2016-09-14 msarett Convert back to 0-255 scale before storing linear bytes
2016-09-14 fmalita Improved optional command handling in SkParsePath::FromSVGString()
2016-09-14 brianosman Bundle common arguments to GrGradientEffect creation

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2341993002
Cr-Commit-Position: refs/heads/master@{#418772}