GitLab

Rather than displaying a modal dialog, LoadLibrary and similar return an error. This allows the GPU process to fail or fall back without interacting with the user.

TEST=try
BUG=69610

Review URL: http://codereview.chromium.org/6271006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71736 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tim@chromium.org

Review URL: http://codereview.chromium.org/6248008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71735 0039d316-1c4b-4281-b951-d872f2087c98

When the ALSA volume mixer is used (if PulseAudio is disabled), the current volume and mute settings will be stored in the browser prefs so they can be restored when starting a new session.

BUG=chrome-os:10470
TEST=Manual, volume and mute setting via keyboard should persist after rebooting.

Review URL: http://codereview.chromium.org/6118006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71734 0039d316-1c4b-4281-b951-d872f2087c98

to UITest::Setup. ChromeFrame perf tests override the Setup method and don't invoke the Base
UITest::Setup implementation. 

This causes a crash in UITest::TearDown invoked during the ChromeFrame perf test runs where 
we crash as the launcher is NULL. Added a check for the same.

BUG=none
TEST=chrome frame perf tests.
TBR=amit

Review URL: http://codereview.chromium.org/6321010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71733 0039d316-1c4b-4281-b951-d872f2087c98

randomly break as out requirement get out of line with the bots.

BUG=68303
TEST=reenabled on Linux

Review URL: http://codereview.chromium.org/6365003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71732 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70031

Review URL: http://codereview.chromium.org/6298005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71730 0039d316-1c4b-4281-b951-d872f2087c98

A couple of extensions sync tests fail due to a DCHECK.

Marking tests as failed until the bug is fixed.

TBR=akalin@chromium.org
BUG=70028
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/6373005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71729 0039d316-1c4b-4281-b951-d872f2087c98

The location of:
 /chrome/browser/browser_theme_provider.cc

Changed to:
 /chrome/browser/themes/browser_theme_provider.cc

BUG=None
TEST=Visit the link now, it will work.

Review URL: http://codereview.chromium.org/6338007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71728 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6323004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71727 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65518
TEST=Look for 'backround' in http://code.google.com/chrome/extensions/extension.html; you should get no hits.
TBR=kurrik

Review URL: http://codereview.chromium.org/6185004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71725 0039d316-1c4b-4281-b951-d872f2087c98

1. Fix subsheet RTL.

for the record, and to whom it may concern:

"""
If neither 'left' nor 'right' is 'auto', the position is over-constrained, and one of them has to be ignored. If the 'direction' property of the containing block is 'ltr, the value of 'left' wins and 'right' becomes -'left'. If 'direction' of the containing block is 'rtl', 'right' wins and 'left' is ignored.
"""

2. add handlers to the body element to remove the subsheets when the user clicks outside them.

BUG=67849
TEST=
1. LANGUAGE=he_IL.utf-8 ./out/Release/chrome (looks right)
2. clicking away from the subsheets to dismiss them should still work.
3. clicking to the right (in ltr) of the subsheets should dismiss them (this is new)

Review URL: http://codereview.chromium.org/6277005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71724 0039d316-1c4b-4281-b951-d872f2087c98

than browser action icons.

BUG=40581
TEST=none

Review URL: http://codereview.chromium.org/6145004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71723 0039d316-1c4b-4281-b951-d872f2087c98

- Remove unnecessary additional instructions for Mac
- Delete hand-generated getstarted.zip file

BUG=64259
TEST=none

Review URL: http://codereview.chromium.org/6126005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71722 0039d316-1c4b-4281-b951-d872f2087c98

the provisional load messages to catch an earlier time to substitute in the
prerendered page.
BUG=none
TEST=search for techcrunch and notice how the preloaded techcrunch.com is used despite the redirect
Review URL: http://codereview.chromium.org/6171007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71721 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68626
TEST=Try to bring up autocomplete for the subject field of the Gmail "compose" view.

Review URL: http://codereview.chromium.org/6301005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71720 0039d316-1c4b-4281-b951-d872f2087c98

http://code.google.com/p/angleproject/source/detail?r=534 .

BUG=none
TEST=built and ran affected test on Mac OS X; trybots (in progress)

Review URL: http://codereview.chromium.org/6332005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71719 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Open startup page manager subpage; it should have content.

Review URL: http://codereview.chromium.org/6246008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71718 0039d316-1c4b-4281-b951-d872f2087c98

the current experiment.

BUG=54338
TEST=none
TBR=gavinp


Review URL: http://codereview.chromium.org/6376002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71717 0039d316-1c4b-4281-b951-d872f2087c98

This is an interim solution for M10 since the final approach (drag and drop) will likely not be ready for M10. This adds inline buttons on hover/edit in the same style as the password field "Show" button, which gives a far better experience (especially when there are a lot of engines) than the old model of a single button on the side.

BUG=63825
TEST=Hovering or editing a search engine should show a "Make Default" button.

Review URL: http://codereview.chromium.org/6352004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71714 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69940
TEST=new tab failures don't cause build failures
TBR=nsylvain@chromium.org

Review URL: http://codereview.chromium.org/6277008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71712 0039d316-1c4b-4281-b951-d872f2087c98

Check for crash dump files

Review URL: http://codereview.chromium.org/6265008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71711 0039d316-1c4b-4281-b951-d872f2087c98

until UI team creates production image.

BUG=chromium-os:10711
TEST=checked to make sure the old killtab image isn't shown.

Review URL: http://codereview.chromium.org/6334006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71709 0039d316-1c4b-4281-b951-d872f2087c98

Also changes the close button to always show for the lead element (even in a non-editable list), and fixes a bug in close-button-based multiple deletion where the deletable property wasn't being checked.

BUG=67027
TEST=List items should be deletable with the delete or backspace key.

Review URL: http://codereview.chromium.org/6317005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71706 0039d316-1c4b-4281-b951-d872f2087c98

I tried to make this look as nice as possible (and close to the mocks), but Alex will have to fiddle with the CSS to finalize it. I didn't implement the button changing to "clearing..." because it changes the width of the button and thus the whole overlay. The throbber + disablement should hopefully be enough of a visual cue.

BUG=63843
TEST=manual

Review URL: http://codereview.chromium.org/6340002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71703 0039d316-1c4b-4281-b951-d872f2087c98

- use defineProperty macro where we can
- don't use |arguments| as a var name

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6335003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71698 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the errors related to bookmarkBarDetached and bookmarkBarAttached.

BUG=69705
TEST=Open NTP.
     Open the error console.
     Reload several times.
     Attach/detach the bookmark bar.
     Reload a few more times
     No errors are shown

Review URL: http://codereview.chromium.org/6359003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71697 0039d316-1c4b-4281-b951-d872f2087c98

the "optimization" of not doing so when no targets are apparent, otherwise
we break draggable list elements.

BUG=69857
TEST=Manually try dragging <li draggable="true">AAA</li> on linux.

Review URL: http://codereview.chromium.org/6369004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71696 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Silences expected log entries.
BUG=none

Review URL: http://codereview.chromium.org/6352007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71695 0039d316-1c4b-4281-b951-d872f2087c98

inject scripts.

This is done by reusing the same UserScriptIdleScheduler for reference fragment navigations.

BUG=64093
TEST=See bug for repro.

Review URL: http://codereview.chromium.org/6099013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71693 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63426
TEST=manual

Review URL: http://codereview.chromium.org/6297002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71692 0039d316-1c4b-4281-b951-d872f2087c98

Reopening, because this CL broke NoticeNotificationChanges on XP for some reason, so I'm going to undo my (now superfluous) changes to flush the queue in WaitForResourceChange().

BUG=65189
TEST=TaskManagerBrowserTest.KillBGContents

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71458

Review URL: http://codereview.chromium.org/6226002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71688 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6269011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71685 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles
R=mirandac
Review URL: http://codereview.chromium.org/6371002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71684 0039d316-1c4b-4281-b951-d872f2087c98

The bookmark favicon sync test fails due to what looks like a sync bug.
Marking the test as failing until the bug is investigated.

TBR=tim@chromium.org
BUG=69694
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/6250009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71683 0039d316-1c4b-4281-b951-d872f2087c98

* Don't bold selected navbar-items.
* Add transparent 1px border to unselected navbar-items to prevent shifting.
* Clicking on the Settings title takes you to the 'Basics' page.
* Only show the pointer when hovering navbar-items.
* Fix navbar-container background in RTL.
* Fix linear-gradient of navbar-item-selected.

BUG=69721
TEST=none

Review URL: http://codereview.chromium.org/6350005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71682 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Adding CHECKs to troubleshoot the crash issue intuple.h/browser_render_process_host.cc (see bug description)"

This reverts commit 29801f4598cf1a605c6e1a7b0295e0ac29f27b59.

BUG=chromium-os:7327
TEST=none

Review URL: http://codereview.chromium.org/6323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71680 0039d316-1c4b-4281-b951-d872f2087c98

as well.

BUG=69331
TEST=none

Review URL: http://codereview.chromium.org/6289006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71678 0039d316-1c4b-4281-b951-d872f2087c98

The enum returned from OnTouchEvent reflects the current status of the touch-sequence. This can be used by the RootView to determine when the touch-event-handler should be reset.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6347002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71677 0039d316-1c4b-4281-b951-d872f2087c98

Previously we would use a "good enough" frame without fully taking duration into account.

BUG=69499
TEST=media_unittests

Review URL: http://codereview.chromium.org/6321005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71676 0039d316-1c4b-4281-b951-d872f2087c98

was no native view we would cache the wrong size leading to clipping.

BUG=51007
TEST=see bug for repro steps (specifically comment 6).

Review URL: http://codereview.chromium.org/6268004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71675 0039d316-1c4b-4281-b951-d872f2087c98