- 22 Apr, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/65dffa4595e2..109321d1bdd1 Created with: gclient setdep -r src-internal@109321d1bdd1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: Ic3aa61e57d7ffe3002ed959621b9c9a926d7b640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577560Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652890}
-
Matt Simmons authored
This change introduces a new metric Tabs.TimeSinceLastView.onTabClobber. This is emitted when a user focuses the omnibox and then subsequently navigates within a certain amount of time after returning to a tab. This and Tabs.TimeSinceLastView.onTabView are mutually exclusive (per-engagement). Bug: 947572 Change-Id: I61a6fff00197134ca806adf6f94bb8bcfef7416b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551942Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#652889}
-
Marijn Kruisselbrink authored
Use three-words "Native File System" everywhere. Also change RuntimeEnabledFeature status from "experimental" to no status, since it should currently only be changed by the base::Feature being enabled. Bug: 853326, 929490 Change-Id: Ifaead92ed2e236dda9661e3f58d02fff017e51f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572251 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#652888}
-
Chris Cunningham authored
NOTRY=true Bug: 954319 Change-Id: Id8eeeb53df0dc8747b9f4f96ae9a6f5891eef8d1 TBR: alph@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576173Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#652887}
-
Peter Kasting authored
This also rewrites the test for style reasons while I'm touching it. Bug: 953836 Change-Id: I2cf956f9fae60a9fc9ef83748e977279a459a2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572110 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#652886}
-
John Abd-El-Malek authored
This is a reland of 4dd1f3ce. Disabled test in msan as well. Original change's description: > Reland "Move loading of data URLs out of the network process." > > This is a reland of f45ff75d > > Original change's description: > > Move loading of data URLs out of the network process. > > > > For subresources the renderer was already loading it in-process. Now for navigations and downloads, we keep them in the browser process. This avoids: > > 1) sending GURLs bigger than 2MB to a different process, which strips them as they're bigger than url::kMaxURLChars > > 2) having the network process deal with a scheme that's not going over the network, which we avoid > > > > Bug: 937146, 939871 > > Change-Id: I8ca8225308b2a5f1f90594ab06943f0641a5c551 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570805 > > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Ken Rockot <rockot@google.com> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#652196} > > Bug: 937146, 939871 > Change-Id: I480da494a987c9b223c1a571821b35e3bdbc7447 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574881 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652335} TBR=bsep@chromium.org Bug: 937146, 939871 Change-Id: I7088f802cb5fef81021c488aa6426d1a87604e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577483 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#652885}
-
Nate Chapin authored
A bunch of tests need to be updated for a behavior change in https://chromium-review.googlesource.com/c/chromium/src/+/1526426 These are the ones where the updated test passes before and after the behavior change. Bug: 914587 Change-Id: Ic8b34c4c205ea2f9bf59b620ca6baac47cd7b1ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576025Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#652884}
-
David Black authored
I was unable to repro the bug consistently with an unaltered build. I was able to repro the bug, however, with some local changes in which I posted the UpdateLabel calls to simulate a timing issue. With this change, I was able to reproduce the bug consistently. Bug: b:130758812 Change-Id: I063527e9c52f5584104ce556d3558fc4ed62e228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577494Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#652883}
-
Martin Robinson authored
Bug: 932708 Change-Id: Ib793df737907234c4ffe7f7d7f591086711d9f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574721 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#652882}
-
Jun Mukai authored
The animation is already ongoing when the closing is scheduled, Chrome is going to crash without SetTargetState() regardless of the side-shelf state. Bug: 954907, 951853 Test: manually Change-Id: Ic5e67e152341cb96829fd2d1e9e768485f8b2eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577482Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#652881}
-
Dana Fried authored
This fixes an issue where a context menu opened from the app menu would trigger UMA logging events for the bookmarks bar. Bug: 951907 Change-Id: I4521b6b7101e2c662f347f479130201482617d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574682Reviewed-by:
-
Wei Li authored
Status bubble text was drawn with certain transparency. When it was changed to be drawn on a label, the color would be automatically computed based on foreground and background colors, which makes the text color even lighter with some themes. We fix that by disable auto color readability on that label. BUG=952061 Change-Id: I25ec54aa82c4d62e7fa67f146f0e7c9e39511eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565504 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#652879}
-
Sébastien Séguin-Gagnon authored
Record when the infobar is shown, opened and dismissed. Bug: 942747 Change-Id: I76b8dbfc3538d7095eb2a9f0d4e96706954c0493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574833 Auto-Submit: sebsg <sebsg@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#652878}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/76c5c490d194..4b68d1e3e421 git log 76c5c490d194..4b68d1e3e421 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 crouleau@chromium.org Speculatively reduce parallelism in metrics calculations to prevent d8 error. Created with: gclient setdep -r src/third_party/catapult@4b68d1e3e421 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:953365 TBR=charliea@chromium.org Change-Id: Id0e080bd242a0b35657db6b10230642d5d13218d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576292Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652877}
-
Nasko Oskov authored
Recent refactoring (r649193) added the NavigationRequest as parameter to ValidateDidCommitParams, but instrumentation landed in r652724 is using the member variable of RenderFrameHostImpl. This CL changes the debug instrumentation to use the passed in parameter, which should be available for most navigations. Bug: 931895 Change-Id: Ic8339dd81948af83fac822d6ab6d95cea01e1838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577581Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#652876}
-
Emil A Eklund authored
Defer computation of ink bounds until needed instead of pre-computing it during shaping. This does not yet change how the bounds are accumulated. In legacy layout the bounds are computed and cached by CachingWordShaper immediately after shaping, minimizing changes to the API or performance. In LayoutNG bounds are no longer computed during the PrepareLayout step, where initial paragraph shaping occurs, nor during the subsequent layout step, where line breaking and fragment construction takes place. Instead bounds are only computed when NGPhysicalTextFragment::SelfInkOverflow is called, typically during painting. This avoids unnecessary and repetitive bounds computation, lowers memory consumption, and simplifies the implementation. Resulting in significant performance improvements. Specifically for forced and off-screen layout. This improves performance significantly for LayoutNG, most of the layout benchmarks in the blink_perf.layout suite improve by between 5% and 20%. chapter-reflow-once 20% long-line-nowrap 18% fit-content-change-available-size-text 11% hindi-line-layout 10% change-text-css-contain 10% latin-ebook-resize 10% Furthermore it significantly improves the more realistic loading.desktop numbers which measure time to fully render a number of real world sites. timeToFirstContentfulPaint:layout 10% timeToInteractive 7% timeToFirstMeaningfulPaint 3% cpuTimeToFirstMeaningfulPaint 3% Bug: 636993 Change-Id: Ib1dbdf4483137039ddba37e4a48c816369425788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572875 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#652875}
-
Chris Cunningham authored
NOTRY=true Bug: 954994 Change-Id: I5a91e3fd45cb886990ab103911117285a7f6a813 TBR: mbarowsky@chromium.org, wangxianzhu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577496Reviewed-by:
-
Siye Liu authored
This change aims to demonstrate how we can re-implement the following methods in a sane way. * TSFTextStore::CancelComposition() * TSFTextStore::ConfirmComposition() In our initial implementation [1], those two methods were implemented in a really hacky way. It was implemented by simulating a text change event during a composition with an assumption that the current IME will terminate the composition when it receives |OnTextChange|. |ITfContextOwnerCompositionServices::TerminateComposition| should have been used instead in this scenario. [1]: e7888801 Bug: 948783 Change-Id: Ibfb270d9f8dc2459ca73824c7405f10111e12ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572240 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#652873}
-
Tatiana Buldina authored
Change-Id: I35cddbfae13842633ff611e2f85966ac12e8b6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572208Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#652872}
-
Khushal authored
Qualcomm needs a usage bit to be set on AHardwareBuffers used with HWC for direct scanout. Currently its set internally in the framework but since Chrome allocates its own buffers with SurfaceControl, it needs to be added by Chrome. R=piman@chromium.org Bug: 889328 Change-Id: Ie5596a1bfcd9916d9676ac29c1f6c0ae2555cef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576000 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#652871}
-
Tommy C. Li authored
This CL surfaces the "Why this suggestion" text in the bubble for removing suggestions. Suggestions that can be removed now have a "More Info / Remove..." context menu entry. Suggestions that cannot be removed have a "More info..." context menu entry. Both bring up a bubble. This won't be the final UX treatment, but gets the capability in there for further refinement. Bug: 929477 Change-Id: I2dc9a5fea920653ead8ff9efea41fb77f91ff919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575872 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#652870}
-
Ovidio Henriquez authored
This change formats the site_settings_handler.cc and site_settings_handler_unittest.cc files. Change-Id: Ia678d766341022b3f5fd3e06b8f2b3788d4f733b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575825Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#652869}
-
David Benjamin authored
Found by the newly-added fuzzer. Fortunately this is not a problem for any existing callers, which only ever passed a StringPiece derived from a full std::string (which promises to be NUL-terminated). Bug: 954703, 954760 Change-Id: I274de66b785d9f272a25264980e21878c5a77872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577580Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#652868}
-
Evan Stade authored
Bug: none Change-Id: If821edbfc5ea2f222c0a885cbe14d8a48c789d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575868 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#652867}
-
Bence Béky authored
This is a follow-up to https://crrev.com/c/1570914. Bug: 912727 Change-Id: I284dbb580bb396da787c7d2f5755428458f88aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577479Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#652866}
-
Tommy C. Li authored
This extends AutocompleteMatch with explanatory text as to where this suggestion came from. This is currently purely based on the AutocompleteMatchType. These are placeholder strings meant for development only. Bug: 929477 Change-Id: Ia8bb271b6f7ad4b2848011bec98d16d4f64f64de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574886 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
-
li authored
Currently, we are sending text query for the timer notification actions. Improve it by adding timer deeplinks that trigger AlarmTimerManager APIs. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome Bug: b:119116816 Test: Manual Change-Id: Ife633a5978f9d0af1a5bef8a70782a7f7d364fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531606 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#652864}
-
chrome://flagsLily Chen authored
This flag will enable net::features::kSameSiteByDefaultCookies, which will make cookies set without a valid SameSite attribute default to being treated as SameSite=Lax. When the feature is enabled, SameSite=None is required to get the previous default behavior of not having any same-site restrictions. Bug: 953306 Change-Id: Iaa7983e6568cdadf18752e89539c3e411325694e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574835Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#652863}
-
Matt Menke authored
The class docs mention a number of methods that I have since removed. Bug: 912727 Change-Id: Ic3ac8c28167b09c8d9acf3b336b58385e17a9ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575725 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#652862}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cbc33b8e3574..7a5b6ec0f6c0 git log cbc33b8e3574..7a5b6ec0f6c0 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 egdaniel@google.com Update comment on vulkan allocator. 2019-04-22 egdaniel@google.com Add back deprecated GrCotnext flush API till clients get fixed. Created with: gclient setdep -r src/third_party/skia@7a5b6ec0f6c0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: Ifb87e61e0db201b05a73af059b645d9af4280a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577565Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f66107f9aa31..fe8eb40a01ae git log f66107f9aa31..fe8eb40a01ae --date=short --no-merges --format='%ad %ae %s' 2019-04-22 dburger@chromium.org In config skew test switch to using proto buffer. Created with: gclient setdep -r src/third_party/chromite@fe8eb40a01ae The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I24bcc965c0f3f4208fb3a390ec7c772c8ba17dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577564Reviewed-by:
-
Xianzhu Wang authored
Bug: 363609, 954591 Change-Id: I522eaf916c9b2d7dbb3ba95a904e9b272d920902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577058Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652859}
-
Robert Ogden authored
The DRP session key may not be available from the request headers. If it isn't, get it from the UI thread instead. Bug: 952523 Change-Id: I82befab8a97b5c463db37b0d5e82edc640d9af18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576154Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#652858}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/bcc71a322953..4f15ce2eb993 git log bcc71a322953..4f15ce2eb993 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 swiftshader.regress@gmail.com Regres: Update test lists @ bcc71a32 Created with: gclient setdep -r src/third_party/swiftshader@4f15ce2eb993 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I13750bafa8ef672260477937fd3dd6ecc5db18cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577562Reviewed-by:
-
chrome://os-settings/James Cook authored
Use pageVisibility to hide sections like autofill, show bookmarks bar, etc. Bug: 950007 Change-Id: I871322a3eca51eb6995fa4ee304461c9f8bd0f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575032Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#652856}
-
Eric Aleshire authored
As part of the EG2 migration, app-side helpers that used to GREYAssert now return NSError*, which are asserted on in test-side code. ASSERT_IF_ERROR simplifies the modification required for test code that call these app-side helpers, while preserving the line number of the failure. This CL aligns the test code in these 4 CLs to use ASSERT_IF_ERROR: http://crrev.com/c/1562756 http://crrev.com/c/1553085 http://crrev.com/c/1558155 http://crrev.com/c/1559889 Bug: 922813 Change-Id: I2d82dd9cd6a9eab6913418d357649c1f13f3699f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574954 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#652855}
-
Alison Maher authored
This change implements Implement ITextRangeProvider::Move. This implementation uses MoveEndpointByUnit to do most of the functionality, with some edge cases handled. Unit tests were added for all unit types except Format and Paragraph. Unit tests for these will be added once MoveEndpointByUnit is completed for each type. AssertMoveEndpointByUnit() and AssertMove() helper functions were added to the unit tests to decrease the amount of repeated code and to increase readability. Bug: 928948 Change-Id: I22dfa7017d162b83fdc6db66dbcfd5266d98bfcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569522Reviewed-by:
-
Aran Gilman authored
In particular, the following were changed: * Reduce wordiness. * Run mdformat. * Remove information about SCOPED_TRACE(), since that appears to be outdated (or maybe just misleading). * Replace section on Google-internal script with link to internal Chrome A11y page on the topic. Change-Id: I94e3a47f435f092b225a60ae2e35c06ddba8d2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555417Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6350cb0f4bb3..cbc33b8e3574 git log 6350cb0f4bb3..cbc33b8e3574 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 brianosman@google.com Add SkSL viewing/editing to viewer Created with: gclient setdep -r src/third_party/skia@cbc33b8e3574 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: Icdf90dcfc90ea4e93ece175bf62fa5c0139cbf6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576151Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1800687a19fc..65dffa4595e2 Created with: gclient setdep -r src-internal@65dffa4595e2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: Ib5e29768284f8532be816d552f1492a31f9f75ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576150Reviewed-by:
-
