GitLab

This CL adds the following metrics:

* If the system has a dbus object at /org/Freedesktop/Notifications
  with interface org.Freedesktop.Notifications
* Server capabilities as returned by GetCapabilities
  * Capabilities are stored in |capabilities_|.  It is not used now,
    but will be in the future.
* Whether native notifications are actually used

BUG=676220
R=peter@chromium.org,mpearson@chromium.org
CC=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2856753002
Cr-Commit-Position: refs/heads/master@{#469434}

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in content.

BUG=713683
R=gab@chromium.org
TBR=dgozman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2857983003
Cr-Commit-Position: refs/heads/master@{#469433}

Add flag to override Effective Connection Type (ECT) returned by
Network Quality Estimator (NQE). If ECT is overridden using both the
flag and the field trial, then the value set by the flag takes the
precedence.

BUG=716221

Review-Url: https://codereview.chromium.org/2850003002
Cr-Commit-Position: refs/heads/master@{#469432}

Currently, the JumpList class has a data member icon_dir_ to hold
/profile/kJumpListIconDirname, which indicates that there's only
one directory to hold jumplist icons. However, there are actually
more than one icon directory. When generating these directory
names, we append various kFoos to icon_dir_.

It's better to append (chrome::kJumpListIconDirname + kFoo) as a
whole to the profile directory as needed at the various points of
use, rather than the current adding various kFoos to icon_dir_.
This avoids the confusion.

BUG=718314

Review-Url: https://codereview.chromium.org/2846383002
Cr-Commit-Position: refs/heads/master@{#469431}

Added ability to disassociate Tether and Wi-Fi networks, and now Wi-Fi and Tether networks are associated as soon as the network becomes connectable.

Adding stevenjb@ for network_icon.cc.

BUG=672263

Review-Url: https://codereview.chromium.org/2819303002
Cr-Commit-Position: refs/heads/master@{#469430}

This relands the sampler, but with a very simplified recovery with no fancy stack scanning in case libunwind stops after one frame.

BUG=531673

Review-Url: https://codereview.chromium.org/2848683006
Cr-Commit-Position: refs/heads/master@{#469429}

This CL changes the class of the content settings exceptions to use a
max-width of 100% which allows the text elision to correctly truncate
the URL.

BUG=717883
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2861933002
Cr-Commit-Position: refs/heads/master@{#469428}

We were adding twice the height necessary when an answer in suggest
was present, which created a large empty space at the end of the
suggestions. This changes it to adding custom "definition" line
height.

BUG=714042

Review-Url: https://codereview.chromium.org/2856253002
Cr-Commit-Position: refs/heads/master@{#469427}

BUG=717694

Review-Url: https://codereview.chromium.org/2856233002
Cr-Commit-Position: refs/heads/master@{#469426}

This issue is caused by Aura Overlay Scrollbar is created with
opacity>0. We
used to call SAC::DidScrollUpdate - LTI::UpdateScrollbars to fade out
when RegisterScrollLayer.

```
#2 0x7f23d0dfe1ea cc::LayerTreeImpl::UpdateScrollbars()
#3 0x7f23d0dfd999 cc::LayerTreeImpl::DidUpdateScrollState()
#4 0x7f23d0e07231 cc::LayerTreeImpl::RegisterScrollLayer()
```

But we remove ScrollbarAnimationController::DidScrollUpdate call in
UpdateScrollbars at
https://crrev.com/697a467f819ce09da5209a3df13b8b92f33e35a4.
Then Overlay Scrollbar can not fade out until we have real scroll.

In this patch, we apply set_needs_show_scrollbars(true) to the layer in
LayerTreeImpl::RegisterScrollLayer that will let
LTI::HandleScrollbarShowRequestsFromMain pickup and call
SAC::DidScrollUpdate.

For cc_unittest, remove set_needs_show_scrollbars call in
LayerTreeHostImplTestScrollbarAnimation.* and
LayerTreeHostImplTest.ScrollbarVisibilityChangeCausesRedrawAndCommit.

BUG=717222
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2858973002
Cr-Commit-Position: refs/heads/master@{#469425}

This CL:

- moves those two fellas (BarcodeDetectionImpl.java and
TextDetectionImpl.java) from //chrome to //services/shape_detection,
with some tiny adaptations.

- changes render_process_host_impl.cc to send requests to the
said service.

- adds a needed InterfaceRegistrar.java to //services/shape_detection
and some android-specific code to shape_detection_service.cc,
following the  //services/device model (BatteryMonitor, concretely).

No new code or functionality is intended in the ...Impl.java
files (except a small change in testing for GMS presence).

BUG=718275
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2855203003
Cr-Commit-Position: refs/heads/master@{#469424}

https://chromium.googlesource.com/angle/angle.git/+log/ba29fa4..677bb6f

BUG=

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2858303002
Cr-Commit-Position: refs/heads/master@{#469423}

BUG=None
TEST=base_unittests --gtest_filter=FileUtilTest.SetCloseOnExec
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2862873002
Cr-Commit-Position: refs/heads/master@{#469422}

Review-Url: https://codereview.chromium.org/2860853003
Cr-Commit-Position: refs/heads/master@{#469421}

When signin is disabled by policy, Chrome Settings on Android show disabled
"Sign in to Chrome" preference row anyway. This CL adds
"Disabled by the administrator of this device" string to show in the preference
summary in such a case.

BUG=709574

Review-Url: https://codereview.chromium.org/2856173002
Cr-Commit-Position: refs/heads/master@{#469420}

Overflows are likely for DataUse.ContentType.UserTraffic histogram. Fix
the overflow by logging the histogram in increments of kilobytes.

BUG=679046

Review-Url: https://codereview.chromium.org/2851923002
Cr-Commit-Position: refs/heads/master@{#469419}

HandleShowStylusTools crashes at desktop ChromeOS UI and shows stylus
tools on device does not have stylus. Adding more checks when we should
HandleShowStylusTools and when to AddPaletteTray.

BUG=712887, 717674, 717422
TEST=Manual && AboutFlagsHistogramTest.CheckHistograms

Review-Url: https://codereview.chromium.org/2825383003
Cr-Commit-Position: refs/heads/master@{#469418}

A recent change (crrev.com/2808093008) did two things:
a) Change a cc file but not change the header accordingly
b) Add a new dependency but not update the gn accordingly

This change fixes those two issues to allow building
Chrome on Android with ffmpeg built in.

Review-Url: https://codereview.chromium.org/2848213003
Cr-Commit-Position: refs/heads/master@{#469417}

Revert of Support base::test::ScopedTaskEnvironment and content::TestBrowserThreadBundle in the same scope. (patchset #7 id:110001 of https://codereview.chromium.org/2860533002/ )

Reason for revert:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk fails

failures:
TestBrowserThreadBundleTest.MultipleTestBrowserThreadBundle
TestBrowserThreadBundleTest.MessageLoopTypeMismatch

Original issue's description:
> Support base::test::ScopedTaskEnvironment and content::TestBrowserThreadBundle in the same scope.
>
> A test suite that depends on a test suite base that provides a
> base::test::ScopedTaskEnvironment may need browser threads. Currently,
> the test suite cannot use content::TestBrowserThreadBundle to get
> these browser threads because base::test::ScopedTaskEnvironment and
> content::TestBrowserThreadBundle both set the main MessageLoop and
> the TaskScheduler. With this CL, content::TestBrowserThreadBundle
> doesn't set the main MessageLoop and the TaskScheduler if they
> already exist.
>
> E.g.
> Test suite: ToolbarActionViewUnitTest
>             Needs BrowserThreads
> Base test suite: views::ViewsTestBase
>                  Provides a ScopedTaskEnvironment
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2860533002
> Cr-Commit-Position: refs/heads/master@{#469304}
> Committed: https://chromium.googlesource.com/chromium/src/+/ba0dacfc73d208fc779907890bc94dbd09ef1aad

TBR=gab@chromium.org,robliao@chromium.org,sky@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2859283002
Cr-Commit-Position: refs/heads/master@{#469416}

This CL increases the clickable area of direct share icon:
1. Change the icon size from 20dp to 24dp.
2. Add 8dp margin on both top and bottom of the icon.
3. If direct share icon is shown, remove the 15dp padding on the right
of the wrapping LinearLayout and add 15dp margin of direct share icon.
This makes the right area of direct share icon responses to the click
event of direct share rather than share.

The design spec is here: https://bbergher.googleplex.com/specs/context-menu/.

BUG=None

Review-Url: https://codereview.chromium.org/2858433002
Cr-Commit-Position: refs/heads/master@{#469415}

This CL adds some basic zoom and pan support (touch input mode only for now)
for the iOS client.

This is minimum code to make use of DesktopViewport. The client gesture stuff
may still need more refactoring or redesign to support trackpad input mode,
deceleration animation, etc.

BUG=714193

Review-Url: https://codereview.chromium.org/2856933007
Cr-Commit-Position: refs/heads/master@{#469414}

TriggerManager is just a skeleton here, to be expanded in future CLs.

Review-Url: https://codereview.chromium.org/2855643002
Cr-Commit-Position: refs/heads/master@{#469413}

BUG=

Review-Url: https://codereview.chromium.org/2857393004
Cr-Commit-Position: refs/heads/master@{#469412}

The code to delete existing offline pages created previously by last_n
was also causing the deletion of the very offline snapshot currently
being loaded. This change fixes that by verifying that the snapshot that
would be deleted is not the same as the one being loaded.

It also changes slightly the way the information of the lastest last_n
snapshot is cleared: now that only happens when the snapshot is actually
being deleted.

BUG=718212

Review-Url: https://codereview.chromium.org/2854213005
Cr-Commit-Position: refs/heads/master@{#469411}

This helps avoid security bugs where callers store a FrameTreeNode ID
and later assume it is for the same RenderFrameHost.  However, a
cross-process navigation may have taken place, leading to a higher or
lower privileged page.

Because extension APIs use the old approach, the previous API is left
as an unsafe option, with comments encouraging callers to avoid it.

BUG=715541
TEST=No behavior change.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2856653004
Cr-Commit-Position: refs/heads/master@{#469410}

- all: Use -p consistently to specify a path to the compile db to match
  the convention of clang::tooling::ClangTool
- all: Default -p to out/Debug for convenience.
- docs: Update docs to reference renamed arguments
- docs: Update clang-tidy documentation to use the compile DB generation
  wrapper script
- run_tool.py: Change tool to a non-positional argument and make it a
  required argument.

Change-Id: I378402cab36e86da4b13fb43e26067cad4db1795
Reviewed-on: https://chromium-review.googlesource.com/494946
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469409}

BUG=705575
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2818283002
Cr-Commit-Position: refs/heads/master@{#469408}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/075011d..211c500

$ git log 075011d..211c500 --date=short --no-merges --format=%ad %ae %s
2017-05-04 philipel@webrtc.org Don't initiate perodic probing if we don't have a bandwidth estimate.
2017-05-04 pbos@webrtc.org Remove layer_sync from TL frame config.
2017-05-04 henrik.lundin@webrtc.org NetEqTest: Extend the callback structure
2017-05-04 sakal@webrtc.org Add functionality to clear surface to a specific color in EglRenderer.
2017-05-04 pbos@webrtc.org Derive current layer from TL frame config.
2017-05-04 magjed@webrtc.org Reland of Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/ (patchset #1 id:1 of https://codereview.webrtc.org/2862663003/ )
2017-05-04 oprypin@webrtc.org Add --quick flag to low bandwidth audio test
2017-05-04 sprang@webrtc.org Update decode/render fps stats when calling VideoReceiveStream::GetStats
2017-05-04 nisse@webrtc.org Revert of Delete deprecated and transitional stuff related to video frame refactoring. (patchset #1 id:1 of https://codereview.webrtc.org/2854873003/ )
2017-05-04 nisse@webrtc.org Reland of Delete deprecated and transitional stuff related to video frame refactoring. (patchset #1 id:1 of https://codereview.webrtc.org/2854883002/ )

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

Review-Url: https://codereview.chromium.org/2862723003
Cr-Commit-Position: refs/heads/master@{#469407}

BUG=717765
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2861963002
Cr-Commit-Position: refs/heads/master@{#469406}

TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2865493002
Cr-Commit-Position: refs/heads/master@{#469405}

- Use more StringPieces and C++11.
- Merge some repeated code.
- Fix nits.

Review-Url: https://codereview.chromium.org/2858213002
Cr-Commit-Position: refs/heads/master@{#469404}

This change will suppress all fling cancel events unless the last event
was a fling event. Also it generates a proper sequence of a scroll
event with zero distance.

BUG=590754
TEST=Fling and touch the touchpad after fling. Should stop scrolling
motion in android apps.

Review-Url: https://codereview.chromium.org/2840113002
Cr-Commit-Position: refs/heads/master@{#469403}

The best practice is apparently not to do this and to use
Serialize()/Deserialize() functions directly. This also removes an
EnumTraits test that isn't super useful.

BUG=none

Review-Url: https://codereview.chromium.org/2857033002
Cr-Commit-Position: refs/heads/master@{#469402}

TBR=bajones@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2863603003
Cr-Commit-Position: refs/heads/master@{#469401}

https://pdfium.googlesource.com/pdfium.git/+log/df673c28191c..dcefccc9f0f2

$ git log df673c281..dcefccc9f --date=short --no-merges --format='%ad %ae %s'
2017-05-04 dsinclair Removing unused IFX_Pause parameters

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ib8116680974b8967fe03da054cdfad05a6dfd721
Reviewed-on: https://chromium-review.googlesource.com/495490
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469400}

BUG=718445

Review-Url: https://codereview.chromium.org/2862863002
Cr-Commit-Position: refs/heads/master@{#469399}

NameMap, which after the previous patch is no longer used by the shader/program managers, is removed, and the tests updated.

Tests are also added for GetOriginalNameFromHashedName, though these don't actually hit the original error case in the bug report. That's a difficult integration issue and is tested instead by the WebGL conformance tests.

Usages of GetOriginalNameFromHashedName are replaced with more specific methods calls in Program::{GetTransformFeedbackVaryings,GetUniformBlocks}. This avoids querying the unnecessary extra four info maps.

BUG=716018
TEST=https://github.com/KhronosGroup/WebGL/pull/2388
TEST=https://github.com/KhronosGroup/WebGL/pull/2389
TEST=ShaderManagerTest.DoCompile
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2852923004
Cr-Commit-Position: refs/heads/master@{#469398}

In the Payment Sheet and the Address selector, display the shipping
option error.

BUG=710004
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2855203002
Cr-Commit-Position: refs/heads/master@{#469397}

BUG=706683

Review-Url: https://codereview.chromium.org/2855033002
Cr-Commit-Position: refs/heads/master@{#469396}

Revert of MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility (patchset #2 id:20001 of https://codereview.chromium.org/2852433003/ )

Reason for revert:
This caused pageVisibility sub-objects to no longer be undefined which (counter intuitively) causes the sub sections to no longer be visible.

There was some discussion about various approaches to fix this here:
https://codereview.chromium.org/2861443003/

However no agreement was reached, so I am reverting this CL.

Original issue's description:
> MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility
>
> This CL:
> * Removes SettingsSubpageBrowsertest which required extra complexity
>   in the Settings page visibility code and only tested coarse load
>   times of subpages; this testing no longer has much value.
> * Eliminates SettingsPageVisibility which was creating multiple
>   definitions of pageVisibility and generally confusing things.
> * Defines pageVisibility in all cases (not just guest mode). This will
>   allow  the use of dom-if and allows conditional pages
>   (i.e. androidApps) to use the same pageVisibility system. Pages still
>    default to visibile unless explicity set to 'false'.
>
> BUG=709442
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2852433003
> Cr-Commit-Position: refs/heads/master@{#468702}
> Committed: https://chromium.googlesource.com/chromium/src/+/1362453f54271dc1036fc104a01cad436c3da26c

TBR=dpapad@chromium.org,hcarmona@chromium.org,michaelpg@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=709442

Review-Url: https://codereview.chromium.org/2866463002
Cr-Commit-Position: refs/heads/master@{#469395}