- 03 Dec, 2019 40 commits
-
-
Jared Saul authored
The following changes have been made at the request of Chrome Privacy: - Closing promo bubble now gives 3 strikes instead of 2 - Declining main bubble now gives 6 (max) strikes instead of 3 - Accepting main bubble now gives 6 (max) strikes instead of 0 - As a result of the above, there is now no reason to add strikes for having deselected cards on the main dialog - Strikes no longer expire after 1 year Change-Id: I57c80fb94f120b9132b7f129d8e20996821de35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931652Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#721153}
-
Justin Cohen authored
Bug: 619982 Change-Id: I504c62ff7c2fc9d4cb2f2197d39425ba6aa97cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932167 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#721152}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b6b7e7b6c8de..c694627157f2 git log b6b7e7b6c8de..c694627157f2 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 herb@google.com Don't draw strikes that are too small 2019-12-03 mtklein@google.com remove SkColorSpaceXformSteps::Required 2019-12-03 kjlubick@google.com [skottieWASM] make sure we are using CPU or GPU correctly 2019-12-03 fmalita@chromium.org Reland "[skottie] Remove defensive seek(0) from Animation ctor" 2019-12-03 mtklein@google.com replace CSXformSteps::Required() in GrSurfaceContext 2019-12-03 mtklein@google.com Fix sprite blitter choice logic 2019-12-03 mtklein@google.com replace CSXformSteps::Required() in SkShader 2019-12-03 mtklein@google.com add friendly new ctor for xform steps 2019-12-03 jvanverth@google.com Some more tweaks to perspective path clipping 2019-12-03 fmalita@chromium.org Revert "[skottie] Remove defensive seek(0) from Animation ctor" Created with: gclient setdep -r src/third_party/skia@c694627157f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029831 Tbr: bsalomon@google.com Change-Id: I9ca41f472ee2a7964cba3cd289a2028f104090a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947978Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721151}
-
chrome://device-logMartin Kreichgauer authored
This helps with reasoning from the logs whether an outstanding CTAP2 request was cancelled, e.g. by sending CTAPHID_CANCEL. Change-Id: I3c93cbd399a074f03821cebcfa2825b6d96b3f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949037 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#721150}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a61151f11cbe..d006a8572a47 git log a61151f11cbe..d006a8572a47 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 crouleau@chromium.org [Telemetry] Only find relevant browsers on Android. Created with: gclient setdep -r src/third_party/catapult@d006a8572a47 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1030053 Tbr: sadrul@google.com Change-Id: Ia1e4cdd3a59d92c5fd012da8a994bd12f81ffdd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947981Reviewed-by:
-
Megan Jablonski authored
This makes sure it is updated for same language translations as well as if the user changes it via the UI. If the user opens the UI on the same page load, their changes via settings are now there rather than reset to the original values. Bug: 976352, 1024512 Change-Id: I1bafea9e8f95267d2388590b194d82996ad3d206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940560Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#721148}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5030e7a4a8f032987f23396f35a598fcbb8f5e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947980Reviewed-by:
-
Fei Ling authored
In fact we already detect whether the mouse is in the resize control. The problem is that the cursor is always set to the pointer cursor in this case. What we should do is to change the cursor depending on the value of the resize style. Bug: 942017 Change-Id: I4205c85627afbad8f59bd85784d4f34046621a9b Fixed: 942017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944315 Commit-Queue: Fei Ling <feiling@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721146}
-
David Bienvenu authored
Use .find to determine if hwnd is a root window in root_window_hwnds_occlusion_state_ instead of iterating through it. Bug: 1029842 Change-Id: I6e2fb476635e0479355983a07149ec7d85149f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949026 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#721145}
-
David Black authored
Previously the rich entry point HTML had been stubbed on the client, but now it is retrieved from the headers of the HTTP response. Eventually this endpoint will migrate to be GRPC/proto based but as of now we rely on passing metadata via response headers. Bug: b:145056104 Change-Id: Ic454a955912d80d916c16f1b26523cd02b202d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949108 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721144}
-
Kurt Horimoto authored
Bug: 1030357 Change-Id: I04d43c5c4fd65d5050e7dd5b2162b2d82a7b7340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949109 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#721143}
-
Anqing Zhao authored
In Chrome OS, the client id and dm token are generated and maintained in cloud_policy_client. Therefore, the SetupRegistration method will be skipped if the operation system is Chrome OS. Related unit tests are changed accordingly. Bug: 1010213 Change-Id: Iaf5da70c226f372bc0f5d125af49de9935d4ceab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940180 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#721142}
-
Nektarios Paisios authored
No information as to how to reproduce the linked bug has been provided in the crash reports. Therefore, using two CHECKs as a quick way of gathering more information from the field. TBR=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1022601 Change-Id: Id7ef83bc58e0b41a16f8a0a7df1720c7f2470618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948495Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#721141}
-
Natalie Chouinard authored
Remove feature-specific method from PreferencesLauncher to the class where it's used. Bug: 1029194 Change-Id: I845474b13e67df8d562a661fa916e47ac05e9405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941307 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#721140}
-
Takumi Fujimoto authored
This reverts commit d44d94c6. Reason for revert: I think this is the cause for this tree-closing failure: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/7768 Original change's description: > Include compatibility checks when submitting policy_templates.json. > > This will change the presubmit checks for policy_templates.json to > ensure that policy changes are backwards compatible with policies > definitions that have already shipped. > > Bug: 1026330 > Change-Id: If054d2376397432c66d948eaf0d2d42d5db13a0b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925190 > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Commit-Queue: Tien Mai <tienmai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721123} TBR=pastarmovj@chromium.org,poromov@chromium.org,tienmai@chromium.org Change-Id: I0ac66ee107a0ad25675e149192b47868653c525c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949265Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#721139}
-
Lambros Lambrou authored
Also updated it to deal with _debug_log replies, and other cleanups. Change-Id: I83484acd33df759f02f37d1d6eef6c2300132a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947478 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#721138}
-
Sebastien Marchand authored
These restrictions are not necessary now that most stuff have been moved to //components/performance_manager. Change-Id: I84a93c998e77ef5da01b0b7264f83c5432dba030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947480 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
-
Robert Ogden authored
This test fails and sometimes flakes because the statistics recorder is interfering with the HistogramTester's init, causing no new entries to be populated during the test. Bug: 1002223 Change-Id: Ia7cfe227a5be11c2f8e7826d3377fb6b79952cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946843Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#721136}
-
Alex Cooper authored
This changes pose_reset and input_state attributes that lived on VRPose to instead live on XRFrameData. This de-couples some frame state from VRPose and paves the way for it to be used instead of gfx::Transforms for some entities. Bug: 1017872 Change-Id: I76474845436168a144f929c8cb94bd4a50b15fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945278Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#721135}
-
Anqing Zhao authored
Currently, the test cases in this file is not enabled for Chrome OS. This cl is to enable it by following steps. - The request type is decided by current operation system. - Skip verification for specific fields. Bug: 1010213 Change-Id: I3d63e728c7b4a663a7f2ae2147f57b681b9494fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947650Reviewed-by:
-
Tom Anderson authored
The version of dbus-launch on the bots does not support --exit-with-x11. Instead, send SIGKILL to the daemon's pid to ensure it exits with xvfb.py. Also, PRESUBMIT.py fails due to a URL exceeding the 80-column limit, even though this line is not modified by this CL. Replace the URL with a commit hash to prevent presubmit failures in the future. BUG=1013812,1027852 R=dpranke Change-Id: I974e3aae9282fc593fc8c86cedfe55c684a7e7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949027 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#721133}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e3c399536949..a097c941d4f8 git log e3c399536949..a097c941d4f8 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 treehugger-gerrit@google.com Merge "TrackEvent: Require track event names to be static strings" 2019-12-03 taylori@google.com Merge "perfetto-ui: Select tracks when selecting time range" Created with: gclient setdep -r src/third_party/perfetto@a097c941d4f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id0de5f3a73b395f2e3def88f5f1d6a27803b9195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947979Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for tracing::mojom::PerfettoService using PendingRemote. Bug: 955171 Change-Id: I99b06720be06acb7b70070d474a6b867fbeac0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939160Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#721131}
-
Anqing Zhao authored
In Chrome OS, this policy only takes effect on primary account, other than all accounts. So this setting's value should be changed to False. Bug: 1010213 Change-Id: Ia0a3e999db90041fa52504ad2f1f7ecd1b316ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947725Reviewed-by:
-
Fredrik Söderquist authored
When nudging the presentation time back in InstanceListChanged(), the previous interval could be the active one, so we need to consider it when updating the active state and when compute the next interval time. Bug: 1030309 Change-Id: I5d20878f45dd4e26c5966c816b9ff5c82e4c40b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948938Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#721129}
-
Fredrik Söderquist authored
Track the entry to start the (next) search in the 'begin' list from, and make sure we advance to the next one for each subsequent iteration of the loop. This should ensure forward progress is made. Bug: 1029573 Change-Id: I7a3d7564527667cec397a1431b0757674ce75469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946477Reviewed-by:
-
Sean Gilhuly authored
The |gpu_preferences| argument is no longer used in CollectGraphicsInfo, so remove it from the signature and callsites. Change-Id: I73399b711a94dc98983bcea7cb82df8499758028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949063Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#721127}
-
Ali Juma authored
This adds the file as an EG2 target, updates #includes, and replaces calls to helpers that can't be used in EG2. This also adds a webStateLastCommittedURL method to ChromeEarlGrey. Bug: 987646 Change-Id: Ib98baad37b422b36a216b7915a0594b0e76c4062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947048Reviewed-by:
-
Nikita Podguzov authored
Bug: 943746 Change-Id: Ic54edc8c0475aa1c31ce59b092e356a28ffbc743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937170 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Jasper Chapman-Black authored
Since caspian_web.wasm has grown to about 8MB, it's probably a good idea to cache it via the ServiceWorker. Change-Id: I60f115d8fe2f557d83b7824090330eec1b07c395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949068Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#721124}
-
Tien Mai authored
This will change the presubmit checks for policy_templates.json to ensure that policy changes are backwards compatible with policies definitions that have already shipped. Bug: 1026330 Change-Id: If054d2376397432c66d948eaf0d2d42d5db13a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925190Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#721123}
-
Natalie Chouinard authored
Remove feature-specific Password logic from PreferencesLauncher to a dedicated PasswordManagerLauncher class. Bug: 1029194 Change-Id: I202d0156a98d112c97c88495c6edbec5b7fe50cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940610 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1018105, 1014859 Change-Id: I293216a4dfe9f6d56bae7a1dd09f73d74025f72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948840Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#721121}
-
Guillaume Jenkins authored
As mentioned in code review feedback on another spell check CL, the site isolation browser test file is getting large, and spell check stuff takes a good chunk of it. This CL moves the spell check site isolation tests to their own file, which is not compiled if spell check is not enabled. The CL also moves a base test class to its own .h and .cc files, since both the non-spell check and the spell check tests inherit from it. Other CL for context: https://chromium-review.googlesource.com/c/chromium/src/+/1918277 Change-Id: Iaea04af280859e42f916667c767a72ddaefcef92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945276 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#721120}
-
Takumi Fujimoto authored
Disabled on debug build for flakiness. Sample failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/15567 TBR=antrim Bug: 997685 Change-Id: Ie06d3ca41aa37181b9098dad0466eca551403b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949204Reviewed-by:
-
Eugene But authored
According to Download.IOSDownloadedFileStatusCode UMA metric there is non-trivial number of download failures with 405 http code (Method Not Allowed). This is because DownloadTask always creates NSURLTask with GET HTTP method regardless of the original HTTP method in the request. This CL adds support for POST request, because this is likely the easiest fix for the problem (I would be surprised if PUT and DELETE methods are used for downloads). We can add support for all HTTP methods later if necessary. Bug: 1030164 Change-Id: Ic3023fee44c580af7e4540b9de15ca957d43d047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948283 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#721118}
-
Nico Weber authored
Might work after #721015. Bug: 1024203 Change-Id: I9403a404c0027394e2256b51df5c6835dd03bb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948494 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#721117}
-
Demetrios Papadopoulos authored
Stop waiting on the lazy_load.html loading before expanding a settings subpage. Waiting is unnecessary, and also triggers an unfortunate iron-list behavior where no items are rendered when its dimensions are 0x0 (essentially when hidden). Waiting was introduced at r719484, and by removing the waiting the code works more similar to before, while still triggering the loading of lazy_load.html. Bug: 1029703 Change-Id: Iae1aaaa2eaf9227b61999201a020e60d2d048c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947957Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#721116}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6aa0bcb82820..be3109961d3d git log 6aa0bcb82820..be3109961d3d --date=short --first-parent --format='%ad %ae %s' 2019-12-03 tandrii@chromium.org Roll bb tool to @ b7405423 Created with: gclient setdep -r src/third_party/depot_tools@be3109961d3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1030156 Tbr: agable@chromium.org Change-Id: I7e82506f1f6c485a99b8a08f39dd67dd671b9119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947977Reviewed-by:
-
Tommy Li authored
Currently, when we get search suggest results back from ZeroSuggestProvider, nothing is bolded. This is inconsistent with as-you-type search suggestions. The root cause is that we purposely set AutocompleteInput::input_text to an empty string for all ZeroSuggest queries, to avoid leaking the user's current URL. (The URL is separately included in eligible). The lack of bolding is an unintended side effect. This CL fixes that, by re-classifying all the search suggest results that come back with the real input text on the client side. This is primarily intended to improve On Focus Query Refinements, but this will affect all ZeroSuggest modes that return search results from a non-empty omnibox. (Should not affect NTP). Note nothing is bolded at all when the input text is empty (on NTP). Navigational suggestions are not affected by this CL. They are currently not bolded at all. Bug: 963173 Change-Id: I7982c780f4b03f3d2b4992051d291fe1cd86f4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947765Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#721114}
-
