- 16 Nov, 2018 40 commits
-
-
Ehsan Karamad authored
This CL adds support for generating violation reports for 'layout-animations' feature policy. The new implementation triggers a report when: 1- CSS Parser finds usage of @keyframes for one of the banned styles. 2- element.animate() changes a banned style. Bug: 902836,867471 Change-Id: I79900603eb0166514d7986dc189ec914bd95f899 Reviewed-on: https://chromium-review.googlesource.com/c/1324138 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#608984}
-
David Black authored
A previous version of this CL was reverted because it caused any cards in the first Assistant response to be laid out with zero width: https://chromium-review.googlesource.com/c/chromium/src/+/1336525 This was caused by UiElementContainerView's width being set to zero due to its flex behavior when animating growth for the first time. We now impose a minimum height restriction on UiElementContainerView so that its width will not be set to zero and cards, which are sized according to the width of UiElementContainerView, will be laid out appropriately. Bug: b:119498360 Change-Id: I7c7a85aa1f3b506ed6a0f6dbdca628ae639e232b Reviewed-on: https://chromium-review.googlesource.com/c/1338960Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#608983}
-
Danyao Wang authored
Navigating away from an app-specific URL in restored session history is a special case that requires a reload to trigger theclient-side redirect in restore_session.html. about:newtab, which is used by the BrowserContainerContainsNTP feature, should be treated as an app-specific URL for this case. This fixes the regression in NavigationTestCase/testRestoreHistoryToNTPAndNavigateForward after enabling BrowserContainerContainsNTP. Bug: 905688 Change-Id: I96d4612152a003f3c7275720a01eb6376c3ff806 Reviewed-on: https://chromium-review.googlesource.com/c/1340761 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#608982}
-
Robbie McElrath authored
Depending on the startup timing, it's possible for NetworkChangeNotifier to create additional net logging, which can cause flakes in the NetExportFileWriterTest test. Change-Id: Ifb2217440b44620dc04769dea5c409992065499a Reviewed-on: https://chromium-review.googlesource.com/c/1340913Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#608981}
-
khmel@chromium.org authored
This allows not to use expensive and fragile set of adb commands and returns ARC provisioning state as it appears in Chrome. TEST=in context of crrev.com/i/717828 BUG=b:119349367 Change-Id: I3582fcca3e36a084dbe8e0ff3522930504ebeb85 Reviewed-on: https://chromium-review.googlesource.com/c/1340797Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#608980}
-
Xiaohan Wang authored
The explainer has been updated to formalize the minHdcpVersion string format to be "1.0", "1.1" etc. This CL updates Chromium's implementation to use the new string format instead of the old format, e.g. "hdcp-1.0", "hdcp-1.1", etc. Bug: 709348 Test: Existing tests updated. Change-Id: I4fe1061077228564fd6931d9900cfd19553dcf09 Reviewed-on: https://chromium-review.googlesource.com/c/1338576Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#608979}
-
Micah Morton authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9a5d5fab32aa..eb9630f2312f $ git log 9a5d5fab3..eb9630f23 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 mortonm system_api: Add constant for IsFsNosymfollowEnabled dbus method. 2018-11-12 cmtm login: support creating ARC server socket in Chrome Created with: roll-dep src/third_party/cros_system_api Bug: 867807 Change-Id: Ic0ebfda7528c999e4dd45738a93156dafe727786 Reviewed-on: https://chromium-review.googlesource.com/c/1340566Reviewed-by:
-
Peter Kasting authored
Changing the click tracking overlay view makes it clearer, when the test fails, if the overlay received a click or not. Touch events won't be supported on Mac for the foreseeable future, so #if those out entirely. Extract duplicated line from an #if. Bug: none Change-Id: I0eac1154459da170a9c6924a20cc290361a219ab Reviewed-on: https://chromium-review.googlesource.com/c/1338860 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#608977}
-
gogerald authored
previously, if there is no visual update or visual update has passed (page is stable), then the callback will not be called until the next visual update. In this CL, it will timeout in ~600ms. b/119486384 Bug: 806868 Change-Id: I4df02a283dd23c30060aae9a95163b5c02e8cb52 Reviewed-on: https://chromium-review.googlesource.com/c/1340559Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#608976}
-
Lei Zhang authored
TBR=jianli@chromium.org,piman@chromium.org,rdevlin.cronin@chromium.org Change-Id: I4a2871883bd28d525b960e89362545af57681c18 Reviewed-on: https://chromium-review.googlesource.com/c/1337375Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#608975}
-
Aiden Benner authored
GEN_JNI contains the actual native method declaration that corresponds to a method in an @JniNatives annotation. This change adds helpers to generate GEN_JNI with all proxy natives that are being registered in a generated registration header file. - Also fixes bug where hashed method names were escaped one too many times. - Adds better tests for special JNI type cases. Change-Id: Ie705d0cf55233c513ad4bc32024212454115bcba Bug: 898261 Reviewed-on: https://chromium-review.googlesource.com/c/1315687 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#608974}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/07ee63d076e5..19ec80fb37ce git log 07ee63d076e5..19ec80fb37ce --date=short --no-merges --format='%ad %ae %s' 2018-11-16 bsalomon@google.com Discard ops that don't have a finite bounds. 2018-11-16 bsalomon@google.com Fix dst copy bounds for aa draw contained within clip. 2018-11-16 mtklein@google.com there are no POSTAMBLEs 2018-11-16 herb@google.com Link SubRuns to Runs, and Runs to Blobs. 2018-11-16 reed@google.com Revert "remove SK_SUPPORT_LEGACY_NESTED_HINTINGENUM from flutter" 2018-11-16 reed@google.com Revert "remove dead code around SK_SUPPORT_LEGACY_FONT_FLAGS" 2018-11-16 reed@google.com remove dead code around SK_SUPPORT_LEGACY_FONT_FLAGS 2018-11-16 reed@google.com remove SK_SUPPORT_LEGACY_NESTED_HINTINGENUM from flutter 2018-11-16 csmartdalton@google.com Prefer GrAAConvexPathRenderer over ccpr 2018-11-16 jvanverth@google.com Revert "Remove use of integers for atlas indexing" 2018-11-16 reed@google.com remove SK_SUPPORT_LEGACY_FONT_FLAGS from flutter Created with: gclient setdep -r src/third_party/skia@19ec80fb37ce The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:905782,chromium:892988,chromium:860021 TBR=rmistry@chromium.org Change-Id: I7e4852fe7dc50d97201d734aa426e1e8dbfc22ba Reviewed-on: https://chromium-review.googlesource.com/c/1340574Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608973}
-
Eric Seckler authored
Moves resetting of TraceEventDataSource fields before flushing threads. This way, the thread's flush no longer races with the field resets. (If flushing occurs before the field resets, another thread may theoretically recreate its ThreadLocalEventSink before the resets, too.) Also flush the disabling thread in the same task, as a future task may be executed on a different worker thread. Bug: 903449 Change-Id: I13eb0d0a330ec66ffd826791f842c6fa7f8bd717 Reviewed-on: https://chromium-review.googlesource.com/c/1340325 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#608972}
-
Christopher Cameron authored
ScopedAccessibilityFocus should have changed the focus to return -[NSWindow accessibilityFocusedUIElement]. TBR=ellyjones Bug: 900846 Change-Id: I7813e4eb7099c69d1106630050b9581b4927d79b Reviewed-on: https://chromium-review.googlesource.com/c/1340911 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#608971}
-
Shawn Gallea authored
Move cursor_shapes interface out of server.cc This CL only moves code around. Bug: 896710 Test: Built on ChromeOS Change-Id: I43f93d25bf08f57d0f111ba99404a1fecb3723da Reviewed-on: https://chromium-review.googlesource.com/c/1324139 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#608970}
-
Michael Thiessen authored
Also refactors control container height resource to match how we handle the control container layout resource. Change-Id: I1ea13d9adf54a01e18cbf9cb5721883a2d0fdab4 Reviewed-on: https://chromium-review.googlesource.com/c/1338330 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#608969}
-
Michael Thiessen authored
This can happen when the Activity is recreated early during initialization, so we handle it be ignoring the saved instance state and loading as usual. Bug: 906172 Change-Id: I010803be39d698425bd1e38b2d34c95f2c658a34 Reviewed-on: https://chromium-review.googlesource.com/c/1340901Reviewed-by:
-
Matthew Denton authored
Deleted our custom sqlite fuzzers that crash on startup. Also added a patch for the upstream version of ossfuzz.c so that it will actually compile and run with our config (SQLITE_OMIT_PROGRESS_CALLBACK and SQLITE_OMIT_AUTOINIT both caused issues). Bug: 900482 Change-Id: Ib314a8589b6c7b6e53704a2ae15bf69c0a62fcdf Reviewed-on: https://chromium-review.googlesource.com/c/1330292 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#608967}
-
Krishna Govind authored
R=abdulsyed@chromium.org Change-Id: I472e2df34f72653c3b0a47b863f58dbbe9eef0b8 Reviewed-on: https://chromium-review.googlesource.com/c/1340336Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#608966}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8ada4d523eb4..5705acabe03a git log 8ada4d523eb4..5705acabe03a --date=short --no-merges --format='%ad %ae %s' 2018-11-16 borenet@google.com [gclient] Make getdep and setdep to provide builtin vars Created with: gclient setdep -r src/third_party/depot_tools@5705acabe03a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:906114 TBR=agable@chromium.org Change-Id: I7cd2e8320bed36ed8d30aa1cf7d8ae6abe1cf766 Reviewed-on: https://chromium-review.googlesource.com/c/1340575Reviewed-by:
-
Alexander Shah authored
Splits |sink_map_| into two maps to differentiate between RootCompositorFrameSinkImpl and CompositorFrameSinkImpl. |sink_map_| is only used for lifetime management. The purpose of the change is to allow greater access to the CompositorFrameSinks than is given through mojom::CompositorFrameSink. R=sadrul@chromium.org Change-Id: I86da2c6094afa9a7d14ca1347c9e636e7c7f08fe Reviewed-on: https://chromium-review.googlesource.com/c/1340789Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Alexander Shah <zandershah@google.com> Cr-Commit-Position: refs/heads/master@{#608964}
-
Ella Ge authored
This reverts commit 390c941f. Reason for revert: causing layout test failure crbug.com/906174 Original change's description: > Stop ExpandRange/EndToSentenceBoundary from using VisiblePosition > > This patch stops the two functions from using VisiblePosition by switch > to the VP-free versions of Start/EndOfSentence(). Hence, this patch > reduces the usage of legacy VisiblePosition. > > Bug: 657237 > Change-Id: I933a020f9bd6643ba1b2cd5111b8be18b2f49086 > Reviewed-on: https://chromium-review.googlesource.com/c/1337816 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608849} TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org Bug: 657237, 906174 Change-Id: I915e9d68f16a11344b0160db4c5702113380273a Reviewed-on: https://chromium-review.googlesource.com/c/1340899 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#608963}
-
Mohamed Heikal authored
WebappActivity inflates its UI asynchronously thus the tab model may not be initialized during early startup. Calling ChromeActivity.getCurrentWebContents (happens on back button press), would crash chrome if the Tab Model is not initialized yet. This cl fixes the issue and makes ChromeActivity.getCurrentWebContents return null instead. Bug: 905583 Change-Id: I4add9cc2f41bb2544e279dd597b7b58a2f68b374 Reviewed-on: https://chromium-review.googlesource.com/c/1340917Reviewed-by:
-
Sam Maier authored
Bug: 872904 Change-Id: If03fdf11044f35fc1a475d9d1b40641fa1d67110 Reviewed-on: https://chromium-review.googlesource.com/c/1340785Reviewed-by:
-
Bo Liu authored
PreSandboxStartup is called in browser process as well where there is no kLang argument. For browser, the locale is set in PostEarlyInitialization. So check for browser process (empty kProcessType) and skip setting icu locale in PreSandboxStartup. Bug: 905910 Change-Id: Ie2dd1f84b81a61479ae87d96f02c36ea40780bb6 Reviewed-on: https://chromium-review.googlesource.com/c/1340562Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#608960}
-
Peter Kasting authored
This updates the comments on the other tests to have TODO form. Bug: 163931, 823543, 824418 Change-Id: Ic82109fb4513a6b8053477ac28e5ee3969799f52 Reviewed-on: https://chromium-review.googlesource.com/c/1334842Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#608959}
-
Oystein Eftevaag authored
This event is extremely frequent and contributes heavily to trace size bloat, which is negatively affecting a lot of the testing infrastructure. Reducing the size of the event and removing the args which are not useful in this case. R=gab@chromium.org BUG=902064 Change-Id: Id7d0ecba3ed084f5ef30d7a29554b14c6a68b963 Reviewed-on: https://chromium-review.googlesource.com/c/1330067 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#608958}
-
Ella Ge authored
This reverts commit 775938b6. Reason for revert: need to revert this to revert r608849 Original change's description: > Change Range::expand() to VisiblePosition-free functions for word and sentence > > This patch changes Range::expand() to call VP-free version of word and > sentence start/end functions, by hoisting the creation of VP from > the functions into itself. In this way we reduce the usage of functions > relying on VP. > > Bug: 657237 > Change-Id: I56ea3cb88972144887eba7701cfdc3628bdbf67b > Reviewed-on: https://chromium-review.googlesource.com/c/1338719 > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608855} TBR=yosin@chromium.org,tkent@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org Bug: 657237, 906174 Change-Id: I46b8df3cfd8ed7f7636f9ef1dabfa350168cb820 Reviewed-on: https://chromium-review.googlesource.com/c/1340906Reviewed-by:
-
Bin Wu authored
Merge internal change: 221684051 R=rch@chromium.org Change-Id: I124ca8f5573966b7c8df35b28793003b834620a4 Reviewed-on: https://chromium-review.googlesource.com/c/1340399Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#608956}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d7cd1203a42b..28d8d7bc673a git log d7cd1203a42b..28d8d7bc673a --date=short --no-merges --format='%ad %ae %s' 2018-11-16 33432579+alan-baker@users.noreply.github.com Fix min base alignment (#2075) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@28d8d7bc673a The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1edd77b44e26cb3624ede1bb0f42ecea2c74c249 Reviewed-on: https://chromium-review.googlesource.com/c/1340573Reviewed-by:
-
Aiden Benner authored
See bugs for rationale Bug: 904912,906160 Change-Id: Ib3e45f2eee2189e90179a6857e5878342c9393ce Reviewed-on: https://chromium-review.googlesource.com/c/1340900Reviewed-by:
-
Ella Ge authored
This reverts commit 4c95576e. Reason for revert: live-edit-no-reveal.js failed on mac bots crbug/906189 Original change's description: > [LayoutTest] Rebaseline live-edit-no-reveal.js after V8 roll > > Bug: V8:8405 > Change-Id: I150f74bf5de8c0a2cd784e6d1399c1c702c2936e > Reviewed-on: https://chromium-review.googlesource.com/c/1339961 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Dan Elphick <delphick@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608839} TBR=rmcilroy@chromium.org,delphick@chromium.org Change-Id: I8d115789c789b22379fc95e418af388edeaea41b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: V8:8405, 906189 Reviewed-on: https://chromium-review.googlesource.com/c/1340943Reviewed-by:
-
Robert Kroeger authored
WebglConformance_conformance_textures_video_tex_2d_rgba_rgba_unsigned_short_5_5_5_1 is failing intermittently on Nexus9. Suppress. BUG=906158 TBR=kbr@chromium.org Change-Id: I1311556d5d2fc040c2b9e7c256a25b1bf0a7c18d Reviewed-on: https://chromium-review.googlesource.com/c/1340866Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#608952}
-
Bruce Dawson authored
ARM64 on Win32 adds a third Win32 target platform which requires updates to the script which configures the toolchain. This includes handling build\win_toolchain.json listing either two or three toolchains, and not copying UCRT DLLs in the ARM64 case, except for ucrtbased.dll. This also fixes some erroneous double quotes, probably left over from previous changes I made to this file. This is in preparation for landing and then using crrev.com/c/1330185 Bug: 893460 Change-Id: I1fa775b662e3c0483174c32ad3c73f30f2802ea9 Reviewed-on: https://chromium-review.googlesource.com/c/1339101Reviewed-by:
-
Lily Chen authored
This reverts commit dc8c60c3. Reason for revert: Bug causing crashes was fixed in https://crrev.com/c/1333135 Original change's description: > Revert "Add reprioritization to SSLConnectJobs" > > This reverts commit 8a9302e2. > > Reason for revert: Causing flaky crashes in external/wpt/webusb/idlharness.https.any.worker.html > > Original change's description: > > Add reprioritization to SSLConnectJobs > > > > This change allows the priority of an SSLConnectJob to be changed. If > > the reprioritization occurs while the job is establishing its underlying > > connection, the priority change is also passed down to the lower-level > > socket pool. > > > > Bug: 166689 > > Change-Id: I87d1e536846443901cc628423f4615c3ffa7542a > > Reviewed-on: https://chromium-review.googlesource.com/c/1327423 > > Commit-Queue: Lily Chen <chlily@chromium.org> > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#606876} > > TBR=mmenke@chromium.org,chlily@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 166689, 904345 > Change-Id: I6458798e11d210258f2a26330548f1ca33eb6c90 > Reviewed-on: https://chromium-review.googlesource.com/c/1331139 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Lily Chen <chlily@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607301} TBR=mmenke@chromium.org,chlily@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 166689, 904345 Change-Id: I54fe803331be6fe3df534c0f6042bf0fb0057cbb Reviewed-on: https://chromium-review.googlesource.com/c/1340824Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#608950}
-
Min Qin authored
Currently DownloadDB records some of the persistent for DownloadItem. And DownloadItem will constantly requesting these data from the DownloadDBCache during its life cycle. Which is unnecessary as these data are already passed to DownloadItem during the creation time. This CL allows DownloadItem to cache those persistent data after creation. So there is no longer any need to request them again, and we can remove them from the DownloadDBCache in future CLs to save memory. BUG=893651 Change-Id: Ic360bd81e283272105ef9d43d91e2b8dd00d9145 Reviewed-on: https://chromium-review.googlesource.com/c/1338328Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608949}
-
Evan Stade authored
It was added in 2012 for PrintPreviewTest but is no longer needed and is causing issues with single process mash tests, where OzonePlatform only expects to get initialized once. If this happens in a test's SetUp(), and parts of it get destroyed by the AtExitManager, they won't be re- initialized for later tests. Tests will still pass in isolation but not when run as a suite. This CL also simplifies PrintPreviewTest a bit, which is the test fixture for which the AtExitManager was originally added. Bug: 905430 Change-Id: I4617aed098962f4eea6a9d1bfe052e3902278557 Reviewed-on: https://chromium-review.googlesource.com/c/1340798Reviewed-by:
-
Justin Cohen authored
This happens when clearing browser data, and forces the NTP to be recreated (and not show previous NTP tiles). Bug: 905735 Change-Id: If818e02703c7324f0a660bf6b115603db3682b74 Reviewed-on: https://chromium-review.googlesource.com/c/1339340Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608947}
-
Ella Ge authored
TBR=kbr@chromium.org BUG=906092 Change-Id: I11105b926d35b5bcb16c2930c04f98db20e5f4b4 Reviewed-on: https://chromium-review.googlesource.com/c/1340788Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/09299cdfd973..4d0fac4a2c9e git log 09299cdfd973..4d0fac4a2c9e --date=short --no-merges --format='%ad %ae %s' 2018-11-16 tsepez@chromium.org Remove some unused strings from CFX_CSSData tables. Created with: gclient setdep -r src/third_party/pdfium@4d0fac4a2c9e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7108ae0af76028e59a5cc51eeedcf69a9094f9fc Reviewed-on: https://chromium-review.googlesource.com/c/1340572Reviewed-by:
-
