GitLab

AudioSyncReader::shared_memory_region() is never called more than once. If we
return a region from this function by value, we don't have to duplicate the
region.

This is a follow-up to https://crrev.com/c/1068928

Bug: 844508
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I22ac7f9bae926ed418c025ac0a8487b98659817a
Reviewed-on: https://chromium-review.googlesource.com/1069352Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561411}

https://pdfium.googlesource.com/pdfium.git/+log/602f06cfb107..18f7fbca4612

$ git log 602f06cfb..18f7fbca4 --date=short --no-merges --format='%ad %ae %s'
2018-05-24 thestig Mark some pointers as non-const in CPDF_NameTree.
2018-05-24 thestig Improve constness for more CPDF_Objects pointers.
2018-05-23 thestig Remove GetBits32().
2018-05-23 thestig Avoid repeated calculations in CFX_BitStream::GetBits().
2018-05-23 thestig Add unit test for CFX_BitStream.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ia95af36aa7ddcdf1ae8e677e1cdc454719f0a97b
Reviewed-on: https://chromium-review.googlesource.com/1071167Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561410}

This is an early prototype to show a manual fill option to the user.
- Using showcase so designers and PMs can play with it.
- Currently the iPad and iPhone specific code is separated in two demos
  to allow quick experimentation.
- iPhone Screenshots
  - https://drive.google.com/file/d/1PbwOiCadB0xRdT9-no-wy8mhfwBv9NCL
  - https://drive.google.com/file/d/1uTqpQVmpHFIZC7mr3LM7RF24xAdxYbjh
- iPad Screenshoots
  - https://drive.google.com/file/d/1Y5yUSO-0Dv6bsx3_F6LV41Us95TKKIlL
  - https://drive.google.com/file/d/19Va4ku9-vvE9doZ6naSUr4iicovfmcOg

Bug: 845472
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0475b630641152fe57d4c246608f75e94d2619fd
Reviewed-on: https://chromium-review.googlesource.com/956486
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561409}

The feature is behind a flag and I'm fairly sure this is an issue with the test itself,
so I'm disabling it for TSan while investigating.

Tbr: primiano@chromium.org
Bug: 846204
Change-Id: Ie0e05a35ceef124722e3cef545a2bc945a5b7849
Reviewed-on: https://chromium-review.googlesource.com/1071075Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561408}

Implementations of WebMIDIAccessor in //content holds an raw pointer to
MIDIAccessorClient, however, the pointer may be invalid between GC marking
and its sweeping.

This CL removes the pointer by clearing WebMIDIAccessor itself on the
context destruction.

Bug: 846182
Change-Id: I857769a34b6c64e48b0540a117b29c94194ed611
Reviewed-on: https://chromium-review.googlesource.com/1071157Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561407}

Move anonymous namespace union ThreadRef to non anonymous namespace
to avoid this warning in GCC:
/../../../chromium-68.0.3432.3/base/debug/activity_tracker.cc:605:31:
warning: 'base::debug::ThreadActivityTracker::Header' has a field
'base::debug::ThreadActivityTracker::Header::thread_ref' whose type
uses the anonymous namespace [-Wsubobject-linkage]
 struct ThreadActivityTracker::Header {

It is discouraged to use in a public type a type declared in an
anonymous namespace. It should not be a problem in our case as it
is only used internally in activity_tracker.cc, but GCC will still
complain in jumbo build as the .cc is used as an include.

Change-Id: I121af0053b5ee51661be99ae4470512909416859
Reviewed-on: https://chromium-review.googlesource.com/1066001
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561406}

BUG=None
TEST=None

Change-Id: Idb4c7792493141c7b95ea8f240b197991c67b3e9
Reviewed-on: https://chromium-review.googlesource.com/1070954Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561405}

https://skia.googlesource.com/skia.git/+log/13235d8966e4..27f5a0df4a28

$ git log 13235d896..27f5a0df4 --date=short --no-merges --format='%ad %ae %s'
2018-05-23 khushalsagar Reland fonts: Cleanup cache miss logging for font remoting.
2018-05-23 khushalsagar Reland fonts: Add support for distance field text to font remoting.
2018-05-23 csmartdalton ccpr: Handle winding and even-odd in the same shader

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=allanmac@chromium.org

Change-Id: I84f83ee900d04da9d48d1423f56d6f4ed1f90992
Reviewed-on: https://chromium-review.googlesource.com/1071121Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561404}

Change-Id: I881f3cd54a59b5aedfb3cfb9e2e49925768509bd
Reviewed-on: https://chromium-review.googlesource.com/1071152Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561403}

TBR=fhorschig@chromium.org,fdoray@chromium.org

Bug: 846121
Change-Id: I8056ceedd453daf33f210cae953deb10a148cc26
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1071329Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561402}

This CL lets ServiceWorkerProviderHost get the resource context from
ServiceWorkerContextWrapper directly, rather than getting from
ServiceWorkerDispatcherHost, then we no longer need to keep a resource
context in each ServiceWorkerDispatcherHost.

BUG=845341

Change-Id: Ia6dd603055607b3e2d53f5bbc7d5095c9514f954
Reviewed-on: https://chromium-review.googlesource.com/1068268Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#561401}

Blink had a bug that sync XHR would timeout after 10 seconds. Add a
regression test to make sure the issue does not reoccur.

BUG=844268

Change-Id: I161e133582b719102a02349828cd4d9a08773785
Reviewed-on: https://chromium-review.googlesource.com/1070089
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561400}

This CL makes the following modifications to the download notification
text:
- Moves time remaining (if known) to the subText/contentInfo.
- Changes the contentText to display percent downloaded, bytes
downloaded, or files downloaded.  The current primary usage will be of
bytes downloaded, which will have the format "XX KB / YY MB" or "XX KB /
?" if the total is unknown.

BUG=845324

Change-Id: Iaf331b6d31c21863ee0a653399d3226e1816dbbd
Reviewed-on: https://chromium-review.googlesource.com/1068127
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561399}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: Ib56847fac69d87b3a296023749357470af80566e
Reviewed-on: https://chromium-review.googlesource.com/1071348Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561398}

This is a reland of 49d49cc1

Relanding with additional upstream CLs (last one fixing the libfuzzer targets):
   $ git log a6f6a3133..a98de15f3 --date=short --no-merges --format='%ad %ae %s'
    2018-05-23 oysteine Fixed unresolved dependencies on fuzzer targets for the Chrome build
    2018-05-23 lalitm perfetto: add ability to override upload limit flag on debuggable builds
    2018-05-23 lalitm perfetto: move sqlite to the non-ui build deps
    2018-05-22 lalitm perfetto: add sqlite to ui part of buildtools
    2018-05-22 hjd Fix clean build of UI

Original change's description:
> Roll src/third_party/perfetto/ a6f6a3133..d1fe1ee42 (39 commits)
>
> https://android.googlesource.com/platform/external/perfetto.git/+log/a6f6a3133cf7..d1fe1ee42456
>
> $ git log a6f6a3133..d1fe1ee42 --date=short --no-merges --format='%ad %ae %s'
> 2018-05-21 oysteine Re-enabled TraceWriter flushing on destruction
> 2018-05-21 hjd Fix mac build
> 2018-05-21 fmayer Tune values for ftrace_largebuffer.
> 2018-05-21 fmayer Change LOCKDOWN_UNSET to LOCKDOWN_UNCHANGED.
> 2018-05-18 brucedawson Disable features that fail in Chromium builds
> 2018-05-18 fmayer Add test config with larger buffer size.
> 2018-05-18 brucedawson Changes to get Perfetto tracing in Chrome for Windows
> 2018-05-18 fmayer Change wording in trace_to_text output.
> 2018-05-18 fmayer Correctly handle EINTR.
> 2018-05-17 fmayer Output duration of ftrace as well as total trace duration.
> 2018-05-17 primiano Add tdresser@ to ui/OWNERS
> 2018-05-17 dproy Rerun ninja when UI source files change
> 2018-05-17 brucedawson Fix Perfetto export definitions for Windows
> 2018-05-17 primiano Fix fuzzers and reduce noise from ftrace_parser unittest
> 2018-05-16 primiano Add skeleton for UI (Node + TypeScript + WASM  + build integration)
> 2018-05-08 primiano Clean up some TODOs and use PageAllocator in CpuReader
> 2018-05-15 lalitm perfetto: update docs to keep in sync with other copies
> 2018-05-15 fmayer Add -b flag to tools/tmux to run in background.
> 2018-05-15 primiano Roll GN, clang and libc++ to match chromium revisions
> 2018-05-14 primiano Fix mac build, make pipe_stats linux-only
> 2018-05-14 brucedawson Enable protozero tests on Windows
> 2018-05-14 brucedawson Use relative path to import perfetto.gni
> 2018-05-10 brucedawson Get page allocator working on Windows
> 2018-05-10 fmayer Add sanity check for page size.
> 2018-05-10 primiano Introduce WASM toolchain
> 2018-05-10 lalitm protos: fix typos for lint to be happy
> 2018-05-09 fmayer Use dynamically read header_page information.
> 2018-05-09 fmayer Add metatracing to trace perfetto itself.
> 2018-05-09 fmayer Add PRESUBMIT to protect whitelist.
> 2018-05-09 fmayer Add compile_commands.json to gitignore.
> 2018-04-30 hjd trace_to_text: Print FtraceStats
> 2018-05-09 fmayer Allow to parse events/header_page.
> 2018-05-08 brucedawson Enable more unit tests on Windows
> 2018-05-08 fmayer Add script to visualize pipestats.
> 2018-05-08 fmayer Add tool to analyze rate of events.
> 2018-05-08 primiano Limit concurrent traces to 5 to prevent stalls in traced_probes
> 2018-05-08 fmayer Temporary workaround for 32-bit crashes.
> 2018-05-04 fmayer Fix off by one.
> 2018-05-03 fmayer Increase ftrace buffer. Decrease i/o scan batches.
>
> Created with:
>   roll-dep src/third_party/perfetto
>
> Change-Id: I0e085bac9d14b1c55b1be527cd80e4f206240308
> Reviewed-on: https://chromium-review.googlesource.com/1068622
> Commit-Queue: Primiano Tucci <primiano@chromium.org>
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560522}

TBR=primiano@chromium.org

Change-Id: I35dad57beeddecb99f4ec48395397714feefd77d
Reviewed-on: https://chromium-review.googlesource.com/1070538
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561397}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ebdd0db493b2..1f156687a201

$ git log ebdd0db49..1f156687a --date=short --no-merges --format='%ad %ae %s'
2018-05-23 agrieve gerrit/api.py: Add get_revision() helper.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:702625


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I36402206ada18e96a8e50729e37fddb326127a03
Reviewed-on: https://chromium-review.googlesource.com/1071168Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561396}

Move wrapper tracing visitation to regular blink::Visitor and inherit
from that in blink::ScriptWrappableVisitor. This is prework for removing
TraceWrappers and solely rely on Trace methods, even for wrapper tracing.

The bigger idea is to bring Trace in sync with TraceWrappers and drop
TraceWrappers completely. The visitors should distinguish which part
of the graph the would like to trace.

Bug: chromium:841830
Change-Id: Iae4d000318f8fd2f81eb9c66ed0a625699bada34
Reviewed-on: https://chromium-review.googlesource.com/1068890Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561395}

FilesApp will only show crostini integration when
features::kExperimentalCrostiniUI is enabled.  There is no need
for a dedicated crostini-files flag.

Bug: 834103
Change-Id: I019f56abe6348b6723c0de9b86425d05b0fe22f4
Reviewed-on: https://chromium-review.googlesource.com/1068584
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561394}

BrowserCompositorMac has historically rolled its own surface sync
via the Suspend/Unsuspend functions, and compositor_suspended_lock_
in RecyclableCompositorMac. This no longer works in MacViews browser,
because we no longer use RecyclableCompositorMac.

Leave the Suspend/Unsuspend code in place for the non-MacViews case.

Split up UpdateSurfaceAndUnsuspend
- Make it just update the surface size
- Call it whenever the compositor is recycled or the surface resizes
- Move the AddRootLayer to TransitionToState

Add a GetDeadlinePolicy method
- When using surface sync, return a deadline of 8 frames (empirically
  works well for retina displays)
- Otherwise return an immediate deadline.

Bug: 840173
Change-Id: I6a1de5698e73d754ee03d9db8f4a97480c71dfb3
Reviewed-on: https://chromium-review.googlesource.com/1069834Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561393}

It was needed because "it's hard to handle IPC errors synchronously",
but we don't have that problem now with mojo IPC. It is not only
redundant but also harmful because it breaks a WebSocketClient contract:
OnFinishOpeningHandshake must precede OnAddChannelResponse.

Bug: 721400
Change-Id: Idd475140d4aef1d49f001855ff80fcf8d5f99cda
Reviewed-on: https://chromium-review.googlesource.com/1068784Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561392}

This (appropriately) DCHECKs when attempted. Skip event routing (send
directly to the root RWHV) when no frame sink is present.

Bug: 844095
Change-Id: I867c9f6cb7135473fc52fb44dcff7ed5e1759658
Reviewed-on: https://chromium-review.googlesource.com/1071120Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561391}

Setting the background color on delegated layers can cause artifacts
(only non-tiled areas get the background color). This also appears
not to have been necessary.

Bug: 845968, 840173
Change-Id: If8eca7d3eb793952a9a606a2d27683b02d2c4b3f
Reviewed-on: https://chromium-review.googlesource.com/1071117Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561390}

The method RenderWidgetHostViewMac::GetOffsetFromRootSurface is to be
used to indicate where the view is in its root ui::Compositor. It used
to be that the two were always aligned, but now they can be offset.

Bug: 846018, 	840173
Change-Id: Id3f761d56c75ebd33b75c40c05d46a84b485d162
Reviewed-on: https://chromium-review.googlesource.com/1070883Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561389}

This CL sets up a subsequent CL which refactors a shared chunk of code
out of the browsertest file.

These files are being checked in as-is (i.e. trigger a number of
formatting warnings) however they aren't included in any build files
so they shouldn't cause any build issues and will be fixed in the
follow-up CL.

TBR=sky@chromium.org

Change-Id: I428463c0a6c9e942899a44c76bebb2e0e0b34856
Reviewed-on: https://chromium-review.googlesource.com/1071070Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561388}

This reverts commit fe197c07.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 561305 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZlMTk3YzA3ZDE2ZjdiZWQzNTQ0NTRhZDYzOTkxYmI5YjRmYWE1MjYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27583

Sample Failed Step: display_unittests

Original change's description:
> Minor bug fix for incorrect DCHECK in display util
> 
> This patch fixes an incorrect DCHECK that was landed in the previous
> patch. The DHCECK_LT should instead be DCHECK_GT.
> 
> Bug: 839458
> Change-Id: I4b45aae9a1cb1c3870774b4c3e2d654ffbf7bb4f
> OriginalChange: I4d5bd761506c6ec14dc92b3d3a120b87e02e2cb7
> Component: Display util, dsf, zoom levels
> Reviewed-on: https://chromium-review.googlesource.com/1070619
> Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561305}

Change-Id: I803ccaa9ecb839f2efc4499c9f78dfbf346578ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839458
Reviewed-on: https://chromium-review.googlesource.com/1070892
Cr-Commit-Position: refs/heads/master@{#561387}

Quick update after the fix for an uninitialized variable[1]
that caused random crashes depends on memory layout.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1068793

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iba5b6b13e199d4ff5a3f67611c5e7158c79ac5b2
Reviewed-on: https://chromium-review.googlesource.com/1068792
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561386}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic5bb4506dccaa78871f025f235592a6401240141
Reviewed-on: https://chromium-review.googlesource.com/1067689Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561385}

As per crbug.com/788015 Comments 1,5:
- Fix padding sizes
- Change button text "Dismiss" -> "Got it"
- Make a button default (blue)
- Replace "Learn more" link with (?) button
  - Button has a11y text and is Tab stop
- Remove X (Close) button from upper right
- Clean up code, use standard LayoutProvider

Bug: 788015
Test: Set up a new Chromebook with Goodies offer available, witness a
dialog living in Harmony

Change-Id: I95058420c54a1b2b48881b95b458971ec163a8ae
Reviewed-on: https://chromium-review.googlesource.com/1040868
Commit-Queue: Greg Levin <glevin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561384}

Disable persistent heap collections on non-main thread, so we only have to worry about Persistents when terminating a thread.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibcbde2d3fe4bce1534999d19be3188d477e958d5
Reviewed-on: https://chromium-review.googlesource.com/1058994Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561383}

I2S Link: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Na7aTFJOpWs/_tpdtav8CAAJ
Plan is to flip the flag before branch cut and unflip if Intent doesn't go through.

Change-Id: I4564e4180b7903f67ac6186390b6c5d1acb74cb7
Reviewed-on: https://chromium-review.googlesource.com/1070448Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561382}

Merge output is important to see any counter overflow warnings.
On coverage bot, this is already captured. So, support similar
functionality in verbose mode.

R=mmoroz@chromium.org,liaoyuke@chromium.org

Bug: 844432
Change-Id: I5bffb5c8d1c5b0748c66ebed3e4becca7619a3eb
Reviewed-on: https://chromium-review.googlesource.com/1070997Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561381}

We only set the format_modifier_ field if the GBM_BO_USE_SCANOUT flags
was set. On platforms where we can't scanout NV12, we fall back to
allocating GbmBuffers without the scanout flag and consequently end up
assuming those are all linear. Except libva, which picks up the tiling
from the kernel bo and decodes with y-tiling enabled.

We need to always and unconditionally store the format modifier, it's
as much part of the buffer meta data as the pixel format. Move
assignment to initializers.

Bug: 845076
Test: crosvideo.appspot.com plays correctly on pre-KBL Intel chromebooks
Change-Id: I74c435807947afb60ea4417ace39751e213792bc
Reviewed-on: https://chromium-review.googlesource.com/1070995
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561380}

This CL makes ScriptElementBase::Loader() protected, and thus
after this CL PendingScript no longer has access to ScriptLoader,
making separation between PendingScript and ScriptLoader more strict.

XML/HTMLParserScriptRunner previously get ScriptLoader via
ScriptElementBase, but after this CL they get ScriptLoader
directly via ScriptLoaderFromElement().

No behavior changes.

Bug: 842349
Change-Id: I5104c0817669e871a68b8d8286d037e3e23622cc
Reviewed-on: https://chromium-review.googlesource.com/1054855
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561379}

The layout test unnecessarily depends on a non-standard behavior
that, HTMLElement.offsetLeft returns non-zero result even for
inline elements without any box (*). The test fails with LayoutNG
as the behavior isn't implemented there.

This patch changes the layout test to compute mouse coordinates
from non-empty inline elements, so that it passes.

(*) https://drafts.csswg.org/cssom-view/#dom-htmlelement-offsetleft:
    "... Return the result of subtracting ... from the x-coordinate of
     the left border edge of the first CSS layout box associated with
     the element ..."

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I35beeb83674a034486b00890f6267ab778892087
Reviewed-on: https://chromium-review.googlesource.com/1070937
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561378}

Sometimes, another app can grab the focus while the confirm-to-quit bubble is
showing. When this happens, Chrome won't get the key release event and the
bubble will stay open forever.  The only way to close it would be to press
Ctrl+Shift+Q again, but this would close Chrome.

This CL closes the confirm-to-quit bubble and resets the state of the controller
when this happens.

BUG=243164
R=sky

Change-Id: I1800501be3cd4896876347ce2fb511a08e90eba7
Reviewed-on: https://chromium-review.googlesource.com/1069487Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561377}

These 2 files "connection.js" and "es6_workaround.js" seem to be to
backport some definitions from ES6 and newer Web APIs not covered by
Closure compiler "back on the day", to be able to compile with these
methods that were already available in our Chromium version.

I've run Closure compiler locally as well as in the bots, so Closure
seems to support these on it current version.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I48f61c9bf439fb8c438dc0155e00f0db9610d96c
Reviewed-on: https://chromium-review.googlesource.com/1068586Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561376}

In Watchdog implementation we notify another thread not holding the
lock. Here
https://www.chromium.org/developers/lock-and-condition-variable it's
stated we need to put Signal() inside the critical section to avoid hard
to find bugs.


Change-Id: I60725d2a33a87ff9067b779f11b372a22e006e10
Reviewed-on: https://chromium-review.googlesource.com/1018462Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561375}

Before https://crrev.com/c/657787, FetchParameters::MakeSynchronous() always
calls SetTimeoutInterval(10). So I thought that 10 second is the default timeout
for all synchronous resouce loading.

But this was wrong. The TimeoutInterval of ResourceRequest was not used. After
the CL the value is used for the timeout in SyncLoadContext. But the default
timeout of sync XMLHttpRequest must be infinite. This caused the bug 844268.

To fix this bug, this CL stops resetting 10 sec timeout in MakeSynchronous().

Bug: 844268
Change-Id: I7295ec78637548dc810bb3a8a12a54db4cfbc368
Reviewed-on: https://chromium-review.googlesource.com/1068893Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561374}

Request bodies may be a blob if NetworkService is disabled. We need to plumb it
to a service worker world if we ship NetS13nSW without NetworkService.
After this CL, there are three cases of how to send the request body to the
service worker's fetch event.

(A) NetworkService is on
In this case, blobs should be passed as a data pipe. Data pipes will be included
by a network::ResourceRequestBody.

(B) NetworkService is off and ServiceWorkerServicification is on
Blobs should be passed as a blink::mojom::BlobPtrs, but
network::ResourceRequestBody cannot contain the blink::mojom::BlobPtrs. Instead,
the BlobPtrs are passed as a parameter of DispatchFetchEventParams separately.

(C) NetworkService and ServiceWorkerServicification are off
All request bodies are passed as a blob. The information of the blob is passed
as three parameters of DispatchFetchEventParams.

Bug: 830292
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I36eb0e08e80ae9feb5af926af4b97757607c1950
Reviewed-on: https://chromium-review.googlesource.com/1046426
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561373}

This CL removes MockScriptLoader definition,
migrates MockScriptLoader::Create*() to MockPendingScript, and
makes ScriptLoader final.

Other changes to test bodies are mechanical:
- Replaced script_loader with pending_script,
- Replaced ScriptLoader with PendingScript,
- Remove "->GetPendingScriptIfControlledByScriptRunner()",

Bug: 842349
Change-Id: I515890efeaffcb0f8dc8c9dad1102591974e8d67
Reviewed-on: https://chromium-review.googlesource.com/1056399
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561372}