- 07 May, 2019 40 commits
-
-
Nate Chapin authored
https://html.spec.whatwg.org/multipage/semantics.html#get-an-element's-target Bug: 959973 Test: http/tests/navigation/location-navigate-iframe-with-base-target.html Change-Id: Id49d355d41b75a9911365da6cb57e895d266fa72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599770Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#657400}
-
Ionel Popescu authored
Bug: 959883 Change-Id: Icd7fb49bd7d4d0d7df18817932c33fdb4c0b5700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594349 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#657399}
-
Ryan Hansberry authored
Creates metrics to capture the success rate of Bluetooth pairing attempts for each valid Bluetooth transport type. Also creates an enumerated metric which captures which Bluetooth transport type was used for each pairing attempt, which will allow us to determine if invalid or unknown transport types are being used. See go/cros-bt-metrics for more. Bug: 953149 Change-Id: I99059b9d90311b7389b68c91a245e4fe6921e38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585384 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#657398}
-
Elly Fong-Jones authored
Bug: None Change-Id: Ie0f73b9cc7457bd4b39a73f26bb862e848f62611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598489 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#657397}
-
Vladimir Levin authored
This patch adds a link to a rasterize and record benchmark documentaiton. R=crouleau@chromium.org Change-Id: I5454a1cd31e0077ade04bc1311f1b5fa2ee3946f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599592Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#657396}
-
Richard Townsend authored
Ran `tools/clang/scripts/upload_revision.py 360094`. Bug: 893460, 959872 Binary-Size: Compiler fluctuations; yesterday's roll saved 150kB Change-Id: I520e8bed7319a3df6240e49193cc086a3c114d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599010Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#657395}
-
Bo Liu authored
Update isAtLeastQ and targetsAtLeastQ to use api numbers. Bug: 960342 Change-Id: Ie05ba40a6bf20cc096d0dfcf59d9e651e0babaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598491Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#657394}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/94a9e615..887824b5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I21c4c165683beaf30edd1fbbd0f346604f9b789d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598838Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657393}
-
Yining Wang authored
Initial browsertest for ManifestWebAppBrowsercontroler. Test on page load for example website in Focus Mode window. Bug: 960447 Change-Id: Id502e8d04874e9377a4b0d56f1474e2d96496b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597122 Commit-Queue: Yining Wang <yiningwang@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#657392}
-
Peng Huang authored
Bug: 960473 Change-Id: Ie6694f1d00ded966e17b6613b852b4bbc41e931f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598718 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#657391}
-
Yue Li authored
Add GetInitParams(.) to provide init params for the widget. Bug: None Test: Local build Change-Id: I931047b54d9d72075d4a94ada54daaa7c41a72ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599713Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#657390}
-
Miguel Casas authored
crrev.com/c/1570813 removed BufferUsage::GPU_READ_CPU_READ_WRITE_PERSISTENT, this CL removes the reference to it from the comment of gfx:BufferUsage. No new code, just comment update. Change-Id: I7de9114200a4c3ee10b24a40a8fe909af215056f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596361 Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#657389}
-
Maks Orlovich authored
Based almost entirely off Matt Menke's https://chromium-review.googlesource.com/c/chromium/src/+/1546318 Bug: 947573 Change-Id: I7571b33cd7e5e3ea4bde4768727d0932e391f6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551181Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#657388}
-
Marijn Kruisselbrink authored
Before this CL the Native File System API hooked into the old FS api from within blink. This makes implementing several of the features we want to support in the new API very difficult, so this CL changes things so the integration point now is in the browser process. As part of doing this, code specific to the new Native File System API is also moved to its own directories in content and blink. Also get rid of getParent() and update tests to not rely on getParent() as that method is not part of the planned API surface. implement a new feature. Bug: 853326 Binary-Size: Increase is due to large size of mojo bindings needed to Change-Id: Ia2702f83b6c80bb4f2d014b48e251814677a59bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576103Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#657387}
-
Xida Chen authored
This CL follows the previous CL here: https://chromium-review.googlesource.com/c/chromium/src/+/1584559, and implements the HasAlpha function. Unit testing has been added. Bug: 946519 Change-Id: I98ee57eaa450882c1e6f83b08a345ee3b97c4f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598840Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#657386}
-
Andrew Xu authored
Both issues are fixed since 76.0.3787.0. But there were no tests related with speaking text under mouse. Add a browser test case for this feature. Bug: 958120, 921182 Change-Id: I9a4aafea1bf3a8f9d23fb606a5afdc9925eeef19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597652 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#657385}
-
Morten Stenshorne authored
These DCHECKs were there to assert correct layout, and over the years they have served us well in finding and fixing bugs that (more often than not) caused bad layout. While there are still bugs that would trigger these DCHECKs, the problematic legacy multicol design (the flowthread idea, and the assumption that it should be possible to 1:1-map any flowthread coordinate to column rows (fragmentainer groups)) makes it practically impossible to avoid problems with these DCHECKs. We're not aware that these DCHECKs would fail on real websites (only with tests generated by the fuzzers), and, given that the multicol implementation will eventually be replaced by LayoutNG, it's time to accept the remaining and mostly unfixable flaws in the current multicol implementation. Bug: 950308, 958671 Change-Id: I0210e073d177bc8fcd02dbf1f1ed5aabb8ccbcf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598817Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#657384}
-
Nick Harper authored
Header Protection requires packets be padded to a minimum size. This modifies QuicTestPacketMaker to add that padding when header protection is in use. Bug: b/124998446 Change-Id: I86a0f990f27280f05b20aa0f7df6805305428d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593603Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#657383}
-
Kyle Spiers authored
Attempting to use the print this page extension results in Unchecked runtime.lastError: JavaScript URLs are not allowed in chrome.tabs.update. Use chrome.tabs.executeScript instead. https://developer.chrome.com/extensions/samples needs to be updated as well. Change-Id: Iea56f32cae87dc4286fe5e1cd61cb5e4ada1e478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554794Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kyle Spiers <ksspiers@google.com> Cr-Commit-Position: refs/heads/master@{#657382}
-
Ben Pastene authored
The immediate outage has passed. It's still got pretty high swarming test pending times, but that was the case prior to the outage, and I don't think that should block us from adding it back to the CQ. R=jbudorick, dpranke Bug: 960100 Change-Id: I6254ddb07da89ed8b85fa410bffbe9d5a332887b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599876 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#657381}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bdce6c8361a0..4403107f9908 git log bdce6c8361a0..4403107f9908 --date=short --no-merges --format='%ad %ae %s' 2019-05-07 nodir@google.com Roll bb Created with: gclient setdep -r src/third_party/depot_tools@4403107f9908 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I897d80abceeb2020516a0b88a15e37ed30d7c8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598879Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657380}
-
Reilly Grant authored
This change fixes a crash due to reentrancy in the ClearGattServices() method when called during disconnect. Destroying a GATT service object and associated characteristic and descriptor objects can run callbacks for pending read or write operations. If these themselves attempt to close the connection an unsafe reentrancy into std::map::clear() will occur. This change reverts the temporary fix for this issue. Bug: 950204 Change-Id: I3b1028389c58dc49e5aefc9ab77fd6be51d86fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597345 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#657379}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8b7597e64f17..60a6a2e77188 git log 8b7597e64f17..60a6a2e77188 --date=short --no-merges --format='%ad %ae %s' 2019-05-07 capn@google.com Fix clamp-to-border addressing mode Created with: gclient setdep -r src/third_party/swiftshader@60a6a2e77188 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/129523279 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I7dee8c9740b9ccf7031b9830a8177952918cb609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599515Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657378}
-
Greg Kerr authored
This is a temporary CL to locate and diagnose a mach service acccess that is hanging. Bug: 871280 Change-Id: I8ef068baa2f6f4b6eb3dd7a15671dffc399db2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599251 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#657377}
-
Ahmed Fakhry authored
When a desk is activated, this CL adds a horizontal movement from the starting (current) desk to the ending (to be activated) desk on all displays, since a desk spans all displays. Demos: https://bugs.chromium.org/p/chromium/issues/detail?id=866622#c24 BUG=866622 TEST=Manual, added tests to increase code coverage in the case of multi displays. Change-Id: I901b000a6ff89173d70e3ab07cbb7656c34d8357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591000 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#657376}
-
Katie D authored
Autoclick menu icons should not be mirrored in RTL languages because they have a directionality: The click types correspond to mouse buttons left and right, and the positions correspond to corners of the screen. Also adds a default screen position. This will be the same as where the volume and brightness sliders show up on the screen in LTR/RTL languages, and change with language direction. However, as soon as the user explicitly picks another position using the autoclick menu position button, the position will be fixed no matter if the user changes their system language direction. See go/chromeos-dwell-menu-design under the "Positioning" subheading. Bug: 958998 Change-Id: I28b3bf44b1f9081d6709e0b8255913f69ccac3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594654 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#657375}
-
Kevin Marshall authored
Defines the FIDL service which will be provided by the CastAgent to supply the CastRunner with bindings scripts and receive channels connected to the scripts. Bug: 953958 Change-Id: Ie1962e1395975b5daf3e3a0f13140f79676adfde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592854 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#657374}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/808c6984e664..5f3a01805f61 git log 808c6984e664..5f3a01805f61 --date=short --no-merges --format='%ad %ae %s' 2019-05-07 lalitm@google.com trace_processor: add template substitution support for SQL metrics Created with: gclient setdep -r src/third_party/perfetto@5f3a01805f61 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:129747127 TBR=perfetto-bugs@google.com Change-Id: Iac3a2e0d1e0c7d038e8c7a2da5be49164c1c122c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598877Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657373}
-
Kenneth Russell authored
One sub-test of this test is changing sense (from failing to passing) and must be suppressed during the change. Bug: angleproject:1293 Bug: angleproject:3285 Tbr: jmadill@chromium.org Change-Id: I322a57abe2a9702a1cdaa444f3d1420b93b89dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598716 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#657372}
-
Dominic Mazzoni authored
The JAWS screen reader is not announcing the text of a bubble dialog when it appears unless the user presses a hot key to read the whole dialog. This can be mitigated by adding a "describedby" relation between the dialog and the main label text. Bug: 953325 Change-Id: I8f9a68a80d7d7e91ea51f2816a3d85e312e93b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582844Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#657371}
-
Kurt Horimoto authored
This allows BrowserObservers to remove themselves in tests to avoid the checks_empty=true DCHECK in the ObserverList. Bug: none Change-Id: I3d87782a29c72b800333cd9eb4b79244daf45adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598874 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#657370}
-
Mehran Mahmoudi authored
This makes the progressbar invisible by default which prevents it from showing on startup. Bug: 959227 Change-Id: I710d2409f80ba4ec85a16e4c9cbc5e631c056eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595983 Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#657369}
-
Sam Goto authored
Report back to the renderer timeouts and task failures. Introduce an MojoInterceptor-based framework to enable us to test more corner cases. Bug: 670299 Change-Id: I13ed957e5bd291f47b775a7a0b817b06f3ba6c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574425 Commit-Queue: Sam Goto <goto@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#657368}
-
Kevin Marshall authored
Redesigns the NamedMessagePortConnector system so that ports are created in JS and pushed to native code, instead of being created on the native side and pushed to JS. The resulting implementation is cleaner because it allows callers to use HTML5 MessagePorts directly, without any need for a buffered wrapper class. * Adapts JS callers to use MessagePort functions and events. * Cleanup: modifies native dependents to take InterfaceHandle<MessagePort> instead of MessagePortPtrs. Bug: 922718 Change-Id: I4ad7b381bd95e42859cd48abccee4fc8e4f64a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595175 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#657367}
-
rajendrant authored
Bug: 952435 Change-Id: Ied1ab046d74eb091beb48937505af8cb3fdea1d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566352Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#657366}
-
Bruno Santos authored
Add entry in translation expectations to list grd files that should not be processed by translation tools, since they might contain parts not available publicly. Bug: 959449 Change-Id: Ic5da08cdb8465b7b7d7922d33b2ed0801a556ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596969 Commit-Queue: Bruno Santos <brunoad@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#657365}
-
Ehsan Karamad authored
'autofocus' post tasks the a callback to run Element::focus(). At this point it is possible that the Docuemnt::frame_ does not exist. This CL checks for frame_ before dereferencing. Bug: 960224, 954349 Change-Id: I9ee544343ef5314c0d9ffef3ba472cd438d528fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598197 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#657364}
-
Antonio Gomes authored
This method is needed when convert a CrossThreadFunction [1] to pass it out of Blink. In this particular case, AudioDestination can pass a CrossThreadFunction instance to blink::MediaMultiChannelResampler without converting it back to base::RepeatingCallback. BUG=None R=jbroman@chromium.org [1] third_party/blink/renderer/platform/wtf/functional.h Change-Id: Ifc5d19049dd3e4b295dd6e88d72d2d5d99ee49b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599712 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#657363}
-
Xiaohan Wang authored
Remove the include of "base/values.h" since it doesn't need anything from it. Bug: 960460 Change-Id: I08050e552bd3d8ddad2b1e909a3e708168c488db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599511 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#657362}
-
Katie D authored
Bug: 960038,960026 Change-Id: I19338b1c3d36ea9adb9aa803d06afaa71c77e5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597968Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#657361}
-