GitLab

Add NULL check for window in GetNativeThemeForWindow() to avoid a crash.

BUG=367698

Review URL: https://codereview.chromium.org/258953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266989 0039d316-1c4b-4281-b951-d872f2087c98

NOTREECHECKS=true
NOTRY=true
TBR=ajwong
BUG=367817

Review URL: https://codereview.chromium.org/252323004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266988 0039d316-1c4b-4281-b951-d872f2087c98

Compile failure in ChromiumOS (daisy) builder.
"irt_exception_handling.cc:101:15: error: 'LOG_FATAL' was not declared in this scope."

> NonSFI NaCl: Plumb Exception IRT enough for breakpad.
> 
> Implements irt_exception.
> 
> This is enough to get breakpad start reporting minidumps on crash.
> 
> Stack overflow case handling with sigaltstack will be handled in a followup change.
> 
> BUG=356925
> NOTRY=True
> 
> Review URL: https://codereview.chromium.org/230413002

TBR=uekawa@chromium.org

Review URL: https://codereview.chromium.org/265433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266987 0039d316-1c4b-4281-b951-d872f2087c98

Previously, accessibility keyboard uses 30 percent of screen
height as its height and compact keyboard uses 41 percent.

The IME VKs always use 41 percent for both full and compact
keyboards. This CL uses 41 percent for all system virtual
keyboards to make it consistent with IME VKs.


BUG=367947
TEST=
1. in about://flags disable input view flag and enable virtual
keyboard flag
2. click any text input area
3. a 4 rows virtual keyboard should show up and will occupy
about 41 percent of screen
4. enable accessibility virtual keyboard in chrome://settings
5. refocus a text input area
6. a 5 rows virtual keyboard should show up and will occupy
about 41 percent of screen

Review URL: https://codereview.chromium.org/258063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266986 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368037
TBR=bajones@chromium.org

Review URL: https://codereview.chromium.org/254173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266985 0039d316-1c4b-4281-b951-d872f2087c98

Compilation of these files w/instrumentation takes too long.
This is a temporary workaround for issue 360158

BUG=360158
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/224713013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266983 0039d316-1c4b-4281-b951-d872f2087c98

Pressing the "Go back" button on the managed user block interstitial page closes the tab if there is no previous URL to go back to.

BUG=307215

Review URL: https://codereview.chromium.org/248963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266982 0039d316-1c4b-4281-b951-d872f2087c98

Many places that don't need ContentView proper and just need the View
managed by ContentViewCore.
BUG=360664
NOTRY=true

Review URL: https://codereview.chromium.org/251443004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266979 0039d316-1c4b-4281-b951-d872f2087c98

Fixing this issue exposed a race condition in .gni processing where an error parsing a file that another thread was waiting for wouldn't signal that other thread that the load was complete, so it would wait forever.

This patch separates out the loading from the signaling in the InputFileManager so we can't forget to do this.

BUG=368019
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/258073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266976 0039d316-1c4b-4281-b951-d872f2087c98

Several tests are using AuraTestHelper and were relying on it to set up the DefaultActivationClient, so I had to have them instantiate the DAC directly after calling SetUp() on the helper. I also had to make the DAC delete itself after the root window it's bound to is destroyed.

R=sky@chromium.org
http://crbug.com/308710

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266616

Review URL: https://codereview.chromium.org/250113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266975 0039d316-1c4b-4281-b951-d872f2087c98

the border color can still conflict with the theme (e.g., no visible border if the tooltip bg is dark), but fixing that is a lot harder because the border, window roundedness, and shadow are all one tiled set of images (see shadow.cc).

BUG=348194

Review URL: https://codereview.chromium.org/258713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266974 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266973 0039d316-1c4b-4281-b951-d872f2087c98

> - Using realpath instead of android_src
> 
> BUG=367235
> 
> Review URL: https://codereview.chromium.org/259763004

TBR=michaelbai@chromium.org

Review URL: https://codereview.chromium.org/263463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266972 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
This delta breaks telemetry_perf_unittests testMeasurementSmoke

ERROR:root:Errored pages:
http://localhost:8000/components/paper-calculator/demo.html
Traceback (most recent call last):
File "/mnt/data/b/build/slave/Linux_ChromiumOS_Tests__1_/build/src/tools/perf/../telemetry/telemetry/decorators.py", line 50, in wrapper
func(*args, **kwargs)
File "/mnt/data/b/build/slave/Linux_ChromiumOS_Tests__1_/build/src/tools/perf/measurements/measurement_unittest.py", line 73, in testMeasurementSmoke
msg='Failed: %s' % benchmark)
AssertionError: Failed: <class 'benchmarks.thread_times.ThreadTimesPolymer'>

Original issue's description:
> add more polymer tests
> 
> BUG=333078
> R=dtu@chromium.org
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266955

TBR=dtu@chromium.org,ykyyip@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=333078

Review URL: https://codereview.chromium.org/257253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266971 0039d316-1c4b-4281-b951-d872f2087c98

Linux: Remove some ChromeOS linker flag workarounds now that full ChromeOS builds set the flags explicitly.

BUG=360082

Review URL: https://codereview.chromium.org/242453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266970 0039d316-1c4b-4281-b951-d872f2087c98

KeyboardDrivenEventRewriter was previously called at the start of
chromeos::EventRewriter, and suppressed further rewriting if it made
any changes. Since EventSource follows that model of breaking out of
the rewriter list, it makes sense to have this be a ui::EventRewriter
itself.

EventRewriterController will also be used for chromeos::EventRewriter
when that is converted to a ui::EventRewriter.

BUG=354034
TEST=unit_test
R=derat@chromium.org, sadrul@chromium.org

Review URL: https://codereview.chromium.org/240173007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266969 0039d316-1c4b-4281-b951-d872f2087c98

Implements irt_exception.

This is enough to get breakpad start reporting minidumps on crash.

Stack overflow case handling with sigaltstack will be handled in a followup change.

BUG=356925
NOTRY=True

Review URL: https://codereview.chromium.org/230413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266968 0039d316-1c4b-4281-b951-d872f2087c98

Front end runs on UI thread, network code runs on IO thread.

BUG=349645
NOTRY=true

Review URL: https://codereview.chromium.org/256913005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266966 0039d316-1c4b-4281-b951-d872f2087c98

Ozone has use_aura=1 and toolkit_views=0. MacViews has use_aura=0 and
toolkit_views=1. Ensure these both link correctly.

This is a follow-up to r266641 and r266283.

BUG=366007
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/252963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266965 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromedriver:776
NOTRY=True

Review URL: https://codereview.chromium.org/259403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266964 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368006
TEST=gpu_unittests, on win/linux, gpu_rasterization is off
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/253883006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367304
R=jln@chromium.org, willchan@chromium.org

Review URL: https://codereview.chromium.org/253803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266958 0039d316-1c4b-4281-b951-d872f2087c98

TBR=brettw@chromium.org
BUG=362608

Review URL: https://codereview.chromium.org/252733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266957 0039d316-1c4b-4281-b951-d872f2087c98

The notification dismissal was reported as from a user, which is not the case when the notification is dismissed programmatically.

BUG=368405
R=dewittj@chromium.org, robliao@chromium.org

Review URL: https://codereview.chromium.org/260533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266956 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333078
R=dtu@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/257283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266955 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary until the throbber icons can be moved into
resources.pak.

BUG=368327,52609
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/263453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266954 0039d316-1c4b-4281-b951-d872f2087c98

We've long had duplicated code in the opus and ffmpeg audio decoders
based around discarding samples from the front of back of output
buffers.  This change standarizes this into a better tested helper
class.

This paves the way for a later change which will expand discard_padding()
for use by media source.

It also fixed the chained ogg case with opus by allowing non-monotonic
timestamps for the opus decoder.

BUG=175281, 360961
TEST=new unittest. existing tests pass.
NOTRY=true

Review URL: https://codereview.chromium.org/259453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266953 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: Speculative; may have made webgl conformance tests for video extensions flaky.

> Remove dropped frame counting and task posting from VideoFrameCompositor.
> 
> While developing VideoFrameScheduler it became apparent that we no longer need to post tasks to notify the compositor as scheduling is already being done on the compositor thread. If there are no posted tasks, it also means we don't need to track dropped frames due to missed scheduler notifications.
> 
> BUG=110814
> 
> Review URL: https://codereview.chromium.org/251733005

TBR=scherkus@chromium.org
BUG=368300

Review URL: https://codereview.chromium.org/258383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266952 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266947 0039d316-1c4b-4281-b951-d872f2087c98

This removes some unnecessary code in the trusted plugin. I broke this out to
its own change while fixing up other things.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/260053008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266945 0039d316-1c4b-4281-b951-d872f2087c98

> First step at synchronizing client model changes with service.
> 
> R=sky@chromium.org
> http://crbug.com/365012
> 
> Review URL: https://codereview.chromium.org/258623005

TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/261513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266944 0039d316-1c4b-4281-b951-d872f2087c98

Rename the pica benchmark to something more generic
to reuse with other page sets. The pica benchmark
will be removed after it's also renamed in the
perf bot.

R=dtu@chromium.org,adamk@chromium.org,tonyg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/255063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266943 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266942 0039d316-1c4b-4281-b951-d872f2087c98

R=jkummerow@chromium.org
TBR=danno@chromium.org

Review URL: https://codereview.chromium.org/259253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266941 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/258623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266940 0039d316-1c4b-4281-b951-d872f2087c98

https://chromium-review.googlesource.com/#/c/190984/
https://chromium-review.googlesource.com/#/c/191137/

BUG=343781

Review URL: https://codereview.chromium.org/204983009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266939 0039d316-1c4b-4281-b951-d872f2087c98

This function was removed from ReverseService inside "native_client/", as it's
no longer necessary. This change removes an implementation that's never called,
and simplifies the Manifest logic, making it easier to move that out of the
trusted plugin.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/258083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266938 0039d316-1c4b-4281-b951-d872f2087c98

Previously code was linking with ViewManager, now I'm connecting
through the shell. As part of this I'm adding a general class that
should make it easy to connect to any server through the shell.

For the time being I'm making the shell explicitly link with the
viewmanager. Eventually that'll have to change.

BUG=365012
TEST=covered by tests
R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/256133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266937 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266936 0039d316-1c4b-4281-b951-d872f2087c98

Chromium base revision: 266668 / eb550b5f
Old Skia revision: 14390
New Skia revision: 14425
Control CL: https://codereview.chromium.org/260083005

This CL was created by Skia's roll_deps.py script.

Bypassing commit queue trybots:
NOTRY=true

Review URL: https://codereview.chromium.org/258053009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266935 0039d316-1c4b-4281-b951-d872f2087c98