GitLab

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2b77059502c9..3ce148638bdc

2020-10-07 8729214+jonahryandavis@users.noreply.github.com Disable -Wno-conversion on MSVC compiler (#2410)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Tbr: radial-bots+chrome-roll@google.com,timvp@google.com
Change-Id: Ied742e5d6f32285a2963d6297dc9c575d91652a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457391Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#814818}

This CL makes
//weblayer/shell/android:weblayer_shell_java ignore unavoidable known
strict mode violations. The KnownViolations.java list is taken matches
the list used for other Google apps.

BUG=1134600

Change-Id: Ie3de4e820798659a5f0e5500329004c657a573fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445854
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814817}

Offers a toggle in the customize dialog that hides modules on the NTP.
Screenshot (shown): https://screenshot.googleplex.com/BKvcrirTE6quvdi
Screenshot (hidden): https://screenshot.googleplex.com/AxMQ6DZa3MrHopf

Upon closing the customize dialog the visibility will be applied to the
current NTP and saved to prefs.

Bug: 1135393
Change-Id: I1dde6109ab3b8acccee5a4c57681a42302fbec76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454329
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814816}

This CL makes CrOS GMC compatible with CrOS light/dark mode feature.

Bug: 1135656

Change-Id: Idd4955fd8676d2171bd323c1282198dc57345981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451316
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814815}

This changes the subtitle that tells the user who is managing this
device. For Dasher domains, it will continue to be a domain (foo.com).
For FlexOrgs, this will be the email of the administrator of the
organization (admin@foo.com).

BUG=chromium:1081272

Change-Id: I41c6eb66115e2e4b9ad7e4427c12935bbcf4b223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454155Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Brian Malcolm <bmalcolm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814814}

https://pdfium.googlesource.com/pdfium.git/+log/3a384ed186dd..ff30c3d43096

2020-10-07 tsepez@chromium.org Make XFA_MAPMODULEDATA::m_ValueMap map onto int, not void*.
2020-10-07 tsepez@chromium.org Make XFA_MAPMODULEDATA be keyed by uint32_t, not void*.
2020-10-06 tsepez@chromium.org Forward declare XFA_MAPDATABLOCKCALLBACKINFO in cjx_object.h
2020-10-06 nigi@chromium.org Roll third_party/freetype/src/ 16ee2a22a..20186d1be (9 commits)
2020-10-06 thestig@chromium.org Remove the last set_sources_assignment_filter().
2020-10-06 thakis@chromium.org stretch engine: Hoist a options reads out of loops
2020-10-06 nigi@chromium.org Roll build/ 23dc5c578..50f81f245 (217 commits)
2020-10-06 tsepez@chromium.org Pass span to CXFA_Graphics::SetLineDash()
2020-10-06 thestig@chromium.org Split CGdiplusExt into its own file.
2020-10-06 thestig@chromium.org Split CGdiDisplayDriver into its own file.
2020-10-06 thestig@chromium.org Split CGdiPrinterDriver into its own file.
2020-10-06 thestig@chromium.org Split CPSPrinterDriver into its own file.
2020-10-06 thestig@chromium.org Split CTextOnlyPrinterDriver into its own file.
2020-10-06 thestig@chromium.org Make some CFX_AggDeviceDriver methods private.
2020-10-06 thestig@chromium.org Replace CAgg_PathData with BuildAggPath().

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: Ia8d75793f9e0eb424f76da007aef3472d151db95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457446Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#814813}

https://chromium.googlesource.com/angle/angle.git/+log/a51c2a0b4243..34951b7955e2

2020-10-07 sdefresne@chromium.org build: Remove no-op calls to set_sources_assignment_filter

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1018739
Tbr: timvp@google.com
Change-Id: I98e51d9b8a5f379a83f5a73e906e7e2fbba0952d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457389Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#814812}

Adds an "additionalText" optional parameter to the ActivityServices
scenarios, allowing to share a piece of text along with a page's URL
and title. This additional text will be added as an extra activity
item, and will be stored in the pasteboard when users select the Copy
activity.

Bug: 1136043
Change-Id: Ia8d86c4ecfb57bdbc2bac3f209ab37973d79fc59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451309
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814811}

Fixed: 1135807
Change-Id: Id627fb657bc1f507c25e845e602d3bcdb5dfbae2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454982Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814810}

Links now appear in var() functions in the Styles panel of DevTools to
allow users to jump to where custom properties are defined.

This change adds a new state to the DevToolsAction enum so we can record
when users click these links.

Frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2451605/

Bug: 1124707
Change-Id: Ib38e57689973a94cf68837234d1bf66653e8d5fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451925Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#814809}

DesktopPWAsWithoutExtensions has shipped. The test no longer
needs to be parameterized

Bug: 1065748
Change-Id: I9827cee3d3393dc4bf2038057aa8ca197b2fe522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454611
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814808}

Adds an ignore:1 to the JSON uploaded to Gold from the Android
RenderTests if we are running on a trybot and it is not the final
retry attempt. This is to counter flaky tests causing unrelated CLs to
receive comments from Gold when the test causes their CL to produce a
new image. With this change, CLs will only receive a comment if a
test fails consistently.

Bug: skia:10787
Change-Id: I827de961e49a357f1755d6931b89468e27bebac6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446717Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814807}

Bug: 1129217
Change-Id: I683aeee86f06a157255eae0c9db3948509ebcbf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438749
Commit-Queue: John Williams <jrw@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814806}

Unless it's guaranteed that `std::forward` always turns into an rvalue
ref, using `std::move(x)`, where `x`'s type is a universal reference, is
generally unsafe. `std::forward` is preferred for these cases.

Bug: 1134310
Change-Id: I09a45cc9ea6378102e1e6227894e4096706f023b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441382Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814805}

Add a TypeConverter to convert the Mojo ScanSettings struct to a
lorgnette::ScanSettings proto.

Bug: 1059779
Change-Id: I521c62bfb98b82214bce812719f05634b5355ead
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453792Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814804}

Instead of just clearing the canvas when going out of view, remove it.
Recreate the canvas once needed again.

Bug: 1134057
Change-Id: I11131d7bf584eb51c94f4fd24484ba9f6675e75e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451387Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814803}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: I71bddb7d051200b4d816d16e4344c7033029e84c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457866Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#814802}

Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010070700_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/uWbmcEtWADarsG0HhmvlhXO-JRde7y_pepUaXfu4TDAC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/170162418
Tbr: help-app@grotations.appspotmail.com
Change-Id: I02decd1ec740760753a917696c443c297ed89b10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456014Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#814801}

Bug: None
Change-Id: I53e732ac6f968583838b12a965c70cb3f56f5dda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457326
Commit-Queue: Tommy Li <tommycli@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814800}

This patch increases the viewport intersection margin for
content-visibility: auto to 150% of the viewport.

This prevents excessive 'checkerboarding' from lack of rendered
content on quick flings.

R=chrishtr@chromium.org
TEST=Tested with scrollBy({ top: 10000, behavior: 'smooth' }) on FB.

Change-Id: I70d3ef371d5aeb943dca26d6decae97184db446b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453029
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814799}

https://android.googlesource.com/platform/external/perfetto.git/+log/91ab730685a6..3419b3b485ba

2020-10-07 primiano@google.com Merge "build: Remove no-op calls to set_sources_assignment_filter"
2020-10-07 ddrone@google.com Merge "Manually copy Chrome extensions to Perfetto"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I44914bbe29b3d8a0a6a74343dfba64a366507760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457390Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#814798}

BrowserControlsOffsetCallback landed in 88, not 87.

I merged the restore code to 87:
https://chromium-review.googlesource.com/c/chromium/src/+/2454639
so the version checks need to be updated.

Lastly, I named a method wrong in Browser. This fixed that.

BUG=none
TEST=this only updates comments.

Change-Id: I073dc8986588853c27aed906ed0f5ccee71f923c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454837Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814797}

Fix build error:
../../components/omnibox/browser/on_device_head_model.h:68:15: error: ‘vector’ in namespace ‘std’ does not name a template type

Bug: 957519
Change-Id: Idad1853af6afbf31faf288b6b5a73007497338a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453452Reviewed-by: Angela Yoeurng <yoangela@chromium.org>
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Cr-Commit-Position: refs/heads/master@{#814796}

DesktopPWAsWithoutExtensions has shipped. The test no longer
needs to be parameterized

Bug: 1065748
Change-Id: I70940f9fe74c1865003ce42d421c36f34515f47c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454778
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814795}

Bug: 1109316
Change-Id: I51cda7d729f1039c8f9edd33ca36a11ece4a73b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456287Reviewed-by: Connie Wan <connily@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814794}

https://dawn.googlesource.com/tint.git/+log/a388d56d9968..28ae1471bf2c

2020-10-07 dsinclair@chromium.org Exclude spirv-tools from the all build target.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-chromium-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I702c5e4e8a973d1689f9e191393033513aa13f7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457386Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#814793}

The index was sometimes too large due to a previous child not being
inserted when it was already aria-owned by another parent.

Bug: 1135887
Change-Id: If43ff07b6601f024d6d358779cb51d2214aaafb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457548
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814792}

Set-up response creation in JavaScript and handling in
CRWTextFragmentsHandler, allowing the collection of success/failure
metrics and measurement of the JavaScript library's rate of success.

Bug: 1136043
Change-Id: I01eea5d85e2827a496b011d116592bebb74bd92e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448683
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814791}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e66f55b48608..79960a9c04c8

2020-10-07 tvanderlippe@chromium.org Typecheck sources/UISourceCodeFrame.js with TypeScript
2020-10-07 aerotwist@chromium.org Remove unnecessary empty string
2020-10-07 jacktfranklin@chromium.org Use :host-context within component for dark mode
2020-10-07 tvanderlippe@chromium.org Typecheck sources/AddSourceMapURLDialog.js with TypeScript
2020-10-07 tvanderlippe@chromium.org Typecheck sources/InplaceFormatterEditorAction.js with TypeScript

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1122511
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I183c0f74cdadf1e0561151d76523353d5494c361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457166Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#814790}

This reverts commit a81c2688.

Reason for revert: b:170312454

Original change's description:
> ambient: cache two backup photos
>
> Handle failure cases better by having backup photos on disk.
> Refresh these images after user logs in.
>
> BUG=b:167332126
>
> Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
> Change-Id: I7046a20ed9606638e851247f8c213d112af6c30b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429585
> Commit-Queue: Jeffrey Young <cowmoo@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Reviewed-by: Tao Wu <wutao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#813904}

TBR=xiaohuic@chromium.org,wutao@chromium.org,meilinw@chromium.org,cowmoo@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:167332126
Change-Id: I378bec2d00d0a857418e368d77b1afee0f9fc92e
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457048Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Jeffrey Young <cowmoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814789}

Move Flags into a more appropriate directory to better follow chromium
directory structure conventions.

Rename directory to avoid unnecessary acrynomn
https://google.github.io/styleguide/cppguide.html#General_Naming_Rules

BUG=b:169582550
TEST='build chrome'

Change-Id: I9f9f8e506109bd27724f879489cb6088a4e9b132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448684Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kyle Williams <kdgwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814788}

This change fixes a crash caused by trying to show the same
supplemental notification twice when dismissing a media notification.
Showing the notification once causes a different problem, where
instead of closing, the dialog stays open with the closed notification
replaced by the previously-hidden supplemental notification.

The fix is to only show supplemental notifications when they are
created, and thereafter only hide them in response to the creation of
a non-supplemental notification.  The original design for supplemental
notifications was based on the idea of supplementatal notifications
being persistent in order to trigger the display of the media control
icon in the toolbar.  In the course of the code review, the design was
changed to create supplemental notifications in a just-in-time manner
to avoid showing the media control icon, so there is no longer any
need to show a supplemental notification that was previously hidden.

Bug: 1107164, b/161612881
Change-Id: I9a9b60b1e1023ef4d8085ca4df949645f999efdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453440Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: John Williams <jrw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814787}

This method is called when users click the enhanced protection link in
security interstitials. Also add a new access point named
kSecurityInterstitial for logging metrics.

Bug: 1130721
Change-Id: I02725db2c9557a7d6440584b8f9145a696affff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434089Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814786}

* Rename MatchCountLabel to FindBarMatchCountLabel and move it
  to top file level, because builder does not support inner class.
* Add builder support to it.

Bug: 1130078
Change-Id: I6ada19042466ca1216c60858f5542d17cf0c1626
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441491
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Auto-Submit: Keren Zhu <kerenzhu@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814785}

See the failure in https://crbug.com/1135290#c1. Explicitly enable
the SAFE_BROWSING_SECURITY_SECTION_UI flag to show "Privacy and
security".

Bug: 1135290
Change-Id: I28d4656e8df987d79312dad2e00d67f861465c3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450665Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814784}

See bug for specs. Focus ring was already done as part of virtual desks.
Since alt tab shares UI with overview, it is done implicitly as well.

Test: manual
Bug: 1128760, 1128757
Change-Id: I194b6e92ca8b406fea7bc05733e295f16adfc648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446838
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Min Chen <minch@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814783}

Add Generate DIR_METADATA files and remove metadata from OWNERS
files for //courgette.

R=huangs@chromium.org

Bug: 1113033
Change-Id: Ia24b5ca4b977524c79c245e78f14d86981aa029d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454274
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814782}

The test is flaky on Android P. See bug for details.

Bug: 1135837
Change-Id: I7b5d41cbeda97bb1cb568d09e89b833487bd46f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454889
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Auto-Submit: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814781}

On some system / device configuration, the accelerometer device
file exists but can't be read by the browser process. When this
happens, it generates error log repeatedly, which is not great.

This CL tries to address this issue in a way. On initializing
accelerometer configuration, it tries to read the device file
at that time, and when it fails to read, it just stops the
initialization and reports an error message. This happens once,
and does not generate repeated logs.

Also, when an error happens, now it can obtain the errno and
print it as a part of the log, so it would be more understandable
why it fails. On my case, it is just permission denied, for some
reasons.

Bug: 1134527
Test: manually with nautilus device in the lab
Change-Id: Ib9823631a70fc54d3e3abc35067aff56a7d7ee50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454840Reviewed-by: Min Chen <minch@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814780}

This reverts commit 243dbcb1.

Reason for revert: breaks tests (https://crbug.com/1136112 & https://crbug.com/1135658)

Original change's description:
> Include translate information in onProvideAssistContent.
>
> Assistant will use this information to determine whether or not to show a translate prompt when Assistant is opened over Chrome.
>
> This is controlled by the "TranslateAssistContent" Feature and is off by default.
>
> Design doc here: https://docs.google.com/document/d/1xZR09XTTGgY0F00_lFOEX7nUc0oqgSrCs5lZFU9INA0/edit
>
> Bug: 1110943
> Change-Id: I213f55af0efdaa2762f4524b74f942b99123f64b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442360
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Scott Little <sclittle@chromium.org>
> Commit-Queue: Josh Simmons <jds@google.com>
> Cr-Commit-Position: refs/heads/master@{#813999}

TBR=isherman@chromium.org,mthiesse@chromium.org,sclittle@chromium.org,sweilun@chromium.org,jds@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1110943, 1136112, 1135658
Change-Id: I51739eb23c0c7ec34a35463ebb498290d853d605
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457086Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814779}